D6366: Fix configure with Qt5Multimedia disabled.
palimaka created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY When passed -DBUILD_TESTING=OFF -DCMAKE_DISABLE_FIND_PACKAGE_Qt5Multimedia=ON, CMake failed because find_package(Qt5 COMPONENTS MULTIMEDIA) was treated as required due to the previous find_package(Qt5 REQUIRED COMPONENTS Xml) call. Finding Qt5Multimedia directly via its own config file ensures that it really is treated as optional. TEST PLAN Configures and builds both with and without Qt5Multimedia enabled. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D6366 AFFECTED FILES CMakeLists.txt To: palimaka, #frameworks Cc: #frameworks
D6249: FindQHelpGenerator: avoid picking up Qt4 version
palimaka added a comment. Sorry for the delay, I was away. Thanks for pushing! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau, kfunk Cc: alexeymin, asturmlechner, #build_system
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 41 - Failure!
BUILD FAILURE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/41/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 23 Jun 2017 23:32:42 +
Build duration:
3 min 45 sec and counting
CONSOLE OUTPUT
[...truncated 450.50 KB...][ 21%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/tcpslavebase.cpp.o[ 21%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/directorysizejob.cpp.o[ 21%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/forwardingslavebase.cpp.o[ 21%] Linking CXX shared module kcookiejar.so[ 22%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/chmodjob.cpp.o[ 22%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kdiskfreespaceinfo.cpp.o[ 22%] Built target kded_kcookiejar[ 22%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/usernotificationhandler.cpp.o[ 22%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/ksambasharedata.cpp.o[ 22%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/ksambashare.cpp.o[ 22%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/knfsshare.cpp.o[ 22%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kfileitem.cpp.o[ 23%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/davjob.cpp.o[ 23%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/deletejob.cpp.o[ 23%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/copyjob.cpp.o[ 23%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filejob.cpp.o[ 23%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mkdirjob.cpp.o[ 23%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mkpathjob.cpp.o[ 23%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kpasswdserverloop.cpp.o[ 24%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kpasswdserverclient.cpp.o[ 24%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kremoteencoding.cpp.o[ 24%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/sessiondata.cpp.o[ 24%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slavebase.cpp.o[ 24%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/dataslave.cpp.o[ 24%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/dataprotocol.cpp.o[ 24%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/desktopexecparser.cpp.o[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/emptytrashjob.cpp.o[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/authinfo.cpp.o[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slaveinterface.cpp.o[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slave.cpp.o[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job_error.cpp.o[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job.cpp.o[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filecopyjob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/listjob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mimetypejob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/multigetjob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/restorejob.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/core/job.cpp:324:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/build/src/core/moc_job_base.cpp:84:21: warning: 'canceled' is deprecated [-Wdeprecated-declarations]case 0: _t->canceled((*reinterpret_cast< KJob*(*)>(_a[1]))); break;^/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/build/src/core/../../../src/core/job_base.h:228:29: note: 'canceled' has been explicitly marked deprecated hereKIOCORE_DEPRECATED void canceled(KJob *job);^In file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/core/job.cpp:324:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/build/src/core/moc_job_base.cpp:119:72: warning: 'canceled' is deprecated [-Wdeprecated-declarations]if (*reinterpret_cast<_t *>(func) == static_cast<_t>(&Job::canceled)) { ^/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/build/src/core/../../../src/core/job_base.h:228:29: note: 'canceled' has been explicitly marked deprecated hereKIOCORE_DEPRECATED void canceled(KJob *job);^2 warnings generated.[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/simplejob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/specialjob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/statjob.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/storedtransferjob.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/transferjob.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filesystemfreespacejob.cpp.o[ 27%] Bu
KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 40 - Failure!
BUILD FAILURE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/40/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Fri, 23 Jun 2017 23:32:42 +
Build duration:
1 min 45 sec and counting
CONSOLE OUTPUT
[...truncated 408.94 KB...]/home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/dataprotocol_p.h:79:10: warning: 'virtual void KIO::DataProtocol::get(const QUrl&)' can be marked override [-Wsuggest-override] void get(const QUrl &url); ^[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slave.cpp.o[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job_error.cpp.o[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job.cpp.oIn file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/slave.cpp:39:0:/home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/dataprotocol_p.h:78:10: warning: 'virtual void KIO::DataProtocol::mimetype(const QUrl&)' can be marked override [-Wsuggest-override] void mimetype(const QUrl &url); ^/home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/dataprotocol_p.h:79:10: warning: 'virtual void KIO::DataProtocol::get(const QUrl&)' can be marked override [-Wsuggest-override] void get(const QUrl &url); ^[ 25%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filecopyjob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/listjob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mimetypejob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/multigetjob.cpp.oIn file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/job.cpp:324:0:/home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/build/src/core/moc_job_base.cpp: In static member function 'static void KIO::Job::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)':/home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/build/src/core/moc_job_base.cpp:84:67: warning: 'void KIO::Job::canceled(KJob*)' is deprecated [-Wdeprecated-declarations] case 0: _t->canceled((*reinterpret_cast< KJob*(*)>(_a[1]))); break; ^In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/simplejob.h:24:0, from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/jobclasses.h:25, from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/job.h:74, from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/job.cpp:22:/home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/job_base.h:228:29: note: declared here KIOCORE_DEPRECATED void canceled(KJob *job); ^In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/job.cpp:324:0:/home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/build/src/core/moc_job_base.cpp:119:72: warning: 'void KIO::Job::canceled(KJob*)' is deprecated [-Wdeprecated-declarations] if (*reinterpret_cast<_t *>(func) == static_cast<_t>(&Job::canceled)) {^In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/simplejob.h:24:0, from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/jobclasses.h:25, from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/job.h:74, from /home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/job.cpp:22:/home/jenkins/workspace/Frameworks kio kf5-qt5 XenialQt5.7/src/core/job_base.h:228:29: note: declared here KIOCORE_DEPRECATED void canceled(KJob *job); ^[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/restorejob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/simplejob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/specialjob.cpp.o[ 26%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/statjob.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/storedtransferjob.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/transferjob.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filesystemfreespacejob.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slaveconfig.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/scheduler.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kprotocolmanager.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/hostinfo.cpp.o[ 27%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kdirnotify.cpp.o[ 28%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kurlauthorized.cpp.o[ 28
D6353: Get the doc dirs with the newly exported function
This revision was automatically updated to reflect the committed changes. Closed by commit R241:b715b58563ca: Get the doc dirs with the newly exported function (authored by ltoscano). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6353?vs=15768&id=15809 REVISION DETAIL https://phabricator.kde.org/D6353 AFFECTED FILES src/ioslaves/help/kio_help.cpp src/ioslaves/help/xslt_help.cpp To: ltoscano, dfaure Cc: #frameworks
D6352: New function to retrieve the documentation directories
This revision was automatically updated to reflect the committed changes. Closed by commit R238:7780d972ad6e: New function to retrieve the documentation directories (authored by ltoscano). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6352?vs=15767&id=15808 REVISION DETAIL https://phabricator.kde.org/D6352 AFFECTED FILES src/docbookxslt.h src/xslt.cpp To: ltoscano, dfaure Cc: #frameworks, #documentation, skadinna
D6353: Get the doc dirs with the newly exported function
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6353 To: ltoscano, dfaure Cc: #frameworks
D6352: New function to retrieve the documentation directories
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D6352 To: ltoscano, dfaure Cc: #frameworks, #documentation, skadinna
D6277: Emit errors when keditbookmarks is missing
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Good fix, thanks. INLINE COMMENTS > aacid wrote in kbookmarkmanager.cpp:341 > i'd go for non const as the other two methods, yes they could be const since > they're not modyfing the object, i guess what the original author had in mind > is a meaning of "this changes things eventually" so that's why it isn't > const, or maybe it was just a mistake :D The author is me, and the calling methods are slots (which are typically not const) ;) REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D6277 To: valeriymalov, #frameworks, dfaure Cc: dfaure, aacid, ltoscano
D6255: KKeySequenceItem: make it possible to record Ctrl+Num+1 as a shortcut.
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D6255 To: davidedmundson, dfaure Cc: #frameworks
D6047: WIP: Support XDG v6
davidedmundson updated this revision to Diff 15797. davidedmundson edited the summary of this revision. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Try to upload via arc... REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=15634&id=15797 BRANCH xdg_merge REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell.h autotests/client/test_xdg_shell_v5.cpp autotests/client/test_xdg_shell_v6.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell-unstable-v6.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_v5.cpp src/client/xdgshell_v6.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v5_interface_p.h src/server/xdgshell_v6_interface.cpp src/server/xdgshell_v6_interface_p.h src/tools/mapping.txt tests/CMakeLists.txt tests/xdgtest.cpp To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
D6087: Haskell: Add all language pragmas as keywords.
arrowdodger added a comment.
In https://phabricator.kde.org/D6087#118963, @dhaumann wrote:
> Demo for the highlighting rule - I don't think I can say anything to the
auto completion issue. I am pretty sure it is unrelated to your xml file.
Sure. Pragmas have following form:
{-# blabla #-}
Specifically, pragmas that enable language extensions looks like
{-# LANGUAGE OverlappingInstances, BangPatterns #-}
As I've found today, pragmas can span onto multiple lines:
{-# LANGUAGE OverlappingInstances,
BangPatterns
#-}
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, #frameworks
D6249: FindQHelpGenerator: avoid picking up Qt4 version
This revision was automatically updated to reflect the committed changes. Closed by commit R240:a13f1dcd2e7b: FindQHelpGenerator: avoid picking up Qt4 version (authored by palimaka, committed by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6249?vs=15514&id=15796 REVISION DETAIL https://phabricator.kde.org/D6249 AFFECTED FILES find-modules/FindQHelpGenerator.cmake To: palimaka, #frameworks, kossebau, kfunk Cc: alexeymin, asturmlechner, #build_system
D6249: FindQHelpGenerator: avoid picking up Qt4 version
kossebau added a comment. So pushing now myself, so this todo can be checked off :) REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau, kfunk Cc: alexeymin, asturmlechner, #build_system
D6087: Haskell: Add all language pragmas as keywords.
dhaumann added a comment. Demo for the highlighting rule - I don't think I can say anything to the auto completion issue. I am pretty sure it is unrelated to your xml file. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 To: arrowdodger, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, #frameworks
D6047: WIP: Support XDG v6
mart added inline comments. INLINE COMMENTS > graesslin wrote in xdgshell_interface.h:80 > @davidedmundson for the ping you could check the old wl_shell_surface > implementation in KWayland. the implementation here in xdgshell_interface is basically copied over the kwayland wl_shell_surface. the code pasted above, is the only kwin part i found that was managing pings in any way, which is the x11 implementation (Client) i guess ShellClient will have to have something along the lines using the kwayland implementations, tough casing between the possible interfaces exposed (wl_shell, xdgshellv5 and xdgshellv6) > graesslin wrote in xdgshell_interface.h:75 > what is "gravity"? as far i understood, it's an hint that tells the window the direction it prefers to popup, so like "please dear compositor make it show below the point i asked to", or at the left, or whatever hint that the compositor can choose to ignore REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6340: Fix incorrect error detection for missing knsrc files
This revision was automatically updated to reflect the committed changes. leinir marked an inline comment as done. Closed by commit R304:eb2e65a882f0: Fix incorrect error detection for missing knsrc files (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6340?vs=15742&id=15781#toc REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6340?vs=15742&id=15781 REVISION DETAIL https://phabricator.kde.org/D6340 AFFECTED FILES src/core/engine.cpp To: leinir, #knewstuff, apol Cc: apol, #frameworks, ZrenBot
D6340: Fix incorrect error detection for missing knsrc files
leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in engine.cpp:130 > are you sure the `endl` is necessary? i am, in fact, reasonably certain it is not required - leftovers are fun, i'll get rid of that :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6340 To: leinir, #knewstuff, apol Cc: apol, #frameworks, ZrenBot
D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin
bcooksley added a comment. All the tooling and functionality i've described is provided by Phabricator itself. We don't have any control over that (without codebase changes, which i'm strongly against due to the speed of development of Phabricator) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6309 To: rjvbb, #frameworks Cc: bcooksley, tfry, kde-mac, #frameworks
D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin
rjvbb added a comment. Ben Cooksley wrote on 20170623::09:17:33 re: "https://phabricator.kde.org/D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin" > The system has now polled the repository and the hook has correspondingly been triggered. I see. Does that mean you have rolled something yourself and could technically make it trigger also on a more compact key that's more in line with the other keywords (and easier to remember, more resistant to typos)? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6309 To: rjvbb, #frameworks Cc: bcooksley, tfry, kde-mac, #frameworks
D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin
bcooksley added a comment. As Phabricator does not host the repositories it polls them periodically based on activity in the repository. For KIconThemes this is about once an hour. The system has now polled the repository and the hook has correspondingly been triggered. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6309 To: rjvbb, #frameworks Cc: bcooksley, tfry, kde-mac, #frameworks
D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin
This revision was automatically updated to reflect the committed changes. Closed by commit R302:ac5cbf6b4aa9: More details about deploying icon themes on Mac & MSWin (authored by rjvbb). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6309?vs=15694&id=15775 REVISION DETAIL https://phabricator.kde.org/D6309 AFFECTED FILES README.md To: rjvbb, #frameworks Cc: tfry, kde-mac, #frameworks
D6087: Haskell: Add all language pragmas as keywords.
arrowdodger added a comment. In https://phabricator.kde.org/D6087#117019, @dhaumann wrote: > Also: could you provide us with a small demo code so that we can extend our unit test? The demo for added highlighting rule, or the problem with autocompletion? REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 To: arrowdodger, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, #frameworks
D6087: Haskell: Add all language pragmas as keywords.
arrowdodger updated this revision to Diff 15772. arrowdodger added a comment. - Use WordDetect instead of StringDetect for `omport` keyword. - Pop `Pragma` context on `#-}` string, not newline. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6087?vs=15129&id=15772 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 AFFECTED FILES data/syntax/haskell.xml To: arrowdodger, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, #frameworks
D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin
rjvbb added a comment. Well, somehow this wasn't closed automatically: https://commits.kde.org/kiconthemes/ac5cbf6b4aa969542a780077213cb39a4c110fe6 > Arguably, this is not the place where I would have looked for an answer to that question, first, but since it does provide an answer, it should try to answer it good. Evidently, that was also my intention. Which makes me wonder: is it possible to deploy a stylesheet that tweaks a built-in style via an auto-loading plugin, and could such a plugin take care of setting an icon theme path? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6309 To: rjvbb, #frameworks Cc: tfry, kde-mac, #frameworks
D6198: Add KAuth support to delete operation
chinmoyr added a comment. > If there was a malicous agent hiding in a dolphin plugin, it would just be making a direct call to the helper and skip all that. Till now I was not aware of what a dolphin plugin can or cannot do. I assumed there would be some kind of restriction. I was wrong , my bad. Now the ioslave can also show a warning but right now it does so only for a particular case, i.e, when only some of the items being deleted are in read-only location but for deletion in a read-only folder we rely on the warning from jobuidelegate. So, right now the only thing I find sensible to do is to make ioslave show warning for both the cases above. By removing persistence the user will have to enter password every time he deletes something which is somewhat annoying. Getting a warning everytime is annoying as well but it is only matter of a click. So to some extent it is like the sudo command. I would also like to point out that my plan, right from the start, was to use the warning from ioslave in 'copy' and 'del' method. As for the rest, mkdir, symlink, rename etc, I was to rely on the warning from the client. I believe I may have to rethink my approach. What will you suggest? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6198 To: chinmoyr, elvisangelaccio, #frameworks Cc: davidedmundson
