D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH addkf5todo REVISION DETAIL https://phabricator.kde.org/D6394 To: kossebau, #frameworks, dfaure Cc: cfeck, apol

D6047: WIP: Support XDG v6

graesslin added a comment. In https://phabricator.kde.org/D6047#119698, @mart wrote: > trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 no need to hurry with it. IMHO the way ping works is completely broken and won't work. At least Qt

D6047: WIP: Support XDG v6

davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Done all comments except ping/pong. Marco, ping me if you ever want this updating. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin,

D6047: WIP: Support XDG v6

davidedmundson updated this revision to Diff 15889. davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - cleanups REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D6047: WIP: Support XDG v6

mart added a comment. trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff,

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

cfeck added a comment. +1 That shouldn't have landed in "protected" area. And no, MSVC has not changed :) REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D6394 To: kossebau, #frameworks Cc: cfeck, apol

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

kossebau added inline comments. INLINE COMMENTS > apol wrote in kcombobox.h:527 > Why KF6? changing visibility doesn't break ABI, AFAIK. We should just not > reorder them. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B hints the access rights are mangled into the

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

apol added inline comments. INLINE COMMENTS > kcombobox.h:527 > > +// TODO KF6: make public like in base classes, so consumers do not need > to cast to base classes > +// when they have a KComboBox (or subclasses) object and want to access > this property Why KF6? changing

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

kossebau created this revision. Restricted Application added a project: Frameworks. REPOSITORY R284 KCompletion BRANCH addkf5todo REVISION DETAIL https://phabricator.kde.org/D6394 AFFECTED FILES src/kcombobox.h To: kossebau, #frameworks

D6390: WIP: Add remote runners over DBus

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This patch allows adding runners which, rather than being in-process receive a search term and provide results

Re: Kirigami in Frameworks

On Sat, Jun 24, 2017 at 3:27 PM, David Faure wrote: >> the default style for QtQuickControlsStyle1 is "Desktop" >> we could have called this style "Desktop" as well so all would have >> aligned nicely, but that could be quite dangerous, as Qt coulddecide >> any moment that they

D6313: WIP: Support device pixel ratio in icon loader and engine

mart added a comment. In https://phabricator.kde.org/D6313#118285, @kvermette wrote: > Behaviorally speaking there's justification for ensuring SVGs are treated the same as PNGs in this case. Looking at the code we aren't shimming the SVGs specifically (unless I'm missing something),

D6376: Fix double delete crash during shutdown

rjvbb added a comment. In https://phabricator.kde.org/D6376#119500, @cullmann wrote: > I don't speak about threading races. The whole class is not thread-safe, if threading occurs, all is lost. Really? Only a single thread at a time should trigger audio notifications, is that

D6376: Fix double delete crash during shutdown

cullmann abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D6376 To: cullmann, #frameworks Cc: aacid, mpyne, rjvbb