davidedmundson added a comment.
> for how i did the kwin part, it must be who called it with discardTimer
(this to allow kwin to receive 2 timeouts before deciding to kill the window)
Ok, I see how it's meant to work but I don't understand why it's done like
that.
From what I see
mart added a comment.
In https://phabricator.kde.org/D6418#120218, @davidedmundson wrote:
> who deletes the qtimer if it times out?
>
> can this timer stuff be shared by moving it into XdgShellInterface::Private
?
for how i did the kwin part, it must be who called it with
davidedmundson added a comment.
who deletes the qtimer if it times out?
can this timer stuff be shared by moving it into XdgShellInterface::Private ?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6418
To: mart, #plasma, davidedmundson, graesslin
Cc:
mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
if more ping arrives before a pong, store each of its
serial and manage them one by one
a new signal,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/15/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 28 Jun 2017 12:29:55 +
Build duration:
1 min 45 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:c0445f0c536b: DOXYGEN_PREPROC ->
DOXYGEN_SHOULD_SKIP_THIS, to standardize within KF5 (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6338?vs=15738=15940#toc
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:f9bd662f22d8: Remove custom doxygen config files
(authored by kossebau).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6339?vs=15739=15939
REVISION DETAIL
ilic added inline comments.
INLINE COMMENTS
> davidedmundson wrote in klocalizedstringtest.cpp:59
> Pretty sure it's fine. kactivities and kjs use them with no issue.
Well, since no-one else complained either, guess it's ok. Easy to fix later if
someone does complain.
> ilic wrote in
ilic accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R249 KI18n
BRANCH
removecustomdoxygencfg
REVISION DETAIL
https://phabricator.kde.org/D6339
To: kossebau, #frameworks, ilic
ilic accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R249 KI18n
BRANCH
standardizedoxygenppmacro
REVISION DETAIL
https://phabricator.kde.org/D6338
To: kossebau, #frameworks, ilic
10 matches
Mail list logo
