D6495: Don't list KF5::WindowSystem in public libraries
asturmlechner added a comment. Thanks, works for me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6495 To: davidedmundson, #plasma Cc: asturmlechner, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6493: Add KF5WindowSystem to link interface
asturmlechner abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6493 To: asturmlechner, #plasma Cc: davidedmundson, #frameworks
D6493: Add KF5WindowSystem to link interface
davidedmundson added a comment. You're right that there's a bug, but I think this solution has backwards. We don't use WindowSystem in public API, and it's PlasmaQuick/CmakeLists.txt that's wrong by putting it in public not the other way round. See https://phabricator.kde.org/D6495 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6493 To: asturmlechner, #plasma Cc: davidedmundson, #frameworks
D6495: Don't list KF5::WindowSystem in public libraries
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We don't use it in public API REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6495 AFFECTED FILES autotests/CMakeLists.txt src/plasmaquick/CMakeLists.txt To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6493: Add KF5WindowSystem to link interface
asturmlechner added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6493 To: asturmlechner, #plasma Cc: #frameworks
D6493: Add KF5WindowSystem to link interface
asturmlechner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Otherwise, reverse-dependencies are bugged with finding KF5WindowSystem themselves. TEST PLAN Builds fine, plasma-sdk does not need to add KF5WindowSystem anymore. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6493 AFFECTED FILES KF5PlasmaConfig.cmake.in src/plasma/CMakeLists.txt To: asturmlechner Cc: #frameworks
D6492: Also use m_currentRequest when checking for installed and updates
apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Otherwise if requestMoreData is called, we query the wrong request which can be quite big if it happens before it's initialized REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D6492 AFFECTED FILES src/core/engine.cpp To: apol, #frameworks, leinir
KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.7 - Build # 15 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/15/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 03 Jul 2017 16:23:56 + Build duration: 1 min 54 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) build.log Description: Binary data
kpage titles and style
Hi, How/where is the rendering of "KPage" titles determined, like for instance the "Widget Style and Behaviour" label in the `kcmshell5 style` dialog? This appears to be a KF5-specific widget that's somehow under control of the widget style. I think I figured out the how/where once but can't seem to find the info anymore so I'd appreciate a pointer. FWIW, drawing this kind of label in a frame and/or with a different background colour isn't appropriate for the native Macintosh style. Thanks, R.
D6452: Add missing export to QueueSignals
This revision was automatically updated to reflect the committed changes. Closed by commit R279:94ab2f237e6b: Add missing export to QueueSignals (authored by davidedmundson). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6452?vs=16058=16139 REVISION DETAIL https://phabricator.kde.org/D6452 AFFECTED FILES src/queuesignals.h To: davidedmundson, dfaure Cc: #frameworks
KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 28 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/28/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Mon, 03 Jul 2017 16:08:28 + Build duration: 3 min 45 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (10/10)85% (79/93)85% (79/93)73% (6039/8239)43% (10494/24415)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests83% (33/40)83% (33/40)97% (2599/2682)49% (6434/13131)src.desktoptojson100% (3/3)100% (3/3)79% (84/106)38% (123/324)src.lib67% (2/3)67% (2/3)56% (302/536)22% (181/825)src.lib.caching100% (2/2)100% (2/2)45% (352/787)18% (192/1076)src.lib.io90% (9/10)90% (9/10)58% (817/1397)29% (921/3154)src.lib.jobs71% (5/7)71% (5/7)52% (159/304)39% (57/146)src.lib.plugin100% (8/8)100% (8/8)86% (646/748)44% (984/2216)src.lib.randomness100% (2/2)100% (2/2)67% (66/99)58% (44/76)src.lib.text63% (5/8)63% (5/8)46% (349/764)40% (748/1867)src.lib.util100% (10/10)100% (10/10)81% (665/816)51% (810/1600) build.log Description: Binary data
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 23 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/23/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 03 Jul 2017 16:08:28 + Build duration: 3 min 9 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s) build.log Description: Binary data
D6331: Make sure that the tsfiles target is generated
apol updated this revision to Diff 16136. apol added a comment. - Restore the old behavior of KI18N_INSTALL_TS_FILES REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6331?vs=15720=16136 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6331 AFFECTED FILES cmake/KF5I18NMacros.cmake To: apol, #frameworks, ltoscano, lueck, aacid Cc: aacid, asturmlechner
D6484: emit runningActivityListChanged on activity creation
This revision was automatically updated to reflect the committed changes. Closed by commit R6:dce2a89774c6: emit runningActivityListChanged on activity creation (authored by mart). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6484?vs=16130=16134 REVISION DETAIL https://phabricator.kde.org/D6484 AFFECTED FILES src/lib/activitiescache_p.cpp To: mart, #plasma, ivan, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6484: emit runningActivityListChanged on activity creation
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Good work. REPOSITORY R6 KActivities BRANCH master REVISION DETAIL https://phabricator.kde.org/D6484 To: mart, #plasma, ivan, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6484: emit runningActivityListChanged on activity creation
mart added a reviewer: ivan. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D6484 To: mart, #plasma, ivan Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6484: emit runningActivityListChanged on activity creation
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if an activity gets created and started immediately, runningActivityListChanged wasn't emitted, a symptom was the activitypager applet not updating the number of activities on activity creation, now emit this on setActivityInfo both when there wasn't such activity yet or the running status changes TEST PLAN activity pager immediately reacts to activity creation, other kactivities users still work REPOSITORY R6 KActivities BRANCH master REVISION DETAIL https://phabricator.kde.org/D6484 AFFECTED FILES src/lib/activitiescache_p.cpp To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 17 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/17/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 03 Jul 2017 13:57:07 + Build duration: 1 min 50 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.plasma-packagestructuretest build.log Description: Binary data
D6480: Fix tab bar layout key handling in RTL
This revision was automatically updated to reflect the committed changes. Closed by commit R242:06410e779b4f: Fix tab bar layout key handling in RTL (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6480?vs=16120=16121 REVISION DETAIL https://phabricator.kde.org/D6480 AFFECTED FILES src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6480: Fix tab bar layout key handling in RTL
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D6480 To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6480: Fix tab bar layout key handling in RTL
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Current code will, when mirrored, treat all keys like they're the left key. BUG: 379894 TEST PLAN Ran plasma in RTL REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D6480 AFFECTED FILES src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 6 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/6/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 03 Jul 2017 09:04:02 + Build duration: 4 min 18 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/5/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 03 Jul 2017 09:04:02 + Build duration: 32 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests build.log Description: Binary data
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/5/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 03 Jul 2017 08:35:57 + Build duration: 4 min 52 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 4 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/4/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 03 Jul 2017 08:35:57 + Build duration: 56 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests build.log Description: Binary data
D1231: Add Remote Access interface to KWayland
Kanedias added a comment. How do I get ID from wl_output interface? I kinda got how I can get the needed info from DrmOutput instance, but not sure how to compare them on server and client side REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
