D6687: Adding support to ipv*.route-metric

jgrulich added a comment. Looks good to me now, it looked to me good even before, but didn't read carefully the documentation. Lamarque, do you see anything else? INLINE COMMENTS > ipv4setting.cpp:455 > > +if(routeMetric() >= 0) { > +

D6624: do not crash qaccessible by causing a resize in a resize event

cfeck added a comment. > It probably does. Were you able to test? I would prefer the simpler patch. I cannot test it, because my system does not have accessibility enabled. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6624 To: sitter, gladhorn Cc:

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/20/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 18 Jul 2017 02:41:33 + Build duration: 56 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/19/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 18 Jul 2017 02:41:33 + Build duration: 37 sec and counting JUnit Tests

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

nalvarez added a comment. Looks reasonable – although I wonder why on earth you're building KDE stuff on Cygwin... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows Cc: nalvarez, #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

apol added a reviewer: Windows. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows Cc: #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

winterz added reviewers: skelly, Build System. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system Cc: #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

winterz created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Cygwin systems aren't ELF based so don't try to pass --enable-new-dtags to 'ld' else you get

D6672: add KAboutLicense::spdx and introduce orLater qualification

mpyne added a comment. In https://phabricator.kde.org/D6672#126360, @sitter wrote: > Ah drat. We could still get rid of the second private ctor though, by moving the defaults from the private to the public and calling the full private ctor: Yes, that would be fine if you want to

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter added a comment. Ah drat. We could still get rid of the second private ctor though, by moving the defaults from the private to the public and calling the full private ctor: KAboutLicense::KAboutLicense(const KAboutData *aboutData) : d(new Private(Unknown,

D6672: add KAboutLicense::spdx and introduce orLater qualification

mpyne added a comment. I like delegating constructors, but we can't use them in Frameworks yet. :( The current compiler requirement policy is that we require a C++ compiler supported in the last 3 Qt minor releases (see

D6687: Adding support to ipv*.route-metric

pvillani added a comment. In https://phabricator.kde.org/D6687#125529, @lvsouza wrote: > The summary says this patch adds route metric support to IPv4 too, but no IPv4 file is touched by this patch. Have you missed the IPv4 changes? Added the missing files. Aboute your comment

D6687: Adding support to ipv*.route-metric

pvillani updated this revision to Diff 16836. pvillani added a comment. Adding missing files and making possible to set route-metric as 0, as described in NetworkManager documentation. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D6754: [server] Send pointer leave if focused surface gets unbound

graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As https://phabricator.kde.org/R127:98e5d269a110dca9cae1e4ed2bb3051f02a69bff just for pointer. REPOSITORY R127

D6751: [Task Manager] Fix icon size in launcher tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d28deb6f4ab2: [Task Manager] Fix icon size in launcher tooltips (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6751?vs=16809=16820

D6751: [Task Manager] Fix icon size in launcher tooltips

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6751 To: broulik, #plasma, hein, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter marked 2 inline comments as done. sitter added a comment. Oh, actually. Maybe we could/should make `KAboutLicense::KAboutLicense(const KAboutData *aboutData)` delegate to the "full" public ctor. Then we can drop `Private(const KAboutData *aboutData);` entirely. Like so

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter marked 3 inline comments as done. sitter added inline comments. INLINE COMMENTS > mpyne wrote in kaboutdata.cpp:166 > Need a setter here for `_versionRestriction` I am changing this one to delegate to the other ctor actually. Not much point > mpyne wrote in kaboutdata.cpp:206 > We use

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter updated this revision to Diff 16814. sitter added a comment. rebase REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6672?vs=16813=16814 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D6672 AFFECTED FILES

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter updated this revision to Diff 16813. sitter marked an inline comment as done. sitter added a comment. - change "partial" Private ctor to delegate to "full" ctor so we don't have repetitive init lists - fix Private cctor to copy version restriction properly - adjust copy test to

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 33 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/33/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Mon, 17 Jul 2017 12:29:44 + Build duration: 3 min 31 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/28/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 17 Jul 2017 12:29:44 + Build duration: 3 min 5 sec and counting JUnit

D6700: disable compiler warning on testing deprecated function

This revision was automatically updated to reflect the committed changes. Closed by commit R244:0c33e313d5e2: disable compiler warning on testing deprecated function (authored by sitter). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6700?vs=16696=16811

D6751: [Task Manager] Fix icon size in launcher tooltips

broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6751 To: broulik, #plasma, hein Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6751: [Task Manager] Fix icon size in launcher tooltips

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Depending on icon theme the implicit size of the icon may be huge. BUG: FIXED-IN: 5.10.4 TEST PLAN Used

Re: Review Request 129590: KAuth: Make D-Bus dependency optional.

> On Jan. 8, 2017, 6:53 nachm., David Faure wrote: > > autotests/CMakeLists.txt, line 5 > > > > > > Better split this into two, to avoid confusing people. I've update the patch, but do not have access rights to

Re: Review Request 126495: Install parsetrigrams tool for cross compiling.

> On Mai 6, 2016, 12:10 nachm., Aleix Pol Gonzalez wrote: > > data/CMakeLists.txt, line 6 > > > > > > Maybe it should be installed in `libexec`? Libexec is not supported on Windows. All executables are installed