KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 36 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/36/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Thu, 20 Jul 2017 01:19:56 + Build duration: 3 min 27 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/31/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 20 Jul 2017 01:19:56 + Build duration: 3 min 8 sec and counting JUnit

D6789: API dox: add note about moc include need with K_PLUGIN_FACTORY(_WITH_JSON)

mpyne accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH addnoteaboutmocincludewithpluginfactory REVISION DETAIL https://phabricator.kde.org/D6789 To: kossebau, #frameworks, mpyne

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 35 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/35/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Wed, 19 Jul 2017 21:42:00 + Build duration: 7 min 50 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/30/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 19 Jul 2017 21:42:00 + Build duration: 1 min 53 sec and counting JUnit

D6672: add KAboutLicense::spdx and introduce orLater qualification

This revision was automatically updated to reflect the committed changes. Closed by commit R244:107a7fd1a3c0: add KAboutLicense::spdx and introduce orLater qualification (authored by sitter). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D6672: add KAboutLicense::spdx and introduce orLater qualification

mpyne accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D6672 To: sitter, sebas, mpyne Cc: #frameworks

D6789: API dox: add note about moc include need with K_PLUGIN_FACTORY(_WITH_JSON)

kossebau created this revision. Restricted Application added a project: Frameworks. REPOSITORY R244 KCoreAddons BRANCH addnoteaboutmocincludewithpluginfactory REVISION DETAIL https://phabricator.kde.org/D6789 AFFECTED FILES src/lib/plugin/kpluginfactory.h To: kossebau, #frameworks

D6786: [server] Send text input leave if focused surface gets unbound

graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As https://phabricator.kde.org/R127:98e5d269a110dca9cae1e4ed2bb3051f02a69bff just for text input. TEST PLAN

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/34/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Wed, 19 Jul 2017 16:11:58 + Build duration: 3 min 47 sec and counting JUnit

D6776: Don't perform wayland specific fixes when on X

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0e5bb3ea70d: Don't perform wayland specific fixes when on X (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6493: Add KF5WindowSystem to link interface

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5033a104e226: Add KF5WindowSystem to link interface (authored by asturmlechner). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau updated this revision to Diff 16912. kossebau added a comment. - use cmake_parse_arguments - fix english grammar in dox REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6772?vs=16880=16912 BRANCH handlenoqmakefound REVISION DETAIL

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/21/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 19 Jul 2017 13:52:04 + Build duration: 1 min 2 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/20/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 19 Jul 2017 13:52:04 + Build duration: 43 sec and counting JUnit Tests

D6776: Don't perform wayland specific fixes when on X

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D6776 To: davidedmundson, #plasma, mart Cc: graesslin, plasma-devel,

D6776: Don't perform wayland specific fixes when on X

davidedmundson updated this revision to Diff 16911. davidedmundson added a comment. Fixed comment nonsense. Shuffled other code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6776?vs=16899=16911 BRANCH origin-master (branched from

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a comment. A regression due to https://phabricator.kde.org/R240:8ac7abb78d97210c5cbbc87fba83d58d7b843a8d Seems the "it allows for modules using it to decide what they should do" was never told the modules using it ;) REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D6767: simplify setContents by letting Qt do more of the work

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D6767 To: sitter, cfeck, davidedmundson Cc: davidedmundson, #frameworks

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a comment. In https://phabricator.kde.org/D6772#126799, @apol wrote: > What's the background for the change? When KDE_INSTALL_USE_QT_SYS_PATHS is explicitely set to ON but no qmake-qt5 executable found (like @rdieter reported to be possible on fedora packaging),

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

apol added a comment. What's the background for the change? INLINE COMMENTS > ECMQueryQmake.cmake:19 > if(NOT QMAKE_EXECUTABLE) > -set(${result_variable} "" PARENT_SCOPE) > -message(WARNING "Should specify a qmake Qt5 binary. Can't check > ${qt_variable}") > -

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

kossebau added a reviewer: apol. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter, apol Cc: #build_system

D6782: Remove unused init() declaration from K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL

kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Method implementation was removed in https://phabricator.kde.org/R244:b6c7c9b93b8dbb24c4a60e7fe72bb1d561d968a0 so this declaration just adds dead code to the macro expansion. TEST PLAN

D6774: Fix labels of DeleteFile/RenameFile actions

elvisangelaccio added a dependent revision: D6777: Port to KStandardAction::MoveToTrash. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D6774 To: elvisangelaccio, #frameworks