D6817: Fix crash based on "random" destruction order

2017-07-21 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:d2d0c00c91dd: fix crash on view destruction because of non-deterministic cleanup of objects (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

KDE CI: Frameworks krunner kf5-qt5 WindowsQt5.7 - Build # 20 - Still unstable!

2017-07-21 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsQt5.7/20/ Project: Frameworks krunner kf5-qt5 WindowsQt5.7 Date of build: Fri, 21 Jul 2017 21:10:56 + Build duration: 2 min 52 sec and counting JUnit Tests

D6820: Add QValidator to KTimeCombobox

2017-07-21 Thread Martin Bednar
bednar created this revision. bednar added a project: Frameworks. REVISION SUMMARY Seeing the "TODO" in KTimeComboBoxPrivate::timeFormatToInputMask, I decided to try and replace the input mask with a QValidator approach (as seen in KDatePicker). This is a first iteration to see if there is i

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.7 - Build # 17 - Still Unstable!

2017-07-21 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/17/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 21 Jul 2017 20:15:35 + Build duration: 2 min 46 sec and counting JUnit Tests

D6817: Fix crash based on "random" destruction order

2017-07-21 Thread Kevin Funk
kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I can't reproduce the crash even without this patch anymore :\ I can't reproduce it *with* this patch either. The patch makes sense given my backtrace in the bug report => ship it! REPOS

D6815: kcmtrash: fix i18n warning

2017-07-21 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Indeed, forget what I said, it's perfectly valid XML. REPOSITORY R241 KIO BRANCH fix-trash-i18n (branched from master) REVISION DETAIL https://phabricator.kde.org/D6815 To: elvisangelaccio, dfaure, davidedmundson Cc: #frameworks

D6817: Fix crash based on "random" destruction order

2017-07-21 Thread Christoph Cullmann
cullmann created this revision. Restricted Application added a subscriber: kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY See bug 381284, actionmenu might end up trying to delete objects already cleaned up by the parent as it has the same parent as the action

D6816: Fix kdirwatch warning

2017-07-21 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R241:36aee9215a1f: Fix kdirwatch warning (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6816?vs=16976&id=16978 REVISION DETAIL https://phab

D6815: kcmtrash: fix i18n warning

2017-07-21 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D6815#127271, @dfaure wrote: > Isn't the use of single quotes for XML attribute values a little bit ... unorthodox? I guess, but it's legal XML and looks better than escaping the double quote imho I'll push afte

D6816: Fix kdirwatch warning

2017-07-21 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-kdirwatch-warning (branched from master) REVISION DETAIL https://phabricator.kde.org/D6816 To: elvisangelaccio, dfaure Cc: #frameworks

D6815: kcmtrash: fix i18n warning

2017-07-21 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-trash-i18n (branched from master) REVISION DETAIL https://phabricator.kde.org/D6815 To: elvisangelaccio, dfaure, davidedmundson Cc: #frameworks

D6815: kcmtrash: fix i18n warning

2017-07-21 Thread David Faure
dfaure added a comment. Isn't the use of single quotes for XML attribute values a little bit ... unorthodox? Looks ok otherwise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6815 To: elvisangelaccio, dfaure Cc: #frameworks

D6815: kcmtrash: fix i18n warning

2017-07-21 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Fixes the following warning: Tag 'b' is not defined in message {<__kuit_internal_top__>Check this box to allow automatic dele

D6816: Fix kdirwatch warning

2017-07-21 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KDirWatch cannot watch QRC paths (see https://phabricator.kde.org/D5877). REPOSITORY R241 KIO BRANCH fix-kdirwatch-warning (bra

D6810: Remove "*.conf" extension rule

2017-07-21 Thread Yunhe Guo
guoyunhe closed this revision. guoyunhe added a comment. This patch has been committed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6810 To: guoyunhe, #framework_syntax_hightlighting, vkrause Cc: vkrause, #frameworks

D6810: Remove "*.conf" extension rule

2017-07-21 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Seems reasonable. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6810 To: guoyunhe, #framework_syntax_hightlighting, vkrause Cc: vkrause, #framework

D6810: Remove "*.conf" extension rule

2017-07-21 Thread Yunhe Guo
guoyunhe added a comment. This should fix bug https://bugs.kde.org/show_bug.cgi?id=382520 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6810 To: guoyunhe, #framework_syntax_hightlighting Cc: #frameworks

D6810: Remove "*.conf" extension rule

2017-07-21 Thread Yunhe Guo
guoyunhe created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY *.conf is a too common file extension that was used by many other file types, like Fontconfig and Apache. Having this rule will mostly c

D6808: Mark MPa and PSI as common units

2017-07-21 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Resolves https://bugs.kde.org/show_bug.cgi?id=379171 REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D6808