KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 37 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/37/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 23:17:33 + Build duration: 8 min 18 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447 build.log Description: Binary data
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 36 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/36/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 22:54:44 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447 build.log Description: Binary data
D6906: Create a "." entry even on empty dirs
albertvaka added a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks, elvisangelaccio
D6906: Create a "." entry even on empty dirs
albertvaka edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks
D6906: Create a "." entry even on empty dirs
albertvaka created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Fixes bug 382046 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 AFFECTED FILES src/core/slavebase.cpp To: albertvaka, #frameworks
D6803: Add template for a ktexteditor plugin
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c3db3b8d4978: Add template for a ktexteditor plugin
(authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6803?vs=16949=17193#toc
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6803?vs=16949=17193
REVISION DETAIL
https://phabricator.kde.org/D6803
AFFECTED FILES
CMakeLists.txt
ExtraDesktop.sh
templates/CMakeLists.txt
templates/ktexteditor-plugin/CMakeLists.txt
templates/ktexteditor-plugin/README.md
templates/ktexteditor-plugin/ktexteditor-plugin.kdevtemplate
templates/ktexteditor-plugin/ktexteditor-plugin.png
templates/ktexteditor-plugin/src/%{APPNAMELC}.json
templates/ktexteditor-plugin/src/%{APPNAMELC}plugin.cpp
templates/ktexteditor-plugin/src/%{APPNAMELC}plugin.h
templates/ktexteditor-plugin/src/%{APPNAMELC}view.cpp
templates/ktexteditor-plugin/src/%{APPNAMELC}view.h
templates/ktexteditor-plugin/src/CMakeLists.txt
templates/ktexteditor-plugin/src/Message.sh
To: kossebau, #frameworks, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel
D6840: Add KF6 TODO for missing argument namespace in slot signature
This revision was automatically updated to reflect the committed changes. Closed by commit R39:b319de339d81: Add KF6 TODO for missing argument namespace in slot signature (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6840?vs=17038=17192 REVISION DETAIL https://phabricator.kde.org/D6840 AFFECTED FILES src/view/kateview.h To: kossebau, #kate, kfunk Cc: kfunk, kwrite-devel, #frameworks
KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 39 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/39/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Tue, 25 Jul 2017 22:50:09 + Build duration: 3 min 45 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (10/10)85% (79/93)85% (79/93)74% (6101/8282)43% (10650/24632)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests83% (33/40)83% (33/40)97% (2635/2718)49% (6538/13336)src.desktoptojson100% (3/3)100% (3/3)79% (84/106)38% (123/324)src.lib67% (2/3)67% (2/3)60% (326/541)27% (225/829)src.lib.caching100% (2/2)100% (2/2)45% (352/787)18% (192/1076)src.lib.io90% (9/10)90% (9/10)58% (817/1397)29% (925/3158)src.lib.jobs71% (5/7)71% (5/7)52% (159/304)39% (57/146)src.lib.plugin100% (8/8)100% (8/8)86% (646/748)44% (984/2216)src.lib.randomness100% (2/2)100% (2/2)67% (66/99)58% (44/76)src.lib.text63% (5/8)63% (5/8)46% (349/764)40% (748/1867)src.lib.util100% (10/10)100% (10/10)82% (667/818)51% (814/1604) build.log Description: Binary data
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 34 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/34/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 22:50:09 + Build duration: 1 min 43 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdirwatch_stat_unittest build.log Description: Binary data
D6782: Remove unused init() declaration from K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL
This revision was automatically updated to reflect the committed changes. Closed by commit R244:a675fe908bed: Remove unused init() declaration from… (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6782?vs=16910=17190 REVISION DETAIL https://phabricator.kde.org/D6782 AFFECTED FILES src/lib/plugin/kpluginfactory.h To: kossebau, #frameworks, kfunk
D6895: Handle fine-grained wheel event in zoomin
carewolf added a comment. DefaultDeltasPerStep is always exactly 120 :D REVISION DETAIL https://phabricator.kde.org/D6895 To: carewolf, cullmann Cc: #frameworks
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart updated this revision to Diff 17176. mart added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. readstringlist REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17175=17176 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h src/kdedmodule.desktop To: mart, #frameworks, #plasma Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart added a comment. ah, yeah, that's a leftover, should go REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: broulik, #frameworks
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart updated this revision to Diff 17177. mart added a comment. less blanks REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17176=17177 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h To: mart, #frameworks, #plasma Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart marked 2 inline comments as done. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
broulik added a comment. Also, your property is `X-KDE-PluginInfo-OnlySupportedPlatform` but you check for `X-KDE-OnlyShowOnQtPlatforms` REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: broulik, #frameworks
D6899: support X-KDE-OnlyShowOnQtPlatforms
broulik added inline comments.
INLINE COMMENTS
> kded.cpp:328
> +{
> +const QStringList supportedPlatforms =
> module.rawData().value(QStringLiteral("X-KDE-OnlyShowOnQtPlatforms")).toVariant().toString().split(QStringLiteral(";"),
> QString::SkipEmptyParts);
> +
KPluginMetaData::readStringList(module.rawData(),
QStringLiteral("X-KDE-OnlyShowOnQtPlatforms"));
> kded.cpp:330
> +
> +return supportedPlatforms.count() == 0 ||
> supportedPlatforms.contains(qApp->platformName());
> +}
`isEmpty()`
> kded.h:90
> + */
> +bool platformSupportsModule(const KPluginMetaData ) const;
> +//@}
static?
> kdedmodule.desktop:111
> +[PropertyDef::X-KDE-PluginInfo-OnlySupportedPlatform]
> +Type=QString
QStringList
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D6899
To: mart, #frameworks, #plasma
Cc: broulik, #frameworks
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart added reviewers: Frameworks, Plasma. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: #frameworks
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY some kded modules can only run in one platform, especially only xcb or only wayland. this makes kded support the X-KDE-OnlyShowOnQtPlatforms entry in the desktop file TEST PLAN touchpad and keyboard kdeds not loaded in wayland REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h src/kdedmodule.desktop To: mart Cc: #frameworks
D6679: Treat Button/ToolButton labels as plaintext
This revision was automatically updated to reflect the committed changes. fvogt marked an inline comment as done. Closed by commit R242:48a8245db4d8: Treat Button/ToolButton labels as plaintext (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6679?vs=16649=17174 REVISION DETAIL https://phabricator.kde.org/D6679 AFFECTED FILES src/declarativeimports/plasmastyle/ButtonStyle.qml src/declarativeimports/plasmastyle/ToolButtonStyle.qml src/declarativeimports/plasmastyle/private/Util.js To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6679: Treat Button/ToolButton labels as plaintext
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6679 To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6782: Remove unused init() declaration from K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL
kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH removeUnusedFactoryInitDeclaration REVISION DETAIL https://phabricator.kde.org/D6782 To: kossebau, #frameworks, kfunk
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 35 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/35/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 12:59:14 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447 build.log Description: Binary data
D6803: Add template for a ktexteditor plugin
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Guess makes sense to have that bundled. Thanks for the work! REPOSITORY R39 KTextEditor BRANCH addplugintemplate REVISION DETAIL https://phabricator.kde.org/D6803 To: kossebau, #frameworks, #ktexteditor, cullmann Cc: cullmann, kwrite-devel
D6800: Add template for a simple kpart-based application
kossebau added a comment. So with the Messages.sh sorted out (thanks @aacid for raising and @lueck for pointing out where it is already handled), if there are no objections, would add on Tuesday, 27th. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6800 To: kossebau, #frameworks, dfaure Cc: lueck, ltoscano, aacid
D6803: Add template for a ktexteditor plugin
kossebau added a comment. So if there are no objections, would add on Tuesday, 27th. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6803 To: kossebau, #frameworks, #ktexteditor Cc: kwrite-devel
D6895: Handle fine-grained wheel event in zoomin
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable to me. I assume the DefaultDeltasPerStep is always > 0 ;=) REVISION DETAIL https://phabricator.kde.org/D6895 To: carewolf, cullmann Cc: #frameworks
D6895: Handle fine-grained wheel event in zoomin
carewolf updated this revision to Diff 17169. carewolf added a comment. Fix smoothness of zooming down CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6895?vs=17167=17169 REVISION DETAIL https://phabricator.kde.org/D6895 AFFECTED FILES src/render/katerenderer.cpp src/render/katerenderer.h src/view/kateviewinternal.cpp src/view/kateviewinternal.h To: carewolf, cullmann Cc: #frameworks
D6895: Handle fine-grained wheel event in zoomin
carewolf added a reviewer: cullmann. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6895 To: carewolf, cullmann Cc: #frameworks
D6895: Handle fine-grained wheel event in zoomin
carewolf created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Avoid zooming in or out too fast when wheel events are finer grained. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6895 AFFECTED FILES src/render/katerenderer.cpp src/render/katerenderer.h src/view/kateviewinternal.cpp src/view/kateviewinternal.h To: carewolf Cc: #frameworks
D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment
broulik added a comment. Yes REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6894 To: broulik, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment
davidedmundson added a comment. > Right clicked an applet so if (applet) would have been true? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6894 To: broulik, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The applet context menu contains containment actions which might be outdated if we don't call this. TEST PLAN Right clicked an applet on my desktop, the "Folder View Settings" submenu containing the desktop containment actions no longer showed actions like "Empty Trash" REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6894 AFFECTED FILES src/scriptengines/qml/plasmoid/containmentinterface.cpp To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5788: Add syntax highlighting for YANG data modeling language
This revision was automatically updated to reflect the committed changes. Closed by commit R216:fa65afb0f7c5: Add syntax highlighting for YANG data modeling language (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5788?vs=14342=17162#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5788?vs=14342=17162 REVISION DETAIL https://phabricator.kde.org/D5788 AFFECTED FILES autotests/folding/highlight.yang.fold autotests/html/highlight.yang.html autotests/input/highlight.yang autotests/reference/highlight.yang.ref data/syntax/yang.xml To: nalvarez, #kate, jkt, dhaumann Cc: aacid, dhaumann, jkt, #frameworks
KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 38 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/38/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Tue, 25 Jul 2017 07:47:58 + Build duration: 4 min 29 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (10/10)85% (79/93)85% (79/93)74% (6101/8282)43% (10650/24632)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests83% (33/40)83% (33/40)97% (2635/2718)49% (6538/13336)src.desktoptojson100% (3/3)100% (3/3)79% (84/106)38% (123/324)src.lib67% (2/3)67% (2/3)60% (326/541)27% (225/829)src.lib.caching100% (2/2)100% (2/2)45% (352/787)18% (192/1076)src.lib.io90% (9/10)90% (9/10)58% (817/1397)29% (925/3158)src.lib.jobs71% (5/7)71% (5/7)52% (159/304)39% (57/146)src.lib.plugin100% (8/8)100% (8/8)86% (646/748)44% (984/2216)src.lib.randomness100% (2/2)100% (2/2)67% (66/99)58% (44/76)src.lib.text63% (5/8)63% (5/8)46% (349/764)40% (748/1867)src.lib.util100% (10/10)100% (10/10)82% (667/818)51% (814/1604) build.log Description: Binary data
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 33 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/33/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 07:47:58 + Build duration: 2 min 55 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdirwatch_stat_unittestFailed: TestSuite.kshelltest build.log Description: Binary data
