Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

2017-07-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127111/#review103504 --- Fix it, then Ship it! src/filewidgets/kurlnavigator.h

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 40 - Still Unstable!

2017-07-28 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/40/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 29 Jul 2017 02:42:13 + Build duration: 20 min and counting JUnit Tests

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 40 - Still Unstable!

2017-07-28 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/40/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 28 Jul 2017 23:21:02 + Build duration: 3 min 11 sec and counting

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

2017-07-28 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R240:03fc1de44ef9: Fix usage of query_qmake: differ between calls expecting qmake or not (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D6972: Add CC BY-SA 4.0 International

2017-07-28 Thread Luigi Toscano
ltoscano updated this revision to Diff 17339. ltoscano added a comment. Simplify the link REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6972?vs=17337=17339 BRANCH add-ccbysa4 REVISION DETAIL https://phabricator.kde.org/D6972 AFFECTED FILES

D6972: Add CC BY-SA 4.0 International

2017-07-28 Thread Luigi Toscano
ltoscano created this revision. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: Documentation, Frameworks. REVISION SUMMARY New default license (for new documents or relicensed). Discussed in the previous months on the kde-community@

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 22 - Still Unstable!

2017-07-28 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/22/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 28 Jul 2017 16:09:24 + Build duration: 4 min 23 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 21 - Still Unstable!

2017-07-28 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/21/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 28 Jul 2017 16:09:24 + Build duration: 45 sec and counting JUnit Tests

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6964#129762, @davidedmundson wrote: > > ‎[13:51] ‎<‎notmart‎>‎ hmm, still random failures in loading components > > ‎[13:58] ‎<‎notmart‎>‎ gaah, import of a subdirectory still breaks > > Is this fixed? no, that's the

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread David Edmundson
davidedmundson added a comment. > ‎[13:51] ‎<‎notmart‎>‎ hmm, still random failures in loading components > ‎[13:58] ‎<‎notmart‎>‎ gaah, import of a subdirectory still breaks Is this fixed? Also we'll need to maybe look at changing how kirigami does its theme stuff so we can make

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread Marco Martin
mart updated this revision to Diff 17325. mart added a comment. comment useless debug REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6964?vs=17324=17325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6964 AFFECTED

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY using the qml url interceptor, rewrite imports in order to load always the plasma styled qqc2 controls in plasmoids and

D6963: Don't block starting notification service

2017-07-28 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY We don't need to manually start the DBus service. It blocks the calling app, and dbusServiceExists means that we will always end

D6960: Properly handle org.fd.Notifications service failing to start

2017-07-28 Thread Daniel Vrátil
dvratil created this revision. dvratil added a project: Frameworks. REVISION SUMMARY Handle the situation when the startServiceByName invoked from the NotifyByPopup plugin fails by setting dbusServiceExists back to false. This forces the plugin to fallback to KPassivePopup instead of putting

D6906: Create a "." entry even on empty dirs

2017-07-28 Thread David Faure
dfaure added a comment. Difficult to test in kio itself, but for sure testable in the autotest for kio_desktop (plasma-workspace/kioslave/desktop/tests) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks, elvisangelaccio Cc: aacid, dfaure

D6906: Create a "." entry even on empty dirs

2017-07-28 Thread David Faure
dfaure added a comment. This commit breaks plasmashell startup for me, with a non-empty desktop:/ 2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister KCoreDirListerCache::slotEntries: KCoreDirListerCache(0x7f6a2002c980) KIO::ListJob(0x26a9ae0) new entries for QUrl("desktop:/")

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-28 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:b669d4148a39: Destroy all kwayland objects created by registry when it is destroyed (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D6946: Emit connectionDied if the QPA is destroyed

2017-07-28 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:7dd186258620: Emit connectionDied if the QPA is destroyed (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6946?vs=17273=17311