KDE CI: Frameworks kparts kf5-qt5 WindowsQt5.7 - Build # 35 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsQt5.7/35/ Project: Frameworks kparts kf5-qt5 WindowsQt5.7 Date of build: Thu, 10 Aug 2017 02:50:42 + Build duration: 27 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) build.log Description: Binary data
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 51 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/51/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 10 Aug 2017 02:51:02 + Build duration: 26 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447 build.log Description: Binary data
KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 51 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/51/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 23:54:26 + Build duration: 2 min 45 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.KDEInstallDirsTest.relative_or_absolute build.log Description: Binary data
KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 42 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/42/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 23:54:26 + Build duration: 2 min 3 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMPoQmToolsTest Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 50 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/50/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 23:45:26 + Build duration: 3 min 33 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMQMLModulesFailed: TestSuite.KDEInstallDirsTest.relative_or_absolute build.log Description: Binary data
D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.
cgiboudeaux added a comment. In https://phabricator.kde.org/D7198#134234, @cgiboudeaux wrote: > Fixed with https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498 (+ https://phabricator.kde.org/R240:ef01c93637e1840ee701673970a371c011e36a40) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: aacid, kfunk, #frameworks, #build_system
KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 41 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/41/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 23:45:26 + Build duration: 2 min 2 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMPoQmToolsTestFailed: TestSuite.ECMQMLModules Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 49 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/49/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 23:32:21 + Build duration: 3 min 41 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMQMLModulesFailed: TestSuite.ExecuteKDEModulesFailed: TestSuite.KDEFetchTranslationsFailed: TestSuite.KDEInstallDirsTest.relative_or_absolute build.log Description: Binary data
KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 40 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/40/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 23:32:21 + Build duration: 1 min 54 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMPoQmToolsTestFailed: TestSuite.ECMQMLModulesFailed: TestSuite.ExecuteKDEModulesFailed: TestSuite.KDEFetchTranslations Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.
cgiboudeaux added a comment. Fixed with https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: aacid, kfunk, #frameworks, #build_system
KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 48 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/48/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 23:23:31 + Build duration: 2 min 47 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMQMLModulesFailed: TestSuite.KDEInstallDirsTest.relative_or_absolute build.log Description: Binary data
KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 39 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/39/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 23:23:31 + Build duration: 1 min 58 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMPoQmToolsTestFailed: TestSuite.ECMQMLModulesFailed: TestSuite.ExecuteKDEModulesFailed: TestSuite.KDEFetchTranslations Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.
aacid added a comment. You broke all the builds REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: aacid, kfunk, #frameworks, #build_system
KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 19 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/19/
Project:
Frameworks baloo kf5-qt5 XenialQt5.7
Date of build:
Wed, 09 Aug 2017 21:40:29 +
Build duration:
1 min 40 sec and counting
CONSOLE OUTPUT
[...truncated 46.40 KB...]Retrieving: Frameworks-kxmlgui-kf5-qt5Retrieving: Frameworks-kplotting-kf5-qt5Retrieving: Frameworks-kunitconversion-kf5-qt5Retrieving: Frameworks-attica-kf5-qt5Retrieving: Frameworks-krunner-kf5-qt5Retrieving: Frameworks-kitemmodels-kf5-qt5Retrieving: Frameworks-threadweaver-kf5-qt5Retrieving: Frameworks-kbookmarks-kf5-qt5Retrieving: Frameworks-kdewebkit-kf5-qt5Retrieving: Frameworks-breeze-icons-kf5-qt5Retrieving: Frameworks-kpackage-kf5-qt5Retrieving: Frameworks-kauth-kf5-qt5Retrieving: Frameworks-kded-kf5-qt5Retrieving: Frameworks-kfilemetadata-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kdelibs4support-kf5-qt5Retrieving: Frameworks-kross-kf5-qt5Retrieving: Frameworks-kdbusaddons-kf5-qt5Retrieving: Frameworks-kwallet-kf5-qt5Retrieving: Frameworks-kwayland-kf5-qt5Retrieving: Frameworks-ktextwidgets-kf5-qt5Retrieving: Frameworks-kiconthemes-kf5-qt5Retrieving: Frameworks-polkit-qt-1-kf5-qt5Retrieving: Frameworks-sonnet-kf5-qt5Retrieving: Frameworks-kitemviews-kf5-qt5Retrieving: Frameworks-kinit-kf5-qt5Retrieving: Frameworks-kglobalaccel-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-kcrash-kf5-qt5Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kparts-kf5-qt5Retrieving: Frameworks-kconfigwidgets-kf5-qt5Retrieving: Frameworks-kdoctools-kf5-qt5Retrieving: Frameworks-syntax-highlighting-kf5-qt5Retrieving: Frameworks-kjobwidgets-kf5-qt5Retrieving: Frameworks-ktexteditor-kf5-qt5Retrieving: Frameworks-kemoticons-kf5-qt5Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-kdesignerplugin-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-kservice-kf5-qt5Retrieving: Frameworks-kio-kf5-qt5Retrieving: Frameworks-phonon-kf5-qt5Retrieving: Frameworks-kactivities-kf5-qt5Retrieving: Frameworks-kjs-kf5-qt5Retrieving: Frameworks-plasma-framework-kf5-qt5Retrieving: Frameworks-kcompletion-kf5-qt5Retrieving: Frameworks-knotifications-kf5-qt5Retrieving: Frameworks-kwindowsystem-kf5-qt5Retrieving: Frameworks-kcodecs-kf5-qt5Retrieving: Frameworks-kdeclarative-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[Frameworks baloo kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project baloo --branchGroup kf5-qt5 --platform XenialQt5.7 --installTo /home/jenkins/install-prefix/cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks baloo kf5-qt5 XenialQt5.7"-- The C compiler identification is GNU 5.4.0-- The CXX compiler identification is GNU 5.4.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- CMake Error at /home/jenkins/install-prefix/share/ECM/kde-modules/KDECMakeSettings.cmake:252 (if): if given arguments:"WIN32" "OR" "5.37.0" "VERSION_GREATER_EQUAL" "5.38.0" Unknown arguments specifiedCall Stack (most recent call first): CMakeLists.txt:42 (include)-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks baloo kf5-qt5 XenialQt5.7/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks baloo kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production/usr/lib/python3/dist-packages/Crypto/Cipher/blockalgo.py:141: FutureWarning: CTR mode needs counter parameter, not IV self._cipher = factory.new(key, *args, **kwargs)[Pipeline] emailextrecipients[Pipeline] emailext
build.log
Description: Binary data
D5631: Fix directory based search.
This revision was automatically updated to reflect the committed changes. Closed by commit R293:5f6bd28119c6: Fix directory based search. (authored by xuetianweng). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5631?vs=13905=17950 REVISION DETAIL https://phabricator.kde.org/D5631 AFFECTED FILES src/lib/searchstore.cpp To: xuetianweng, #frameworks, lbeltrame Cc: elvisangelaccio, lbeltrame
D5631: Fix directory based search.
elvisangelaccio added a comment. Any reason why this hasn't been committed yet? REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D5631 To: xuetianweng, #frameworks, lbeltrame Cc: elvisangelaccio, lbeltrame
D7045: Remove busy loop check in TransferJobPrivate::slotDataReqFromDevice
dfaure added a comment. Yes that would be a good idea. AFAICS it's still one good reason to loop around, i.e. it's a possible regression from this patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7045 To: aacid Cc: dfaure, apol, #frameworks
D7045: Remove busy loop check in TransferJobPrivate::slotDataReqFromDevice
aacid added a comment. If you read the code (and the test that was failing once i changed the code), no i don't think it is about that. Do you want me to add a unit test for that scenario? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7045 To: aacid Cc: dfaure, apol, #frameworks
D6775: Fix labels of DeleteFile/RenameFile actions
This revision was automatically updated to reflect the committed changes. Closed by commit R237:0a166cb2b421: Fix labels of DeleteFile/RenameFile actions (authored by elvisangelaccio). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6775?vs=16884=17944 REVISION DETAIL https://phabricator.kde.org/D6775 AFFECTED FILES src/gui/kstandardshortcut.cpp To: elvisangelaccio, #frameworks, dfaure
KDE CI: Frameworks kconfig kf5-qt5 XenialQt5.7 - Build # 26 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20XenialQt5.7/26/
Project:
Frameworks kconfig kf5-qt5 XenialQt5.7
Date of build:
Wed, 09 Aug 2017 20:35:14 +
Build duration:
42 sec and counting
CONSOLE OUTPUT
[...truncated 36.28 KB...] > git init /home/jenkins/workspace/Frameworks kconfig kf5-qt5 XenialQt5.7/ci-tooling/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision b8a07296c9538dca7cb7e5946577276aa1241f1e (origin/master)Commit message: "Merge branch 'master' of git://anongit.kde.org/kde-dev-scripts" > git config core.sparsecheckout # timeout=10 > git checkout -f b8a07296c9538dca7cb7e5946577276aa1241f1e[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks kconfig kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kconfig --branchGroup kf5-qt5 --environment production --platform XenialQt5.7 --installTo /home/jenkins/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[Frameworks kconfig kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project kconfig --branchGroup kf5-qt5 --platform XenialQt5.7 --installTo /home/jenkins/install-prefix/cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks kconfig kf5-qt5 XenialQt5.7"-- The C compiler identification is GNU 5.4.0-- The CXX compiler identification is GNU 5.4.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- CMake Warning (dev) at /usr/lib/x86_64-linux-gnu/cmake/Qt5/Qt5ModuleLocation.cmake:4 (set): Policy CMP0053 is not set: Simplify variable reference and escape sequence evaluation. Run "cmake --help-policy CMP0053" for policy details. Use the cmake_policy command to set the policy and suppress this warning. For input:'${_qt5_install_prefix}/Qt5@module@/Qt5@module@Config.cmake' the old evaluation rules produce:'/usr/lib/x86_64-linux-gnu/cmake/Qt5/Qt5Config.cmake' but the new evaluation rules produce:'/usr/lib/x86_64-linux-gnu/cmake/Qt5@module@/Qt5@module@Config.cmake' Using the old result for compatibility since the policy is not set.Call Stack (most recent call first): /usr/lib/x86_64-linux-gnu/cmake/Qt5/Qt5Config.cmake:25 (include) CMakeLists.txt:18 (find_package)This warning is for project developers. Use -Wno-dev to suppress it.-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at /home/jenkins/install-prefix/share/ECM/kde-modules/KDECMakeSettings.cmake:252 (if): if given arguments:"WIN32" "OR" "5.37.0" "VERSION_GREATER_EQUAL" "5.38.0" Unknown arguments specifiedCall Stack (most recent call first): CMakeLists.txt:22 (include)-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks kconfig kf5-qt5 XenialQt5.7/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks kconfig kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production/usr/lib/python3/dist-packages/Crypto/Cipher/blockalgo.py:141: FutureWarning: CTR mode needs counter parameter, not IV self._cipher = factory.new(key, *args, **kwargs)[Pipeline] emailextrecipients[Pipeline] emailext
build.log
Description: Binary data
D6774: Fix labels of DeleteFile/RenameFile actions
This revision was automatically updated to reflect the committed changes. Closed by commit R265:b0a481e66905: Fix labels of DeleteFile/RenameFile actions (authored by elvisangelaccio). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6774?vs=17901=17942 REVISION DETAIL https://phabricator.kde.org/D6774 AFFECTED FILES src/kstandardaction.h src/kstandardaction_p.h To: elvisangelaccio, #frameworks, dfaure Cc: dfaure, cfeck
KDE CI: Frameworks kconfigwidgets kf5-qt5 XenialQt5.7 - Build # 21 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20XenialQt5.7/21/
Project:
Frameworks kconfigwidgets kf5-qt5 XenialQt5.7
Date of build:
Wed, 09 Aug 2017 20:28:49 +
Build duration:
1 min 20 sec and counting
CONSOLE OUTPUT
[...truncated 31.49 KB...] > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10Fetching upstream changes from https://anongit.kde.org/kapidox > git fetch --tags --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 3afc9468606f06d4cb3c5a009875edba52a83710 (origin/master)Commit message: "Escape HTML from search query" > git config core.sparsecheckout # timeout=10 > git checkout -f 3afc9468606f06d4cb3c5a009875edba52a83710[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-dev-scripts > git init /home/jenkins/workspace/Frameworks kconfigwidgets kf5-qt5 XenialQt5.7/ci-tooling/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision b8a07296c9538dca7cb7e5946577276aa1241f1e (origin/master)Commit message: "Merge branch 'master' of git://anongit.kde.org/kde-dev-scripts" > git config core.sparsecheckout # timeout=10 > git checkout -f b8a07296c9538dca7cb7e5946577276aa1241f1e[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks kconfigwidgets kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kconfigwidgets --branchGroup kf5-qt5 --environment production --platform XenialQt5.7 --installTo /home/jenkins/install-prefix/Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kauth-kf5-qt5Retrieving: Frameworks-kguiaddons-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kdoctools-kf5-qt5Retrieving: Frameworks-kcodecs-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-polkit-qt-1-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-karchive-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[Frameworks kconfigwidgets kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project kconfigwidgets --branchGroup kf5-qt5 --platform XenialQt5.7 --installTo /home/jenkins/install-prefix/cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks kconfigwidgets kf5-qt5 XenialQt5.7"-- The C compiler identification is GNU 5.4.0-- The CXX compiler identification is GNU 5.4.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at /home/jenkins/install-prefix/share/ECM/kde-modules/KDECMakeSettings.cmake:252 (if): if given arguments:"WIN32" "OR" "5.37.0" "VERSION_GREATER_EQUAL" "5.38.0" Unknown arguments specifiedCall Stack (most recent call first): CMakeLists.txt:18 (include)-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks kconfigwidgets kf5-qt5 XenialQt5.7/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks kconfigwidgets kf5-qt5 XenialQt5.7] Running shell
D7153: Drop broken mid-button click handling
This revision was automatically updated to reflect the committed changes. Closed by commit R263:c47154c9fbdb: Drop broken mid-button click handling (authored by elvisangelaccio). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7153?vs=17756=17940 REVISION DETAIL https://phabricator.kde.org/D7153 AFFECTED FILES src/ktoolbar.cpp To: elvisangelaccio, #frameworks, dfaure Cc: dfaure
KDE CI: Frameworks kxmlgui kf5-qt5 XenialQt5.7 - Build # 31 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20XenialQt5.7/31/
Project:
Frameworks kxmlgui kf5-qt5 XenialQt5.7
Date of build:
Wed, 09 Aug 2017 20:00:47 +
Build duration:
59 sec and counting
CONSOLE OUTPUT
[...truncated 36.25 KB...] > git init /home/jenkins/workspace/Frameworks kxmlgui kf5-qt5 XenialQt5.7/ci-tooling/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision b8a07296c9538dca7cb7e5946577276aa1241f1e (origin/master)Commit message: "Merge branch 'master' of git://anongit.kde.org/kde-dev-scripts" > git config core.sparsecheckout # timeout=10 > git checkout -f b8a07296c9538dca7cb7e5946577276aa1241f1e[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks kxmlgui kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kxmlgui --branchGroup kf5-qt5 --environment production --platform XenialQt5.7 --installTo /home/jenkins/install-prefix/Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-breeze-icons-kf5-qt5Retrieving: Frameworks-kconfigwidgets-kf5-qt5Retrieving: Frameworks-kdoctools-kf5-qt5Retrieving: Frameworks-kitemviews-kf5-qt5Retrieving: Frameworks-kiconthemes-kf5-qt5Retrieving: Frameworks-kcodecs-kf5-qt5Retrieving: Frameworks-kservice-kf5-qt5Retrieving: Frameworks-sonnet-kf5-qt5Retrieving: Frameworks-kdbusaddons-kf5-qt5Retrieving: Frameworks-polkit-qt-1-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kcrash-kf5-qt5Retrieving: Frameworks-attica-kf5-qt5Retrieving: Frameworks-kwindowsystem-kf5-qt5Retrieving: Frameworks-kglobalaccel-kf5-qt5Retrieving: Frameworks-kcompletion-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-kauth-kf5-qt5Retrieving: Frameworks-ktextwidgets-kf5-qt5Retrieving: Frameworks-kguiaddons-kf5-qt5Retrieving: Frameworks-karchive-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[Frameworks kxmlgui kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project kxmlgui --branchGroup kf5-qt5 --platform XenialQt5.7 --installTo /home/jenkins/install-prefix/cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks kxmlgui kf5-qt5 XenialQt5.7"-- The C compiler identification is GNU 5.4.0-- The CXX compiler identification is GNU 5.4.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at /home/jenkins/install-prefix/share/ECM/kde-modules/KDECMakeSettings.cmake:252 (if): if given arguments:"WIN32" "OR" "5.37.0" "VERSION_GREATER_EQUAL" "5.38.0" Unknown arguments specifiedCall Stack (most recent call first): CMakeLists.txt:24 (include)-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks kxmlgui kf5-qt5 XenialQt5.7/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks kxmlgui kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production/usr/lib/python3/dist-packages/Crypto/Cipher/blockalgo.py:141: FutureWarning: CTR mode needs counter parameter, not IV self._cipher = factory.new(key, *args, **kwargs)[Pipeline] emailextrecipients[Pipeline] emailext
build.log
Description: Binary data
D6775: Fix labels of DeleteFile/RenameFile actions
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The StandardShortcut enum is seriously lacking documentation (for each enum value)... REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D6775 To: elvisangelaccio, #frameworks, dfaure
D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one
davidedmundson abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: davidedmundson, #plasma, matank Cc: mart, plasma-devel, davidedmundson, ltoscano, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one
davidedmundson commandeered this revision. davidedmundson edited reviewers, added: matank; removed: davidedmundson. davidedmundson added a comment. > I can confrim that mart's patch ( https://phabricator.kde.org/D7127) solves the issue. I'll close this . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: davidedmundson, #plasma, matank Cc: mart, plasma-devel, davidedmundson, ltoscano, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D7078: [server] Fix crash when sending selection to a DDI without a DataSource
graesslin added a comment.
> the send_selection spec says we should be passing a null resource if we
have no selection, whereas this version creates a data offer with nothing in it.
But we have a selection, that's the point. We just don't have a datasource on
the selection.
Relevant code in KWin which goes into the code path:
if (selection) {
xclipboard->sendSelection(selection);
} else {
xclipboard->sendClearSelection();
}
We do check whether we have a selection. So from KWayland Server side we have
a selection. If we would not have a Selection it would go into
sendClearSelection.
That we don't send any useful DataOffer doesn't really matter. We also don't
check whether the DataSource has any offers.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7078
To: graesslin, #kwin, #plasma, #frameworks
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6775: Fix labels of DeleteFile/RenameFile actions
elvisangelaccio added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D6775 To: elvisangelaccio, #frameworks, dfaure
KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 47 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/47/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 17:17:19 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMQMLModulesFailed: TestSuite.KDEInstallDirsTest.relative_or_absolute build.log Description: Binary data
KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 38 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/38/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 17:17:19 + Build duration: 2 min 39 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMPoQmToolsTestFailed: TestSuite.ECMQMLModulesFailed: TestSuite.ExecuteKDEModulesFailed: TestSuite.KDEFetchTranslations Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.
dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: kfunk, #frameworks, #build_system
D7078: [server] Fix crash when sending selection to a DDI without a DataSource
davidedmundson added a comment.
I don't think we did go in there because we have a selection, otherwise
other->selection() wouldn't be null.
If we want DDI::sendSelection(DDI *other) to always keep the client in sync
we should do:
auto selection = other->selection();
if (!selection) {
sendClearSelection();
return;
}
the send_selection spec says we should be passing a null resource if we have
no selection, whereas this version creates a data offer with nothing in it.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7078
To: graesslin, #kwin, #plasma, #frameworks
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7078: [server] Fix crash when sending selection to a DDI without a DataSource
graesslin added a comment. In https://phabricator.kde.org/D7078#134111, @davidedmundson wrote: > Isn't the real bug from that trace here: > > datadevice_interface.cpp:204 > void DataDeviceInterface::sendSelection(DataDeviceInterface *other) > d->createDataOffer(other->selection()); > > it's valid for other->selection() to be null, so this should be guarded there. If I do that your modified unit test passes. > > Guarding inside the method I fear will mask future bugs. Guarding there would be result in incorrect state. We went into sendSelection because there is a selection. That the source is null doesn't really matter. But we have to inform the DDI which gets the selection which selection there is. If not it still operates on outdated data. So I thought it's better to continue there and ensure the DataOffer is created. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."
Hi, Not sure where to ask about this: I recently upgraded to frameworks 5.35.0 and applications 17.04.2 . I don't think I tested konqueror5 with a remote website (on Mac), and discover today that it fails with terminal errors of the style kf5.kio.widgets: KonqRun(0x7f89f7dd9db0) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist." and the following message shown in the browser window: This site can’t be reached The web page at error:/?error=111=http%3A%2F%2Fwww.kde.org%2F#http://www.kde.org might be temporarily down or it may have moved permanently to a new web address. ERR_UNKNOWN_URL_SCHEME Qupzilla works fine using the same Qt install and a mostly identical konqueror build works fine too on my Linux system. This reeks of an issue with KIO but I cannot put my finger on it? Thanks, René
D7078: [server] Fix crash when sending selection to a DDI without a DataSource
davidedmundson added a comment. Isn't the real bug from that trace here: datadevice_interface.cpp:204 void DataDeviceInterface::sendSelection(DataDeviceInterface *other) d->createDataOffer(other->selection()); it's valid for other->selection() to be null, so this should be guarded there. If I do that your modified unit test passes. Guarding inside the method I fear will mask future bugs. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7078: [server] Fix crash when sending selection to a DDI without a DataSource
graesslin added a comment. ping! This is a crash fix. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7216: refactor kpackagetool away from stringy options
apol added a comment. if that makes you happy, it makes me happy. +1 REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D7216 To: sitter, sebas, apol Cc: #frameworks
D7216: refactor kpackagetool away from stringy options
sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
A notable advantage of qcommandlineoption is that using the objects the
compiler makes sure that everyone is talking about the same option.
Previously kpackagetool would create the option objects in main but then
not use them to grab values out of the commandlineparser, instead relying
on the stringy representation of the option. This is a tad harder to
read but more importantly, it bypasses the compiler opening the code up for
typos. Namely one could do `d->parser->value("hahs")` while doing
`d->parser->value(Options::hahs)` will result in a build failure.
To preven this, refactor the entire option handling to use static option
instances from a new Options namespace as to let the compiler help us not
write typos.
In the future option handling could be additionally changed to parse all
options at once early on and construct an option struct or something to
reduce code clutter from calling isSet a million times.
TEST PLAN
- all existing tests pass
- `--help` still looks correct
REPOSITORY
R290 KPackage
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7216
AFFECTED FILES
src/kpackagetool/kpackagetool.cpp
src/kpackagetool/main.cpp
src/kpackagetool/options.h
To: sitter, sebas, apol
Cc: #frameworks
D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.
kfunk accepted this revision. kfunk added a comment. I like the initiative, +1 REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: kfunk, #frameworks, #build_system
KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 37 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/37/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Wed, 09 Aug 2017 11:10:29 + Build duration: 2 min 35 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMPoQmToolsTestFailed: TestSuite.ECMQMLModules Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 46 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/46/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 11:10:29 + Build duration: 2 min 28 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 50 test(s)Failed: TestSuite.ECMQMLModulesFailed: TestSuite.KDEInstallDirsTest.relative_or_absolute build.log Description: Binary data
D7094: Include a module for finding qml imports as runtime dependencies
This revision was automatically updated to reflect the committed changes. Closed by commit R240:e5301edf1daf: Include a module for finding qml imports as runtime dependencies (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7094?vs=17922=17924 REVISION DETAIL https://phabricator.kde.org/D7094 AFFECTED FILES modules/ECMFindQMLModule.cmake.in modules/ECMQMLModules.cmake tests/CMakeLists.txt To: apol, #build_system, #frameworks, sitter Cc: dfaure, aacid
D7094: Include a module for finding qml imports as runtime dependencies
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Oh it's gorgeous! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7094 To: apol, #build_system, #frameworks, sitter Cc: dfaure, aacid
D7094: Include a module for finding qml imports as runtime dependencies
apol updated this revision to Diff 17922. apol added a comment. if no qmlplugindump REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7094?vs=17911=17922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7094 AFFECTED FILES modules/ECMFindQMLModule.cmake.in modules/ECMQMLModules.cmake tests/CMakeLists.txt To: apol, #build_system, #frameworks, sitter Cc: dfaure, aacid
D7196: Fix accepting dialogs with ctrl+return when buttons are renamed
This revision was automatically updated to reflect the committed changes. Closed by commit R252:7524bf1535b4: Fix accepting dialogs with ctrl+return when buttons are renamed (authored by apol). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7196?vs=17862=17921 REVISION DETAIL https://phabricator.kde.org/D7196 AFFECTED FILES src/kstyle/kstyle.cpp tests/kstyletest.cpp To: apol, #frameworks, dfaure
D7058: Initialize the "Pause" button state in the widget tracker
This revision was automatically updated to reflect the committed changes. Closed by commit R288:35b442449166: Initialize the "Pause" button state in the widget tracker (authored by apol). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7058?vs=17531=17920 REVISION DETAIL https://phabricator.kde.org/D7058 AFFECTED FILES src/kwidgetjobtracker.cpp To: apol, #frameworks, dfaure Cc: aacid
D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux Cc: #frameworks, #build_system
D7094: Include a module for finding qml imports as runtime dependencies
sitter added inline comments.
INLINE COMMENTS
> apol wrote in ECMFindQMLModule.cmake.in:30
> Doing find_program for now. The right fix would be to change Qt to export the
> `qmlplugindump` target.
You still need to do "something" if qmlplugindump isn't found. Print a
`message(WARNING` and/or `add_feature_info` or something similar.
Right now the code would mark the plugin not found but not tell the user that
the reason it was not found is that the helper is missing.
e.g. here kirigami is actually installed but qmlplugindump is not:
10:45:09 /tmp/t/b
$ cmake ..
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/lib/icecc/bin/gcc
-- Check for working C compiler: /usr/lib/icecc/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/lib/icecc/bin/g++
-- Check for working CXX compiler: /usr/lib/icecc/bin/g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- qmlplugindump failed for org.kde.kirigami.
-- Could NOT find org.kde.kirigami-QMLModule (missing:
org.kde.kirigami-QMLModule_FOUND)
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/t/b
10:45:12 /tmp/t/b
$ cat ../CMakeLists.txt
project(test)
cmake_minimum_required(VERSION 3.5)
find_package(ECM 1.3.0 REQUIRED NO_MODULE)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH})
include(ECMQMLModules)
ecm_find_qmlmodule(org.kde.kirigami 2.1)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7094
To: apol, #build_system, #frameworks, sitter
Cc: dfaure, aacid
D7196: Fix accepting dialogs with ctrl+return when buttons are renamed
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D7196 To: apol, #frameworks, dfaure
D7153: Drop broken mid-button click handling
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah, hmm, I used to use that feature. E.g. in konqueror, just like an MMB click would open links in a different tab, MMB on the back button would open the previous page in a different tab. But OK, that was the time when konqueror features were polluting all of kdelibs, clearly ;) I can't think of another use case for this. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7153 To: elvisangelaccio, #frameworks, dfaure Cc: dfaure
D7058: Initialize the "Pause" button state in the widget tracker
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D7058 To: apol, #frameworks, dfaure Cc: aacid
D7045: Remove busy loop check in TransferJobPrivate::slotDataReqFromDevice
dfaure added a comment.
isn't this about the case where there is more data available than
MAX_READ_BUF_SIZE, so we didn't read it all and we need to loop around to read
the rest?
OK, that's not what the if says, but I think that's still one case where we
need to loop. So maybe it should be
if (bytesRead == MAX_READ_BUF_SIZE) {
QIODevice doesn't emit readyRead() again if it notified us about 16K being
available and we only read 8K.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7045
To: aacid
Cc: dfaure, apol, #frameworks
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 50 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/50/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 09 Aug 2017 06:39:29 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447 build.log Description: Binary data
