D7458: Show icons in icon border context menu

croick created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY - if icons are defined for marks, use them in the context menu - more general approach than https://phabricator.kde.org/D7158

D7367: Added Intel HEX file support for the Syntax highlighting database

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, I am happy with that ;=) Now I can look at colorful numbers at work, hehe ;=) REVISION DETAIL https://phabricator.kde.org/D7367 To: martonmiklos,

Re: konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

I noticed that most output came from adblock, I left it in since it supposedly proves that the http slave is not completely dysfunctional. Not that I'm perfectly certain about that, what might actually be happening is that somehow it fails anything that's not a local file (if that makes sense).

D7367: Added Intel HEX file support for the Syntax highlighting database

martonmiklos added a comment. In https://phabricator.kde.org/D7367#138232, @cullmann wrote: > Hmm, the diff still looks like it has the old names, perhaps the update went wrong somehow? Yepp, I have missed the second page after the diff upload. It should be correct now.

Re: konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

On lundi 21 août 2017 17:57:54 CEST René J.V. Bertin wrote: > I managed to get some kioslave debug output: > > https://paste.kde.org/p9fcraknw/whqlo6 > > It looks like the http slave is loaded, but that konqueror5 thinks it isn't, > or something of the sort. (public version of the paste:

D7367: Added Intel HEX file support for the Syntax highlighting database

martonmiklos updated this revision to Diff 18514. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7367?vs=18310=18514 REVISION DETAIL https://phabricator.kde.org/D7367 AFFECTED FILES autotests/html/highlight.hex.html autotests/input/highlight.hex data/syntax/intelhex.xml To:

D7391: Replace KStandardAction::PasteText with KStandardAction::Paste

This revision was automatically updated to reflect the committed changes. Closed by commit R39:b53e6d04cf09: Replace KStandardAction::PasteText with KStandardAction::Paste (authored by elvisangelaccio). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D6829: Add ability to use the new kauth helper in file ioslave

chinmoyr updated this revision to Diff 18508. chinmoyr added a comment. - Added new variable m_failure to PrivilegeOperationReturnValue so that we can directly check for failed state rather than depending upon fallacy of other variables. - Added check for chmod, chown and utime operation

D7367: Added Intel HEX file support for the Syntax highlighting database

cullmann added a comment. Hmm, the diff still looks like it has the old names, perhaps the update went wrong somehow? REVISION DETAIL https://phabricator.kde.org/D7367 To: martonmiklos, #framework_syntax_hightlighting, cullmann Cc: dhaumann, cullmann, #frameworks, vkrause

D7367: Added Intel HEX file support for the Syntax highlighting database

martonmiklos marked an inline comment as done. martonmiklos added a comment. In https://phabricator.kde.org/D7367#138030, @cullmann wrote: > I am happy beside one thing I missed: I think the file should be called intelhex.xml, given its for the intel hex format only (the name is already

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/52/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 21 Aug 2017 17:08:34 + Build duration: 4 min 5 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/48/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 21 Aug 2017 17:08:34 + Build duration: 32 sec and counting JUnit Tests

D6197: Add kauth helper to file ioslave

chinmoyr updated this revision to Diff 18504. chinmoyr added a comment. - Minor changes in sendFileDescriptor function because constructor of FdSender changed in https://phabricator.kde.org/D6709. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6197?vs=18301=18504 BRANCH master

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

chinmoyr updated this revision to Diff 18502. chinmoyr added a comment. - Made changes that were suggested here : https://codereview.stackexchange.com/questions/173306/sharing-file-descriptor-between-an-under-privileged-and-a-privileged-process-us CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/51/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 21 Aug 2017 16:15:06 + Build duration: 4 min 22 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/47/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 21 Aug 2017 16:15:06 + Build duration: 32 sec and counting JUnit Tests

D7439: Don't clear Qt's SSL CA certificate store

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5947eeb5f5aa: Don't clear Qt's SSL CA certificate store (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7439?vs=18456=18497 REVISION DETAIL

Re: konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

I managed to get some kioslave debug output: https://paste.kde.org/p9fcraknw/whqlo6 It looks like the http slave is loaded, but that konqueror5 thinks it isn't, or something of the sort. hope this helps... R.

D7439: Don't clear Qt's SSL CA certificate store

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yep. We don't even have our own set of CA certificates, anymore, so clearing the Qt ones makes no sense anymore. Maybe this is why I was getting lots of SSL errors in konqueror-kf5...

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/50/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 21 Aug 2017 13:31:25 + Build duration: 1 min 6 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/46/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 21 Aug 2017 13:31:25 + Build duration: 32 sec and counting JUnit Tests

D6390: Add remote runners over DBus

This revision was automatically updated to reflect the committed changes. Closed by commit R308:8389c530e531: Add remote runners over DBus (authored by davidedmundson). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6390?vs=16245=18481 REVISION DETAIL

D7402: Use QUrls from match to create mimeData in base implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R308:b0421c21867b: Use QUrls from match to create mimeData in base implementation (authored by davidedmundson). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE

KDE CI: Frameworks krunner kf5-qt5 XenialQt5.7 - Build # 23 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20XenialQt5.7/23/ Project: Frameworks krunner kf5-qt5 XenialQt5.7 Date of build: Mon, 21 Aug 2017 11:00:23 + Build duration: 2 min 1 sec and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.7 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/23/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 21 Aug 2017 11:00:23 + Build duration: 1 min 56 sec and counting JUnit Tests

D7448: generate and use a local cdda_interface headerfile copy

rjvbb set the repository for this revision to R342 KIO AudioCD. REPOSITORY R342 KIO AudioCD REVISION DETAIL https://phabricator.kde.org/D7448 To: rjvbb, #frameworks

D7448: generate and use a local cdda_interface headerfile copy

rjvbb updated this revision to Diff 18476. rjvbb added a comment. headerfile processing should be independent of whether it has ioctl_device_name. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7448?vs=18471=18476 REVISION DETAIL https://phabricator.kde.org/D7448 AFFECTED FILES

D7380: KCD: use modern logging classes throughout

rjvbb added a comment. > BTW it is *not* curious that isn't qInfo isn't "disabled by *.info=false in qtlogging.ini", it's rather expected since qInfo() is one layer below categorized logging, just like qDebug and qWarning. qtlogging.ini (and the QT_LOGGING_RULES env vars) are about qC*.

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/45/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 21 Aug 2017 09:12:26 + Build duration: 1 min 2 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/49/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 21 Aug 2017 09:12:26 + Build duration: 1 min 1 sec and counting JUnit Tests

D5431: New LESS syntax based on SCSS

guoyunhe abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate, cullmann Cc: jtamate, gszymaszek, dhaumann, cullmann, #frameworks

D5431: New LESS syntax based on SCSS

cullmann added a comment. Ok, thanks for comparing it. Sorry that I didn't look at it earlier, my fault :/ You can abandon this change then. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To: guoyunhe, #framework_syntax_hightlighting,

D5431: New LESS syntax based on SCSS

guoyunhe added a comment. They didn't include any screenshots in https://phabricator.kde.org/D5799 so I make my own: F3871416: Screenshot_20170821_113740.png The results are almost the same except text styles. Left is theirs, right is mine.

D7380: KCD: use modern logging classes throughout

dfaure added a comment. For information, qCInfo() is enabled by default if you use the ECM macro for declaring the logging category, or if you pass QtInfoMsg to the Qt macro. But then again, it seems fine with me to use qInfo() in a test program, no need for categorized output for this.

D5431: New LESS syntax based on SCSS

dhaumann added subscribers: gszymaszek, jtamate. dhaumann added a comment. In that case, can you judge whether your patch or the other one is better? Add for review: @gszymaszek @jtamate REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To:

D7448: generate and use a local cdda_interface headerfile copy

rjvbb added a reviewer: Frameworks. REPOSITORY R342 KIO AudioCD REVISION DETAIL https://phabricator.kde.org/D7448 To: rjvbb, #frameworks

D5431: New LESS syntax based on SCSS

guoyunhe added a comment. In https://phabricator.kde.org/D5431#138044, @dhaumann wrote: > Hm, just yesterday we committed https://phabricator.kde.org/D5799, which seems to do the same thing. Can you compare this and possibly update your patch? Sorry we did not notice this earlier...

D5656: Adds method to force the reloading of a document

anthonyfieroni added a comment. Make a protected constructor Document::Document(DocumentPrivate ) : d(dd) {} In KateDocument extend DocumentPrivate with KateDocumentPrivate, override documentReload and give it to base Document KateDocument(...) : Document(*new

D7380: KCD: use modern logging classes throughout

rjvbb set the repository for this revision to R342 KIO AudioCD. REPOSITORY R342 KIO AudioCD REVISION DETAIL https://phabricator.kde.org/D7380 To: rjvbb, #frameworks, davidedmundson, ltoscano Cc: dfaure, ltoscano, davidedmundson

D7380: KCD: use modern logging classes throughout

rjvbb updated this revision to Diff 18470. rjvbb added a comment. Using qInfo() in testkcd. Curious that qInfo() is enabled (and isn't disabled by `*.info=false` in qtlogging.ini) by default but qCInfo() isn't (as you'd expect for "info level" logging). CHANGES SINCE LAST UPDATE

D5431: New LESS syntax based on SCSS

dhaumann added a comment. Hm, just yesterday we committed https://phabricator.kde.org/D5799, which seems to do the same thing. Can you compare this and possibly update your patch? Sorry we did not notice this earlier... REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D5431: New LESS syntax based on SCSS

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, given I have no real idea about this HL, looks not wrong, but could you add/extend a unit test? Then this can go in I would say. Thanks for the change! REPOSITORY

D5656: Adds method to force the reloading of a document

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Please go the non-virtual way, thanks. Or has somebody else a better idea (or dislikes the whole additional API function). REPOSITORY R39 KTextEditor REVISION DETAIL

D7391: Replace KStandardAction::PasteText with KStandardAction::Paste

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sounds reasonable! REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D7391 To: elvisangelaccio, #ktexteditor, cullmann Cc: cullmann,