vandenoever added a comment.
> "X-KDE-InitialPreference": "5"
is a string
"X-KDE-InitialPreference": 5
is a number
REVISION DETAIL
https://phabricator.kde.org/D7533
To: dfaure, apol, davidedmundson, arichardson
Cc: vandenoever, elvisangelaccio, bshah, #frameworks
valeriymalov updated this revision to Diff 18774.
valeriymalov edited the summary of this revision.
valeriymalov added a comment.
Oops, should be fixed now
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7487?vs=18616=18774
BRANCH
master
REVISION
wbauer added a comment.
The referenced bug number seems to be wrong.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D7487
To: valeriymalov, #frameworks
Cc: wbauer, broulik
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/43/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 25 Aug 2017 19:33:21 +
Build duration:
4 min 21 sec and counting
JUnit
dfaure closed this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7236
To: dfaure, mart, arichardson, davidedmundson
Cc: #frameworks
dfaure added a comment.
It will be tested at every "make test" in kio and kpackage ;-)
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7236
To: dfaure, mart, arichardson, davidedmundson
Cc: #frameworks
arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Test would be great but the patch is pretty trivial so not really needed.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/60/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 25 Aug 2017 19:08:51 +
Build duration:
1 min 7 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/56/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 25 Aug 2017 19:08:51 +
Build duration:
34 sec and counting
JUnit Tests
mart updated this revision to Diff 18767.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- get rid of setTransientFor
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7369?vs=18760=18767
BRANCH
dfaure added a comment.
ping?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7236
To: dfaure, mart, arichardson, davidedmundson
Cc: #frameworks
dfaure added reviewers: arichardson, davidedmundson.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7236
To: dfaure, mart, arichardson, davidedmundson
Cc: #frameworks
mart updated this revision to Diff 18760.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- add a serverside setTransientFor in xdgshell
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
REPOSITORY
R303 KInit
BRANCH
kdbus-appId
REVISION DETAIL
https://phabricator.kde.org/D7479
To: elvisangelaccio, dfaure, apol
Cc: #frameworks
elvisangelaccio updated this revision to Diff 18758.
elvisangelaccio added a comment.
Use `leftRef()`
REPOSITORY
R303 KInit
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7479?vs=18700=18758
BRANCH
kdbus-appId
REVISION DETAIL
https://phabricator.kde.org/D7479
AFFECTED
This revision was automatically updated to reflect the committed changes.
Closed by commit R252:588cd0075612: Return high-resolution line edit clear icon
(authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7249?vs=18000=18757#toc
REPOSITORY
R252 Framework Integration
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
First round of review, client api is done.
INLINE COMMENTS
> registry.h:1275
> + * @param name The name for the removed interface
> + * @since 5.25
> + **/
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7520#139761, @broulik wrote:
> I do have two somewhat different looking icons in the context menu.
dolphin git master? Make sure you have https://phabricator.kde.org/D6778,
which is what caused the regression
>
elvisangelaccio added inline comments.
INLINE COMMENTS
> kurifilter.cpp:682-684
> // NOTE: Plugin priority is determined by the InitialPreference entry in
> // the .desktop files, so the trader result is already sorted and should
> // not be manually sorted.
This comment looks
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
mart/xdgforeign
REVISION DETAIL
https://phabricator.kde.org/D7531
To: davidedmundson, #plasma, graesslin
Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, leezu,
mart updated this revision to Diff 18744.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- add a manual test for foreign
- remove Unstable from public symbols
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
davidedmundson updated this revision to Diff 18741.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
bleh
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7531?vs=18740=18741
BRANCH
davidedmundson updated this revision to Diff 18740.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Update connections better
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a968892ba9d5: Guard failed testItem creation (authored by
davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7532?vs=18726=18735
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ac2434087725: Force Plasma style for QQC2 in applets
(authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6964?vs=17706=18737
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D6964
REVISION DETAIL
https://phabricator.kde.org/D6964
To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a25b628e25aa: Install the PlasmaComponents.3/private
folder (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6693
To: davidedmundson, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5137a988b1f4: [Service] Use KConfig::SimpleConfig
(authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7510?vs=18673=18733#toc
REPOSITORY
R242 Plasma Framework (Library)
bshah added a comment.
> One thing I don't understand is the need for toString().toInt(),
> or in other words, why my json file with a numeric value gets turned
> into a string value when using qtplugininfo to inspect the plugin:
Maybe you need to add following in the
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b4c1c9cdfa01: Drop remains of "locolor" themes (authored
by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7516?vs=18681=18732
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The breadcrumbs and menu items in the breadcrumb separators already did that
but the path selector, which looks like a breadcrumb
dfaure created this revision.
REVISION SUMMARY
This makes it possible to run the unittest without installing the
plugins first.
One thing I don't understand is the need for toString().toInt(),
or in other words, why my json file with a numeric value gets turned
into a string value
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7510
To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D7532
To: davidedmundson, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot,
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/9/
Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 25 Aug 2017 08:50:19 +
Build duration:
6 min 16 sec and counting
CONSOLE OUTPUT
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7dd46685bed7: [KUrlNavigator] Emit tabRequested when
place in menu is middle-clicked (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7513?vs=18678=18729#toc
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:027576183f94: [KUrlNavigator] Emit tabRequested when
places selector is middle-clicked (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
broulik added a comment.
I do have two somewhat different looking icons in the context menu.
`user-trash` is for a place, not an action, so this might lead to a colorized
icon showing up in the menu (when using larger icon sizes and/or high dpi)
REPOSITORY
R265 KConfigWidgets
39 matches
Mail list logo
