Re: Running applications and unittests without "make install"

2017-08-29 Thread Ben Cooksley
On 30/08/2017 4:10 PM, "Friedrich W. H. Kossebau" wrote: Hi Ben & all, Hi Friedrich, Am Samstag, 19. August 2017, 02:24:21 CEST schrieb Ben Cooksley: > On Wed, Aug 16, 2017 at 3:17 AM, David Faure wrote: > > Hi everyone, > > Hi David, > > > The documentation

Re: Running applications and unittests without "make install"

2017-08-29 Thread Friedrich W. H. Kossebau
Hi Ben & all, Am Samstag, 19. August 2017, 02:24:21 CEST schrieb Ben Cooksley: > On Wed, Aug 16, 2017 at 3:17 AM, David Faure wrote: > > Hi everyone, > > Hi David, > > > The documentation for how to do that is now up at > > > >

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

2017-08-29 Thread Friedrich W . H . Kossebau
kossebau reopened this revision. kossebau added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > KDECMakeSettings.cmake:46-47 > +# > +# When find_package(ECM 5.38) or higher is called, this also selects > +# a layout for the build dir that helps running

Re: Review Request 128661: [KTreeWidgetsSearchLineWidget] Use placeholderText instead of separate label

2017-08-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128661/ --- (Updated Aug. 29, 2017, 8:57 nachm.) Status -- This change has been

D6963: Don't block starting notification service

2017-08-29 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R289:1c97e1d9741f: Don't block starting notification service (authored by davidedmundson). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6963?vs=18912=18933

D6963: Don't block starting notification service

2017-08-29 Thread Jos van den Oever
vandenoever added a comment. The patch looks clean, but I do not fully understand how is supposed to work. Perhaps an explanation of the different scenarios would help future readers of this code. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL

D6963: Don't block starting notification service

2017-08-29 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D6963 To: davidedmundson, mart Cc: alexeymin, marten, vandenoever, mck182, dvratil, #frameworks

D7605: Add apidox to KStandardShorcut::StandardShortcut

2017-08-29 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D7605 AFFECTED FILES src/gui/kstandardshortcut.h To: elvisangelaccio, #frameworks

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 71 - Still Unstable!

2017-08-29 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/71/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 29 Aug 2017 13:18:00 + Build duration: 4 min 24 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 67 - Still Unstable!

2017-08-29 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/67/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 29 Aug 2017 13:18:00 + Build duration: 59 sec and counting JUnit Tests

Re: relocatable kdoctools

2017-08-29 Thread Harald Sitter
On Sun, Aug 27, 2017 at 8:37 PM, Luigi Toscano wrote: > Even without the if branch it would be still complicated. Ah! I think I get the complexity now. At build time we need to run our tools already and so the dtd/xsl need to be able to resolve the paths, hence the

D7601: [EventPluginsManager] Expose pluginPath in model

2017-08-29 Thread Kai Uwe Broulik
broulik added a dependent revision: D7603: [Digital Clock] Show event plugin configurations only if enabled. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7601 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory

2017-08-29 Thread Kai Uwe Broulik
broulik added a dependent revision: D7603: [Digital Clock] Show event plugin configurations only if enabled. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7602 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory

2017-08-29 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7602 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory

2017-08-29 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The appendCategory(ConfigCategory*) allows to add a category created by e.g. an Instantiator that can use bindings

D7601: [EventPluginsManager] Expose pluginPath in model

2017-08-29 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY That's what digital clock stores in its config, allows us to do matching. REPOSITORY R242 Plasma Framework (Library)

Re: relocatable kdoctools

2017-08-29 Thread Harald Sitter
On Thu, Aug 24, 2017 at 3:20 PM, Ralf Habacker wrote: > 10. The conclusion of 9. is that it might also be a solution on windows > to patch only all generated files after 3. and before 4. Hm, I may be missing a piece of the puzzle in my mind, but it appears to me this

D7582: [FrameSvgItem] Create margins/fixedMargins object on demand

2017-08-29 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:a8ce2e85ecf5: [FrameSvgItem] Create margins/fixedMargins object on demand (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Fwd: Change in qt/qtbase[dev]: Make QPlatformServices as a separated plugin

2017-08-29 Thread David Faure
This might be of interest to some of you. -- Forwarded Message -- Subject: Change in qt/qtbase[dev]: Make QPlatformServices as a separated plugin Date: mardi 29 août 2017, 10:59:02 CEST From: Jan Grulich (Code Review) To: David Faure

D7582: [FrameSvgItem] Create margins/fixedMargins object on demand

2017-08-29 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7582 To: broulik, #plasma, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D6963: Don't block starting notification service

2017-08-29 Thread David Edmundson
davidedmundson updated this revision to Diff 18912. davidedmundson added a comment. Remove startFdo flag Keep windows away from DBus activation Better handle the service owner changing on a potentially DBus activated notification handler REPOSITORY R289 KNotifications CHANGES

D7033: Port ki18n from QtScript to QtQml

2017-08-29 Thread Dominik Haumann
dhaumann added a comment. The changes to from QScriptValue to QJSValue look quite good (similar to the ones done in KTextEditor). I cannot really comment on the FIXMEs you have added, though. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D7033 To: carewolf, ilic