alexeymin added a comment.
Maybe https://phabricator.kde.org/D7700 is better? We should choose one here,
I guess
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7668
To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik,
elvisangelaccio, aacid,
jgrulich added a comment.
In https://phabricator.kde.org/D7660#144542, @dhaumann wrote:
> @jgrulich Can you comment on this, since the old patch that this change
refers came from you ? :-) I'm sure you understand this better than me.
Not sure I can say much, I wrote this patch bec
ngraham added a reviewer: emmanuelp.
ngraham added a comment.
Any remaining objections?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7668
To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik,
elvisangelaccio, aacid, emmanuelp
Cc: elvisangelac
ngraham added reviewers: dfaure, emmanuelp.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7446
To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure,
emmanuelp
Cc: #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano,
#konqueror, n
elvisangelaccio added a subscriber: andreaska.
elvisangelaccio added a comment.
@andreaska Is it possible to add a new breeze icon for the move-to-trash
action?
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7520
To: elvisangelaccio, #frameworks
Cc: andreask
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:34c2460d09dd: Deprecate KStandardShortcut::SaveOptions
(authored by elvisangelaccio).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7758?vs=19357&id=19386
REVISIO
This revision was automatically updated to reflect the committed changes.
Closed by commit R265:806a5243bd71: Deprecate KStandardAction::PasteText and
KPasteTextAction (authored by elvisangelaccio).
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7294?vs
rkflx added a comment.
Thank you so much for your help until now, Dominik! Unfortunately, there's
one more thing: The CI does not like `testChrome` :( Could you tell me how the
workflow is now?
- Should this be discussed here? New review request? Just commit?
- What's the timeframe I'm
mgallien added a comment.
In https://phabricator.kde.org/D7750#144373, @anthonyfieroni wrote:
>
https://phabricator.kde.org/source/kfilemetadata/browse/master/src/extractorcollection.cpp;621101fd9e9d82be3d84f2140a4bf53ea13fd3f0$137
> Look it leak now, no?
Sorry, I misread your
mgallien added a comment.
According to QPluginLoader, if one wants to release the memory,
In https://phabricator.kde.org/D7750#144373, @anthonyfieroni wrote:
>
https://phabricator.kde.org/source/kfilemetadata/browse/master/src/extractorcollection.cpp;621101fd9e9d82be3d84f2140a4bf53ea
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/38/
Project:
Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7
Date of build:
Sun, 10 Sep 2017 19:11:28 +
Build duration:
8 min 48 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/38/
Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 10 Sep 2017 19:11:28 +
Build duration:
2 min 12 sec and counting
JUn
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:69e9e2ca2230: KSqueezedTextLabel: Respect indent, margin
and frame width (authored by rkflx).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7164?vs=19345&id
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:ee67903f1369: KSqueezedTextLabel: Add several autotests
(authored by rkflx).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7163?vs=19331&id=19379
REVISION
safaalfulaij updated this revision to Diff 19370.
safaalfulaij added a comment.
- Fix global and local view values
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7660?vs=19368&id=19370
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7660
dfaure added a comment.
If all you need is , you can use
QCoreApplication::applicationDirPath().
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7706
To: habacker, dfaure
Cc: dfaure, #frameworks
dfaure added a comment.
In https://phabricator.kde.org/D7580#144518, @kossebau wrote:
> When I read this initially, I guessed this method is just about the view
state. But is also bound to data-pulling by the kpart, given that the default
implementation explicitely calls openUrl() with t
dhaumann added a comment.
The concept with the 'Set' flag is not yet correct.
INLINE COMMENTS
> kateconfig.cpp:1241
> m_autoBracketsSet(false),
> +m_backspaceRemoveComposed(false),
> m_view(nullptr)
Should be: m_backspaceRemoveComposed_Set_(False)
> kateconfig.cpp:1288
>
safaalfulaij updated this revision to Diff 19368.
safaalfulaij added a comment.
- Add the implementation of backspaceRemoveComposed
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7660?vs=19097&id=19368
BRANCH
master
REVISION DETAIL
https://phabrica
dhaumann added reviewers: jgrulich, hein.
dhaumann added a subscriber: jgrulich.
dhaumann added a comment.
@jgrulich Can you comment on this, since the old patch that this change
refers came from you ? :-) I'm sure you understand this better than me.
REPOSITORY
R39 KTextEditor
REVISION DET
habacker added a reviewer: dfaure.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7706
To: habacker, dfaure
Cc: dfaure, #frameworks
habacker added a comment.
Does QStandardPaths provide a parameter to retrieve the runtime binary
install location ?
For example if kdeinit5.exe is located in /bin it should return
or if is installed in and there is no 'bin' dir
in path it should return ?
With QLibraryInfo::location()
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/27/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Sun, 10 Sep 2017 14:24:58 +
Build duration:
5 min 5 sec and counting
JUnit Tests
kossebau added a comment.
In https://phabricator.kde.org/D7580#144414, @dfaure wrote:
> In https://phabricator.kde.org/D7580#142971, @kossebau wrote:
>
> > > "how would zoom and other custom state properties be save and retrieved
again" -> using BrowserExtension's saveState/restoreSt
This revision was automatically updated to reflect the committed changes.
Closed by commit R303:f75926ea16f0: Fix 'klauncher uses absolute compile time
install path for finding kioslave.exe' (authored by habacker).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7707?vs=19232&id=19364#toc
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/32/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 10 Sep 2017 14:24:58 +
Build duration:
48 sec and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/31/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 10 Sep 2017 14:22:55 +
Build duration:
1 min 50 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/26/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Sun, 10 Sep 2017 14:22:55 +
Build duration:
1 min 50 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:9990eb0518e5: kpackage: bundle a copy of
servicetypes/kpackage-generic.desktop (authored by dfaure).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7243?vs=17988&i
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:a34d2dcd87e7: kpackagetool: bundle a copy of
servicetypes/kpackage-generic.desktop (authored by dfaure).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7242?vs=179
dfaure added a comment.
I'll take silence as approval, this should be non-controversial...
REVISION DETAIL
https://phabricator.kde.org/D7243
To: dfaure, mart
Cc: #frameworks
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R265 KConfigWidgets
BRANCH
deprecate-pastetext
REVISION DETAIL
https://phabricator.kde.org/D7294
To: elvisangelaccio, #frameworks, dfaure
On mercredi 30 août 2017 06:10:10 CEST Friedrich W. H. Kossebau wrote:
> Perhaps in the long term also the logic in ECM needs to be changed, so the
> new build artifact placement can be triggered by other means from cmake code
> which is prepared for the optional new feature (by testing the version
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7758
To: elvisangelaccio, #frameworks, dfaure
On vendredi 1 septembre 2017 15:02:16 CEST Marco Martin wrote:
> On Thu, Aug 31, 2017 at 5:06 PM, Marco Martin wrote:
> > any objection into pulling it into a framework? anything particular for
> > the procedure?
>
> as an update to that, i've update its cmake files and metadata files
> to be coh
elvisangelaccio updated this revision to Diff 19358.
elvisangelaccio edited the summary of this revision.
elvisangelaccio added a comment.
- Bump @since
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7294?vs=18351&id=19358
BRANCH
deprecate-pastete
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
For consistency with https://phabricator.kde.org/D7293.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7758
AFFECTED FILES
src/gui/kstandard
dfaure added inline comments.
INLINE COMMENTS
> kinit_win.cpp:205
> +{
> +return QLibraryInfo::location(QLibraryInfo::PrefixPath);
> +}
That's the Qt install prefix. I guess it matches your KF5 install prefix for
this patch to work, but it doesn't seem like a universal solution.
Maybe this
dhaumann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
BRANCH
arcpatch-D7163
REVISION DETAIL
https://phabricator.kde.org/D7163
To: rkflx, #frameworks, dhaumann
Cc: dhaumann
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R303 KInit
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7707
To: habacker, cfeck, dfaure
Cc: #frameworks
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
I think this is good enough, especially since according to your research the
previous code also exists in certain Qt releases also as LGPLv2.
REPOSITORY
R236 KWidgetsAddons
BRANCH
martonmiklos added a comment.
In https://phabricator.kde.org/D7367#143391, @cullmann wrote:
> Should be fixed now:
>
> commit
https://phabricator.kde.org/R216:fd79b6842c6f33a1aca4f500354ca2a69c52689e
> Author: Christoph Cullmann
> Date: Wed Sep 6 08:08:49 2017 +0200
>
>
dfaure added a comment.
In https://phabricator.kde.org/D7580#142971, @kossebau wrote:
> > "how would zoom and other custom state properties be save and retrieved
again" -> using BrowserExtension's saveState/restoreState as usual, no? I'm
not 100% sure about the interaction with streamin
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:940adc7e6e69: [Plasma Components 3] Fix RTL in some
widgets. (authored by safaalfulaij).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7715?vs=1
44 matches
Mail list logo