D7861: Support clojure's "@" macro with brackets

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. In general looks good, but 2 issues: 1. Please increase the version number in the lab xml element. 2. Please extend the unit test here: https://github.com/KDE/syntax-hig

D7864: Basic support for PHP and Python fenced code blocks in Markdown

dhaumann added a comment. Could you also extend the test case in https://github.com/KDE/syntax-highlighting/blob/master/autotests/input/test.markdown This way, we can automatically guarantee that we will not break this feature accidentally. REPOSITORY R216 Syntax Highlighting REVIS

D7864: Basic support for PHP and Python fenced code blocks in Markdown

gszymaszek added a subscriber: cfeck. gszymaszek added a comment. Not ready to land, but uploaded per @cfeck’s suggestion (bug 356974 ). REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek,

D7864: Basic support for PHP and Python fenced code blocks in Markdown

gszymaszek created this revision. gszymaszek added a reviewer: KTextEditor. Restricted Application added a project: Frameworks. REVISION SUMMARY This patch enables syntax highlighting of PHP and Python code blocks in Markdown code. REPOSITORY R216 Syntax Highlighting BRANCH markdown-code-

D6103: scan the whole install folder for qml dependencies

patrickelectric added a comment. I don't know if is related to this commit, but when compiling my application via kirigami with `make create-*` and uploading to my cellphone, a white screen appears. Using adb to debug with logcat, this error took my attention: `libatcore-gui.so: qrc:///mai

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/74/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 17 Sep 2017 16:33:19 + Build duration: 21 min and counting JUnit Tests

D7849: Fix the tray icon scaling on HiDPI screens

pgkos added a comment. @anthonyfieroni my first version of the diff changed only the tray icon QML file, but I think that it is better to fix it in the plasma framework, as that function is used in multiple other places and there is the same problem with wrongly sized icons on hidpi screens.

D7849: Fix the tray icon scaling on HiDPI screens

anthonyfieroni added a comment. So, Kai is right, it roundToIconSize only round size independent from dpi. Then when it used, it should be multiplyed by dpi. REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: anthonyfieroni, broulik, #frameworks, davidedmundson, plasm

D7849: Fix the tray icon scaling on HiDPI screens

pgkos added a comment. @broulik consider this case: The tray icons' size is defined by default in `org.kde.plasma.private.systemtray/contents/config/main.xml` to `smallMedium`, which means 22 pixels on a 96-dpi screen. On a 192-dpi screen, the icons' real size is 44 pixels. Now, in `o

D7849: Fix the tray icon scaling on HiDPI screens

broulik added a comment. I don't understand this. RoundToIconSize is supposed to round down and that's it. If I pass it 100 px because I'm on a high dpi screen, it will still return 100. Only if I pass it e.g. 34 it will change it to 32. REVISION DETAIL https://phabricator.kde.org/D7849 T

D7849: Fix the tray icon scaling on HiDPI screens

pgkos updated this revision to Diff 19612. pgkos added a comment. Fixed the previous diff. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7849?vs=19592&id=19612 REVISION DETAIL https://phabricator.kde.org/D7849 AFFECTED FILES src/declarativeimports/core/units.cpp src/declarat

D7861: Support clojure's "@" macro with brackets

koichia edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7861 To: koichia Cc: #frameworks, cullmann, vkrause, dhaumann

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

marten marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7823 To: marten, #frameworks, #build_system Cc: cgiboudeaux, cfeck, heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

marten updated this revision to Diff 19611. marten added a comment. Diff updated to move library target definition after find_package_handle_standard_args. If these modules are accepted into ECM then KMix needs a further commit anyway, in order to remove the final requirement for KDELibs

D7861: Support clojure's "@" macro with brackets

koichia created this revision. koichia added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This change will fix clojure's syntax highlighting like the following code: `(@

D7245: Improve reStructuredText highlighting

cullmann added a comment. Hi, please add a testcase and we are done here. Without a test case this can easily degenerate later again. REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, #frameworks

D7699: Add support for custom search paths for application-specific syntax and theme definitions

cullmann added a comment. I think you are right, the indexer is an other issue. We could even just disable that index... files are used by the framework beside for its own internal dirs. I guess for this review just Volker needs to say which version should go in and we are done. REPOS

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/41/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 17 Sep 2017 11:31:46 + Build duration: 7 min 58 sec and counting JUn

KDE CI: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/41/ Project: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 Date of build: Sun, 17 Sep 2017 11:31:46 + Build duration: 5 min 9 sec and counting JUnit

D7859: KMessageBox: Use question mark icon for question dialogs

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9b05a12a43db: KMessageBox: Use question mark icon for question dialogs (authored by rkflx). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7859?vs=19604&id=1

D7859: KMessageBox: Use question mark icon for question dialogs

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D7859 To: rkflx, #frameworks, cfeck Cc: alexeymin

D7859: KMessageBox: Use question mark icon for question dialogs

rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Besides `Information`, `Warning` and `Critical`, the `QMessageBox::Icon` enum supports icons of type `Question`. Instead of falling back to an "information" i