awilcox created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
While packaging kinit 5.38.0 for Adélie, I ran in to the following error:
-- Installing:
/usr/src/packages/user/kinit/pkg/kinit/usr/l
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/93/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Sat, 30 Sep 2017 03:09:49 +
Build duration:
1 min 42 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/88/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 30 Sep 2017 03:09:49 +
Build duration:
1 min 12 sec and counting
JUnit Tests
cfeck added a comment.
BUG: 385175
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D8060
To: mart, dfaure, #frameworks, rikmills
Cc: cfeck, #frameworks
cfeck added a comment.
Uh, forget what I wrote. You wanted to pass only the colorSet enum, not the
complete color scheme.
+1 to this.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D8060
To: mart, dfaure, #frameworks, rikmills
Cc: cfeck, #frameworks
cfeck added a comment.
> remove the public dependency to KConfigWidgets as this is breaking existing
apps
Does it work if you use a forward declaration instead of an include? As far
as I know, both "Type f()" and "void f(Type *p)" do not need the actual
function declaration, because bot
aacid resigned from this revision.
aacid added a comment.
I'm not the one that wrote this code, i have zero input on whether this is a
good idea or not or if it should be removed or not
All i can do is offer the 1688 pdf files i have lying around to test the
difference before and after r
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:d967bd9e9345: Properly create KPixmapSequence (authored
by elvisangelaccio).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8000?vs=19959&id=20118
REVISION DETAI
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/45/
Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 29 Sep 2017 18:42:56 +
Build duration:
8 min 3 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/45/
Project:
Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7
Date of build:
Fri, 29 Sep 2017 18:42:56 +
Build duration:
7 min 18 sec and counting
JUnit
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:d82aec496412: KSqueezedTextLabel: Squeeze text when
changing indent or margin (authored by rkflx).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7977?vs=198
ngraham added reviewers: Frameworks, VDG.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8056
To: simgunz, dfaure, #frameworks, #vdg
Cc: alexeymin, #frameworks
mart added reviewers: Frameworks, rikmills.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D8060
To: mart, dfaure, #frameworks, rikmills
Cc: #frameworks
mart created this revision.
mart added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
remove the public dependency to KConfigWidgets as
this is breaking existing apps, but instead let
application
mart added a comment.
https://phabricator.kde.org/D8060 solves the same problem without new
dependencies
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D7891
To: mart, #frameworks, #plasma, hein, dfaure
Cc: rikmills, plasma-devel, #frameworks, ZrenBot, progwolff
davidedmundson added a comment.
It doesn't explicitly say anything, but I don't see how we can.
I do have an approach where we would be able to show a polkit dialog
described in https://phabricator.kde.org/T4437.
REPOSITORY
R127 KWayland
BRANCH
filter2
REVISION DETAIL
https://pha
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Due you know whether we are allowed to block? E.g. to show a polkit dialog?
My assumption would be we are not allowed to block here.
REPOSITORY
R127 KWayland
BRANCH
filter2
REVI
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix-attributes
REVISION DETAIL
https://phabricator.kde.org/D8042
To: dhaumann, vkrause, cullmann
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b8d4bb51c5db: Add support for custom search paths for
application-specific syntax and theme… (authored by zrax, committed by vkrause).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
davidedmundson updated this revision to Diff 20101.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
updates
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8050?vs=20069&id=20101
BRANCH
fil
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in filtered_display.cpp:41
> I tried.
>
> modding getConnection means modding modding ClientConnection constructor,
> modding that means modding the Private ctor
>
> that gets into
>
> wl_client_add_destroy_listener(c,
graesslin added a comment.
Btw. today is a great day: I finally can clean up my whiteboard. I had
drafted an idea how to do what this change does more than a year ago and it's
still waiting for the future me to implement it. But with this change I can
finally clean it without having a bad co
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in filtered_display.cpp:41
> Why a const cast? Or other said: could we overload the getConnection to
> accept a const wl_client*?
I tried.
modding getConnection means modding modding ClientConnection constructor,
modding
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in filtered_display.cpp:62
> Somewhat.
> This is new in 1.13, we depend on 1.7.
>
> Debian is currently on 1.12.
> (my general rule is: "is Debian has it, everyone else must do")
>
> Should we #ifdefs and then no-op (with
graesslin added inline comments.
INLINE COMMENTS
> filtered_display.cpp:41
> +auto t = static_cast(data);
> +auto clientConnection =
> t->q->getConnection(const_cast(client));
> +auto interface = wl_global_get_interface(global);
Why a const cast? Or other said: could we
apol added a comment.
Before disabling it altogether on Android, I'd prefer to look into why it's
not working. Give me a week, please?
If you still want it in, maybe a solution would be to have instead something
like:
option(CENTRALIZED_BINARIES "puts all binaries on bindir/lib an
mart added inline comments.
INLINE COMMENTS
> dfaure wrote in kiconloader.h:465
> I guess this is OK as is, so remove the comment (it's not we can change this
> later)
apparently this is giving problems indeed, polkit is now failing to build since
it wasn't explicitly linking to KConfigWidgets
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in filtered_display.cpp:62
> I didn't know such API exists! This is great ;-)
>
> But I think you need to increase the minimum Wayland version.
Somewhat.
This is new in 1.13, we depend on 1.7.
Debian is currently on 1.12.
rikmills added a comment.
Since this change, polkit-kde-agent-1 fails to build from source with the
error:
> In file included from /usr/include/KF5/KIconThemes/KIconLoader:1:0,
> from
/<>/polkit-kde-agent-1-5.10.95+p17.10+git20170929.1419/AuthDialog.cpp:37:
> /usr/include/KF5/K
graesslin added inline comments.
INLINE COMMENTS
> filtered_display.cpp:62
> +}
> +wl_display_set_global_filter(*this, Private::globalFilterCallback,
> d.data());
> +});
I didn't know such API exists! This is great ;-)
But I think you need to increase the minimum Wayland ve
graesslin added a comment.
My main concern remains: how do we know that it doesn't introduce further
regressions? Did you test that Alt+tab and alt+shift+tab still works? Also when
changing keyboard layout?
For this frameworks release I think it's too late: the regression potential
is j
mart added a reviewer: Frameworks.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8058
To: mart, apol, dfaure, #frameworks
Cc: #frameworks, #build_system
mart created this revision.
mart added reviewers: apol, dfaure.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
on Android the output directories need to stay default
or it breaks packaging wi
davidedmundson abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik, bcooksley
Cc: mart, bcooksley, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, a
simgunz edited the test plan for this revision.
simgunz added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8056
To: simgunz, dfaure
Cc: #frameworks
simgunz created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The current "open with" dialog implementation does not follow the KDE
principle "Simple by default, powerful when needed" for the following
davidedmundson abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8013
To: davidedmundson, #plasma, broulik, bcooksley
Cc: bcooksley, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/92/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 29 Sep 2017 09:40:19 +
Build duration:
1 min 39 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/91/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 29 Sep 2017 09:37:39 +
Build duration:
2 min 24 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/87/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 29 Sep 2017 09:37:40 +
Build duration:
1 min 5 sec and counting
JUnit Tests
davidedmundson added a comment.
@mart Kai did it already.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik, bcooksley
Cc: mart, bcooksley, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-moha
mart added inline comments.
INLINE COMMENTS
> iconitem.cpp:624
> +
> +if (QQuickWindow::sceneGraphBackend() == QLatin1String("software")) {
> +animated = false;
enclose this part with #ifdef on Qt version?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabr
rjvbb added a comment.
OK, my bad, `fsWatcher` is a `KDirWatchPrivate` member, not a global and not
a static member either. Apologies for that - but it doesn't change the symptoms
I'm seeing.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8043
To: rjvbb, #fram
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/48/
Project:
Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7
Date of build:
Fri, 29 Sep 2017 08:56:46 +
Build duration:
3 min 37 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/124/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 29 Sep 2017 08:49:12 +
Build duration:
10 min and counting
JUni
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/120/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Fri, 29 Sep 2017 08:49:12 +
Build duration:
5 min 6 sec and counting
J
bcooksley reopened this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
Reopening - This breaks the build with Qt 5.7 based systems, which is the
minimum requirement for Frameworks.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://p
bcooksley requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik, bcooksley
Cc: bcooksley, plasma-devel, #frameworks, ZrenBot, progwol
rjvbb added a comment.
Hmmm, I'll double-check. I didn't really go beyond the thought that it seemed
to make sense to use a single watcher instance if most of the time you'll be
watching items that live on a single disk.
> Could it be that QFSW itself uses a single static object intern
bcooksley requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8013
To: davidedmundson, #plasma, broulik, bcooksley
Cc: bcooksley, plasma-devel, #frameworks, ZrenBot, progwol
bcooksley reopened this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
Reopening - This breaks the build with Qt 5.7 based systems, which is the
minimum requirement for Frameworks.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://p
rjvbb added a comment.
I did see some symptoms that could only be explained by a memory layout
change (and apparently caused by this patch). Shame I didn't notice that before
posting (I only tested with recompiled code).
Would it be possible to change the name of this virtualised class a
dfaure added a comment.
> Using a KDirWatch per thread would still mean that they can be accessing
the shared QFSW instance concurrently.
Are you sure it's shared? d->fsWatcher isn't static.
Could it be that QFSW itself uses a single static object internally? In that
case it's QSFW tha
53 matches
Mail list logo
