BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/111/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Mon, 02 Oct 2017 03:02:17 +
Build duration:
19 min and counting
JUnit Tests
Name: (root)
smithjd added a comment.
Copying/cutting file tags works both from local files and also tagged files.
Breaking tags works, e.g. nested tag foo in bar can be copied or cut to
foobar/barfoo tag path. Cutting and pasting a file folder results in a new tag
on the folder, copying applies the
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/112/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 02 Oct 2017 03:02:17 +
Build duration:
11 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/90/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 02 Oct 2017 03:02:33 +
Build duration:
8 min 44 sec and counting
JUnit Tests
ngraham added a reviewer: vhanda.
ngraham added a comment.
Oh, I'm a dolt. I was trying to apply this to KIO, not Baloo. Ignore me;
works fine when you're not holding it wrong. :)
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/95/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 02 Oct 2017 03:02:33 +
Build duration:
1 min 41 sec and counting
JUnit Tests
smithjd added a comment.
Maybe update your local repo? It is against the most recent commit in master.
It was diff'ed from a non-master branch...
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks
Cc: ngraham
ngraham added a comment.
Fantastic work. I wasn't able to apply it with `arc`, though:
This diff is against commit 9383ea8927579555301eb378c1ce299dde2a2d08, but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state?
smithjd created this revision.
smithjd added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Allow for more operations on tag trees (e.g. rename, copy, delete) and fix
some existing issues.
BUG: 314373
BUG: 340098
BUG: 376229
BUG: 332214
fvogt added a comment.
In https://phabricator.kde.org/D8077#151362, @broulik wrote:
> Meh.
>
> I suspect there are other modules affected as well?
I'm not sure, I didn't test anything beyond the default plasma configuration.
A quick scan with a script showed mostly false
mardelle updated this revision to Diff 20216.
mardelle added a comment.
Added test to check stale file is correctly found
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8084?vs=20180=20216
REVISION DETAIL
https://phabricator.kde.org/D8084
AFFECTED
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/125/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 01 Oct 2017 21:06:55 +
Build duration:
5 min 10 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/121/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Sun, 01 Oct 2017 21:06:55 +
Build duration:
4 min 35 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:4f43c236e34e: Fix org.kde.plasma.calendar with Qt 5.10
(authored by fvogt).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8077?vs=20165=20213
dfaure updated this revision to Diff 20212.
dfaure added a comment.
Add unittest for Alt+Tab and Alt+Shift+Tab, passes.
Real-world testing passed too.
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7829?vs=20066=20212
BRANCH
master
REVISION
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Meh.
I suspect there are other modules affected as well?
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8077
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2d8eab6f502e: Fix non-existing itemDatas (authored by
dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8092?vs=20197=20203
REVISION DETAIL
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix-more-attributes
REVISION DETAIL
https://phabricator.kde.org/D8092
To: dhaumann, vkrause
Cc: #frameworks
mgallien updated this revision to Diff 20200.
mgallien added a comment.
add a setAutoDeletePlugin method and modify the name of the enum value to not
use the shared word
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7750?vs=19918=20200
BRANCH
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Still broken:
haml.xml" Reference of non-existing itemData attributes: QSet("Escaped
Text",
mpyne added a comment.
Any objections? If not I'll try to commit in the next few days.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8002
To: mpyne, #frameworks
ngraham added a comment.
In https://phabricator.kde.org/D8056#151057, @simgunz wrote:
> > - When the text field has focus, make the down arrow key move to the list
of found results so that you can select one with the keyboard and not have to
use the mouse at all
>
> I like the idea
ltoscano added a comment.
I would say that the testing by @fvogt is enough, and given that most
distributions are trying to phase out OpenSSL 1.0, and that they are compiling
Qt with OpenSSL 1.1, I would suggest to push this and see fix any breakages
later.
It's low risk, as those
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Looks good. To nitpick, setAutoDeletePlugin(true) would have been clearer
IMHO.
(Shared sounds like shared_ptr i.e. refcounting, which isn't the case here,
it's just autodelete=off)
ltoscano added a comment.
I don't know the code too much, but would it be possible to add an autotest
for this?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8084
To: mardelle, #frameworks, shaforostoff
Cc: ltoscano
mardelle created this revision.
mardelle added reviewers: Frameworks, shaforostoff.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
KAutoSaveFile does not correctly handle simple characters like spaces in file
names!!!
When creating a stale file (backup file) , to
broulik added inline comments.
INLINE COMMENTS
> kiconloader.cpp:869
> % QLatin1Char('_')
> - % paletteId(qApp->palette(), mColorSet)
> + % paletteId(mPalette)
> % (q->theme() && q->theme()->followsColorScheme() && state ==
>
simgunz added a comment.
> - When the text field has focus, make the down arrow key move to the list
of found results so that you can select one with the keyboard and not have to
use the mouse at all
I like the idea and in my personal opinion it should behave as you suggest,
but before
28 matches
Mail list logo
