D8147: Use QActionGroup for input mode selection

2017-10-04 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I once recovery this as well. Thanks for the fix, please commit. REPOSITORY R39 KTextEditor BRANCH defaultinputmode REVISION DETAIL https://phabricator.kde.org/D8147 To:

D8148: Fix missing spell check bar

2017-10-04 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R39 KTextEditor BRANCH spelldialog REVISION DETAIL https://phabricator.kde.org/D8148 To: croick, #ktexteditor, dhaumann Cc: dhaumann, #frameworks,

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 126 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/126/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 03:09:29 + Build duration: 21 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 122 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/122/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Thu, 05 Oct 2017 03:09:28 + Build duration: 20 min and counting JUnit

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 114 - Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/114/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 03:08:48 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 113 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/113/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Thu, 05 Oct 2017 03:08:48 + Build duration: 9 min 56 sec and counting JUnit Tests Name:

D8098: Strip down and re-write the tags KIO slave.

2017-10-04 Thread James Smith
smithjd updated this revision to Diff 20362. smithjd added a comment. - Fix tag navigation display labels in Dolphin. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=20320=20362 BRANCH master-nestedTags (branched from master) REVISION DETAIL

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 52 - Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/52/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Thu, 05 Oct 2017 00:55:16 + Build duration: 3 min 32 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 47 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/47/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 05 Oct 2017 00:55:16 + Build duration: 2 min 24 sec and counting JUnit

D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries

2017-10-04 Thread Michael Pyne
This revision was automatically updated to reflect the committed changes. Closed by commit R244:4bdc7bb199ec: desktoptojson: Improve legacy service type detection heuristic. (authored by mpyne). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8002?vs=19963=20361#toc REPOSITORY R244

D8148: Fix missing spell check bar

2017-10-04 Thread Christoph Roick
croick created this revision. croick added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - the spell check bar removes itself from the bottom view bar, now is added again when required

D8146: Don't try to override label heights - PlasmaComponents

2017-10-04 Thread David Edmundson
davidedmundson added a comment. I do hold a personal vendetta against this line, so I wish I could approve it. But, unlike the QQC2 change, PlasmaComponents.Label is pre-existing and used /everywhere/ . Not just within Plasma, but in literally every applet in the KDE store. I don't

D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries

2017-10-04 Thread Michael Pyne
mpyne added inline comments. INLINE COMMENTS > graesslin wrote in desktopfileparser.cpp:547 > Be careful with for and qt containers. This causes a detach. Either use the > old variant or wrap the list in qAsConst ( which is new in 5.7) OK. I think we settled on Qt 5.6 for now at the request

D8147: Use QActionGroup for input mode selection

2017-10-04 Thread Christoph Roick
croick created this revision. croick added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - now shows the current mode at start - automatically is mutually exclusive TEST PLAN -

D8146: Don't try to override label heights - PlasmaComponents

2017-10-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Plasma. nicolasfella added a project: Plasma. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Same as https://phabricator.kde.org/D8129 but

D8077: Fix org.kde.plasma.calendar with Qt 5.10

2017-10-04 Thread Kai Uwe Broulik
broulik added a comment. Despite just having built p-f from git I still get > Error loading QML file: file:///usr/share/plasma/plasmoids/org.kde.plasma.fuzzyclock/contents/ui/main.qml:51:34: Type PlasmaCalendar.MonthView unavailable >

Re: konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

2017-10-04 Thread René J . V . Bertin
Bump. This is still an issue with konqueror 17.08.1 and KF5 5.38.0 . Time to escalate this to BKO I guess. R.

D7369: Wayland foreign protocol

2017-10-04 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Documentation is still missing, Unstable suffix is still in two many API calls. INLINE COMMENTS > registry.h:527-528 > + > +zxdg_exporter_v2

D7810: Add missing icon sizes

2017-10-04 Thread Nathaniel Graham
ngraham added a comment. Thanks for the patch, Mandian! Can you mention some details of your testing process in the Test Plan section, and maybe attach some before-and-after screenshots? Also make sure this change doesn't cause any regressions when running software in a non-MATE (i.e.

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 105 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/105/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 04 Oct 2017 15:58:49 + Build duration: 1 min 7 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 99 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/99/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 04 Oct 2017 15:58:49 + Build duration: 43 sec and counting JUnit Tests

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9 - Build # 10 - Still Failing!

2017-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.9/10/ Project: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 04 Oct 2017 15:52:41 + Build duration: 36 sec and counting

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7 - Build # 10 - Still Failing!

2017-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20XenialQt5.7/10/ Project: Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7 Date of build: Wed, 04 Oct 2017 15:52:41 + Build duration: 46 sec and counting

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7 - Build # 10 - Still Failing!

2017-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.7/10/ Project: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 04 Oct 2017 15:52:41 + Build duration: 24 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 98 - Still unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/98/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 04 Oct 2017 14:45:39 + Build duration: 1 min 19 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 104 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/104/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 04 Oct 2017 12:51:17 + Build duration: 1 min 4 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 103 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/103/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 04 Oct 2017 12:45:37 + Build duration: 1 min 19 sec and counting JUnit Tests

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9 - Build # 9 - Still Failing!

2017-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.9/9/ Project: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 04 Oct 2017 12:19:46 + Build duration: 1 min 4 sec and

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7 - Build # 9 - Still Failing!

2017-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20XenialQt5.7/9/ Project: Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7 Date of build: Wed, 04 Oct 2017 12:19:46 + Build duration: 1 min 0 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 102 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/102/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 04 Oct 2017 12:18:06 + Build duration: 1 min 50 sec and counting JUnit Tests

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7 - Build # 9 - Still Failing!

2017-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.7/9/ Project: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 04 Oct 2017 12:19:46 + Build duration: 19 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 96 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/96/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 04 Oct 2017 12:18:06 + Build duration: 1 min 20 sec and counting JUnit Tests

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9 - Build # 8 - Still Failing!

2017-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.9/8/ Project: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 04 Oct 2017 11:02:46 + Build duration: 2 min 13 sec and

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7 - Build # 8 - Still Failing!

2017-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20XenialQt5.7/8/ Project: Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7 Date of build: Wed, 04 Oct 2017 11:02:46 + Build duration: 1 min 4 sec and counting

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7 - Build # 8 - Still Failing!

2017-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.7/8/ Project: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 04 Oct 2017 11:02:46 + Build duration: 22 sec and counting

D8135: [FrameSvg] Optimize updateSizes

2017-10-04 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8135 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8135: [FrameSvg] Optimize updateSizes

2017-10-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY frame->fooHeight is the same as frame->fooFixedHeight if the border is enabled, we

D7884: - Increase size of trailing mark

2017-10-04 Thread Helio Castro
helio updated this revision to Diff 20330. helio added a comment. Rebase on current master REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=19888=20330 BRANCH big_trailing REVISION DETAIL https://phabricator.kde.org/D7884 AFFECTED FILES

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 112 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/112/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Wed, 04 Oct 2017 06:46:56 + Build duration: 19 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 77 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/77/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 04 Oct 2017 06:47:46 + Build duration: 17 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 113 - Fixed!

2017-10-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/113/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 04 Oct 2017 06:46:56 + Build duration: 7 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 76 - Still Unstable!

2017-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/76/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 04 Oct 2017 05:44:44 + Build duration: 14 min and counting JUnit Tests