D7520: Fix icon of KStandardAction::MoveToTrash

This revision was automatically updated to reflect the committed changes. Closed by commit R265:b8641527bb67: Fix icon of KStandardAction::MoveToTrash (authored by elvisangelaccio). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7520?vs=20631=20966

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/128/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 18 Oct 2017 18:57:57 + Build duration: 5 min 9 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 122 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/122/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 18 Oct 2017 18:57:57 + Build duration: 1 min 3 sec and counting JUnit Tests

D8354: Remove check for SNI hosts when chosing

davidedmundson added a comment. > Just tested: this fixes the freeze I'm experiencing on startup! It's a combo of both this, the other one, and apparently your change from a while ago with the async version lookup. I'm quite glad there isn't a forth issue! I suggest us devs export

D8347: KIO::PreviewJob::defaultPlugins() function

ngraham added a comment. I am indeed up for lots of bug reports. :) We can't find the bugs if many (most?) users don't use the feature because it's off by default! FWIW, I've always turned all plugins on as one of the first things I do on a new install, and I have yet to see a

D8347: KIO::PreviewJob::defaultPlugins() function

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D8347#156930, @ngraham wrote: > I still need to add a @since in the header documentation, after which point hopefully @markg will approve. :) +1

D8348: Add a section for removable devices

anthonyfieroni added inline comments. INLINE COMMENTS > kfileplacesitem.cpp:90 > > +if (m_device.udi().isEmpty()) > +updateDeviceInfo(m_bookmark.metaDataItem(QStringLiteral("UDI"))); Braces even on one line block. > kfileplacesitem.cpp:328 > +{ > +if (m_device.udi() != udi) {

D8347: KIO::PreviewJob::defaultPlugins() function

ngraham added a comment. I still need to add a @since in the header documentation, after which point hopefully @markg will approve. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8347 To: ngraham, #frameworks, broulik, #dolphin, markg Cc: markg, anthonyfieroni,

D7520: Fix icon of KStandardAction::MoveToTrash

ngraham added a comment. Can we land this? REPOSITORY R265 KConfigWidgets BRANCH user-trash REVISION DETAIL https://phabricator.kde.org/D7520 To: elvisangelaccio, #frameworks, ngraham Cc: ngraham, andreaska, broulik

D8347: KIO::PreviewJob::defaultPlugins() function

broulik added a comment. Agreed. I'd say if nobody objects this week this is good to go REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8347 To: ngraham, #frameworks, broulik, #dolphin, markg Cc: markg, anthonyfieroni, elvisangelaccio, #frameworks

D8348: Add a section for removable devices

renatoo updated this revision to Diff 20953. renatoo added a comment. Update parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=20941=20953 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 20952. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=20940=20952 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

D8243: Implement support for categories on KfilesPlacesView

renatoo updated this revision to Diff 20951. renatoo added a comment. Fixed places item size calculation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8243?vs=20939=20951 REVISION DETAIL https://phabricator.kde.org/D8243 AFFECTED FILES

D8347: KIO::PreviewJob::defaultPlugins() function

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8347 To: ngraham, #frameworks, broulik, #dolphin, markg Cc: markg, anthonyfieroni, elvisangelaccio, #frameworks

D8347: KIO::PreviewJob::defaultPlugins() function

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > anthonyfieroni wrote in previewjob.cpp:740 > const QStringList blackList = { QStringLiteral("textthumbnail") }; I wrote it the way I did on purpose, to facilitate people adding new entries if and when

D8347: KIO::PreviewJob::defaultPlugins() function

ngraham added a comment. Right, I deliberately made this a change of the default values. I didn't want to override existing user preferences. I do agree that there should probably be a mechanism to immediately enable new plugins as they're installed, but IMHO that's a different change

D8354: Remove check for SNI hosts when chosing

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Just tested: this fixes the freeze I'm experiencing on startup! REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D8354 To:

KDE CI: Frameworks kcodecs kf5-qt5 AndroidQt5.9 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20AndroidQt5.9/3/ Project: Frameworks kcodecs kf5-qt5 AndroidQt5.9 Date of build: Wed, 18 Oct 2017 12:55:58 + Build duration: 4 min 6 sec and counting

D8243: Implement support for categories on KfilesPlacesView

dfaure added a comment. +1, looks good to me, implementation wise. I'll let someone else decide on the actual feature (e.g. retesting for bugs, like Kévin did). I suspect that the use of QApplication::font/fontMetrics breaks when setting a font on that widget, but well, who would do

D8348: Add a section for removable devices

renatoo updated this revision to Diff 20941. renatoo edited the summary of this revision. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=20919=20941 REVISION DETAIL https://phabricator.kde.org/D8348

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 20940. renatoo edited the summary of this revision. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=20918=20940 REVISION DETAIL https://phabricator.kde.org/D8332

D8243: Implement support for categories on KfilesPlacesView

renatoo updated this revision to Diff 20939. renatoo marked 11 inline comments as done. renatoo edited the summary of this revision. renatoo added a comment. Fixed typo and code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8243?vs=20675=20939 REVISION

D8355: Remove check for SNI hosts when chosing

davidedmundson abandoned this revision. davidedmundson added a comment. arc sent this twice for some reason. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8355 To: davidedmundson Cc: #frameworks

D8355: Remove check for SNI hosts when chosing

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Previous code (since very first commit) checked for both having a valid KSNI watcher as well as making sure there was a host

D8354: Remove check for SNI hosts when chosing

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Previous code (since very first commit) checked for both having a valid KSNI watcher as well as making sure there was a host

D8347: KIO::PreviewJob::defaultPlugins() function

broulik added a comment. Unfortunately this will not automatically enable newly installed thumbnailers once the user has changed the setting, right? Dolphin does `readEntry("foo", defaultPlugins)`, as soon as it's there new ones aren't taken into account. Perhaps we need another function

D8346: Remove blocking call in KStatusNotifierItem

davidedmundson abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8346 To: davidedmundson Cc: xuetianweng, #frameworks

Re: qqc2-desktop-style as framework

On Sat, Oct 14, 2017 at 1:41 PM, Volker Krause wrote: > Observations while trying to add this to the KF5 Yocto recipes: > - it shows up as Tier 1 on https://api.kde.org/frameworks/index.html but seems > to have a hard dependency on Kirigami shoud be tier 3 (should have be fixed

D8347: KIO::PreviewJob::defaultPlugins() function

markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. I'm a bit skeptical about this function... It in fact is all plugins minus (in this case) the text thumbnail with no way to configure it afterwards. That means a updates