KDE CI: Frameworks kservice kf5-qt5 XenialQt5.7 - Build # 28 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/28/ Project: Frameworks kservice kf5-qt5 XenialQt5.7 Date of build: Thu, 26 Oct 2017 05:10:27 + Build duration: 7 min 8 sec and counting JUnit Tests Name: (root) Failed: 5 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kmimeassociationstestFailed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycoca_xdgdirstestFailed: TestSuite.ksycocathreadtest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report86% (6/7)87% (73/84)87% (73/84)57% (4460/7841)36% (2195/6063)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (13/13)100% (13/13)82% (1127/1382)41% (663/1617)src.kbuildsycoca100% (1/1)100% (1/1)91% (61/67)65% (13/20)src.kdeinit0% (0/2)0% (0/2)0% (0/326)0% (0/262)src.plugin67% (2/3)67% (2/3)47% (47/100)38% (36/96)src.services90% (28/31)90% (28/31)52% (1575/3046)33% (625/1904)src.sycoca84% (26/31)84% (26/31)55% (1542/2800)39% (824/2114)tests.pluginlocator100% (3/3)100% (3/3)90% (108/120)68% (34/50)
D7660: Fix a regression caused by changing backspace key behavior
safaalfulaij added a comment. In https://phabricator.kde.org/D7660#158479, @ngraham wrote: > @safaalfulaij, any progress on the latest comments? Not really. I was busy with college. I'll try finishing it in the coming week. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann Cc: ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks
D5209: Load translations from KPackage files if bundled
Zren added a comment. Another note: `plasmoidviewer` is unaffected by this patch. Meaning - `devpath/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` will not show translations in plasmoidviewer, but if you install to - `/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` - `/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` - `/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` - `/usr/share/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` - `/usr/share/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` it will work in plasmoidviewer. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D5209: Load translations from KPackage files if bundled
Zren added a comment. This worked - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` These didn't work - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/org.kde.plasma.eventcalendar.mo` - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/org.kde.plasma.eventcalendar.po` - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.po` - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/org.kde.plasma.eventcalendar.mo` - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/org.kde.plasma.eventcalendar.po` - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/plasma_applet_org.kde.plasma.eventcalendar.po` - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/plasma_applet_org.kde.plasma.eventcalendar.mo` More importantly, `contents/locale/fr/*` didn't work, which means I need to either copy or symlink to fr_BE, fr_CA, fr_CH, fr_FR, and fr_LU. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.9 - Build # 4 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.9/4/ Project: Frameworks kunitconversion kf5-qt5 AndroidQt5.9 Date of build: Thu, 26 Oct 2017 00:31:45 + Build duration: 1 min 27 sec and counting
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham planned changes to this revision. ngraham added a comment. Oh, great idea. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
abetts added a comment. Could this also be added to global shortcuts if it is not there already? That the user can define the keys to use for Preferences? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
Re: Frameworks release schedule?
On Wed, Oct 25, 2017 at 1:44 AM, Harald Sitter wrote: > On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote: >> Hi, >> I send this email to kde-frameworks-devel >> >> It's the correct ML for having an answer about it >> >> Regards. Hi Laurent, I thought that frameworks-devel was being deprecated but I guess I'm out of the loop. So thanks. >> Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit : >>> Hello folks, with my Kubuntu release manager hat on, I was filling in >>> the calendar for the next 6 months. For Frameworks, this page: >>> https://community.kde.org/Schedules/Frameworks is now on a provisional >>> schedule - 5.40 (expected) Sat November 4th, 2017 for tagging, >>> (expected) Sat November 11th, 2017. >>> >>> Is the schedule for the next 6 months still undecided, or has the wiki >>> page just not been filled in yet? > > "... and so on. Until further notice: tagging happens the first > saturday of every month, and the public release is one week later." > > That generally holds true unless something causes or needs an > extraordinary delay (which in the past has never been more than a > couple of days). > > HS Thanks Harald! Valorie -- http://about.me/valoriez
KDE CI: Frameworks kconfig kf5-qt5 AndroidQt5.9 - Build # 2 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20AndroidQt5.9/2/ Project: Frameworks kconfig kf5-qt5 AndroidQt5.9 Date of build: Wed, 25 Oct 2017 23:09:37 + Build duration: 3 min 57 sec and counting
D8457: Don't build the kconfig_compiler tests when crosscompiling
This revision was automatically updated to reflect the committed changes. Closed by commit R237:a07822207374: Don't build the kconfig_compiler tests when crosscompiling (authored by apol). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8457?vs=21267&id=21342 REVISION DETAIL https://phabricator.kde.org/D8457 AFFECTED FILES autotests/CMakeLists.txt To: apol, #frameworks, davidedmundson
D8457: Don't build the kconfig_compiler tests when crosscompiling
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D8457 To: apol, #frameworks, davidedmundson
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham added a comment. Thanks for your comments, @rkflx. I have no strong opinions on what the shortcut should be. Side note: if KMail and Kontact don't get this change automatically, that's a sign that they're not using `KStandardAction::Preferences()` and should be. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
rkflx added a comment.
Since @ngraham added me as reviewer, here are my 2 cents. Trying the patch, I
made those observations:
- [Alt] often is released by the user only after the dialog is shown already,
resulting in the (normally hidden) accelerators ("_") of the dialog showing and
then dissappearing, which looks odd.
- Normally [Alt] is used either for accessing the menu itself or in
combination with the cursor/navigation keys, but not so much for shortcuts.
While there are exceptions, at least our shortcuts for executing standard
actions affecting all apps should IMHO stick to [Ctrl].
- Does not work in Kontact and KMail (but does work in KOrganizer and KMail's
"New Mail" window).
Note I don't oppose the idea to have a universal shortcut for opening the
preferences, but I feel that with the currently selected shortcut the net
effect to the overall user experience and consistency is slightly negative.
I won't block this patch, but instead let me add this ideas:
- The patch is not really urgent. Do we have the chance to gather some
telemetry data on the usage of shortcuts as well as on the preferences dialog?
That way we could better evaluate the usefulness and maybe even choose
non-conflicting shortcuts.
- Apply the change only via a shortcut theme package for Mac refugees (not
sure if can we have such a thing?)
- If we change it at all, this should get in very early in the cycle to judge
how much this conflicts with custom shortcuts users have.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik,
#frameworks
D7828: createKMessageBox tries to focus a default button when available
rkflx added a comment. In general, having a default button while setting the initial focus elsewhere is mainly useful for larger dialogs like our various standard configuration dialogs, where this provides a way to accept without tabbing forever. For smaller dialogs like a messagebox this is not that important, but at least consistent. For messageboxes my general expectation is that the default button should also have focus to more clearly guide the user in the best decision regarding what button choose. That said, I agree with @subdiff to at least allow deviations from this, while at the same time fixing Dolphin. BTW, Dolphin's inconsistency is the reason why I mentioned this Differential in https://phabricator.kde.org/T7022. > a fix for this change in behaviour when a parent widget is present or not This sounds reasonable and would be great if this fixed Dolphin. There is another odd behaviour in Dolphin's tab close confirmation dialog compared to e.g. Konsole's: First the default button is Quit, after switching focus around with [⇥] in every possible direction suddenly Close is default. Maybe this is related to not specifying a parent window and could help solving this? REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: rkflx, abetts, subdiff, ngraham, aacid, #frameworks
D8437: KWidgetsAddons : more compact password dialog
ngraham accepted this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk, ngraham Cc: cfeck, ngraham
D8437: KWidgetsAddons : more compact password dialog
rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk Cc: cfeck, ngraham
D8437: KWidgetsAddons : more compact password dialog
rjvbb updated this revision to Diff 21340. rjvbb added a comment. patch cleaned up as requested. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8437?vs=21188&id=21340 REVISION DETAIL https://phabricator.kde.org/D8437 AFFECTED FILES src/kpassworddialog.ui To: rjvbb, #frameworks, kfunk Cc: cfeck, ngraham
D7828: createKMessageBox tries to focus a default button when available
aacid added a comment. In https://phabricator.kde.org/D7828#160029, @ngraham wrote: > In other words, it seems intentional that the button marked default will always receive focus. No, open kate->settings->configure kate Ok is the default button and it is not supposed to have the focus, default == should have focus is simply not what default means. REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: abetts, subdiff, ngraham, aacid, #frameworks
D7828: createKMessageBox tries to focus a default button when available
emateli added a comment. I think this is getting a bit out of hand here. Please try to read my last message where I explain why I decided to submit this patch and why I think it's a bug (the whole parent widget thing). Given the new information on why this occurs the whole focus by force thing might not be optimal (although I don't see it as being wrong either), so we can check for a solution that perhaps simply fixes the inconsistency when being called with a parent and without one. This could be easily solvable in Dolphin's repository where this would need only one additional parameter to the `createKMessageBox` call, but I still thing it belongs to be fixed in the frameworks. REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: abetts, subdiff, ngraham, aacid, #frameworks
D7828: createKMessageBox tries to focus a default button when available
ngraham added a comment. In https://phabricator.kde.org/D7828#160028, @aacid wrote: > In https://phabricator.kde.org/D7828#160018, @ngraham wrote: > > > Once you press tab the focus moves elsewhere and hitting return or enter will press whatever's selected rather than the original default button. So really the concept of a "Default Button" in our world seems to mostly be synonymous with "the button that receives focus by default." In this case, then there should only be one focus, and that focus should be on whatever is marked as a default button. Makes sense to me. > > > Hmmm, that's not really what it happens, is it? > otherwise "i am focused on the checkbox but press enter and the button gets pressed" would never happen? It seems that regardless, the condition with this Dolphin dialog box where the checkbox receives focus but another buttin is marked as Default is actually unintentional, and is a bug that should be fixed. Try this in Kate: Open a new document, type some stuff, and close it. In the resulting dialog box, he "Save" button is focused by default, but if you hit tab or the right arrow key, the focus will shift to another button and then hitting return or enter will press that button. This is a really nice feature. In other words, it seems intentional that the button marked default will always receive focus. REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: abetts, subdiff, ngraham, aacid, #frameworks
D7828: createKMessageBox tries to focus a default button when available
aacid added a comment. In https://phabricator.kde.org/D7828#160018, @ngraham wrote: > Once you press tab the focus moves elsewhere and hitting return or enter will press whatever's selected rather than the original default button. So really the concept of a "Default Button" in our world seems to mostly be synonymous with "the button that receives focus by default." In this case, then there should only be one focus, and that focus should be on whatever is marked as a default button. Makes sense to me. Hmmm, that's not really what it happens, is it? otherwise "i am focused on the checkbox but press enter and the button gets pressed" would never happen? REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: abetts, subdiff, ngraham, aacid, #frameworks
D7828: createKMessageBox tries to focus a default button when available
ngraham added a comment. Once you press tab the focus moves elsewhere and hitting return or enter will press whatever's selected rather than the original default button. So really the concept of a "Default Button" in our world seems to mostly be synonymous with "the button that receives focus by default." In this case, then there should only be one focus, and that focus should be on whatever is marked as a default button. Makes sense to me. REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: abetts, subdiff, ngraham, aacid, #frameworks
D7828: createKMessageBox tries to focus a default button when available
aacid added a comment. In https://phabricator.kde.org/D7828#159598, @ngraham wrote: > In https://phabricator.kde.org/D7828#159556, @abetts wrote: > > > If you have two highlights, how do you know what's going to be activated when hitting enter? > > > My thoughts exactly. But it does not really solve that, once you press tab and then you still have the same problem, right? REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: abetts, subdiff, ngraham, aacid, #frameworks
D7194: Detach before setting the d pointer
apol added a comment. In https://phabricator.kde.org/D7194#159878, @kossebau wrote: > @apol Was this patch created due to some bug seen, or perhaps only of the kind oh-that-seems-wrong-lets-be-nice-and-prevent-things? If the latter that might be handy :) I had some issue where I started to see objects changing what they reported over time in Discover. I don't remember what the exact issue was at the moment (It's from early August...). I don't think it makes a lot of sense to have objects changing values that can't report which values changed, hence adding the detach API. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7194 To: apol, leinir Cc: sitter, kossebau, whiting, mutlaqja, broulik, #frameworks
D8450: User can now hide an entire places group from KFilePlacesView
franckarrecot added a comment. I will add pics soonish REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, mlaurent Cc: #frameworks
D7194: Detach before setting the d pointer
kossebau added a comment. @leinir I now completely gave up on the patch which tried to adapt to the non-shared EntryInternal. As the screenshot loading code and the payload download code rely on the explicitly shared data to attach the fetched screenshots resp. update the download state, that would need some more redesign of logic to update the central EntryInternal storage and from there any interested viewer on that. Which I do not have the energy to try now. So by what I have seen I would vote for a revert as well. + some kf6 notes as you mentioned. @apol Was this patch created due to some bug seen, or perhaps only of the kind oh-that-seems-wrong-lets-be-nice-and-prevent-things? If the latter that might be handy :) Too bad that EntryInternal is exposed at all in the KNS API, while there is a public read-only wrapper to it. Seems the person designing this code initially should have named it EntryInternalReallyIMeanIt, but then descendants still might have just helped themselves as now for whatever they needed to ;) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7194 To: apol, leinir Cc: sitter, kossebau, whiting, mutlaqja, broulik, #frameworks
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 132 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/132/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 25 Oct 2017 13:10:40 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest
KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 128 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/128/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Wed, 25 Oct 2017 13:10:40 + Build duration: 4 min 13 sec and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report86% (6/7)62% (57/92)62% (57/92)38% (3501/9230)26% (1860/7156)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (22/22)100% (22/22)76% (607/795)38% (390/1028)src.declarativeimports.core57% (4/7)57% (4/7)28% (246/883)14% (86/620)src.plasma62% (13/21)62% (13/21)40% (1420/3581)29% (773/2697)src.plasma.private46% (11/24)46% (11/24)39% (649/1649)28% (303/1080)src.plasma.scripting0% (0/3)0% (0/3)0% (0/190)0% (0/126)src.plasmaquick50% (6/12)50% (6/12)27% (548/2019)19% (302/1583)src.plasmaquick.private33% (1/3)33% (1/3)27% (31/113)27% (6/22)
D8445: [PlasmaComponents Menu] Add ungrabMouseHack
This revision was automatically updated to reflect the committed changes. Closed by commit R242:c52a6c574869: [PlasmaComponents Menu] Add ungrabMouseHack (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8445?vs=21232&id=21305 REVISION DETAIL https://phabricator.kde.org/D8445 AFFECTED FILES src/declarativeimports/plasmacomponents/qmenu.cpp src/declarativeimports/plasmacomponents/qmenu.h To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 134 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/134/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 25 Oct 2017 11:47:45 + Build duration: 1 min 49 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (2/2)67% (6/9)67% (6/9)64% (409/640)43% (169/393)Coverage Breakdown by Package Name FilesClassesLinesConditionalssrc80% (4/5)80% (4/5)54% (173/320)34% (90/263)src.libkirigami50% (2/4)50% (2/4)74% (236/320)61% (79/130)
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 128 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/128/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 25 Oct 2017 11:47:45 + Build duration: 1 min 17 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
D8451: JavaScript: include standard mime types
ChALkeR edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8451 To: ChALkeR, #framework_syntax_highlighting Cc: #frameworks
D8434: Created 'shared' section
renatoo updated this revision to Diff 21297. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21238&id=21297 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, ngraham, #frameworks, #dolphin Cc: mlaurent, #frameworks
D8348: Add a section for removable devices
renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
D8348: Add a section for removable devices
renatoo updated this revision to Diff 21296. renatoo added a comment. Used new connect API REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21228&id=21296 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, #dolphin, #frameworks, #vdg Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 133 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/133/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Wed, 25 Oct 2017 10:43:44 + Build duration: 4 min 58 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (2/2)67% (6/9)67% (6/9)64% (409/640)43% (169/393)Coverage Breakdown by Package Name FilesClassesLinesConditionalssrc80% (4/5)80% (4/5)54% (173/320)34% (90/263)src.libkirigami50% (2/4)50% (2/4)74% (236/320)61% (79/130)
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 127 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/127/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 25 Oct 2017 10:43:44 + Build duration: 44 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
D8450: User can now hide an entire places group from KFilePlacesView
franckarrecot updated this revision to Diff 21291. franckarrecot added a comment. updated according to comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8450?vs=21244&id=21291 REVISION DETAIL https://phabricator.kde.org/D8450 AFFECTED FILES src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h src/filewidgets/kfileplacesview.cpp To: franckarrecot, ngraham, renatoo, mlaurent Cc: #frameworks
D8367: Hidding place groups implementation in KFilePlacesModel
franckarrecot updated this revision to Diff 21290. franckarrecot added a comment. updated according to comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=21243&id=21290 REVISION DETAIL https://phabricator.kde.org/D8367 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h To: franckarrecot, renatoo, mlaurent, ngraham Cc: ngraham, mlaurent, #frameworks
D8366: Factoring out lists of url data within KFilePlacesModelTest
franckarrecot updated this revision to Diff 21289. franckarrecot added a comment. switch removable after regular devices REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8366?vs=20973&id=21289 REVISION DETAIL https://phabricator.kde.org/D8366 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: franckarrecot, renatoo, mlaurent Cc: mlaurent, #frameworks
D8450: User can now hide an entire places group
franckarrecot retitled this revision from "WIP: User can now hide an entire places group" to "User can now hide an entire places group". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, mlaurent Cc: #frameworks
D8450: User can now hide an entire places group from KFilePlacesView
franckarrecot retitled this revision from "User can now hide an entire places group" to "User can now hide an entire places group from KFilePlacesView". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, mlaurent Cc: #frameworks
D8366: Factoring out lists of url data within KFilePlacesModelTest
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. seems ok for me REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, mlaurent Cc: mlaurent, #frameworks
D8450: WIP: User can now hide an entire places group
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:297
> +const QModelIndexList indexesGroup =
> placesModel->groupIndexes(placesModel->groupType(index));
> +
> +for (const QModelIndex &idx : indexesGroup) {
m_disappearingItems.reserve(m_disappearingItems.count() + indexesGroup.count())
?
> kfileplacesview.cpp:431
> +
> +const KFilePlacesModel *placesModel = static_cast *>(index.model());
> +if (placesModel && placesModel->isPlaceGroupHidden(index)) {
index.model() can be null ?
otherwise it's not necessary to check "if (placesModel" as you use
static_cast<...>
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks
Re: Frameworks release schedule?
On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote: > Hi, > I send this email to kde-frameworks-devel > > It's the correct ML for having an answer about it > > Regards. > > Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit : >> Hello folks, with my Kubuntu release manager hat on, I was filling in >> the calendar for the next 6 months. For Frameworks, this page: >> https://community.kde.org/Schedules/Frameworks is now on a provisional >> schedule - 5.40 (expected) Sat November 4th, 2017 for tagging, >> (expected) Sat November 11th, 2017. >> >> Is the schedule for the next 6 months still undecided, or has the wiki >> page just not been filled in yet? "... and so on. Until further notice: tagging happens the first saturday of every month, and the public release is one week later." That generally holds true unless something causes or needs an extraordinary delay (which in the past has never been more than a couple of days). HS
Re: Frameworks release schedule?
Hi, I send this email to kde-frameworks-devel It's the correct ML for having an answer about it Regards. Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit : > Hello folks, with my Kubuntu release manager hat on, I was filling in > the calendar for the next 6 months. For Frameworks, this page: > https://community.kde.org/Schedules/Frameworks is now on a provisional > schedule - 5.40 (expected) Sat November 4th, 2017 for tagging, > (expected) Sat November 11th, 2017. > > Is the schedule for the next 6 months still undecided, or has the wiki > page just not been filled in yet? > > Valorie -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
D7828: createKMessageBox tries to focus a default button when available
emateli added a comment. Hey @subdiff, thanks for your input on this. Whether this patch goes in or not, I still think that this "odd" behaviour is something that the frameworks should fix or change rather than relying on the developer of each application to do this. However I never expected this to stir up such a conversation given that I thought this was the normal behaviour in Plasma, given that all(?) the other dialogs created by the framework have the default button focused (See: Konsole close dialog w/ multiple tabs open (the exact same dialog as Dolphin's), or Konversation after having joined a channel. ) Since these functions internally all rely on `createKMessageBox` and work properly so to say, I dug a bit deeper into this and found out the following why Dolphin's close dialog is the odd one out: If no parent window is specified when calling this function then the checkbox will be focused, if one is passed then the focus shifts onto the buttons. Current call: `QDialogButtonBox* buttons = new QDialogButtonBox(QDialogButtonBox::Yes | QDialogButtonBox::No | QDialogButtonBox::Cancel);` "Fixed" call: `QDialogButtonBox* buttons = new QDialogButtonBox(QDialogButtonBox::Yes | QDialogButtonBox::No | QDialogButtonBox::Cancel, dialog);` This leads me to believe that the checkbox having the focus is an irregularity, whether one would consider it a bug is a matter of prespective. But i would expect the frameworks to be consistent in what it does and whether the dialog has a parent or not should not affect what widget is focused. But just like @aacid mentioned, we should not look to break existing code, so given the new information on why this occurs, then perhaps a new implementation might be needed or simply a fix for this change in behaviour when a parent widget is present or not. REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: abetts, subdiff, ngraham, aacid, #frameworks
D7194: Detach before setting the d pointer
leinir added a subscriber: sitter. leinir added a comment. Damn... Well spotted, @kossebau. Right, so immediate (at least temporary solution) to make things not broken would annoyingly enough be to revert the patch, yes... I am now thinking that another oddity noticed by @sitter last week was caused by this as well (going by the installedFiles data being out of sync, it would seem likely it would cause what they were seeing). So... while it feels a bit odd, i would have to vote to revert immediately, and create a new patch documenting why we can't detach in certain classes... Possibly adding in a TODO for Frameworks 6 (there's already a couple of those in kns). REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7194 To: apol, leinir Cc: sitter, kossebau, whiting, mutlaqja, broulik, #frameworks
D8463: C# syntax highlighting, add support for multi-line @"verbatim strings"
genethomas created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I have added support for mult-iline @"verbatim strings" REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8463 AFFECTED FILES data/syntax/cs.xml To: genethomas Cc: #frameworks
D8367: Hidding place groups implementation in KFilePlacesModel
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:596
> +const QHash groupStates = groupStateHidden(root);
> +for (KFilePlacesItem *item : items) {
> +if (bool hasToBeHidden = groupStates.value(item->groupType())) {
for(... : qAsConst(items)) {
}
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks
D8348: Add a section for removable devices
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesitem.cpp:354
> +if (m_access) {
> +connect(m_access, SIGNAL(accessibilityChanged(bool,QString)),
> +this, SLOT(onAccessibilityChanged(bool)));
could you use new connect api please ?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
