D8577: Fix: Missing dependencies for ktexeditor autotests

2017-11-05 Thread Christoph Cullmann
cullmann added a comment. Hmm, I would rather like to have this fixed than having that dependency just for that. I thought during the port it compiled completely without QtScript. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8577 To: hgoebel, #ktexteditor,

D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData

2017-11-05 Thread David Faure
dfaure added a comment. The KCM uses KServiceTypeTrader so we still need the desktop files. REPOSITORY R301 KEmoticons REVISION DETAIL https://phabricator.kde.org/D8671 To: dfaure, #frameworks Cc: apol

D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData

2017-11-05 Thread Aleix Pol Gonzalez
apol added a comment. Other than that +1 INLINE COMMENTS > CMakeLists.txt:19 > ) > -set_target_properties(emoticonstheme_adium PROPERTIES > LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/emoticonsthemes") > -install( > -TARGETS emoticonstheme_adium > -DESTINATION

D8577: Fix: Missing dependencies for ktexeditor autotests

2017-11-05 Thread Hartmut Goebel
hgoebel added a comment. QtScript is only required for the tests. Maybe just a left-over #include? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8577 To: hgoebel, #ktexteditor, dfaure Cc: dhaumann, #frameworks, kevinapavew, demsking, cullmann, sars

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 58 - Fixed!

2017-11-05 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/58/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 05 Nov 2017 23:00:27 + Build duration: 1 min 1 sec and counting

KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 28 - Still Unstable!

2017-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/28/ Project: Frameworks kemoticons kf5-qt5 XenialQt5.7 Date of build: Sun, 05 Nov 2017 22:52:22 + Build duration: 5 min 42 sec and counting JUnit Tests

D8672: Fix build with LibreSSL

2017-11-05 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Unfortunately LibreSSL sets OPENSSL_VERSION_NUMBER to 0x2000L and doesn't support the OpenSSL 1.1 API. TEST PLAN Builds with LibreSSL

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 131 - Still Unstable!

2017-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/131/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Sun, 05 Nov 2017 22:45:27 + Build duration: 5 min 18 sec and counting JUnit Tests Name:

D8348: Add a section for removable devices

2017-11-05 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D8348#164713, @abetts wrote: > What about something like this as well > > F548: Unmount.png > > The removable device gets an "unmount" or "disconnect" icon on hover? > >

D8577: Fix: Missing dependencies for ktexeditor autotests

2017-11-05 Thread Dominik Haumann
dhaumann added a comment. I am a bit surprised by this commit: we just removed the dependency on QtScript in favor of QtQML and now it's back. I don't think this hurts much, but the goal is to not depend on it... ?! REPOSITORY R39 KTextEditor REVISION DETAIL

D8348: Add a section for removable devices

2017-11-05 Thread Andres Betts
abetts added a comment. What about something like this as well F548: Unmount.png The removable device gets an "unmount" or "disconnect" icon on hover? Thoughts? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348

D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData

2017-11-05 Thread David Faure
dfaure created this revision. dfaure added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY This makes it possible to run the autotests without installing kemoticons. TEST PLAN ctest; also playing a bit with `kcmshell5 emoticons`, but not full

D8434: Created 'remote' section

2017-11-05 Thread Renato Oliveira Filho
renatoo marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks

D8434: Created 'remote' section

2017-11-05 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21934. renatoo marked 4 inline comments as done. renatoo added a comment. Fixed typos REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21809=21934 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8348: Add a section for removable devices

2017-11-05 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21933. renatoo added a comment. Parent branch update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21808=21933 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

2017-11-05 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 21932. renatoo marked an inline comment as done. renatoo added a comment. Fixed import REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=21807=21932 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES

Re: Python bindings using cppyy (was: An update on Python bindings)

2017-11-05 Thread Shaheed Haque
Philipp, On 5 November 2017 at 14:48, Philipp A. wrote: > Hi Shaheed, Chris, > > Shaheed Haque schrieb am Sa., 4. Nov. 2017 um > 18:35 Uhr: > >> FWIW, I already tried that (types.ModuleType is itself a perfectly >> subclassable class!) […] >> >> Now,

D8332: Added baloo urls into places model

2017-11-05 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kfileplacesviewtest.cpp:30 > + > +#include > +#include Please don't include the full module (which also contains all QtCore) #include is OK, #include is not. Confusing, I know. REPOSITORY R241 KIO REVISION DETAIL

D8434: Created 'remote' section

2017-11-05 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplacesmodeltest.cpp:804 > + > +// check if url list is corret after insertion > +QStringList urls; typo: correct > kfileplacesmodeltest.cpp:812

D8461: Remove unused config.h.cmake entries

2017-11-05 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The answer to "I'm not sure why" is easy: `git log -S MALLOC` shows exactly two commits, the one that introduced the usage of this stuff, and the one that removed it again. Ain't git

D8577: Fix: Missing dependencies for ktexeditor autotests

2017-11-05 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8577 To: hgoebel, #ktexteditor, dfaure Cc: #frameworks, kevinapavew, demsking, cullmann, sars, dhaumann

D8577: Fix: Missing dependencies for ktexeditor autotests

2017-11-05 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R39:d6fc0b782046: Fix: Missing dependencies for ktexeditor autotests (authored by hgoebel, committed by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8577?vs=21656=21931#toc REPOSITORY

D8590: KPageListView: Update width on font change

2017-11-05 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH KPageListView-updateWidth REVISION DETAIL https://phabricator.kde.org/D8590 To: volkov, cfeck, wojnilowicz, dfaure, rkflx, broulik Cc: #frameworks

D8619: Refactor and remove duplicate code in kfileplacesview

2017-11-05 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplacesview.cpp:66 > +QSize sizeHint(const QStyleOptionViewItem , > const QModelIndex ) const Q_DECL_OVERRIDE; > +void

D8632: kded: remove dbus calls to ksplash.

2017-11-05 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R297:185afa8a3af8: kded: remove dbus calls to ksplash. (authored by dfaure). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8632?vs=21812=21929 REVISION DETAIL

D8640: [KDirModel] Emit change for HasJobRole when jobs change

2017-11-05 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdirmodel.cpp:696 > +std::set_symmetric_difference(urlList.begin(), urlList.end(), > + m_allCurrentDestUrls.begin(), >

D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found

2017-11-05 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R240:f7707bb546bc: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found (authored by dfaure). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D8670: Change label "Advanced options" > "Terminal options"

2017-11-05 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH terminal-options-label REVISION DETAIL https://phabricator.kde.org/D8670 To: simgunz, dfaure, ngraham, fabianr Cc: #frameworks

D8643: Fix display of remote:/ in the qfiledialog

2017-11-05 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kfileitem.cpp:559 > d->m_strName = name; > -d->m_strText = KIO::decodeFileName(d->m_strName); > +if (!d->m_entry.contains(KIO::UDSEntry::UDS_DISPLAY_NAME)) { > +d->m_strText = KIO::decodeFileName(d->m_strName); Wouldn't it be

Re: Test failures with krunner 5.39.0

2017-11-05 Thread David Faure
On mercredi 1 novembre 2017 16:37:30 EET Hartmut Goebel wrote: > Hallo, > > I'm packaging krunner 5.39.0 for GNU Guix [1]. GNU Guix builds all > software in an isolated environment (a container), which includes only > the packages and tools specified explicitly. > > When running the tests,

D8670: Change label "Advanced options" > "Terminal options"

2017-11-05 Thread Simone Gaiarin
simgunz added reviewers: dfaure, ngraham, fabianr. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8670 To: simgunz, dfaure, ngraham, fabianr Cc: #frameworks

D8670: Change label "Advanced options" > "Terminal options"

2017-11-05 Thread Simone Gaiarin
simgunz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Be more specific with the label as HIG say REPOSITORY R241 KIO BRANCH terminal-options-label REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-05 Thread Simone Gaiarin
simgunz added a comment. I have fixed what dfaure suggested. I couldn't remove the cast at line 463 because a Segmentation fault happens. It is not clear to me why exactly. Regarding removing the categories I need to work on that, because it is not trivial apparently. I thought it was

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-11-05 Thread Simone Gaiarin
simgunz updated this revision to Diff 21925. simgunz marked 4 inline comments as done. simgunz added a comment. - Fix code styling - Set appModel and proxyModel together, store proxyModel in data member - Avoid casts using pointer to proxyModel REPOSITORY R241 KIO CHANGES SINCE LAST

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

2017-11-05 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D8636#164605, @Zren wrote: > Quick note since I just notice you suggested a lowercase `i` in `?linkid=3`, should I change it to lowercase or stick with camelcase? I don't really mind, maybe leave it as `link`? REPOSITORY

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

2017-11-05 Thread Chris Holland
Zren added a comment. Quick note since I just notice you suggested a lowercase `i` in `?linkid=3`, should I change it to lowercase or stick with camelcase? REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren, apol Cc: #frameworks

Re: Python bindings using cppyy (was: An update on Python bindings)

2017-11-05 Thread Philipp A.
Hi Shaheed, Chris, Shaheed Haque schrieb am Sa., 4. Nov. 2017 um 18:35 Uhr: > FWIW, I already tried that (types.ModuleType is itself a perfectly > subclassable class!) […] > > Now, none of that may be a limiting factor in the plan you seem to be > discussing, but it was part

Re: Python bindings using cppyy (was: An update on Python bindings)

2017-11-05 Thread Chris Burel
> On Nov 4, 2017, at 4:46 AM, Philipp A. wrote: > > Entirely new bindings lead to new applications being written using those > bindings. Writing applications in Python 2 is an immediate maintenance burden > and people only do it because of stubborn ideology or a complete

D7660: Fix a regression caused by changing backspace key behavior

2017-11-05 Thread Safa Alfulaij
safaalfulaij updated this revision to Diff 21916. safaalfulaij added a comment. - Applying last comment (hopefully I did what you meant :!) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19781=21916 BRANCH master REVISION DETAIL

D8330: Open files in TagLib extractor readonly

2017-11-05 Thread Nathaniel Graham
ngraham added a comment. Is this ready to land, or do we need some more eyeballs on it first? REPOSITORY R286 KFileMetaData BRANCH readOnly REVISION DETAIL https://phabricator.kde.org/D8330 To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien Cc: mgallien, ngraham,

Re: Python bindings using cppyy (was: An update on Python bindings)

2017-11-05 Thread Boudewijn Rempt
On Sat, 4 Nov 2017, Chris Burel wrote: > I think this is a remarkably short sighted statement. It assumes that people > that would use these bindings have no existing Python codebase at all, and > can afford to start a brand new project. The reality is much different. > > Let's take a specific

D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found

2017-11-05 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. +1. Tested with a few repo without noticing any regression. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D8660 To:

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

2017-11-05 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In https://phabricator.kde.org/D7823#164474, @cgiboudeaux wrote: > Don't forget to create .rst files in doc/find-module and change 'Since 5.39.0' to 'Since 5.40.0' '5.41.0', sorry REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

2017-11-05 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. No news from the ECM maintainer, please push. Don't forget to create .rst files in doc/find-module and change 'Since 5.39.0' to 'Since 5.40.0' REPOSITORY R240 Extra CMake

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 61 - Fixed!

2017-11-05 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/61/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Sun, 05 Nov 2017 10:02:28 + Build duration: 8 min 2 sec and counting JUnit Tests

D8662: Validate that for all attributes an itemData exists

2017-11-05 Thread Dominik Haumann
dhaumann updated this revision to Diff 21900. dhaumann added a comment. - Fix typo REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8662?vs=21899=21900 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8662 AFFECTED FILES

D8662: Validate that for all attributes an itemData exists

2017-11-05 Thread Dominik Haumann
dhaumann added a comment. This patch is not yet ready, since we still have the following errors: 1. data/syntax/haml.xml" Reference of non-existing itemData attributes: QSet("Array", "Ruby embedded in haml", "Escaped Text") 2. data/syntax/lilypond.xml" Reference of non-existing

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 57 - Still Unstable!

2017-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/57/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 05 Nov 2017 10:02:28 + Build duration: 2 min 41 sec and counting JUnit

D8662: Validate that for all attributes an itemData exists

2017-11-05 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds a check at compile time that verifies that for all refereced attributes an

D8084: KAutoSaveFile breaks if source file name contains a space!

2017-11-05 Thread Jean-Baptiste Mardelle
This revision was automatically updated to reflect the committed changes. Closed by commit R244:8ed107304694: Fix KAutoSave bug on file with white space in it (authored by mardelle). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8084?vs=21868=21898

D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found

2017-11-05 Thread David Faure
dfaure created this revision. dfaure added reviewers: cgiboudeaux, kfunk. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY This of course requires running the unittests via ctest rather than launching the executable directly. TEST PLAN `ctest -V -R

D7612: KDECMakeSettings: more docu about the layout of the build dir

2017-11-05 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R240:d5ac6b2455d0: KDECMakeSettings: more docu about the layout of the build dir (authored by dfaure). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D7612: KDECMakeSettings: more docu about the layout of the build dir

2017-11-05 Thread David Faure
dfaure added a comment. No feedback, but this is just docu, I'll push it. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7612 To: dfaure, kossebau Cc: #build_system, #frameworks

KDE CI: Frameworks kxmlgui kf5-qt5 XenialQt5.7 - Build # 49 - Fixed!

2017-11-05 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20XenialQt5.7/49/ Project: Frameworks kxmlgui kf5-qt5 XenialQt5.7 Date of build: Sun, 05 Nov 2017 08:41:48 + Build duration: 2 min 25 sec and counting JUnit Tests

KDE CI: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 - Build # 55 - Fixed!

2017-11-05 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/55/ Project: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 Date of build: Sun, 05 Nov 2017 08:41:08 + Build duration: 3 min 8 sec and counting JUnit

D8084: KAutoSaveFile breaks if source file name contains a space!

2017-11-05 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8084 To: mardelle, #frameworks, shaforostoff, dfaure Cc: dfaure, ngraham, cfeck, ltoscano

KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 27 - Still Unstable!

2017-11-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/27/ Project: Frameworks kemoticons kf5-qt5 XenialQt5.7 Date of build: Sun, 05 Nov 2017 09:02:28 + Build duration: 5 min 44 sec and counting JUnit Tests

D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found

2017-11-05 Thread David Faure
dfaure updated this revision to Diff 21894. dfaure added a comment. now with the right patch... REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8660?vs=21893=21894 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8660 AFFECTED