This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c02178fa380c: restore old behaviour of FindPulseAudio
(authored by jhirte, committed by cgiboudeaux).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
drosca added a comment.
Just for the record, how does Konsole inherit this fd when BluezQt is only
used in plasmashell + kded and KDE apps are afaik not forked from these
processes?
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To: ofreyermuth,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/14/
Project:
Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 13 Nov 2017 09:53:46 +
Build duration:
20 hr and counting
anthonyfieroni created this revision.
anthonyfieroni added reviewers: leinir, dfaure.
anthonyfieroni added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
1. Notify engine to not observe image
bshah added a comment.
Do you have commit access?
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To: ofreyermuth, davidedmundson
Cc: bshah, broulik, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:cb168d3a0bd5: Add missing icon sizes (authored by
ngraham).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7810?vs=22206=22307
REVISION DETAIL
ngraham commandeered this revision.
ngraham edited reviewers, added: mandian; removed: ngraham.
ngraham added a comment.
Yoink.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: ngraham, #breeze, #vdg, jensreuterberg, #frameworks, hein, mandian
Cc:
kkofler created this revision.
kkofler added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
src/core/slave.cpp (Slave::createSlave): Do not look for the kioslave
binary in QCoreApplication::applicationDirPath(). In distribution
packages, this
apol edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8809
To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
davidedmundson added a comment.
you can close https://bugs.kde.org/show_bug.cgi?id=382233
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8809
To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ofreyermuth added a comment.
In https://phabricator.kde.org/D8806#167404, @broulik wrote:
> If you add the following (upper-case with a colon and space) on its own
line in your commit message [...]
Many thanks, done!
REPOSITORY
R269 BluezQt
REVISION DETAIL
ofreyermuth edited the summary of this revision.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To: ofreyermuth, davidedmundson
Cc: broulik, #frameworks
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We were reporting that the margins were changing whenever anything changed
in a FrameSvg,
turbov added inline comments.
INLINE COMMENTS
> cgiboudeaux wrote in FindPythonModuleGeneration.cmake:212
> NAMES clang clang-3.8 clang-3.9
>
> and remove the lines 234-239
What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0???
I've just checked Ubuntu 14.04 (Clang 3.3 to
jhirte updated this revision to Diff 22300.
jhirte added a comment.
v3 should address all comments
as I don't have commit rights, could one of KDE devs commit it?
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8777?vs=22242=22300
REVISION
broulik added a comment.
If you add the following (upper-case with a colon and space) on its own line
in your commit message the bug will be automatically closed once it landed:
BUG: 386886
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To:
ofreyermuth added a comment.
Thanks for the quick review!
I also created a related issue report here:
https://bugs.kde.org/show_bug.cgi?id=386886
which can of course be closed once the patch has landed.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To:
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To: ofreyermuth, davidedmundson
Cc: #frameworks
ofreyermuth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
They may be leaked into all child processes,
including regular Konsole terminals on KDE.
I observed them showing up at all
mandian added a comment.
This is a patch I wrote when I was packaging MATE desktop. What I only care
is it works well :).
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein
Cc: andreask,
mandian added a comment.
In https://phabricator.kde.org/D7810#167373, @ngraham wrote:
> You would renounce your copyright in this case.
If it is only a matter of copyright yes, of course :).
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To:
ngraham added a comment.
I'm afraid all commits require a full name and a real, public email address.
Take a look at the git logs and you'll see. They all have real names and email
addresses.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian,
mandian added a comment.
@ngraham the mail is the one you know but please do not expose it in a public
page (I'd like to avoid spam bots). The name I use is the same you know too (I
use this to sign the packages I build for OpenMandirva).
@jensreuterberg sure! I'll ask for help on this
ngraham added a comment.
Thanks for the patch! For UI changes, a before-and-after screenshot pair is
always nice. Also, have you tested that the default username-and-password combo
still works?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8791
To:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/62/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 13 Nov 2017 19:22:11 +
Build duration:
2 min 12 sec and counting
JUnit
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:6758d45cb596: Add a new function to measure the length by
text. (authored by xuetianweng).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8800?vs=22287=22288
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
I'm very happy to see this. I opened a thread about this on k-c-d (I think)
last year, but I didn't follow through with actual code. We have various search
fields in KDE that do something like
xuetianweng added a reviewer: Frameworks.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8800
To: xuetianweng, hein, apol, #frameworks
Cc: #frameworks
xuetianweng created this revision.
xuetianweng added reviewers: hein, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
CJK language contains more information per character. When people try to
write code to cap
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The trigrams.map will have to be installed from a different
installation.
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:9e2ed7fb8950: Add FindSasl2.cmake to ECM (authored by
cgiboudeaux).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8790?vs=22267=22276
REVISION DETAIL
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8790
To: cgiboudeaux, #kde_pim, vkrause
Cc: #frameworks, #build_system, dvasin, winterz, vkrause, mlaurent,
This revision was automatically updated to reflect the committed changes.
Closed by commit R283:af4f0052f1ef: Allow to only build the kauth-policy-gen
code generator (authored by vkrause).
REPOSITORY
R283 KAuth
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7274?vs=5=22275
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/148/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 13 Nov 2017 15:15:00 +
Build duration:
5 min 14 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/142/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 13 Nov 2017 15:15:00 +
Build duration:
1 min 28 sec and counting
JUnit Tests
cgiboudeaux added a project: KDE PIM.
cgiboudeaux added a reviewer: KDE PIM.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8790
To: cgiboudeaux, #kde_pim
Cc: #frameworks, #build_system, dvasin, winterz, vkrause, mlaurent, knauss,
dvratil
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/137/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Mon, 13 Nov 2017 14:31:30 +
Build duration:
10 min and counting
JUnit
cryptodude created this revision.
cryptodude added reviewers: dfaure, cfeck.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
In case the user starts the KPasswordDialog without the
KPasswordDialog::ShowUsernameLine,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/147/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 13 Nov 2017 14:31:20 +
Build duration:
5 min 16 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/141/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 13 Nov 2017 14:31:30 +
Build duration:
4 min 11 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/141/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 13 Nov 2017 14:31:20 +
Build duration:
41 sec and counting
JUnit Tests
cgiboudeaux created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
We have copies of this module in several PIM repositories (kdepim-runtime,
kldap, kimap, libksieve...).
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/65/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Mon, 13 Nov 2017 13:27:22 +
Build duration:
7 min 57 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/61/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 13 Nov 2017 13:26:34 +
Build duration:
1 min 56 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/64/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Mon, 13 Nov 2017 13:22:07 +
Build duration:
5 min 12 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/60/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 13 Nov 2017 13:20:29 +
Build duration:
2 min 31 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/63/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Mon, 13 Nov 2017 13:13:54 +
Build duration:
8 min 12 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/59/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 13 Nov 2017 13:13:54 +
Build duration:
2 min 21 sec and counting
JUnit
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.
Not an extension I have ever encountered, but it's conflict-free with
everything else we have, so that should be fine.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
davidedmundson abandoned this revision.
REPOSITORY
R283 KAuth
REVISION DETAIL
https://phabricator.kde.org/D7732
To: davidedmundson
Cc: aacid, ltoscano, #frameworks
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38):
${JELLY_SCRIPT,template="html_gmail"}
^
java.io.IOException: remote file operation failed:
cgiboudeaux added inline comments.
INLINE COMMENTS
> FindPythonModuleGeneration.cmake:212
> +libclang_LIBRARY
> +clang
> +PATH ${LLVM_LIBDIR}
NAMES clang clang-3.8 clang-3.9
and remove the lines 234-239
> FindPythonModuleGeneration.cmake:213
> +
52 matches
Mail list logo
