dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
sitter created this revision.
sitter added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
keditbookmarks lives in applications, making it very likely that it is
not installed. this does already raise an error window explaining that
the binary is
sitter created this revision.
sitter added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
authorizeKAction is internally calling authorizeAction, so simply switch
the function calls to the new name
fixes excessive deprecation warnings getting
ngraham accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure
Cc: dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
ngraham added a comment.
@dfaure?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
apol added a comment.
In https://phabricator.kde.org/D8173#167835, @aacid wrote:
> In https://phabricator.kde.org/D8173#167776, @apol wrote:
>
> > I either need more information
>
>
> I'm happy to provide any information you want, i just don't know what you
need other than
aacid added a comment.
In https://phabricator.kde.org/D8173#167776, @apol wrote:
> I either need more information
I'm happy to provide any information you want, i just don't know what you
need other than KConfigCore.so is in the apk without your patch and not with
your patch.
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/143/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 14 Nov 2017 20:50:48 +
Build duration:
2 min 26 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/149/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Tue, 14 Nov 2017 20:50:48 +
Build duration:
1 min 14 sec and counting
JUnit Tests
anthonyfieroni updated this revision to Diff 22371.
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8811?vs=22308=22371
REVISION DETAIL
https://phabricator.kde.org/D8811
AFFECTED FILES
src/core/engine.cpp
src/core/imageloader.cpp
mandian added a comment.
Great!
Thank you all!
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: ngraham, #breeze, #vdg, jensreuterberg, #frameworks, hein, mandian
Cc: andreask, hein, ngraham, cfeck, #frameworks
apol updated this revision to Diff 22368.
apol added a comment.
Remove debug variable
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8820?vs=22359=22368
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8820
AFFECTED FILES
apol added a comment.
I've done a build of with and without and I don't see such differences:
$ zipinfo ktuberling-patch.apk > patch
$ less patch
$ zipinfo ktuberling-nopatch.apk > nopatch
$ diff patch nopatch
1,2c1,2
< Archive: ktuberling-patch.apk
< Zip file
broulik added inline comments.
INLINE COMMENTS
> platformtheme.cpp:159
> +if (!d->m_init) {
> +static int i = 0;
> +emit colorSetChanged(colorSet);
Unused
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8820
To: apol, #frameworks
Cc: broulik,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/58/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Tue, 14 Nov 2017 16:44:57 +
Build duration:
6 min 25 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/57/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 14 Nov 2017 16:44:57 +
Build duration:
6 min 28 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:42b2daaec407: [server] Support inhibiting the
IdleInterface (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8383?vs=21016=22363#toc
REPOSITORY
R127 KWayland
CHANGES
graesslin added a comment.
ping
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8396
To: graesslin, #frameworks, #kwin, #plasma_on_wayland
Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Since we are using the timer, it will make the UI react to it at some point
despite it not really
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/138/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Tue, 14 Nov 2017 13:04:56 +
Build duration:
12 min and counting
JUnit
kkofler added a comment.
And the historical reason the name was not suffixed is because the binary was
moved to a private libexec subdirectory to prevent conflicts. This worked fine
as long as `/usr/bin` did not end up in the search path (in particular, for the
whole 4.x series).
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/142/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 14 Nov 2017 13:04:56 +
Build duration:
12 min and counting
dhaumann accepted this revision.
dhaumann added a comment.
Can you commit yourself?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D8782
To: genethomas, vkrause, dhaumann
Cc: dhaumann, vkrause, #frameworks
kkofler added a comment.
In https://phabricator.kde.org/D8810#167568, @cullmann wrote:
> Yeah, that was done to be able to provide win/linux install bundles.
A GNU/Linux install bundle should have a reparented FHS-like tree, possibly
wrapped in an image file
cullmann added a comment.
I can live with that ;=)
But still I think kioslave5 as name would make this not needed and be more in
line with kded5/...
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8810
To: kkofler, #frameworks, kfunk, cullmann
Cc: broulik, kfunk
kkofler updated this revision to Diff 22338.
kkofler retitled this revision from "Do not look for kioslave binary in
applicationDirPath (#386859)" to "Do not look for kioslave binary in
applicationDirPath on *nix (#386859)".
kkofler edited the summary of this revision.
kkofler added a comment.
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:eab03787350a: Add signals indicating if a screen was
added or removed (authored by amantia).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
colomar added a comment.
In https://phabricator.kde.org/D8773#167607, @broulik wrote:
> What I would like to see is that when you open the "Edit Toolbar" dialog
that you then can drag around tool bar buttons and drag them from and to the
dialog, like Firefox does it and how @colomar
apol added a comment.
> If we're doing some caching in there now anyway, can we perhaps add
individual signals for the margins or is it not worth it?
No, we don't have any caching. Also they never seem to change, on my system
it goes from 0 (default) to 6 for all of them (whatever is in
anthonyfieroni added inline comments.
INLINE COMMENTS
> broulik wrote in engine.cpp:536
> You're copying `entry` into the lambda just for a debug.
If / when someone want to read debug messages, they will be consistent.
> broulik wrote in imageloader_p.h:59
> Why have this argument if you're
broulik added a comment.
What I would like to see is that when you open the "Edit Toolbar" dialog that
you then can drag around tool bar buttons and drag them from and to the dialog,
like Firefox does it and how @colomar suggested. Given you can already
re-arrange toolbar buttons whilst
broulik added a comment.
Good idea with the RAII class.
If we're doing some caching in there now anyway, can we perhaps add
individual signals for the margins or is it not worth it?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8809
To:
broulik added inline comments.
INLINE COMMENTS
> engine.cpp:536
> +connect(l, ::signalError, this, [=]() {
> +qCDebug(KNEWSTUFFCORE) << "ERROR preview: " << entry.name() << type;
> +--m_numPictureJobs;
You're copying `entry` into the lambda just for a debug.
>
turbov added a comment.
@cgiboudeaux,
Yep, this review is the first in series about to clean up the code of
`FindPythongModuleGeneration` and make it generic (not only for Ubuntu) and
flexible.
It is why I want to clean up it from "hard-coded" values like `3.8`/`3.9` and
"brute
renatoo updated this revision to Diff 22330.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21934=22330
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
renatoo updated this revision to Diff 22329.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=21933=22329
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
renatoo updated this revision to Diff 22328.
renatoo marked 2 inline comments as done.
renatoo added a comment.
Fallback to initial url if the searchUrl is invalid.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=21932=22328
REVISION DETAIL
cullmann added a comment.
> Doesn't the QStandardPaths call below find it?
No, as that will use searchPaths.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8810
To: kkofler, #frameworks, kfunk, cullmann
Cc: broulik, kfunk
cullmann added a comment.
Yeah, that was done to be able to provide win/linux install bundles.
Actually would it make not more sense to suffix the kioslave with "5" or
something like that like we did for the libs to avoids clashs?
REPOSITORY
R241 KIO
REVISION DETAIL
broulik added a comment.
Doesn't the `QStandardPaths` call below find it?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8810
To: kkofler, #frameworks, kfunk, cullmann
Cc: broulik, kfunk
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.
Just chiming in here, without having a final solution for your problem: This
search path has been added for a reason -- to find a kioslave.exe next to the
application binary in
kfunk added a reviewer: cullmann.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8810
To: kkofler, #frameworks, kfunk, cullmann
Cc: kfunk
shaheed added inline comments.
INLINE COMMENTS
> shaheed wrote in FindPythonModuleGeneration.cmake:212
> The original code had a minimum requirement of either 3.8 or 3.9 (I don't
> recall exactly, but the code here implies 3.8 is the minimum). Newer versions
> are fine.
I remembered as soon
shaheed added inline comments.
INLINE COMMENTS
> turbov wrote in FindPythonModuleGeneration.cmake:212
> What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0???
>
> I've just checked Ubuntu 14.04 (Clang 3.3 to 3.9 available) and 17.10 (up to
> 5.0 available)... installing
drosca added a comment.
Though on the other hand, why isn't KLauncher (KRun) used for running apps
everywhere? This way they are forked from `kdeinit5` and this issue is
non-existant.
Quick test:
- Launch from taskmanager -> forked from plasmashell
- Launch from quicklaunch
bshah added a comment.
In https://phabricator.kde.org/D8806#167510, @drosca wrote:
> Why? It's not like any other process can't open /dev/rfkill as we ship udev
rule to enable r+w access to /dev/rfkill for all users.
My comment was question :-)
But well I didn't know about
cgiboudeaux added inline comments.
INLINE COMMENTS
> turbov wrote in FindPythonModuleGeneration.cmake:213
> Why `HINTS` is "better"?? As for me this is not a "hint" -- at this point we
> know exactly the correct libdir location... it is why I use `PATH`...
drosca added a comment.
In https://phabricator.kde.org/D8806#167509, @bshah wrote:
> I do wonder if this is security fix? And should probably be handled like
that?
Why? It's not like any other process can't open /dev/rfkill as we ship udev
rule to enable r+w access to
bshah added a comment.
I do wonder if this is security fix? And should probably be handled like that?
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To: ofreyermuth, davidedmundson
Cc: drosca, bshah, broulik, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R269:ae044d6dfec9: Do not leak rfkill file descriptors.
(authored by ofreyermuth, committed by drosca).
REPOSITORY
R269 BluezQt
CHANGES SINCE LAST UPDATE
ofreyermuth added a comment.
In https://phabricator.kde.org/D8806#167503, @drosca wrote:
> I need your full name and e-mail to commit it (I can't get it with `arch
patch` probably because you didn't upload this review with `arc diff`).
Oliver Freyermuth
drosca added a comment.
Alright, thanks for the explanation.
I need your full name and e-mail to commit it (I can't get it with `arch
patch` probably because you didn't upload this review with `arc diff`).
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
cgiboudeaux added inline comments.
INLINE COMMENTS
> turbov wrote in FindPythonModuleGeneration.cmake:212
> What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0???
>
> I've just checked Ubuntu 14.04 (Clang 3.3 to 3.9 available) and 17.10 (up to
> 5.0 available)... installing
ofreyermuth added a comment.
In https://phabricator.kde.org/D8806#167483, @drosca wrote:
> Just for the record, how does Konsole inherit this fd when BluezQt is only
used in plasmashell + kded and KDE apps are afaik not forked from these
processes?
What exactly happens depends
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8640
To: broulik, #frameworks, dfaure, hein, mwolff
ofreyermuth added a comment.
In https://phabricator.kde.org/D8806#167457, @bshah wrote:
> Do you have commit access?
In case you are adressing me: No.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To: ofreyermuth, davidedmundson
Cc: drosca,
56 matches
Mail list logo
