KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Dec 2017 07:18:03 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 26 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/26/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Wed, 06 Dec 2017 07:18:03 + Build duration: 4 min 19 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 168 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/168/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 06 Dec 2017 07:18:03 +
Build duration:
1 min 21 sec and counting
CONSOLE OUTPUT
[...truncated 104.15 KB...]-- Found XCB_SHAPE: /usr/local/lib/libxcb-shape.so (found version "1.12") -- Found XCB_XFIXES: /usr/local/lib/libxcb-xfixes.so (found version "1.12") -- Found XCB_COMPOSITE: /usr/local/lib/libxcb-composite.so (found version "1.12") -- Found XCB_DAMAGE: /usr/local/lib/libxcb-damage.so (found version "1.12") -- Found XCB: /usr/local/lib/libxcb.so;/usr/local/lib/libxcb-render.so;/usr/local/lib/libxcb-shape.so;/usr/local/lib/libxcb-xfixes.so;/usr/local/lib/libxcb-composite.so;/usr/local/lib/libxcb-damage.so (found version "1.12") found components: XCB COMPOSITE DAMAGE SHAPE XFIXES RENDER CMake Warning (dev) at /usr/local/lib/cmake/Qt5/Qt5ModuleLocation.cmake:4 (set): Policy CMP0053 is not set: Simplify variable reference and escape sequence evaluation. Run "cmake --help-policy CMP0053" for policy details. Use the cmake_policy command to set the policy and suppress this warning. For input:'${_qt5_install_prefix}/Qt5@module@/Qt5@module@Config.cmake' the old evaluation rules produce:'/usr/local/lib/cmake/Qt5/Qt5Config.cmake' but the new evaluation rules produce:'/usr/local/lib/cmake/Qt5@module@/Qt5@module@Config.cmake' Using the old result for compatibility since the policy is not set.Call Stack (most recent call first): /usr/local/lib/cmake/Qt5/Qt5Config.cmake:25 (include) CMakeLists.txt:103 (find_package)This warning is for project developers. Use -Wno-dev to suppress it.-- Found OpenGL: /usr/local/lib/libGL.so -- Found EGL: /usr/local/lib/libEGL.so (found version "1.5") -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * KF5Wayland (required version >= 5.41.0), Integration with the Wayland compositor * KF5DocTools (required version >= 5.41.0), Tools to generate documentation * X11, X11 libraries, * XCB, X protocol C-language Binding, * OpenGL, The OpenGL libraries, * PkgConfig * EGL, A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG.,Support for Window Thumbnail on EGL platform-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.9.1) * Qt5Quick * Qt5Gui * Qt5Sql * Qt5Qml * Qt5Svg * KF5Activities (required version >= 5.41.0) * KF5Archive (required version >= 5.41.0) * KF5Config (required version >= 5.41.0) * KF5ConfigWidgets (required version >= 5.41.0) * KF5DBusAddons (required version >= 5.41.0) * KF5Declarative (required version >= 5.41.0) * KF5GlobalAccel (required version >= 5.41.0) * KF5GuiAddons (required version >= 5.41.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.41.0) * KF5IconThemes (required version >= 5.41.0) * KF5KIO (required version >= 5.41.0) * KF5Service (required version >= 5.41.0) * KF5WindowSystem (required version >= 5.41.0) * KF5Notifications (required version >= 5.41.0) * KF5Package (required version >= 5.41.0) * KF5 (required version >= 5.41.0) * Qt5X11Extras * Qt5 * ECM (required version >= 1.6.0), Extra CMake Modules., * Qt5Test (required version >= 5.7.0) Required for tests * KF5CoreAddons * KF5XmlGui * Qt5Widgets-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring incomplete, errors occurred!See also "/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/build/CMakeFiles/CMakeOutput.log".See also "/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 114 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/114/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 06 Dec 2017 07:03:48 +
Build duration:
2 min 53 sec and counting
CONSOLE OUTPUT
[...truncated 127.04 KB...] get_target_property() called with non-existent target "Qt5::uic".Call Stack (most recent call first): src/CMakeLists.txt:226 (ki18n_wrap_ui)CMake Error at /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18NMacros.cmake:43 (get_target_property): get_target_property() called with non-existent target "Qt5::uic".Call Stack (most recent call first): src/CMakeLists.txt:226 (ki18n_wrap_ui)CMake Error at /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18NMacros.cmake:43 (get_target_property): get_target_property() called with non-existent target "Qt5::uic".Call Stack (most recent call first): src/CMakeLists.txt:249 (ki18n_wrap_ui)-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - SuccessCMake Warning (dev) at /usr/local/lib/cmake/Qt5/Qt5ModuleLocation.cmake:4 (set): Policy CMP0053 is not set: Simplify variable reference and escape sequence evaluation. Run "cmake --help-policy CMP0053" for policy details. Use the cmake_policy command to set the policy and suppress this warning. For input:'${_qt5_install_prefix}/Qt5@module@/Qt5@module@Config.cmake' the old evaluation rules produce:'/usr/local/lib/cmake/Qt5/Qt5Config.cmake' but the new evaluation rules produce:'/usr/local/lib/cmake/Qt5@module@/Qt5@module@Config.cmake' Using the old result for compatibility since the policy is not set.Call Stack (most recent call first): /usr/local/lib/cmake/Qt5/Qt5Config.cmake:25 (include) autotests/CMakeLists.txt:1 (find_package)This warning is for project developers. Use -Wno-dev to suppress it.-- Looking for fdatasync-- Looking for fdatasync - not found-- The following OPTIONAL packages have been found: * PkgConfig-- The following REQUIRED packages have been found: * ECM (required version >= 5.41.0), Extra CMake Modules., * Qt5Widgets * Qt5Network (required version >= 5.9.1) * Qt5Qml * Qt5PrintSupport * Qt5Xml * Qt5XmlPatterns * KF5Archive (required version >= 5.41.0) * KF5Config (required version >= 5.41.0) * KF5GuiAddons (required version >= 5.41.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.41.0) * KF5KIO (required version >= 5.41.0) * KF5Parts (required version >= 5.41.0) * KF5Sonnet (required version >= 5.41.0) * KF5IconThemes (required version >= 5.41.0) * Qt5Core * Qt5Gui * KF5SyntaxHighlighting (required version >= 5.41.0) * Qt5Test * Qt5 (required version >= 5.7.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * LibGit2 (required version >= 0.22.0), A plain C library to interface with the git version control system., * EditorConfig-- Configuring incomplete, errors occurred!See also "/usr/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7/build/CMakeFiles/CMakeOutput.log".See also "/usr/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Dec 2017 06:40:33 + Build duration: 20 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 20 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/20/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 06 Dec 2017 06:40:33 + Build duration: 8 min 10 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 - Build # 62 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/62/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 06 Dec 2017 06:44:53 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT [...truncated 37.98 KB...]JENKINS_HOME = '/home/production/data'EXECUTOR_NUMBER = '0'BUILD_DISPLAY_NAME= '#62'MM_CHARSET= 'UTF-8'PWD = '/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7'BLOCKSIZE = 'K'JENKINS_SERVER_COOKIE = 'durable-e3d60f6c9a22b605fbdf619a3e76bd9a'JOB_DISPLAY_URL = 'https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/display/redirect'PKG_CONFIG_PATH = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'NODE_NAME = 'FreeBSD Builder 3'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'HOME = '/usr/home/jenkins'_ = '/usr/local/bin/java'JENKINS_NODE_COOKIE = 'e0ee03bb-9526-4276-8703-83bfdafbdc68'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'HUDSON_COOKIE = 'fafef25c-729b-4004-a91c-c8d0722d6c95'RUN_DISPLAY_URL = 'https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/62/display/redirect'JAVA_HOME = '/usr/local/openjdk8-jre'SSH_CONNECTION= '144.76.220.218 47414 95.85.23.247 22'HUDSON_URL= 'https://build.kde.org/'USER = 'jenkins'RUN_CHANGES_DISPLAY_URL = 'https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/62/display/redirect?page=changes'HUDSON_SERVER_COOKIE = '4acee20278191cab'SHLVL = '1'LOGNAME = 'jenkins'MAIL = '/var/mail/jenkins'BUILD_NUMBER = '62'WORKSPACE = '/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7'JOB_URL = 'https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/'BUILD_TAG = 'jenkins-Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7-62'BUILD_ID = '62'SHELL = '/usr/local/bin/bash'BUILD_URL = 'https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/62/'XDG_CONFIG_DIRS = '/usr/local/etc/xdg'PATH = '/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins/bin'LANG = 'en_US.UTF-8'QT_SELECT = 'qt5'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/" "/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7"-- The C compiler identification is Clang 3.8.0-- The CXX compiler identification is Clang 3.8.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Could not set up the appstream test. appstreamcli is missing.CMake Error at /usr/local/lib/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:172 (include): include could not find load file:/usr/local/lib/cmake/Qt5Widgets/Qt5WidgetsConfigExtras.cmakeCall Stack (most recent call first): /usr/local/lib/cmake/Qt5/Qt5Config.cmake:28 (find_package) CMakeLists.txt:18 (find_package)CMake Error at /usr/local/lib/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:174 (include): include could not find load file:/usr/local/lib/cmake/Qt5Widgets/Qt5WidgetsMacros.cmakeCall Stack (most recent call first): /usr/local/lib/cmake/Qt5/Qt5Config.cmake:28 (find_package) CMakeLists.txt:18 (find_package)CMake Error at src/CMakeLists.txt:91 (qt5_wrap_ui): Unknown CMake command "qt5_wrap_ui".-- Configuring incomplete, errors occurred!See also "/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/build/CMakeFiles/CMakeOutput.log".See also "/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks kwidgetsaddons
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 160 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/160/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 06 Dec 2017 06:40:33 + Build duration: 2 min 5 sec and counting CONSOLE OUTPUT [...truncated 163.32 KB...]-- Looking for connect in socket - not foundCMake Deprecation Warning at autotests/CMakeLists.txt:2 (cmake_policy): The OLD behavior for policy CMP0028 will be removed from a future version of CMake. The cmake-policies(7) manual explains that the OLD behaviors of all policies are deprecated and that a policy should be set to OLD only under specific short-term circumstances. Projects should be ported to the NEW behavior and not rely on setting a policy to OLD.-- Found ZLIB: /usr/lib/libz.so (found version "1.2.8") CMake Deprecation Warning at tests/CMakeLists.txt:2 (cmake_policy): The OLD behavior for policy CMP0028 will be removed from a future version of CMake. The cmake-policies(7) manual explains that the OLD behaviors of all policies are deprecated and that a policy should be set to OLD only under specific short-term circumstances. Projects should be ported to the NEW behavior and not rely on setting a policy to OLD.-- The following OPTIONAL packages have been found: * KF5DocTools (required version >= 5.41.0), Provides tools to generate documentation in various format from DocBook files Required to build help ioslave and documentation * GSSAPI, Allows KIO to make use of certain HTTP authentication services,A MIT or HEIMDAL flavor of GSSAPI can be used * X11 * KF5Wallet (required version >= 5.41.0), Safe desktop-wide storage for passwords Required to have permanent storage of passwords for kpasswdserver * KF5Notifications (required version >= 5.41.0), Notifications library Required to have error notification support in kpac * Qt5Script (required version >= 5.7.0), QtScript, one of the Qt5 modules Required to build support for auto-configuration of network proxies-- The following REQUIRED packages have been found: * ECM (required version >= 5.41.0), Extra CMake Modules., * KF5Config (required version >= 5.41.0) * KF5CoreAddons (required version >= 5.41.0) * KF5DBusAddons (required version >= 5.41.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.41.0) * KF5Service (required version >= 5.41.0) * KF5Solid (required version >= 5.41.0) * Qt5Gui (required version >= 5.9.1) * KF5Completion (required version >= 5.41.0) * KF5ConfigWidgets (required version >= 5.41.0) * KF5IconThemes (required version >= 5.41.0) * KF5ItemViews (required version >= 5.41.0) * KF5JobWidgets (required version >= 5.41.0) * KF5WidgetsAddons (required version >= 5.41.0) * KF5WindowSystem (required version >= 5.41.0) * Qt5DBus * Qt5Network * Qt5Xml * Qt5X11Extras * Qt5 (required version >= 5.7.0) * LibXslt,Required by the KDE help system to process DocBook XML * LibXml2,Required by the KDE help system to process DocBook XML * Qt5Core (required version >= 5.7.0) * KF5Bookmarks (required version >= 5.41.0) * KF5TextWidgets (required version >= 5.41.0) * KF5Archive (required version >= 5.41.0) * ZLIB, Support for gzip compressed files and data streams,Required for httpfiltertest * Qt5Test * Qt5Widgets * Qt5Concurrent (required version >= 5.7.0) * KF5XmlGui (required version >= 5.41.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RECOMMENDED packages have not been found: * ACL, LibACL,Support for manipulating access control lists Support for manipulating access control lists Support for manipulating access control lists-- Configuring incomplete, errors occurred!See also "/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/build/CMakeFiles/CMakeOutput.log".See also "/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks kio kf5-qt5 FreeBSDQt5.7] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext
D9217: KUriFilter: don't return an error on non-existing files.
broulik added a comment. https://bugs.kde.org/show_bug.cgi?id=372813 REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio Cc: broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dfaure added a comment. That's exactly what this fixes (not only ~/foo but also /foo/bar). Out of curiosity, in which context (app) were you seeing that issue? REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio Cc: broulik, #frameworks
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 25 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/25/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 05 Dec 2017 22:37:02 + Build duration: 9 min 2 sec and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Dec 2017 22:37:02 + Build duration: 8 min 43 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 167 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/167/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 05 Dec 2017 22:37:02 + Build duration: 5 min 4 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretest
D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3ad4798ca683: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4362?vs=23315=23541 REVISION DETAIL https://phabricator.kde.org/D4362 AFFECTED FILES src/plasmaquick/appletquickitem.cpp To: broulik, #plasma, davidedmundson Cc: mart, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4362 To: broulik, #plasma, davidedmundson Cc: mart, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D9217: KUriFilter: don't return an error on non-existing files.
broulik added a comment. Will this fix typing `~/foo` when foo does not exist return an invalid URL? REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio Cc: broulik, #frameworks
Re: kcrash, fork, and stdout/stderr
On mardi 5 décembre 2017 16:46:50 CET Thiago Macieira wrote: > On Tuesday, 5 December 2017 04:12:30 PST David Faure wrote: > > I see. But how should one implement a crash handler that autorestarts an > > app, then, in a "standalone application" use case, i.e. no kdeinit or > > other > > daemon running in the background? > > Wait, why are you forking in the first place? > > Just exec the process again. It will replace the current process without > closing the pipes. The parent won't notice a thing. Interesting idea. It might work, except that what KCrash currently does is both restart the app and attach drkonqi to the crashed app (or dump core, if drkonqi is disabled), so that users/developers know a crash happened. Doing just execve() wouldn't allow that. I'm tempted to just not touch it further. > Of course, that may be a problem: the parent may see the output from the > child process again. It would probably not matter for GUI apps, and the unittest could be adjusted. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.7 - Build # 4 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/4/ Project: Frameworks kservice kf5-qt5 SUSEQt5.7 Date of build: Tue, 05 Dec 2017 22:00:47 + Build duration: 6 min 30 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/4/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Dec 2017 22:00:47 + Build duration: 4 min 38 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.7 - Build # 39 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.7/39/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 05 Dec 2017 22:00:47 + Build duration: 3 min 3 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)
D8689: Fix the result of KDesktopFile::sortOrder()
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I don't really mind/care if it's fixed or not, if it's deprecated and unused :-) Want to submit a patch to deprecate it? REPOSITORY R237 KConfig BRANCH fix-sort-order REVISION DETAIL https://phabricator.kde.org/D8689 To: volkov, #frameworks, dfaure Cc: dfaure, #frameworks
D9189: Do not crash when setting new line edit on an editable combo box
dfaure added a comment. @anthonyfieroni commit https://phabricator.kde.org/R446:0c4f04b074d9d214b86721ac7c881a6ea95b8c41 seems to have added that KLineEdit just to be able to show the clear button. This could just be ported to QLineEdit::setClearButtonEnabled these days. REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D9189 To: mwolff, dfaure, anthonyfieroni Cc: #frameworks
D9189: Do not crash when setting new line edit on an editable combo box
dfaure accepted this revision. REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D9189 To: mwolff, dfaure, anthonyfieroni Cc: #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dfaure created this revision. dfaure added reviewers: emateli, elvisangelaccio. REVISION SUMMARY This allows to use partially-typed paths for completion purposes. TEST PLAN Adjusted unittest passes. BRANCH master REVISION DETAIL https://phabricator.kde.org/D9217 AFFECTED FILES autotests/kurifiltertest.cpp src/urifilters/shorturi/kshorturifilter.cpp To: dfaure, emateli, elvisangelaccio Cc: #frameworks
D8920: Fixes url navigation with relative links on KUrlNavigator
dfaure added inline comments. INLINE COMMENTS > kurlnavigator.cpp:1009 > +// Always expand starting ~/ to $HOME. We want all inputs starting with > it to point home directory. > +// The reason this expansion is performed here, is that kshorturifilter > will not return the desired result > +// if said directory does not exist. This is written like kshorturifilter is buggy... I looked into it to see if there was a good reason why kshorturifilter returns Error in case of a non-existing local path, but in fact it doesn't really have to. If the user types a non-existing path in a URL bar then opening that path will error anyway, there's no need to catch that at the kurifilter level. I'm working on a fix for kshorturifilter. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks
D9175: Migrate some more QRegExps to QRegularExpression
dhaumann marked 4 inline comments as done. dhaumann added a comment. Mark some comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9175 To: dhaumann, cullmann, kfunk, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9175: Migrate some more QRegExps to QRegularExpression
dhaumann updated this revision to Diff 23538. dhaumann marked 3 inline comments as done. dhaumann added a comment. - Minor updates to the patch. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9175?vs=23437=23538 BRANCH QRegExpCleanup2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D9175 AFFECTED FILES src/search/kateplaintextsearch.cpp src/search/kateregexpsearch.h src/search/katesearchbar.cpp src/utils/codecompletionmodelcontrollerinterface.cpp src/utils/katebookmarks.cpp src/utils/katecommandrangeexpressionparser.cpp src/utils/katesedcmd.cpp src/variableeditor/variablelistview.cpp src/view/kateview.cpp To: dhaumann, cullmann, kfunk, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9175: Migrate some more QRegExps to QRegularExpression
dhaumann marked 5 inline comments as done. dhaumann added a comment. Update patch comes in a second. INLINE COMMENTS > mwolff wrote in katebookmarks.cpp:129 > static? I don't think this is critical. Maybe it's even better to not have it static, since otherwise it'll lurk around until application exit. > mwolff wrote in katecommandrangeexpressionparser.cpp:119 > future: splitRef Yes, later... > mwolff wrote in katesedcmd.cpp:164 > here and below: capturedRef? Can do, but some lines later, its converted to a QString anyways, so we don't gain anything :-) > mwolff wrote in kateview.cpp:3595 > what was that old code trying to do? did you understand it? Now that's a good point: I don't completely. It appends a leading and trailing space, and the searches with \b%1 once, and with %1\b again. But isn't that always true? This is about the highlight selection feature, and I couldn't spot any difference in behavior. Still maybe I missed something... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9175 To: dhaumann, cullmann, kfunk, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9213: KUriFilter: port away from KServiceTypeTrader
dfaure added reviewers: apol, davidedmundson. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9213 To: dfaure, apol, davidedmundson Cc: #frameworks
D9213: KUriFilter: port away from KServiceTypeTrader
dfaure updated this revision to Diff 23535. dfaure added a comment. Drop the use of KService; broke reading of "Keys" without the servicetype available REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9213?vs=23529=23535 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9213 AFFECTED FILES autotests/kurifiltertest.cpp src/urifilters/ikws/CMakeLists.txt src/urifilters/ikws/ikwsopts.cpp src/urifilters/ikws/ikwsopts.h src/urifilters/ikws/kuriikwsfilter.cpp src/urifilters/ikws/kuriikwsfiltereng.cpp src/urifilters/ikws/kuriikwsfiltereng.h src/urifilters/ikws/kurisearchfilter.cpp src/urifilters/ikws/searchprovider.cpp src/urifilters/ikws/searchprovider.h src/urifilters/ikws/searchproviderregistry.cpp src/urifilters/ikws/searchproviderregistry.h src/widgets/kurifilter.cpp To: dfaure Cc: #frameworks
D8920: Fixes url navigation with relative links on KUrlNavigator
emateli updated this revision to Diff 23532. emateli added a comment. - ~/ at the start always resolves to $HOME REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8920?vs=22702=23532 BRANCH relative-files-v2 REVISION DETAIL https://phabricator.kde.org/D8920 AFFECTED FILES autotests/kurlnavigatortest.cpp src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h src/widgets/kurifilter.cpp src/widgets/kurifilter.h To: emateli, #frameworks, dfaure Cc: #frameworks
D8782: add *.email to the extensions
This revision was automatically updated to reflect the committed changes. Closed by commit R216:273e2f26fb55: email.xml: add *.email to the extensions (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8782?vs=22251=23531 REVISION DETAIL https://phabricator.kde.org/D8782 AFFECTED FILES data/syntax/email.xml To: genethomas, vkrause, dhaumann Cc: dhaumann, vkrause, #frameworks
D9214: Remove unused keyword lists and contexts
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Mostly just removed, some commented out where it seemed more appropriate. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH RemoveUnusedKeywordLists (branched from master) REVISION DETAIL https://phabricator.kde.org/D9214 AFFECTED FILES data/syntax/ample.xml data/syntax/ansforth94.xml data/syntax/css.xml data/syntax/dosbat.xml data/syntax/euphoria.xml data/syntax/freebasic.xml data/syntax/fsharp.xml data/syntax/gcc.xml data/syntax/ilerpg.xml data/syntax/metafont.xml data/syntax/pango.xml data/syntax/powershell.xml data/syntax/ruby.xml data/syntax/scss.xml data/syntax/tcsh.xml data/syntax/vhdl.xml data/syntax/xmldebug.xml data/syntax/xonotic-console.xml To: dhaumann, vkrause Cc: #frameworks
D9186: Remove unused contexts and itemDatas
dhaumann closed this revision. dhaumann added a comment. Committed with https://cgit.kde.org/syntax-highlighting.git/commit/?id=bb939b4ace0213b822383e23cd15719ad9b4242d REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D9186 To: dhaumann, vkrause Cc: #frameworks
KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.7 - Build # 3 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.7/3/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.7 Date of build: Tue, 05 Dec 2017 18:36:42 + Build duration: 4 min 41 sec and counting JUnit Tests Name: (root) Failed: 10 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-picFailed: TestSuite.kimageformats-read-pcxFailed: TestSuite.kimageformats-read-psdFailed: TestSuite.kimageformats-read-rasFailed: TestSuite.kimageformats-read-rgbFailed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-pcxFailed: TestSuite.kimageformats-write-rgbFailed: TestSuite.kimageformats-write-tga
D9213: KUriFilter: port away from KServiceTypeTrader
dfaure created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Instead, locate the desktop files and read them, into a memory cache. This allows to run the KIO unittests without installing KIO. TEST PLAN kurifiltertest and kurifiltersearchprovideractionstest now pass with empty XDG_DATA_DIRS. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9213 AFFECTED FILES autotests/kurifiltertest.cpp src/urifilters/ikws/CMakeLists.txt src/urifilters/ikws/kuriikwsfilter.cpp src/urifilters/ikws/kuriikwsfiltereng.cpp src/urifilters/ikws/kuriikwsfiltereng.h src/urifilters/ikws/kurisearchfilter.cpp src/urifilters/ikws/searchprovider.cpp src/urifilters/ikws/searchprovider.h src/urifilters/ikws/searchproviderregistry.cpp src/urifilters/ikws/searchproviderregistry.h src/widgets/kurifilter.cpp To: dfaure Cc: #frameworks
KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/4/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Dec 2017 18:36:42 + Build duration: 1 min 9 sec and counting JUnit Tests Name: (root) Failed: 10 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-picFailed: TestSuite.kimageformats-read-pcxFailed: TestSuite.kimageformats-read-psdFailed: TestSuite.kimageformats-read-rasFailed: TestSuite.kimageformats-read-rgbFailed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-pcxFailed: TestSuite.kimageformats-write-rgbFailed: TestSuite.kimageformats-write-tga
D9182: return nullptr -> return {} for QFlags
This revision was automatically updated to reflect the committed changes. Closed by commit R287:7f2c44add4aa: Use brace-initializer instead of nullptr in returning 0-QFlags (authored by mkoller). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9182?vs=23458=23528 REVISION DETAIL https://phabricator.kde.org/D9182 AFFECTED FILES src/imageformats/eps.cpp src/imageformats/exr.cpp src/imageformats/kra.cpp src/imageformats/ora.cpp src/imageformats/pcx.cpp src/imageformats/pic.cpp src/imageformats/psd.cpp src/imageformats/ras.cpp src/imageformats/rgb.cpp src/imageformats/tga.cpp src/imageformats/xcf.cpp To: mkoller, kfunk, kossebau Cc: #frameworks
D9212: Pony: Remove unused keyword lists
dhaumann created this revision. dhaumann added reviewers: jpoelen, jpoelen2, vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Comment out currently unused keyword lists to avoid having dead code lying around. Or is there a better fix? TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH PonyCleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D9212 AFFECTED FILES data/syntax/pony.xml To: dhaumann, jpoelen, jpoelen2, vkrause Cc: #frameworks
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 113 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/113/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 05 Dec 2017 17:37:46 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.completion_test
D9211: Iterate over initializer_lists to avoid mem allocs
dhaumann created this revision. dhaumann added a reviewer: mwolff. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I had to add a helper function to avoid messy STL iterator code everywhere. Not an ideal solution, but std::contains() simply still does not exist, yet :-) TEST PLAN make test REPOSITORY R39 KTextEditor BRANCH AvoidAllocs (branched from master) REVISION DETAIL https://phabricator.kde.org/D9211 AFFECTED FILES src/document/katedocument.cpp src/script/katescriptmanager.cpp src/view/kateview.cpp To: dhaumann, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9205: QStringList initializer list cleanup
This revision was automatically updated to reflect the committed changes. Closed by commit R39:eb0bdd49417c: QStringList initializer list cleanup (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9205?vs=23518=23525 REVISION DETAIL https://phabricator.kde.org/D9205 AFFECTED FILES autotests/src/katedocument_test.cpp autotests/src/kateencodingtest.cpp autotests/src/kateview_test.cpp autotests/src/vimode/completion.cpp autotests/src/vimode/keys.cpp src/dialogs/katedialogs.cpp src/dialogs/katedialogs.h src/document/editorconfig.cpp src/document/katedocument.cpp src/mode/katemodeconfigpage.h src/script/katescriptmanager.cpp src/syntax/katehighlightingcmds.h src/utils/katecmds.h src/utils/katesedcmd.h src/variableeditor/variablelineedit.cpp src/view/kateview.cpp src/vimode/appcommands.cpp To: dhaumann, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Dec 2017 17:29:11 + Build duration: 5 min 58 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 24 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/24/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 05 Dec 2017 17:29:11 + Build duration: 5 min 39 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 166 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/166/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 05 Dec 2017 17:29:11 + Build duration: 4 min 19 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretest
D9209: Don't set a window icon in Plasma::Dialog
This revision was automatically updated to reflect the committed changes. Closed by commit R242:78f83f5c7744: Dont set a window icon in Plasma::Dialog (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9209?vs=23520=23523 REVISION DETAIL https://phabricator.kde.org/D9209 AFFECTED FILES src/plasmaquick/dialog.cpp To: hein, #plasma, #frameworks, davidedmundson, graesslin Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9209: Don't set a window icon in Plasma::Dialog
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9209 To: hein, #plasma, #frameworks, davidedmundson, graesslin Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D4362: [AppletQuickItem] Only set QtQuick Controls 1 style once per engine
broulik added a comment. Ping. (Stupid Phab doesn't move this thing to the top in search result because it'd old) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4362 To: broulik, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/19/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Dec 2017 17:14:06 + Build duration: 7 min 55 sec and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
D9209: Don't set a window icon in Plasma::Dialog
broulik added a comment. +1 I still get an icon for plasma popups in tabbox and present windows REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9209 To: hein, #plasma, #frameworks, davidedmundson, graesslin Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 23 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/23/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 05 Dec 2017 17:14:06 + Build duration: 6 min 46 sec and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 165 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/165/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 05 Dec 2017 17:14:06 + Build duration: 4 min 56 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretest
D9205: QStringList initializer list cleanup
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
yep this is better than before after all
INLINE COMMENTS
> kateview.cpp:1385
>
> -QStringList l;
> -
> -l << QStringLiteral("edit_replace")
> - << QStringLiteral("tools_spelling")
> - << QStringLiteral("tools_indent")
> - << QStringLiteral("tools_unindent")
> - << QStringLiteral("tools_cleanIndent")
> - << QStringLiteral("tools_align")
> - << QStringLiteral("tools_comment")
> - << QStringLiteral("tools_uncomment")
> - << QStringLiteral("tools_toggle_comment")
> - << QStringLiteral("tools_uppercase")
> - << QStringLiteral("tools_lowercase")
> - << QStringLiteral("tools_capitalize")
> - << QStringLiteral("tools_join_lines")
> - << QStringLiteral("tools_apply_wordwrap")
> - << QStringLiteral("tools_spelling_from_cursor")
> - << QStringLiteral("tools_spelling_selection");
> +static const QStringList l {
> + QStringLiteral("edit_replace")
this could still be an initializer list
REPOSITORY
R39 KTextEditor
BRANCH
QStringListCleanup (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9205
To: dhaumann, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D7968: Forward QComboBox signals instead of QComboBox lineedit signals
mwolff updated this revision to Diff 23522. mwolff retitled this revision from "WIP: Forward QComboBox signals instead of QComboBox lineedit signals" to "Forward QComboBox signals instead of QComboBox lineedit signals". mwolff edited the summary of this revision. mwolff removed subscribers: dfaure, broulik, apol. mwolff added a comment. proper unit test, one must not QSignalSpy::wait when the signals already arrived! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7968?vs=19860=23522 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7968 AFFECTED FILES autotests/kurlrequestertest.cpp src/widgets/kurlrequester.cpp To: mwolff, apol Cc: #frameworks
D9126: [RTL] - align properly the selected text for RTL
This revision was automatically updated to reflect the committed changes. Closed by commit R242:71f8f16fea15: [RTL] - align properly the selected text for RTL (authored by mvourlakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9126?vs=23332=23521 REVISION DETAIL https://phabricator.kde.org/D9126 AFFECTED FILES src/declarativeimports/plasmastyle/ComboBoxStyle.qml To: mvourlakos, #plasma, davidedmundson Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9209: Don't set a window icon in Plasma::Dialog
hein created this revision. hein added reviewers: Plasma, Frameworks, davidedmundson, graesslin. Restricted Application added projects: Plasma, Frameworks. REVISION SUMMARY Setting a window icon is costly enough to be worth avoiding when it's not actually needed. This is a resurrection of David's old patch: https://git.reviewboard.kde.org/r/128484/ The concerns in the old discussion that led to its rejection are no longer valid today: In the meantime we implemented a way for apps to announce their .desktop file in a window hint, which KWin (and libtm) will fall back to to look up an icon if not set. As plasmashell does this, we can drop the setIcon call here and won't regress. TEST PLAN The pinned systray popup dialog still gets the Plasma icon in the Present Windows effect. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9209 AFFECTED FILES src/plasmaquick/dialog.cpp To: hein, #plasma, #frameworks, davidedmundson, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7968: WIP: Forward QComboBox signals instead of QComboBox lineedit signals
mwolff added inline comments.
INLINE COMMENTS
> dfaure wrote in kurlrequestertest.cpp:162
> Then use QTest::keyClick to send key events to the widget?
I still don't get it to work. This is my currently latest attempt:
void KUrlRequesterTest::testComboEditableRequester()
{
KUrlComboRequester req;
QSignalSpy textSpy(, ::textChanged);
QSignalSpy editSpy(, ::textEdited);
QSignalSpy returnSpy(, static_cast(::returnPressed));
QSignalSpy returnWithTextSpy(, static_cast(::returnPressed));
QVERIFY(!req.comboBox()->isEditable());
req.comboBox()->setEditable(true);
req.show();
QSignalSpy comboTextSpy(req.comboBox(), ::currentTextChanged);
QSignalSpy comboEditSpy(req.comboBox(), ::editTextChanged);
auto* lineEdit = req.comboBox()->lineEdit();
QVERIFY(lineEdit);
QSignalSpy lineTextSpy(lineEdit, ::textChanged);
QSignalSpy lineEditSpy(lineEdit, ::textEdited);
// FIXME: this still doesn't emit any signal, but it works in practice
when actually interacting with the widget?
QTest::keyClicks(lineEdit, QStringLiteral("foobar"), Qt::NoModifier, 100);
QVERIFY(lineTextSpy.wait());
QCOMPARE(lineTextSpy.first().first().toString(),
QStringLiteral("foobar"));
QVERIFY(lineEditSpy.wait());
QCOMPARE(lineEditSpy.first().first().toString(),
QStringLiteral("foobar"));
}
Note that the widget (which I now show) actually shows the text getting written
via the QTest::keyClicks method. But none of the signals is actually getting
emitted... I'm flabbergasted. Looking at the QLineEdit test code, it doesn't
seem to actually contain a positive test for an of `isEditable`...
I feel like I'm missing something fundamental here. Note that I can see the
signals just fine in GammaRay when I interact with an editable combo box :-/
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7968
To: mwolff, apol
Cc: dfaure, broulik, apol, #frameworks
D9205: QStringList initializer list cleanup
dhaumann added a comment. @mwolff I have a separate patch where I use STL algos in katedocument. I would like to keep this as separate patch, though. So is this change fine now? make test still passes. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9205 To: dhaumann, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/5/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Dec 2017 16:24:36 + Build duration: 5 min 4 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-querytestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 5 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
Date of build:
Tue, 05 Dec 2017 16:24:36 +
Build duration:
3 min 37 sec and counting
CONSOLE OUTPUT
[...truncated 88.86 KB...]-- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") CMake Warning at CMakeLists.txt:52 (find_package): By not providing "FindKF5DocTools.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "KF5DocTools", but CMake did not find one. Could not find a package configuration file provided by "KF5DocTools" (requested version 5.41.0) with any of the following names:KF5DocToolsConfig.cmakekf5doctools-config.cmake Add the installation prefix of "KF5DocTools" to CMAKE_PREFIX_PATH or set "KF5DocTools_DIR" to a directory containing one of the above files. If "KF5DocTools" provides a separate development package or SDK, be sure it has been installed.-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following REQUIRED packages have been found: * Qt5 (required version >= 5.7.0) * KF5Archive (required version >= 5.41.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.41.0) * KF5CoreAddons (required version >= 5.41.0) * ECM (required version >= 1.6.0), Extra CMake Modules., * Qt5Core * Qt5Test (required version >= 5.7.0) Required for tests-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * KF5DocTools (required version >= 5.41.0), Tools to generate documentation-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kpackage kf5-qt5 SUSEQt5.7/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kpackage kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform SUSEQt5.7 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target mockhandler_autogenScanning dependencies of target KF5Package_autogen[ 4%] Automatic MOC for target mockhandler[ 4%] Automatic MOC and RCC for target KF5PackageGenerating MOC compilation mocs_compilation.cpp[ 4%] Built target mockhandler_autogenScanning dependencies of target mockhandler[ 6%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/mockhandler_autogen/mocs_compilation.cpp.o[ 8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/main.cpp.oGenerating MOC source include/moc_packagestructure.cppGenerating MOC source include/private/moc_package_p.cppGenerating MOC source include/moc_packagejob_p.cppGenerating MOC source include/moc_packagejobthread_p.cppGenerating MOC source PGVKHOT7RA/moc_packages_p.cppGenerating MOC compilation mocs_compilation.cppGenerating RCC source EWIEGA46WW/qrc_kpackage.cpp[ 8%] Built target KF5Package_autogenScanning dependencies of target KF5Package[ 10%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/package.cpp.o[ 12%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packagestructure.cpp.o[ 14%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packages.cpp.o[ 16%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packageloader.cpp.o[ 18%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejob.cpp.o/home/jenkins/workspace/Frameworks kpackage kf5-qt5 SUSEQt5.7/src/kpackage/packageloader.cpp: In member function 'QList KPackage::PackageLoader::listPackages(const QString&, const QString&)':/home/jenkins/workspace/Frameworks kpackage kf5-qt5 SUSEQt5.7/src/kpackage/packageloader.cpp:194:35: error: 'currentSecsSinceEpoch' is not a member of 'QDateTime' const qint64 now = QDateTime::currentSecsSinceEpoch(); ^[ 20%] Linking CXX executable ../../bin/mockhandlermake[2]: *** [src/kpackage/CMakeFiles/KF5Package.dir/build.make:111: src/kpackage/CMakeFiles/KF5Package.dir/packageloader.cpp.o] Error 1make[2]: *** Waiting for unfinished jobs[ 20%] Built target mockhandlermake[1]: *** [CMakeFiles/Makefile2:172: src/kpackage/CMakeFiles/KF5Package.dir/all] Error 2make: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks kpackage kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u
KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 42 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/42/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Dec 2017 16:24:36 +
Build duration:
30 sec and counting
CONSOLE OUTPUT
[...truncated 69.02 KB...] Add the installation prefix of "KF5DocTools" to CMAKE_PREFIX_PATH or set "KF5DocTools_DIR" to a directory containing one of the above files. If "KF5DocTools" provides a separate development package or SDK, be sure it has been installed.-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following REQUIRED packages have been found: * Qt5 (required version >= 5.7.0) * KF5Archive (required version >= 5.41.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.41.0) * KF5CoreAddons (required version >= 5.41.0) * ECM (required version >= 1.6.0), Extra CMake Modules., * Qt5Core * Qt5Test (required version >= 5.7.0) Required for tests-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * KF5DocTools (required version >= 5.41.0), Tools to generate documentation-- Configuring done-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Frameworks kpackage kf5-qt5 FreeBSDQt5.7/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kpackage kf5-qt5 FreeBSDQt5.7] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform FreeBSDQt5.7 --usingInstall /usr/home/jenkins/install-prefix/Scanning dependencies of target KF5Package_autogenScanning dependencies of target mockhandler_autogen[ 4%] Automatic MOC for target mockhandler[ 4%] Automatic MOC and RCC for target KF5PackageGenerating MOC compilation mocs_compilation.cpp[ 4%] Built target mockhandler_autogenScanning dependencies of target mockhandler[ 8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/mockhandler_autogen/mocs_compilation.cpp.o[ 8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/main.cpp.o[ 10%] Linking CXX executable ../../bin/mockhandlerGenerating MOC source include/moc_packagestructure.cppGenerating MOC source include/private/moc_package_p.cppGenerating MOC source include/moc_packagejob_p.cppGenerating MOC source include/moc_packagejobthread_p.cppGenerating MOC source PGVKHOT7RA/moc_packages_p.cppGenerating MOC compilation mocs_compilation.cppGenerating RCC source EWIEGA46WW/qrc_kpackage.cpp[ 10%] Built target KF5Package_autogen[ 10%] Built target mockhandlerScanning dependencies of target KF5Package[ 12%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/package.cpp.o[ 14%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packagestructure.cpp.o[ 16%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packageloader.cpp.o[ 18%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejobthread.cpp.o[ 20%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packages.cpp.o[ 22%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejob.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kpackage kf5-qt5 FreeBSDQt5.7/src/kpackage/packagestructure.cpp:20:/usr/home/jenkins/workspace/Frameworks kpackage kf5-qt5 FreeBSDQt5.7/build/src/kpackage/KF5Package_autogen/include/../../../../../src/kpackage/packagestructure.h:126:30: warning: private field 'd' is not used [-Wunused-private-field]PackageStructurePrivate *d; ^/usr/home/jenkins/workspace/Frameworks kpackage kf5-qt5 FreeBSDQt5.7/src/kpackage/packageloader.cpp:194:35: error: no member named 'currentSecsSinceEpoch' in 'QDateTime'; did you mean 'currentMSecsSinceEpoch'?const qint64 now = QDateTime::currentSecsSinceEpoch(); ~~~^ currentMSecsSinceEpoch/usr/local/include/qt5/QtCore/qdatetime.h:323:19: note: 'currentMSecsSinceEpoch' declared herestatic qint64 currentMSecsSinceEpoch() Q_DECL_NOTHROW; ^1 warning generated.[ 25%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/versionparser.cpp.o[ 27%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/version.cpp.o1 error generated.[ 29%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/mocs_compilation.cpp.ogmake[2]: *** [src/kpackage/CMakeFiles/KF5Package.dir/build.make:111:
D9190: TransferJob: workaround for when the readChannelFinished has already been emitted
nicolasfella added a comment. > Yes it does. You don't know it but > m_reply = Daemon::instance()->networkAccessManager()->put(req, m_origin.data()); > in filetransferjob.cpp is using kio. I really didn't know that > Are you sure you know how to run kdeconnect with the patched kio to say this doesn't fix the problem for you? I included a qCDebug(KIO_CORE) << "FooBar"; after the patched section and when I start the KDE Connect daemon from the Konsole I can see it in the output. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: anthonyfieroni, nicolasfella, #frameworks
D9205: QStringList initializer list cleanup
dhaumann updated this revision to Diff 23518. dhaumann added a comment. Use initializer_lists directly REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9205?vs=23513=23518 BRANCH QStringListCleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D9205 AFFECTED FILES autotests/src/katedocument_test.cpp autotests/src/kateencodingtest.cpp autotests/src/kateview_test.cpp autotests/src/vimode/completion.cpp autotests/src/vimode/keys.cpp src/dialogs/katedialogs.cpp src/dialogs/katedialogs.h src/document/editorconfig.cpp src/document/katedocument.cpp src/mode/katemodeconfigpage.h src/script/katescriptmanager.cpp src/syntax/katehighlightingcmds.h src/utils/katecmds.h src/utils/katesedcmd.h src/variableeditor/variablelineedit.cpp src/view/kateview.cpp src/vimode/appcommands.cpp To: dhaumann, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9207: Don't load KDE platform module in kglobalaccel5
graesslin added a comment. I'm against a risky change here. Especially as this becomes irrelevant with Wayland. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: kcrash, fork, and stdout/stderr
On Tuesday, 5 December 2017 04:12:30 PST David Faure wrote:
> > forking inside a signal handler is a bad idea because it may deadlock. If
> > the crash happens while glibc holds some mutexes relating to
> > pthread_atfork, then you'll have a problem.
>
> I see. But how should one implement a crash handler that autorestarts an
> app, then, in a "standalone application" use case, i.e. no kdeinit or other
> daemon running in the background?
Use syscall(SYS_clone) instead of fork(). The system call always works, it's
glibc's fork() internals that are known to have problems.
Linux-only, of course.
>From forkfd.c:
/* start the child - can't use fork() because it may deadlock */
#if defined(__NR_clone2)
child_pid = syscall(__NR_clone2, SIGCHLD, NULL, 0, NULL, NULL, NULL);
#elif defined(__cris__) || defined(__s390__)
child_pid = syscall(__NR_clone, NULL, SIGCHLD, NULL, NULL, 0L);
#else
child_pid = syscall(__NR_clone, SIGCHLD, NULL, NULL, NULL, 0L);
#endif
if (child_pid == 0) {
/* child process - restore state */
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
Re: kcrash, fork, and stdout/stderr
On Tuesday, 5 December 2017 04:12:30 PST David Faure wrote: > I see. But how should one implement a crash handler that autorestarts an > app, then, in a "standalone application" use case, i.e. no kdeinit or other > daemon running in the background? Wait, why are you forking in the first place? Just exec the process again. It will replace the current process without closing the pipes. The parent won't notice a thing. Of course, that may be a problem: the parent may see the output from the child process again. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center
D9207: Don't load KDE platform module in kglobalaccel5
hein created this revision. hein added reviewers: Plasma, davidedmundson, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I'm not as sure on this one as I was with https://phabricator.kde.org/D9194 and the activity manager daemon, but from code skimming I can't see anything that requires Plasma settings, and this provides a small speedup. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9207 AFFECTED FILES src/runtime/main.cpp To: hein, #plasma, davidedmundson, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9206: Implement a kfile dialog where we can add custom widget
mlaurent added a comment. It's the problem that if class doesn't exist nobody will think to use it (or he will reimplement it). After that it's not a problem for me to put this code only in LO :) As you want :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9206 To: mlaurent, mwolff, dfaure Cc: #frameworks
D9190: TransferJob: workaround for when the readChannelFinished has already been emitted
aacid added a comment. In https://phabricator.kde.org/D9190#176216, @nicolasfella wrote: > I'm sorry, but this does not resolve https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so it could be a (similar) bug there. Yes it does. You don't know it but m_reply = Daemon::instance()->networkAccessManager()->put(req, m_origin.data()); in filetransferjob.cpp is using kio. Are you sure you know how to run kdeconnect with the patched kio to say this doesn't fix the problem for you? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: anthonyfieroni, nicolasfella, #frameworks
D9206: Implement a kfile dialog where we can add custom widget
mwolff added a comment. Most of this is just forwarding code from KFileWidget, so we could just use that directly? I mean if our LO integration is going to be the only user of this class, then maybe we should start by adding this code there and only upstream it if we think more people are going to use it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9206 To: mlaurent, mwolff, dfaure Cc: #frameworks
D9205: QStringList initializer list cleanup
mwolff added a comment.
better than before, but some things could be improved some more
INLINE COMMENTS
> katedocument.cpp:4518
> +// view variable names
> +static const QStringList vvl {
> + QStringLiteral("dynamic-word-wrap")
even better would be to not name this list type at all, to use initializer_list
and then use STL algorithms on it, but this is already better. The advantage of
my suggested pattern is that there is no memory allocation at all anymore.
Compare https://godbolt.org/g/3SvKNw against https://godbolt.org/g/w9ySts (it
should be similar for QStrings)
> katedocument.cpp:4613
> else if (var == QLatin1String("eol") || var ==
> QLatin1String("end-of-line")) {
> -QStringList l;
> -l << QStringLiteral("unix") << QStringLiteral("dos") <<
> QStringLiteral("mac");
> +const QStringList l{ QStringLiteral("unix"),
> QStringLiteral("dos"), QStringLiteral("mac") };
> if ((n = l.indexOf(val.toLower())) != -1) {
dito
> katedocument.cpp:4733
> val = val.trimmed().toLower();
> -static const QStringList trueValues = QStringList() <<
> QStringLiteral("1") << QStringLiteral("on") << QStringLiteral("true");
> +static const QStringList trueValues{ QStringLiteral("1"),
> QStringLiteral("on"), QStringLiteral("true") };
> if (trueValues.contains(val)) {
dito
> katedocument.cpp:4739
>
> -static const QStringList falseValues = QStringList() <<
> QStringLiteral("0") << QStringLiteral("off") << QStringLiteral("false");
> +static const QStringList falseValues{ QStringLiteral("0"),
> QStringLiteral("off"), QStringLiteral("false") };
> if (falseValues.contains(val)) {
dito
> katescriptmanager.cpp:119
> */
> -foreach (const QString , QStringList() <<
> QLatin1String("indentation") << QLatin1String("commands")) {
> +for (const QString type : { QLatin1String("indentation"),
> QLatin1String("commands") }) {
> // basedir for filesystem lookup
use auto on the left
> kateview.cpp:1385
>
> -QStringList l;
> -
> -l << QStringLiteral("edit_replace")
> - << QStringLiteral("tools_spelling")
> - << QStringLiteral("tools_indent")
> - << QStringLiteral("tools_unindent")
> - << QStringLiteral("tools_cleanIndent")
> - << QStringLiteral("tools_align")
> - << QStringLiteral("tools_comment")
> - << QStringLiteral("tools_uncomment")
> - << QStringLiteral("tools_toggle_comment")
> - << QStringLiteral("tools_uppercase")
> - << QStringLiteral("tools_lowercase")
> - << QStringLiteral("tools_capitalize")
> - << QStringLiteral("tools_join_lines")
> - << QStringLiteral("tools_apply_wordwrap")
> - << QStringLiteral("tools_spelling_from_cursor")
> - << QStringLiteral("tools_spelling_selection");
> +static const QStringList l {
> + QStringLiteral("edit_replace")
don't name a type (use initializer list) and then use range-based for below
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9205
To: dhaumann, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9189: Do not crash when setting new line edit on an editable combo box
anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. Let's David says but i think KOpenWithDialog should be fixed as well, why we need new KLineEdit while KHistoryComboBox do it for us? https://phabricator.kde.org/source/kio/browse/master/src/widgets/kopenwithdialog.cpp;befcbbd4e36b8f2a948e2baa88a0642e24d55564$601 REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D9189 To: mwolff, dfaure, anthonyfieroni Cc: #frameworks
D9206: Implement a kfile dialog where we can add custom widget
mlaurent edited the test plan for this revision. mlaurent added reviewers: mwolff, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9206 To: mlaurent, mwolff, dfaure Cc: #frameworks
D9206: Implement a kfile dialog where we can add custom widget
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R241 KIO BRANCH add_kfile_dialog REVISION DETAIL https://phabricator.kde.org/D9206 AFFECTED FILES autotests/CMakeLists.txt autotests/kfilecustomdialogtest.cpp autotests/kfilecustomdialogtest.h src/filewidgets/CMakeLists.txt src/filewidgets/kfilecustomdialog.cpp src/filewidgets/kfilecustomdialog.h tests/CMakeLists.txt tests/kfilecustomdialogtest_gui.cpp tests/kfilecustomdialogtest_gui.h To: mlaurent Cc: #frameworks
D9205: QStringList initializer list cleanup
dhaumann created this revision.
dhaumann added a reviewer: mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Simple cleanup of QStringList{...}
TEST PLAN
make test
REPOSITORY
R39 KTextEditor
BRANCH
QStringListCleanup (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9205
AFFECTED FILES
autotests/src/katedocument_test.cpp
autotests/src/kateencodingtest.cpp
autotests/src/kateview_test.cpp
autotests/src/vimode/completion.cpp
autotests/src/vimode/keys.cpp
src/dialogs/katedialogs.cpp
src/dialogs/katedialogs.h
src/document/editorconfig.cpp
src/document/katedocument.cpp
src/mode/katemodeconfigpage.h
src/script/katescriptmanager.cpp
src/syntax/katehighlightingcmds.h
src/utils/katecmds.h
src/utils/katesedcmd.h
src/variableeditor/variablelineedit.cpp
src/view/kateview.cpp
src/vimode/appcommands.cpp
To: dhaumann, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9189: Do not crash when setting new line edit on an editable combo box
mwolff edited the summary of this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9189 To: mwolff, dfaure Cc: #frameworks
D9189: Do not crash when setting new line edit on an editable combo box
mwolff updated this revision to Diff 23508. mwolff retitled this revision from "Do not crash when completion object gets destroyed underneath us" to "Do not crash when setting new line edit on an editable combo box". mwolff edited the summary of this revision. mwolff removed subscribers: anthonyfieroni, dfaure. mwolff added a comment. update commit message REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9189?vs=23507=23508 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9189 AFFECTED FILES autotests/kcombobox_unittest.cpp src/kcombobox.cpp To: mwolff, dfaure Cc: #frameworks
D9189: Do not crash when completion object gets destroyed underneath us
mwolff updated this revision to Diff 23507. mwolff added a comment. write unit test and document what's going on in more detail REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9189?vs=23473=23507 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9189 AFFECTED FILES autotests/kcombobox_unittest.cpp src/kcombobox.cpp To: mwolff, dfaure Cc: anthonyfieroni, dfaure, #frameworks
KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 13 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/13/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Dec 2017 13:43:20 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 14 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/14/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Tue, 05 Dec 2017 13:43:20 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
D9168: Migrate some QRegExps to QRegularExpression
This revision was automatically updated to reflect the committed changes. Closed by commit R39:f9dbd24e80b7: Migrate some QRegExps to QRegularExpression (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9168?vs=23491=23506#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9168?vs=23491=23506 REVISION DETAIL https://phabricator.kde.org/D9168 AFFECTED FILES autotests/src/scripting_test.cpp src/completion/katewordcompletion.cpp src/document/katedocument.cpp src/mode/katemodeconfigpage.cpp src/mode/katemodemanager.cpp src/printing/printpainter.cpp src/utils/katecmds.cpp To: dhaumann, cullmann, kfunk, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9202: Highlighting Indexer: Check for infinite loops
This revision was automatically updated to reflect the committed changes. Closed by commit R216:1c0667ac6af8: Highlighting Indexer: Check for infinite loops (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9202?vs=23504=23505 REVISION DETAIL https://phabricator.kde.org/D9202 AFFECTED FILES data/syntax/cpp.xml src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause Cc: #frameworks
D9202: Highlighting Indexer: Check for infinite loops
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH CheckLookAhead (branched from master) REVISION DETAIL https://phabricator.kde.org/D9202 To: dhaumann, vkrause Cc: #frameworks
D9189: Do not crash when completion object gets destroyed underneath us
mwolff added inline comments. INLINE COMMENTS > mwolff wrote in kcombobox.cpp:317 > can you be more specific, such that I can build a unit test out of this? And > are you saying that `QComboBox::setLineEdit` is deleting the line edit? ah I think I got it now, thanks for the hint! REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9189 To: mwolff, dfaure Cc: anthonyfieroni, dfaure, #frameworks
D9202: Highlighting Indexer: Check for infinite loops
dhaumann updated this revision to Diff 23504. dhaumann added a comment. missing return true statement REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9202?vs=23503=23504 BRANCH CheckLookAhead (branched from master) REVISION DETAIL https://phabricator.kde.org/D9202 AFFECTED FILES data/syntax/cpp.xml src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause Cc: #frameworks
D9202: Highlighting Indexer: Check for infinite loops
dhaumann updated this revision to Diff 23503. dhaumann added a comment. Fixed typo REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9202?vs=23502=23503 BRANCH CheckLookAhead (branched from master) REVISION DETAIL https://phabricator.kde.org/D9202 AFFECTED FILES data/syntax/cpp.xml src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause Cc: #frameworks
D9202: Highlighting Indexer: Check for infinite loops
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The infinite loop check looks for a lookAhead="true" in combination with context="#stay". This would possibly lead to an infinite loop, and indicates a bug in a highlighting file. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH CheckLookAhead (branched from master) REVISION DETAIL https://phabricator.kde.org/D9202 AFFECTED FILES data/syntax/cpp.xml src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause Cc: #frameworks
D9189: Do not crash when completion object gets destroyed underneath us
mwolff added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kcombobox.cpp:317 > KHistoryComboBox is constructed with line edit in, then setLineEdit removes > it with completion object in. can you be more specific, such that I can build a unit test out of this? And are you saying that `QComboBox::setLineEdit` is deleting the line edit? REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9189 To: mwolff, dfaure Cc: anthonyfieroni, dfaure, #frameworks
D9190: TransferJob: workaround for when the readChannelFinished has already been emitted
nicolasfella added a comment. I'm sorry, but this does not resolve https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so it could be a (similar) bug there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: anthonyfieroni, nicolasfella, #frameworks
D9168: Migrate some QRegExps to QRegularExpression
mwolff accepted this revision.
mwolff added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> katedocument.cpp:4475
> // found vars, if any
> QString s;
>
future: this could be a ref, quite probably, and capturedRef could be used below
> katedocument.cpp:4517
>
> QStringList vvl; // view variable names
> vvl << QStringLiteral("dynamic-word-wrap") <<
> QStringLiteral("dynamic-word-wrap-indicators")
future: someone should make this a static const array and use an initializer
list
> katemodemanager.cpp:165
> QString varLine = type->varLine;
> -if (QRegExp(QLatin1String("kate:(.*)")).indexIn(varLine) < 0) {
> +if (varLine.indexOf(QStringLiteral("kate:")) < 0) {
> varLine.prepend(QLatin1String("kate: "));
even better: `!varLine.contains(QLatin1String("kate:"))`, or even `startsWith`?
though the old code did a `contains` check
REPOSITORY
R39 KTextEditor
BRANCH
QRegExpCleanup (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9168
To: dhaumann, cullmann, kfunk, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
Re: KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 156 - Still Failing!
Thanks, fixed. David
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/10/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Dec 2017 13:12:10 + Build duration: 2 min 48 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 157 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/157/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 05 Dec 2017 13:12:10 + Build duration: 2 min 29 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 12 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/12/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Tue, 05 Dec 2017 13:12:10 + Build duration: 2 min 8 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
Re: kcrash, fork, and stdout/stderr
On lundi 4 décembre 2017 17:04:25 CET Thiago Macieira wrote:
> On Monday, 4 December 2017 00:26:55 PST David Faure wrote:
> > > Or do you fork a child at that point? fork from inside a signal handler
> > > is
> > > an incredibly bad idea, don't do it.
> >
> > Well, I guess that's why it's the fallback from the main strategy which is
> > "ask kdeinit to restart that application" (even if it doesn't provide a
> > kdeinit module). But kdeinit might not be running, outside plasma
> > workspace.
> >
> > This has always been like that, it goes back to 2006 (Luboš), it was
> > discussed with you
> > https://marc.info/?l=kde-core-devel=113699766611213=2 ("There's still
> > a
> > fallback to use fork() in case using kdeinit fails for any reason.")
>
> Well, I've learnt a lot in the last 11 years.
>
> forking inside a signal handler is a bad idea because it may deadlock. If
> the crash happens while glibc holds some mutexes relating to
> pthread_atfork, then you'll have a problem.
I see. But how should one implement a crash handler that autorestarts an app,
then, in a "standalone application" use case, i.e. no kdeinit or other daemon
running in the background?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
D9168: Migrate some QRegExps to QRegularExpression
dhaumann marked an inline comment as done. dhaumann added a comment. Update patch. INLINE COMMENTS > mwolff wrote in katecmds.cpp:502 > static? I do not think static is needed here: When you invoke the command line (F7), and type 'char 0x123', then creating a QRegularExpression will not be a bottleneck. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9168 To: dhaumann, cullmann, kfunk, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9168: Migrate some QRegExps to QRegularExpression
dhaumann updated this revision to Diff 23491. dhaumann marked 4 inline comments as done. dhaumann added a comment. Remove one usage of QRegularExpression REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9168?vs=23488=23491 BRANCH QRegExpCleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D9168 AFFECTED FILES autotests/src/scripting_test.cpp src/completion/katewordcompletion.cpp src/document/katedocument.cpp src/mode/katemodeconfigpage.cpp src/mode/katemodemanager.cpp src/printing/printpainter.cpp src/utils/katecmds.cpp To: dhaumann, cullmann, kfunk, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9124: make packageurlinterceptor as noop as possible
mart updated this revision to Diff 23490. mart added a comment. - use kpackage_install_bundled_package REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23463=23490 BRANCH phab/packegeFileUrl REVISION DETAIL https://phabricator.kde.org/D9124 AFFECTED FILES KF5PlasmaMacros.cmake autotests/configmodeltest.cpp examples/shell/customcorona.cpp src/plasmaquick/appletquickitem.cpp src/plasmaquick/configmodel.cpp src/plasmaquick/configview.cpp src/plasmaquick/packageurlinterceptor.cpp src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.cpp To: mart, #plasma Cc: davidedmundson, ngraham, apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D9197: experimental support for rcc files loading in kpackage
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
support for the contents/ directory of kpackage to be
compressed in an rcc file, new cmake macro
kpackage_install_bundled_package which generates it,
the old install package is unaltered for better retrocompatibility
TEST PLAN
most of plasma ui works correctly, plasmoids can be migrated
safely, some other things may still require adapting as
setSource(QUrl::fromLocalFile(package.filePath("mainscript"))
must be changed to
setSource(package.fileUrl("mainScript"))
REPOSITORY
R290 KPackage
BRANCH
kpackageqrc
REVISION DETAIL
https://phabricator.kde.org/D9197
AFFECTED FILES
CMakeLists.txt
KF5PackageMacros.cmake
qrc.cmake
src/kpackage/package.cpp
src/kpackage/package.h
To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D9189: Do not crash when completion object gets destroyed underneath us
anthonyfieroni added a reviewer: dfaure. anthonyfieroni added inline comments. INLINE COMMENTS > kcombobox.cpp:317 > > QComboBox::setLineEdit(edit); > d->klineEdit = qobject_cast(edit); KHistoryComboBox is constructed with line edit in, then setLineEdit removes it with completion object in. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9189 To: mwolff, dfaure Cc: anthonyfieroni, dfaure, #frameworks
