D9290: [filewidgets] Fix create path
anthonyfieroni added inline comments.
INLINE COMMENTS
> pathhelpers_p.h:31
> +{
> +if (!path1.endsWith(QLatin1Char('/'))) {
> +return path1 + QLatin1Char('/') + path2;
To be absolutely sure we can add pedantic check
if (!path1.endsWith('/') && !path2.startsWith('/'))
?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9290
To: anthonyfieroni, #frameworks, dfaure, hein, aacid
D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes
bcooksley added a comment. Depending on the end goal of this you may wish to also set the following environment variables: CMAKE_PREFIX_PATH: to help guide CMake to look here in addition to system prefixes PKG_CONFIG_PATH: to help pkg-config find *.pc files QMAKEFEATURES: to help qmake find *.pri files Details on how those need to be used are documented in the CI environment management code at https://cgit.kde.org/sysadmin/ci-tooling.git/tree/helpers/helperslib/EnvironmentHandler.py REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9299 To: apol, #frameworks, sitter Cc: bcooksley, ngraham, sitter, cgiboudeaux, #build_system
KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 - Build # 88 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/88/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 13 Dec 2017 05:59:15 + Build duration: 1 hr 9 min and counting CONSOLE OUTPUT [...truncated 84.40 KB...]VCTOOLSREDISTDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.12.25810\'VCTOOLSVERSION= '14.12.25827'VISUALSTUDIOVERSION = '15.0'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.5.1'VSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.16299.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION = '10.0.16299.0\'WINDOWSSDKVERBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\'WINDOWSSDKVERSION = '10.0.16299.0\'WORKSPACE = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH = 'C:\ProgramData\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix;C:\CM\msvc2017x64d;C:\CM\msvc2017x64d\dev-utils'QT_PLUGIN_PATH= 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix\lib\plugins'QML2_IMPORT_PATH = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix\lib\qml'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix\share;C:\CM\msvc2017x64d\share;C:\CM\msvc2017x64d\dev-utils\share'XDG_CONFIG_DIRS = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix\etc/xdg'PKG_CONFIG_PATH = 'C:\CM\msvc2017x64d\lib\pkgconfig;C:\CM\msvc2017x64d\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\CM\msvc2017x64d\mkspecs/features'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM" "C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.12.25830.2-- The CXX compiler identification is MSVC 19.12.25830.2-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Found KF5Activities: C:/CI/workspace/Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: C:/CI/workspace/Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: C:/CI/workspace/Frameworks plasma-framework kf5-qt5
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 33 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/33/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Wed, 13 Dec 2017 06:52:48 + Build duration: 5 min 2 sec and counting CONSOLE OUTPUT [...truncated 84.45 KB...]BUILD_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/33/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/'BUILD_DISPLAY_NAME= '#33'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 SUSEQt5.7-33'NODE_LABELS = 'Docker Swarm-a4a1efc31d53 SUSEQt5.7'LOGNAME = 'jenkins'JRE_HOME = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE = '1000'CPU = 'x86_64'JENKINS_SERVER_COOKIE = 'durable-dd61419fc6bc4674f7684fc7faa79756'CVS_RSH = 'ssh'LESSOPEN = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.7"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.42.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.42.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.42.0") -- Found KF5WindowSystem:
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 29 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/29/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Dec 2017 06:52:48 + Build duration: 3 min 29 sec and counting CONSOLE OUTPUT [...truncated 84.47 KB...]BUILD_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/29/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#29'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 SUSEQt5.10-29'NODE_LABELS = 'Docker Swarm-3db7ffc72f65 SUSEQt5.10'LOGNAME = 'jenkins'JRE_HOME = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE = '1000'CPU = 'x86_64'JENKINS_SERVER_COOKIE = 'durable-be856f07c03ab9ec6b98fe4ebe7bc462'CVS_RSH = 'ssh'LESSOPEN = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.42.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.42.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.42.0") -- Found KF5WindowSystem:
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 5 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 13 Dec 2017 05:59:15 + Build duration: 46 min and counting CONSOLE OUTPUT [...truncated 60.00 KB...]TERM = 'su'XDG_CURRENT_DESKTOP = 'KDE'LD_LIBRARY_PATH = '/usr/home/jenkins/install-prefix/lib'USER = 'jenkins'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'RUN_DISPLAY_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/5/display/redirect'BUILD_NUMBER = '5'PATH = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins//bin'SHELL = '/usr/local/bin/bash'BUILD_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/5/'JOB_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'BLOCKSIZE = 'K'PKG_CONFIG_PATH = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'_ = '/usr/local/bin/java'JENKINS_NODE_COOKIE = '6e113526-b5b2-4b11-ad34-8d8626163288'LANG = 'en_US.UTF-8'HUDSON_COOKIE = 'ebc1c694-25c5-43f1-b0e1-9b805b9859c1'SSH_CLIENT= '10.150.80.1 37052 22'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'HUDSON_HOME = '/home/production/data'XDG_CONFIG_DIRS = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'JOB_BASE_NAME = 'Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9-5'SSH_CONNECTION= '10.150.80.1 37052 10.150.85.131 22'MAIL = '/var/mail/jenkins'JOB_DISPLAY_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/display/redirect'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/" "/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 3.8.0-- The CXX compiler identification is Clang 3.8.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.2") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes:
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 13 Dec 2017 05:59:05 + Build duration: 44 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.completion_test
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 32 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/32/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Wed, 13 Dec 2017 06:37:17 + Build duration: 3 min 27 sec and counting CONSOLE OUTPUT [...truncated 84.41 KB...]BUILD_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/32/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/'BUILD_DISPLAY_NAME= '#32'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 SUSEQt5.7-32'NODE_LABELS = 'Docker Swarm-3edf674cdb20 SUSEQt5.7'LOGNAME = 'jenkins'JRE_HOME = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE = '1000'CPU = 'x86_64'JENKINS_SERVER_COOKIE = 'durable-dd61419fc6bc4674f7684fc7faa79756'CVS_RSH = 'ssh'LESSOPEN = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.7"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.42.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.42.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.42.0") -- Found KF5WindowSystem:
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 28 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/28/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Dec 2017 06:37:17 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT [...truncated 84.09 KB...]BUILD_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/28/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#28'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 SUSEQt5.10-28'NODE_LABELS = 'Docker Swarm-ef0d7b99f148 SUSEQt5.10'LOGNAME = 'jenkins'JRE_HOME = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE = '1000'CPU = 'x86_64'JENKINS_SERVER_COOKIE = 'durable-be856f07c03ab9ec6b98fe4ebe7bc462'CVS_RSH = 'ssh'LESSOPEN = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.42.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.42.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.42.0") -- Found KF5WindowSystem:
KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 19 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/19/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Wed, 13 Dec 2017 05:59:05 + Build duration: 38 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 18 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/18/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Dec 2017 05:59:05 + Build duration: 27 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 3 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/3/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 13 Dec 2017 05:58:52 + Build duration: 25 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 32 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/32/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 13 Dec 2017 05:58:50 + Build duration: 24 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 56 test(s)
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 10 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 13 Dec 2017 05:58:50 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 31 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/31/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Wed, 13 Dec 2017 05:59:15 + Build duration: 19 min and counting CONSOLE OUTPUT [...truncated 84.50 KB...]BUILD_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/31/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/'BUILD_DISPLAY_NAME= '#31'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 SUSEQt5.7-31'NODE_LABELS = 'Docker Swarm-d6a6f5068e36 SUSEQt5.7'LOGNAME = 'jenkins'JRE_HOME = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE = '1000'CPU = 'x86_64'JENKINS_SERVER_COOKIE = 'durable-dd61419fc6bc4674f7684fc7faa79756'CVS_RSH = 'ssh'LESSOPEN = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.7"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.42.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.42.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.42.0") -- Found KF5WindowSystem:
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 14 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/14/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Wed, 13 Dec 2017 05:58:52 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 27 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Dec 2017 05:59:15 + Build duration: 16 min and counting CONSOLE OUTPUT [...truncated 84.62 KB...]BUILD_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/27/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#27'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 SUSEQt5.10-27'NODE_LABELS = 'Docker Swarm-9162c00ca8d4 SUSEQt5.10'LOGNAME = 'jenkins'JRE_HOME = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE = '1000'CPU = 'x86_64'JENKINS_SERVER_COOKIE = 'durable-be856f07c03ab9ec6b98fe4ebe7bc462'CVS_RSH = 'ssh'LESSOPEN = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.42.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.42.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.42.0") -- Found KF5WindowSystem:
KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 9 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/9/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Wed, 13 Dec 2017 05:58:40 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest
KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/9/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Dec 2017 05:58:40 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetestFailed: TestSuite.kurltest
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/12/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Dec 2017 05:58:52 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 4 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/4/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 13 Dec 2017 05:58:40 + Build duration: 9 min 41 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest
D9290: [filewidgets] Fix create path
anthonyfieroni updated this revision to Diff 23843. anthonyfieroni added a comment. Rename function, remove variadic template, it still not needed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9290?vs=23828=23843 REVISION DETAIL https://phabricator.kde.org/D9290 AFFECTED FILES src/core/chmodjob.cpp src/core/copyjob.cpp src/core/deletejob.cpp src/core/forwardingslavebase.cpp src/core/kcoredirlister.cpp src/core/kfileitem.cpp src/core/listjob.cpp src/core/mkpathjob.cpp src/filewidgets/kdiroperator.cpp src/filewidgets/kfilewidget.cpp src/filewidgets/knewfilemenu.cpp src/filewidgets/kurlnavigatorbutton.cpp src/ioslaves/trash/kio_trash.cpp src/ioslaves/trash/tests/testtrash.cpp src/pathhelpers_p.h src/urifilters/ikws/searchproviderregistry.cpp src/urifilters/shorturi/kshorturifilter.cpp src/widgets/clipboardupdater.cpp src/widgets/kpropertiesdialog.cpp src/widgets/kurlcompletion.cpp src/widgets/kurlrequester.cpp src/widgets/paste.cpp src/widgets/renamedialog.cpp To: anthonyfieroni, #frameworks, dfaure, hein, aacid
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 20 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Dec 2017 03:59:02 + Build duration: 3 min 13 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 18 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/18/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Wed, 13 Dec 2017 03:59:02 + Build duration: 3 min 12 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 13 Dec 2017 03:59:02 + Build duration: 2 min 26 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest
Re: Default location of the settings file on windows when using KXmlGuiWindow/KMainWindow
On 12.12.2017 13:13, Kåre Särs wrote: On måndag 11 december 2017 kl. 21:55:23 EET Albert Astals Cid wrote: El dijous, 7 de desembre de 2017, a les 22:13:21 CET, Alexander Semke va escriure: Hi all, https://bugs.kde.org/show_bug.cgi?id=387626 we've got this problem reported and I don't see how to easily fix this. LabPlot's MainWindow inherits from KXmlGuiWindow. When saving the auto settings in KMainWindow, KSharedConfig::openConfig() is used which uses QStandardPaths::GenericConfigLocation for the location: https://api.kde.org/frameworks/kconfig/html/classKSharedConfig.html#a32820 86 49f2e3f0ee895c9b11aa82205 According to the problem description in this ticket, I assume this is a valid request since it makes a lot of sense to me, we have to use QStandardPaths::AppDataLocation for the location of the config file. Do I need to set here KMainWindow::setAutoSettings() with a KConfig having the proper name and location? I'd actually expect this to be done by the underlying framework(s)... We read the settings in many places via KSharedConfig::openConfig() which also defaults to the same rc file under QStandardPaths::GenericConfigLocation. For all our custom and application specific settings we can of course provide AppDataLocation explicitely but this also looks to me like not the most optimal solution since we'd need to touch the code at many places. How is this handled in other KF5-applications? Can somebody share some best practices here? You may try the kde windows list if noone answers here. Actually I think kde-frameworks-devel would be a better place to take this up. (CC:ing) One problem is that we have have used GenericConfigLocation long before AppDataLocation was introduced and there would be backwards compatibility problems if we directly would just switch to AppDataLocation. How about checking first whether the rc-file already exists in GenericConfigLocation? If it already exists, use it. If not, create a new one in AppDataLocation. With this we shouldn't run into backward compatibility issues and should be fine (i.e. using the roaming folder) with the new default location for new users. -- Alexander
D9290: [filewidgets] Fix create path
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Thanks!
INLINE COMMENTS
> helpers.h:23
> +
> +#ifndef KIO_HELPERS_H
> +#define KIO_HELPERS_H
This file should be called *_p.h to make it clear that it's not installed (and
therefore not public API).
helpers is too generic though, let's at least call this something like
pathhelpers_p.h
> helpers.h:30
> +inline
> +QString addPath(QString path)
> +{
const QString & to avoid one copy
I think the template below could also take const QString as input.
I'm also wondering about the name. The name addPath made sense in KUrl, but
here we're not "adding one path to an object". This is more about concatenating
paths. How about concatPaths() ?
> helpers.h:35
> +
> +template + class = typename std::enable_if QString>::value>::type>
Fancy variadic template, but is it actually called with more than 2 args
anywhere? :-)
If not I'd suggest to keep it a simple function with 2 args.
> helpers.h:36
> +template + class = typename std::enable_if QString>::value>::type>
> +T addPath(T path, T1... pathN)
is the enable_if needed? After all if someone calls this with int or whatever
else, it will simply fail to compile, right?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9290
To: anthonyfieroni, #frameworks, dfaure, hein, aacid
KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.7 - Build # 7 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/7/ Project: Frameworks kservice kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 22:04:11 + Build duration: 6 min 47 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/7/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Dec 2017 22:04:11 + Build duration: 4 min 23 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 4 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/4/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 22:04:11 + Build duration: 2 min 35 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.ksycocatest
D9252: Created 'GroupHiddenRole' for KPlacesModel
elvisangelaccio removed a dependent revision: D9242: Implemented support for hide/show groups. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 To: renatoo, mwolff Cc: #frameworks
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 17 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/17/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 20:30:26 + Build duration: 4 min 3 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 6 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 20:30:26 + Build duration: 2 min 25 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest
D8336: Improve apidox of KJobTrackerInterface
This revision was automatically updated to reflect the committed changes. Closed by commit R244:c688a15d871a: Improve apidox of KJobTrackerInterface (authored by elvisangelaccio). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8336?vs=23725=23831 REVISION DETAIL https://phabricator.kde.org/D8336 AFFECTED FILES src/lib/jobs/kjobtrackerinterface.h To: elvisangelaccio, kossebau, dfaure Cc: apol, #frameworks
D9076: Have an application that can cross-check if the promised platforms are correct
This revision was automatically updated to reflect the committed changes. Closed by commit R857:235e202a1374: Have an application that can cross-check if the promised platforms are correct (authored by apol). REPOSITORY R857 CI System Tooling CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9076?vs=23784=23829 REVISION DETAIL https://phabricator.kde.org/D9076 AFFECTED FILES helpers/check-platform.py To: apol, #frameworks, bcooksley Cc: adridg, bcooksley, dfaure
D9290: [filewidgets] Fix create path
anthonyfieroni updated this revision to Diff 23828. anthonyfieroni added a comment. Helper function in all over places. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9290?vs=23768=23828 REVISION DETAIL https://phabricator.kde.org/D9290 AFFECTED FILES src/core/chmodjob.cpp src/core/copyjob.cpp src/core/deletejob.cpp src/core/forwardingslavebase.cpp src/core/kcoredirlister.cpp src/core/kfileitem.cpp src/core/listjob.cpp src/core/mkpathjob.cpp src/filewidgets/kdiroperator.cpp src/filewidgets/kfilewidget.cpp src/filewidgets/knewfilemenu.cpp src/filewidgets/kurlnavigatorbutton.cpp src/helpers.h src/ioslaves/trash/kio_trash.cpp src/ioslaves/trash/tests/testtrash.cpp src/urifilters/ikws/searchproviderregistry.cpp src/urifilters/shorturi/kshorturifilter.cpp src/widgets/clipboardupdater.cpp src/widgets/kpropertiesdialog.cpp src/widgets/kurlcompletion.cpp src/widgets/kurlrequester.cpp src/widgets/paste.cpp src/widgets/renamedialog.cpp To: anthonyfieroni, #frameworks, dfaure, hein, aacid
D9076: Have an application that can cross-check if the promised platforms are correct
bcooksley accepted this revision. bcooksley added a comment. This revision is now accepted and ready to land. Perfect. Lets get this committed. REPOSITORY R857 CI System Tooling BRANCH master REVISION DETAIL https://phabricator.kde.org/D9076 To: apol, #frameworks, bcooksley Cc: adridg, bcooksley, dfaure
D9276: highlight PlasmaComponents3.ComboBox list items
mvourlakos added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9275: fix RTL appearance for ComboBox
mvourlakos added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8923: Offer QWindow API for KJobWidgets:: decorators
This revision was automatically updated to reflect the committed changes. Closed by commit R288:02053c0ff28f: Offer QWindow API for KJobWidgets:: decorators (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8923?vs=22686=23820#toc REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8923?vs=22686=23820 REVISION DETAIL https://phabricator.kde.org/D8923 AFFECTED FILES src/kjobwidgets.cpp src/kjobwidgets.h To: apol, #frameworks, dfaure Cc: dfaure, kfunk
D9206: Implement a kfile dialog where we can add custom widget
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfilecustomdialogtest.h:30 > +public: > +explicit KFileCustomDialogTest(QObject *parent = nullptr); > +~KFileCustomDialogTest() = default; not really useful, in unittests (there's initTestcase which is better for initializations anyway) > kfilecustomdialog.h:32 > + * This class implement a custom file dialog. > + * It uses a KFileWidget and we can add some custom widget > + * @since 5.42 API documentation rarely says "we". Suggested rephrasing: It uses a KFileWidget and allows the application to provide a custom widget. ... which will be shown where, BTW? Below the directory view and above the buttons? Or on the side? I see the implementation is KFileWidget::setCustomWidget so I could be less lazy and look that up, but the user of KFileCustomDialog wouldn't even know this anyway (unless the docu for setCustomWidget is improved to point there). > kfilecustomdialog.h:43 > +/** > + * @brief setUrl assign base url > + * @param url Please reuse the documentation from KFileWidget, it's better. > kfilecustomdialog.h:68 > +void accept() override; > +void slotOk(); > +void slotCancel(); Is this needed? Does it need to be public? Why not connect to KFileWidget's slotOk directly? (or using a lambda) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9206 To: mlaurent, mwolff, dfaure Cc: #frameworks
D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes
sitter requested changes to this revision.
sitter added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> KDEInstallDirs.cmake:699
> +if(INSTALL_PREFIX_SCRIPT)
> +file(WRITE ${CMAKE_BINARY_DIR}/prefix.sh "
> +export XDG_DATA_DIRS=${KDE_INSTALL_FULL_DATADIR}:$XDG_DATA_DIRS
>From a style perspective, I'd suggest having the prefix.sh live somewhere in
>the installed ECM tree and get copied, rather than maintained as a glorified
>heredoc in the cmake code. That's just a suggestion though.
> KDEInstallDirs.cmake:700
> +file(WRITE ${CMAKE_BINARY_DIR}/prefix.sh "
> +export XDG_DATA_DIRS=${KDE_INSTALL_FULL_DATADIR}:$XDG_DATA_DIRS
> +export XDG_CONFIG_DIRS=${KDE_INSTALL_FULL_CONFDIR}:$XDG_CONFIG_DIRS
This is not correct, the XDG_ vars are not necessarily set, so all code that
sets them ought to ensure their default values are appended if necessary.
> If $XDG_DATA_DIRS is either not set or empty, a value equal to
> /usr/local/share/:/usr/share/ should be used.
i.e.
export
XDG_DATA_DIRS=${KDE_INSTALL_FULL_DATADIR}:${XDG_DATA_DIRS:-/usr/local/share:/usr/share}
> KDEInstallDirs.cmake:701
> +export XDG_DATA_DIRS=${KDE_INSTALL_FULL_DATADIR}:$XDG_DATA_DIRS
> +export XDG_CONFIG_DIRS=${KDE_INSTALL_FULL_CONFDIR}:$XDG_CONFIG_DIRS
> +export PATH=${KDE_INSTALL_FULL_BINDIR}:$PATH
Same as for XDG_DATA_DIRS
> If $XDG_CONFIG_DIRS is either not set or empty, a value equal to /etc/xdg
> should be used."
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9299
To: apol, #frameworks, sitter
Cc: sitter, cgiboudeaux, #build_system
D9206: Implement a kfile dialog where we can add custom widget
dfaure added a comment.
Hmm. I can see the usefulness, it's certainly much better than the way people
have historically inserted custom widgets into QFileDialog
(https://stackoverflow.com/questions/16987916/add-widgets-to-qfiledialog, URGH).
On the other hand, I'm wondering if this is going to be abused as a
KFileDialog replacement, losing the "native" look-n-feel for the file dialog on
Windows / macOS.
Well, that's certainly a pre-requisite for any custom widget to work, it
should just be made extra clear to app developers that what they lose in return
is the ability to get native dialogs on Windows and macOS (and Gnome, I
suppose).
So, I'm OK with this, provided that this documentation is added:
The downside of using this class is that your application will not be able to
get a native file dialog on non-Plasma environments (Windows, macOS, ...). For
this reason you should really think twice before deciding to use it, as a
custom widget might improve user experience within the Plasma workspace, but
might make it worse for users who are used to the native file dialog. In 99% of
the cases, you want to use QFileDialog instead.
INLINE COMMENTS
> kfilecustomdialogtest.cpp:42
> +
> +QVBoxLayout *mainLayout = dlg.findChild *>(QStringLiteral("mainlayout"));
> +QVERIFY(mainLayout);
This isn't really testing anything useful. Rename the layout and the test
breaks. Maybe better verify that dlg itself has a layout, rather than "there is
a child layout somwhere called mainlayout".
> kfilecustomdialogtest.cpp:47
> +QVERIFY(mFileWidget);
> +QVERIFY(dlg.fileWidget());
> +}
QCOMPARE(dlg.fileWidget(), mFileWidget) ? More useful ;)
> kfilecustomdialogtest_gui.cpp:26
> +
> +KFileCustomDialogTest_gui::KFileCustomDialogTest_gui()
> +{
remove
> kfilecustomdialogtest_gui.h:26
> +
> +class KFileCustomDialogTest_gui
> +{
unused, remove (remove the whole header...)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9206
To: mlaurent, mwolff, dfaure
Cc: #frameworks
D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes
cgiboudeaux added a comment. +1. Please add the missing documentation about this new option. INLINE COMMENTS > apol wrote in KDEInstallDirs.cmake:700-704 > Usually isn't necessary as you get the libraries through the rpath. I can add > it though. It won't harm and solve potential issues if for any reason the rpath is removed > apol wrote in KDEInstallDirs.cmake:707 > I wouldn't expect distros to pick this up, distros usually operate > exclusively on /usr. If for some reason they did, they can always get this > file in from a separate package that only installs this file. > > It's the right location though, because all projects in the same prefix will > need this variables in the same way. Allright. just add the PERMISSIONS keyword to make it executable. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9299 To: apol, #frameworks Cc: cgiboudeaux, #build_system
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. @kfunk what do you think about it ? :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes
apol added inline comments. INLINE COMMENTS > cgiboudeaux wrote in KDEInstallDirs.cmake:700-704 > missing LD_LIBRARY_PATH ? Usually isn't necessary as you get the libraries through the rpath. I can add it though. > cgiboudeaux wrote in KDEInstallDirs.cmake:707 > I'm not sure that's the right location. my installation prefixes only > contains subdirectories. > This file will also be overwritten if several modules turn the option on > (which is an issue for distributions if they decide to enable the feature) I wouldn't expect distros to pick this up, distros usually operate exclusively on /usr. If for some reason they did, they can always get this file in from a separate package that only installs this file. It's the right location though, because all projects in the same prefix will need this variables in the same way. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9299 To: apol, #frameworks Cc: cgiboudeaux, #build_system
D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes
cgiboudeaux added inline comments.
INLINE COMMENTS
> KDEInstallDirs.cmake:700-704
> +export XDG_DATA_DIRS=${KDE_INSTALL_FULL_DATADIR}:$XDG_DATA_DIRS
> +export XDG_CONFIG_DIRS=${KDE_INSTALL_FULL_CONFDIR}:$XDG_CONFIG_DIRS
> +export PATH=${KDE_INSTALL_FULL_BINDIR}:$PATH
> +export QT_PLUGIN_PATH=${KDE_INSTALL_FULL_QTPLUGINDIR}:$QT_PLUGIN_PATH
> +export QML2_IMPORT_PATH=${KDE_INSTALL_FULL_QMLDIR}:$QML2_IMPORT_PATH
missing LD_LIBRARY_PATH ?
> KDEInstallDirs.cmake:707
> +
> +install(FILES ${CMAKE_BINARY_DIR}/prefix.sh DESTINATION
> ${CMAKE_INSTALL_PREFIX})
> +endif()
I'm not sure that's the right location. my installation prefixes only contains
subdirectories.
This file will also be overwritten if several modules turn the option on (which
is an issue for distributions if they decide to enable the feature)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9299
To: apol, #frameworks
Cc: cgiboudeaux, #build_system
D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes
apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY If enabled it will install a prefix.sh script to the root of the prefix. This file will be useful to be able to easily set up a prefix to be used by integrating the environment variables it exports. TEST PLAN Only tested it in basy systems, unsure how it will work on others REPOSITORY R240 Extra CMake Modules BRANCH prefix REVISION DETAIL https://phabricator.kde.org/D9299 AFFECTED FILES kde-modules/KDEInstallDirs.cmake To: apol, #frameworks Cc: #build_system
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 4 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/4/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 14:43:10 + Build duration: 32 min and counting CONSOLE OUTPUT [...truncated 60.21 KB...]RUN_CHANGES_DISPLAY_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/4/display/redirect?page=changes'PWD = '/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9'RUN_DISPLAY_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/4/display/redirect'USER = 'jenkins'XDG_CURRENT_DESKTOP = 'KDE'SSH_CLIENT= '144.76.220.218 36942 22'LD_LIBRARY_PATH = '/usr/home/jenkins/install-prefix/lib'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'HUDSON_COOKIE = '9932d29d-f362-4c79-afcf-e3cd6906d489'NODE_NAME = 'FreeBSD Builder 3'JOB_NAME = 'Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9'QML2_IMPORT_PATH = '/usr/home/jenkins/install-prefix/lib/qml'BLOCKSIZE = 'K'JOB_BASE_NAME = 'Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9'HOME = '/usr/home/jenkins'JAVA_HOME = '/usr/local/openjdk8-jre'EXECUTOR_NUMBER = '0'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9-4'JOB_DISPLAY_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/display/redirect'HUDSON_SERVER_COOKIE = '4acee20278191cab'HUDSON_HOME = '/home/production/data'_ = '/usr/local/bin/java'BUILD_DISPLAY_NAME= '#4'HUDSON_URL= 'https://build.kde.org/'LOGNAME = 'jenkins'MM_CHARSET= 'UTF-8'NODE_LABELS = 'FreeBSD Builder 3 FreeBSDQt5.9'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/" "/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 3.8.0-- The CXX compiler identification is Clang 3.8.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.2") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.42.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.42.0") -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.42.0") -- Found
KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 - Build # 87 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/87/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 12 Dec 2017 14:43:10 + Build duration: 15 min and counting CONSOLE OUTPUT [...truncated 84.01 KB...]VCTOOLSREDISTDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.12.25810\'VCTOOLSVERSION= '14.12.25827'VISUALSTUDIOVERSION = '15.0'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.5.1'VSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.16299.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION = '10.0.16299.0\'WINDOWSSDKVERBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\'WINDOWSSDKVERSION = '10.0.16299.0\'WORKSPACE = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH = 'C:\ProgramData\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix;C:\CM\msvc2017x64d;C:\CM\msvc2017x64d\dev-utils'QT_PLUGIN_PATH= 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix\lib\plugins'QML2_IMPORT_PATH = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix\lib\qml'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix\share;C:\CM\msvc2017x64d\share;C:\CM\msvc2017x64d\dev-utils\share'XDG_CONFIG_DIRS = 'C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9\install-prefix\etc/xdg'PKG_CONFIG_PATH = 'C:\CM\msvc2017x64d\lib\pkgconfig;C:\CM\msvc2017x64d\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\CM\msvc2017x64d\mkspecs/features'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM" "C:\CI\workspace\Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.12.25830.2-- The CXX compiler identification is MSVC 19.12.25830.2-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Found KF5Activities: C:/CI/workspace/Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: C:/CI/workspace/Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: C:/CI/workspace/Frameworks plasma-framework kf5-qt5
KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 14:19:30 + Build duration: 37 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupe
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 26 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Dec 2017 14:43:10 + Build duration: 5 min 55 sec and counting CONSOLE OUTPUT [...truncated 84.41 KB...]BUILD_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/26/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#26'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 SUSEQt5.10-26'NODE_LABELS = 'Docker Swarm-5589e2bb1b71 SUSEQt5.10'LOGNAME = 'jenkins'JRE_HOME = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE = '1000'CPU = 'x86_64'JENKINS_SERVER_COOKIE = 'durable-be856f07c03ab9ec6b98fe4ebe7bc462'CVS_RSH = 'ssh'LESSOPEN = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.42.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.42.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.42.0") -- Found KF5WindowSystem:
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 30 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/30/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 14:43:10 + Build duration: 2 min 12 sec and counting CONSOLE OUTPUT [...truncated 84.11 KB...]BUILD_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/30/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL = 'https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/'BUILD_DISPLAY_NAME= '#30'XCURSOR_THEME = 'DMZ'PYTHONSTARTUP = '/etc/pythonstart'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks plasma-framework kf5-qt5 SUSEQt5.7-30'NODE_LABELS = 'Docker Swarm-a5450f08f437 SUSEQt5.7'LOGNAME = 'jenkins'JRE_HOME = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE = '1000'CPU = 'x86_64'JENKINS_SERVER_COOKIE = 'durable-dd61419fc6bc4674f7684fc7faa79756'CVS_RSH = 'ssh'LESSOPEN = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP = 'KDE'ASAN_OPTIONS = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON "/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 SUSEQt5.7"-- The C compiler identification is GNU 7.2.1-- The CXX compiler identification is GNU 7.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.42.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.42.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.42.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.42.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.42.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.42.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.42.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.42.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.42.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python (found version "2.7.14") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.42.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.42.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.42.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.42.0") -- Found KF5WindowSystem:
D9287: disappearing scrollbars on mobile
This revision was automatically updated to reflect the committed changes. Closed by commit R242:b2f61f8e3c9f: disappearing scrollbars on mobile (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9287?vs=23809=23814 REVISION DETAIL https://phabricator.kde.org/D9287 AFFECTED FILES CMakeLists.txt src/declarativeimports/plasmacomponents3/ScrollBar.qml src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml To: mart, #plasma, bshah, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 7 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/7/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 14:19:30 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupe
KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/6/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Dec 2017 14:19:30 + Build duration: 6 min 59 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupe
D9287: disappearing scrollbars on mobile
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D9287 REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma, bshah, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9287: disappearing scrollbars on mobile
mart updated this revision to Diff 23809. mart added a comment. - fix deps REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9287?vs=23761=23809 BRANCH arcpatch-D9287 REVISION DETAIL https://phabricator.kde.org/D9287 AFFECTED FILES CMakeLists.txt src/declarativeimports/plasmacomponents3/ScrollBar.qml src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml To: mart, #plasma, bshah Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9287: disappearing scrollbars on mobile
mart marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma, bshah Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9287: disappearing scrollbars on mobile
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in DefaultListItemBackground.qml:23 > does this change kill this? > > If so +1000 ah, yes it does, will remove REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma, bshah Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 16 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/16/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 13:00:30 + Build duration: 8 min 29 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 24 test(s)
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 18 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/18/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Dec 2017 13:00:30 + Build duration: 7 min 43 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 24 test(s)
KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 3 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/3/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 13:00:15 + Build duration: 5 min 57 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.ksycocatest
KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.7 - Build # 6 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/6/ Project: Frameworks kservice kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 13:00:15 + Build duration: 3 min 26 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/6/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Dec 2017 13:00:15 + Build duration: 3 min 0 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 13:00:30 + Build duration: 2 min 44 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest
D9295: do not treat ts-pmap-compile as exectuable
This revision was automatically updated to reflect the committed changes. Closed by commit R249:54147ad2fc2d: do not treat ts-pmap-compile as exectuable (authored by sitter). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9295?vs=23802=23803 REVISION DETAIL https://phabricator.kde.org/D9295 AFFECTED FILES cmake/ts-pmap-compile.py To: sitter, ilic Cc: #frameworks
D9295: do not treat ts-pmap-compile as exectuable
ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D9295 To: sitter, ilic Cc: #frameworks
D9295: do not treat ts-pmap-compile as exectuable
sitter created this revision. sitter added a reviewer: ilic. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - strip shebang - make -x the script is run through add_custom_command with the explicit python exeutable found by FindPythonInterp (which may be either python or python3) and the script is compatible with either. To prevent confusion and prevent linting tech from tripping over the fact that the script references the python2 interpreter (which EOLs in 2020) we'll make sure not to make it look like this script should be run without manually running it through the interpreter. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D9295 AFFECTED FILES cmake/ts-pmap-compile.py To: sitter, ilic Cc: #frameworks
Re: Default location of the settings file on windows when using KXmlGuiWindow/KMainWindow
On måndag 11 december 2017 kl. 21:55:23 EET Albert Astals Cid wrote: > El dijous, 7 de desembre de 2017, a les 22:13:21 CET, Alexander Semke va > > escriure: > > Hi all, > > > > https://bugs.kde.org/show_bug.cgi?id=387626 > > we've got this problem reported and I don't see how to easily fix this. > > LabPlot's MainWindow inherits from KXmlGuiWindow. When saving the auto > > settings in KMainWindow, KSharedConfig::openConfig() is used which uses > > QStandardPaths::GenericConfigLocation for the location: > > https://api.kde.org/frameworks/kconfig/html/classKSharedConfig.html#a32820 > > 86 49f2e3f0ee895c9b11aa82205 > > > > According to the problem description in this ticket, I assume this is a > > valid request since it makes a lot of sense to me, we have to use > > QStandardPaths::AppDataLocation for the location of the config file. Do > > I need to set here KMainWindow::setAutoSettings() with a KConfig having > > the proper name and location? I'd actually expect this to be done by the > > underlying framework(s)... > > > > We read the settings in many places via KSharedConfig::openConfig() > > which also defaults to the same rc file under > > QStandardPaths::GenericConfigLocation. For all our custom and > > application specific settings we can of course provide AppDataLocation > > explicitely but this also looks to me like not the most optimal solution > > since we'd need to touch the code at many places. How is this handled in > > other KF5-applications? Can somebody share some best practices here? > > You may try the kde windows list if noone answers here. Actually I think kde-frameworks-devel would be a better place to take this up. (CC:ing) One problem is that we have have used GenericConfigLocation long before AppDataLocation was introduced and there would be backwards compatibility problems if we directly would just switch to AppDataLocation. Regards, Kåre > > Cheers, > Albert > > > Thanks and Regards, > > Alexander
D9292: Remove premise that doesn't apply anymore
apol abandoned this revision. apol added a comment. `¯\_(ツ)_/¯` REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D9292 To: apol, #frameworks, dfaure Cc: dfaure
D9076: Have an application that can cross-check if the promised platforms are correct
apol added a comment. In https://phabricator.kde.org/D9076#178587, @bcooksley wrote: > This can go in from my perspective, code looks fine from my understanding of it. > > In terms of 'All' as a platform, how is that handled? (assuming that's a valid specification in the Frameworks metadata.yaml files) See line 29, if 'all' we replace it with the list of all the platforms we know. REPOSITORY R857 CI System Tooling REVISION DETAIL https://phabricator.kde.org/D9076 To: apol, #frameworks Cc: adridg, bcooksley, dfaure
D9207: Don't load KDE platform module in kglobalaccel5
davidedmundson added a comment. > The description: "I'm not as sure on this..." and "but from code skimming I can't see anything that I went through this code thoroughly recently for a change I made. We know we don't have any graphical widgets used anywhere; the use of QGuiApplication shows we're not showing in any widgets anywhere, and we can be confident that we're not having a secret manual or QML interface somewhere with any other visual things. That leaves 3 things: - icons (I checked, this and dependencies are fine) - QStylehints (also fine) - use of Qt standard keys. This is at least used client side, but I don't think on the server side. It's the one part you'll need to "prove". REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 08:47:47 + Build duration: 30 min and counting JUnit Tests Name: (root) Failed: 5 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 31 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/31/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Dec 2017 08:47:47 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 56 test(s)
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 31 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/31/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 08:47:47 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
D9292: Remove premise that doesn't apply anymore
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. OpenSuSE Leap 42.3: $ ls -l /usr/share/pixmaps | wc -l 46 $ rpm -qf /usr/share/pixmaps/yast.png yast2-control-center-3.1.6-3.3.x86_64 $ rpm -qil yast2-control-center-3.1.6-3.3.x86_64 | grep png /usr/share/pixmaps/yast.png $ rpm -qf /usr/share/pixmaps/wireshark-gtk.png wireshark-ui-gtk-2.2.10-24.1.x86_64 $ rpm -qil wireshark-ui-gtk | grep png /usr/share/pixmaps/wireshark-gtk.png So these packages don't put any icon elsewhere... REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D9292 To: apol, #frameworks, dfaure Cc: dfaure
D8336: Improve apidox of KJobTrackerInterface
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8336 To: elvisangelaccio, kossebau, dfaure Cc: apol, #frameworks
D9076: Have an application that can cross-check if the promised platforms are correct
bcooksley added a comment. This can go in from my perspective, code looks fine from my understanding of it. In terms of 'All' as a platform, how is that handled? (assuming that's a valid specification in the Frameworks metadata.yaml files) REPOSITORY R857 CI System Tooling REVISION DETAIL https://phabricator.kde.org/D9076 To: apol, #frameworks Cc: adridg, bcooksley, dfaure
KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/5/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Dec 2017 08:00:27 + Build duration: 9 min 3 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupe
KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 6 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/6/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 08:00:27 + Build duration: 3 min 53 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupe
KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 4 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/4/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 08:00:27 + Build duration: 1 min 57 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupe
