BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/9/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 18 Dec 2017 02:20:36 +
Build duration:
5 min 43 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/20/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 18 Dec 2017 02:20:36 +
Build duration:
3 min 9 sec and counting
JUnit Tests
ngraham added a comment.
We have a report in the wild that this broke compiling KWin with CMake 3.10.x
for someone on Gentoo: https://bugs.kde.org/show_bug.cgi?id=387983
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9334
To: mlaurent, dfaure
Cc: ngraham,
apol added a comment.
Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to be
exported with kconfigcompiler though, at the moment it's not.
Here's the android scripts for reference.
https://cgit.kde.org/sysadmin/ci-tooling.git/tree/system-images/android/sdk
bcooksley added a reviewer: apol.
bcooksley added a subscriber: apol.
bcooksley added a comment.
I believe @apol was doing things along these lines for his Android work.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9387
To: habacker, dfaure, ltoscano, bcooksley,
bcooksley added a comment.
This is also a duplicate as mentioned on the other reviews?
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7706
To: habacker, dfaure, ltoscano, bcooksley
Cc: dfaure, #frameworks
bcooksley added a comment.
This is a duplicate of https://phabricator.kde.org/D7706 and
https://phabricator.kde.org/D9384 no?
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7708
To: habacker, cfeck, ltoscano, bcooksley
Cc: #frameworks
bcooksley added a comment.
From my understanding of this on Linux/FreeBSD the install destinations for
these binaries are different. On Windows you should have one install prefix per
application and you can't mix Qt versions in an application.
So i'm not seeing how we end up with a
bcooksley added a comment.
I'll leave this to someone with more experience with the kdeinit codebase to
approve, but agree that this does need to be made relocatable.
This patch will probably fix a whole pile of tests on CI.
REPOSITORY
R303 KInit
REVISION DETAIL
bcooksley requested changes to this revision.
bcooksley added a comment.
This revision now requires changes to proceed.
Rather than writing the content of the file out from CMakeLists it should
probably be a template as well, even if it's a second file.
REPOSITORY
R311 KWallet
REVISION
cgiboudeaux added a comment.
This will have effects on the non-kio users :
https://lxr.kde.org/search?_string=kio_http_cache_cleaner
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5175
To: habacker, dfaure, ltoscano, bcooksley
Cc: cgiboudeaux, #frameworks
habacker created this revision.
habacker added reviewers: dfaure, ltoscano, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Cross compiling client packages which require kconfig_compiler
or kconf_update
habacker created this revision.
habacker added reviewers: dfaure, ltoscano, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Add missing method Solid::NetworkingPrivate::serviceOwnerChanged().
TEST PLAN
habacker edited the summary of this revision.
habacker edited the test plan for this revision.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D9384
To: habacker, ltoscano, bcooksley, dfaure
Cc: #frameworks
habacker added reviewers: ltoscano, bcooksley, dfaure.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D9384
To: habacker, ltoscano, bcooksley, dfaure
Cc: #frameworks
habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R303 KInit
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9384
AFFECTED FILES
src/kdeinit/kinit_win.cpp
To: habacker
Cc:
habacker created this revision.
habacker added reviewers: dfaure, ltoscano, bcooksley.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
On Windows service executables are installed in the same directory as
normal
habacker added reviewers: ltoscano, bcooksley.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5175
To: habacker, dfaure, ltoscano, bcooksley
Cc: #frameworks
habacker added reviewers: ltoscano, bcooksley.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5173
To: habacker, dfaure, ltoscano, bcooksley
Cc: bcooksley, dfaure, aacid, #frameworks
habacker added reviewers: ltoscano, bcooksley.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7706
To: habacker, dfaure, ltoscano, bcooksley
Cc: dfaure, #frameworks
habacker added a reviewer: bcooksley.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7708
To: habacker, cfeck, ltoscano, bcooksley
Cc: #frameworks
habacker added a reviewer: ltoscano.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7708
To: habacker, cfeck, ltoscano
Cc: #frameworks
habacker created this revision.
habacker added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
compiled kwallet
REPOSITORY
R311 KWallet
BRANCH
master
REVISION DETAIL
habacker added a reviewer: dfaure.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5173
To: habacker, dfaure
Cc: bcooksley, dfaure, aacid, #frameworks
habacker added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5175
To: habacker, dfaure
Cc: #frameworks
Hello,
thanks to kdebugsettings and category files, now it is possible to easily
enable/disable debugging at runtime. However, there are a few shortcomings to
this approach, which emerged when I tried to package KF5 5.41 for openSUSE:
1. There should be a macro in ECM to unify the installation
cgilles added a comment.
What's about this very important entry to improve Solid support under MacOS ?
It will be integrated officially soon ?
Gilles Caulier
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D7401
To: rjvbb, #frameworks, kfunk
Cc: kfunk,
nicolasfella added a comment.
Now it does. Awesome!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9190
To: aacid, dfaure, apol, albertvaka
Cc: ngraham, nicolasfella, anthonyfieroni, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f521183c4cc2: Highlighting indexer: Enable errors
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9377?vs=24027=24028
REVISION
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
EnableErrors (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9377
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Erros include:
- missing contexts
- duplicate contexts
- missing itemDatas
- missing keyword
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:412f5a7e705c: Highlighting indexer: report unused
itemDatas and missing itemDatas (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6b9c12981391: Lilypond, MetaFont, RHTML: Fix
missing/unused itemDatas (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9cdf1bee0dd3: Prolog, RelaxNG, RMarkDown: Fix
highlighting issues (authored by dhaumann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9376?vs=24023=24024#toc
REPOSITORY
R216 Syntax
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixMoreXmlFiles (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9375
To: dhaumann, vkrause
Cc: #frameworks
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixRemaining (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9376
To: dhaumann, vkrause
Cc: #frameworks
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixMoreHls (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9374
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixRemaining (branched from master)
REVISION
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixMoreXmlFiles (branched from master)
REVISION
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
With this patch, all issues are revealed, and not only missing itemDatas.
TEST PLAN
make test
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:91ca8ca39f66: Haml: Fix invalid and unused itemDatas
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9373?vs=24017=24018
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixHaml (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9373
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixHaml (branched from master)
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b80748a58293: ObjectiveC++: Remove duplicate comment
contexts (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
RemoveDuplicateCommentContexts (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9372
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The context "Commentar 1" was the same as "SingleLineComment".
The context "Commentar 2" was the same
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:da6d5a7cc33a: Diff, ObjectiveC++: Cleanups and fix
highlighting files (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixDiff (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9371
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixDiff (branched from master)
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:00cbdc0fdc7d: Stata highlighting: Remove unused itemData
and fix non-existing attribute (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixStata (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9370
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixStata (branched from master)
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b58763275dfd: XML (Debug): Fix incorrect DetectChar rule
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9369?vs=24007=24008
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixXmlDebug (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9369
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The fix is to simply remove the parts of the char that were
ignored anyways. Whether this is the
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ec49a95d0959: Highlighting Indexer: Support cross-hl
context checking (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
vkrause accepted this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixIncludeRulesCheck (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9361
To: dhaumann, vkrause, cullmann
Cc: #frameworks
dhaumann updated this revision to Diff 24003.
dhaumann added a comment.
Cleanups
- ContextChecker::check(): use 'success' bool correctly (was unused before)
- remove m_ for member variables in the Language helper class
- turn firstContext into a bool and immediately add the first
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:f2f65dee2962: do not make the context menu a Window
(authored by mkoller).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8519?vs=21431=23999
REVISION
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8519
To: mkoller, davidedmundson, graesslin
Cc: #frameworks
mkoller added a comment.
Ping!
Anything wrong with this 2 liner patch ?
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8519
To: mkoller, davidedmundson, graesslin
Cc: #frameworks
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixIncludeRulesCheck (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9361
To: dhaumann, vkrause, cullmann
Cc: #frameworks
62 matches
Mail list logo