D9386: Mingw32 compile fix

dfaure added a comment. That's trivial, isn't it? Rename networking.cpp to networking_unix.cpp, and move to networking.cpp the methods that are platform-independent. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9386 To: habacker, dfaure, ltoscano,

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 9 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/9/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Dec 2017 07:44:48 + Build duration: 4 min 18 sec and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 14 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/14/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Wed, 20 Dec 2017 06:29:00 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/13/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Wed, 20 Dec 2017 06:04:00 + Build duration: 22 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/13/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Dec 2017 06:04:00 + Build duration: 21 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 20 Dec 2017 06:04:00 + Build duration: 15 min and counting JUnit

D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.

bcooksley added a comment. I still question how these installs conflict - as all the scenarios where they could conflict should already be taken into account: 1. Linux distros, FreeBSD, etc have no co-installability issues here 2. Windows installs should be one prefix per application,

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 20 Dec 2017 01:16:31 + Build duration: 17 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/12/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Wed, 20 Dec 2017 01:16:32 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/12/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Dec 2017 01:16:32 + Build duration: 6 min 50 sec and counting

D9386: Mingw32 compile fix

habacker closed this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9386 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks

D9381: Use cmake variable kwallet_xml for specifing org.kde.KWallet.xml

This revision was automatically updated to reflect the committed changes. Closed by commit R311:32745503b519: Use cmake variable kwallet_xml for specifing org.kde.KWallet.xml (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9381?vs=24036=24135#toc REPOSITORY R311

D9383: Use correct service executable path for installing kwalletd dbus service on Win32

This revision was automatically updated to reflect the committed changes. Closed by commit R311:74ce261240ae: Use correct service executable path for installing kwalletd dbus service on… (authored by habacker). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

habacker added a comment. In https://phabricator.kde.org/D9404#181209, @dfaure wrote: > So the if() is needed, yes, > the AFTER isn't enough? I tried that and it does not help - AFTER|BEFORE affects only the order of directories added with include_directories > I

D9386: Mingw32 compile fix

habacker added a comment. In https://phabricator.kde.org/D9386#181227, @dfaure wrote: > If this wasn't kdelibs4support, I'd insist for sharing the implementation rather than duplicating it. Would be nice to share, but networking.cpp is only be used on non win32 platform, so how

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 23:07:17 + Build duration: 24 min and counting JUnit Tests Name: (root)

D9381: Use cmake variable kwallet_xml for specifing org.kde.KWallet.xml

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D9381 To: habacker, dfaure Cc: #frameworks

D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.

dfaure added a comment. Well, the kstars hack shouldn't exist and makes me cringe. But indeed the kate mac-packaging script is a valid case, please get in touch with Christoph Cullmann about it. The rekonq use case looks valid too but that code doesn't seem really maintained

D9386: Mingw32 compile fix

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. If this wasn't kdelibs4support, I'd insist for sharing the implementation rather than duplicating it. But oh well :-) REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/38/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 23:00:46 + Build duration: 7 min 31 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/39/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Tue, 19 Dec 2017 23:00:46 + Build duration: 7 min 28 sec and counting JUnit Tests Name: (root)

D7706: Use runtime install prefix instead of compile time install prefix.

dfaure added a comment. QStandardPaths::InstallLocation cannot ever exist, if you mean by that "the install location for KF5" or "the install location for a KF5-based application". How would that work? There could be (at least) 3 different install locations, at least on Unix: one for Qt,

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 22:48:01 + Build duration: 18 min and counting JUnit Tests Name: (root)

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d9c5673c20ea: TransferJob: fix for when the readChannelFinished has already been emitted… (authored by aacid). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

aacid closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: ngraham, nicolasfella, anthonyfieroni, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/38/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Tue, 19 Dec 2017 22:48:01 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 22:48:01 + Build duration: 6 min 21 sec and counting JUnit Tests Name:

D9399: Fix crash, presumably since Qt 5.10?

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ca2364d9c203: Fix crash, presumably since Qt 5.10? (authored by apol). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9399?vs=24103=24130 REVISION DETAIL

D9018: Don't cause circular linking on Windows

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9018 To: leinir, #frameworks, apol Cc: vonreth, cgiboudeaux, alexeymin, apol, #frameworks

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

dfaure added a comment. So the if() is needed, the AFTER isn't enough? I wonder how AFTER works in combination with linking to targets that provide include dirs. This looks all a bit hackish, but I don't have a better suggestion other than this possible simplification. REPOSITORY

D9399: Fix crash, presumably since Qt 5.10?

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9399 To: apol, #frameworks, dfaure Cc: anthonyfieroni, ngraham

D9318: [knewstuff] Limit request cache size

dfaure added a comment. Well, if this QSet can be huge, then these conversions from QList and to QList are going to take a lot of CPU. Are you sure it wouldn't be much faster to do a linear search at append time, in exchange for saving all those temporary-containers conversions? This

D9383: Use correct service executable path for installing kwalletd dbus service on Win32

dfaure accepted this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D9383 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks

D9405: [Uri Filter Search Provider] readName() of KDesktopFile

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Oops :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9405 To: broulik, dfaure Cc: #frameworks

D9018: Don't cause circular linking on Windows

leinir added a comment. Would it be possible to get an accept here, or is there something people fundamentally disagree with about it? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9018 To: leinir, #frameworks Cc: vonreth, cgiboudeaux, alexeymin, apol, #frameworks

D9018: Don't cause circular linking on Windows

vonreth added a comment. +1 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9018 To: leinir, #frameworks Cc: vonreth, cgiboudeaux, alexeymin, apol, #frameworks

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/11/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.7 Date of build: Tue, 19 Dec 2017 15:56:35 + Build duration: 8 min 58 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 15:56:36 + Build duration: 6 min 44 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/11/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 15:56:36 + Build duration: 5 min 30 sec and counting JUnit Tests

D9406: Fix ASAN warning on TestXdgForeign

This revision was automatically updated to reflect the committed changes. Closed by commit R127:b13560ceac59: Fix ASAN warning on TestXdgForeign (authored by davidedmundson). Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland CHANGES

D9407: Scope exported/imported objects to the test

This revision was automatically updated to reflect the committed changes. Closed by commit R127:9121e6897254: Scope exported/imported objects to the test (authored by davidedmundson). Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland

D9407: Scope exported/imported objects to the test

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9407 To: davidedmundson, #plasma,

D9406: Fix ASAN warning on TestXdgForeign

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D9406 To: davidedmundson, #plasma, graesslin Cc:

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/18/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 15:13:40 + Build duration: 4 min 56 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 15:13:40 + Build duration: 1 min 9 sec and counting JUnit Tests

D9324: [Air theme] Add task bar progress graphic

broulik added a comment. > What should be the move here? What do you mean? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.7 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/8/ Project: Frameworks kservice kf5-qt5 SUSEQt5.7 Date of build: Tue, 19 Dec 2017 12:58:15 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/8/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 12:58:15 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 12:58:15 + Build duration: 3 min 23 sec and counting JUnit Tests

D9398: Fix TagLib detection and build on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R320:5e6c6fe0c7a1: Fix TagLib detection and build on Windows (authored by kfunk). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9398?vs=24075=24104 REVISION DETAIL

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 - Build # 66 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/66/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 19 Dec 2017 11:26:55 + Build duration: 1 hr 3 min and counting

D9399: Fix crash, presumably since Qt 5.10?

apol updated this revision to Diff 24103. apol added a comment. One change at a time REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9399?vs=24102=24103 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9399 AFFECTED FILES

D9399: Fix crash, presumably since Qt 5.10?

apol updated this revision to Diff 24102. apol added a comment. Use QIODevice::ReadWrite REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9399?vs=24100=24102 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9399 AFFECTED FILES

D9408: extractors: Hide warnings from system headers

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Also prefer kde_target_enable_exceptions() over the function enabling exceptions globally. REPOSITORY R286 KFileMetaData BRANCH master

D9399: Fix crash, presumably since Qt 5.10?

dfaure added a comment. I wonder if the bug is inside QIODevice::skip, which shouldn't CHECK_READABLE in all cases (only when it's going to fall back to reading). Alternatively we could open the device in ReadWrite mode, no? That might make more sense, for a device that already has some

D9399: Fix crash, presumably since Qt 5.10?

dfaure added a comment. How does that remove the warning from QIODevice::skip, which we're now calling directly instead of indirectly? I don't get it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9399 To: apol, #frameworks, dfaure Cc: anthonyfieroni, ngraham

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 11:40:45 + Build duration: 3 min 46 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/17/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 11:40:45 + Build duration: 2 min 31 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 11:26:55 + Build duration: 14 min and counting JUnit Tests

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

dfaure accepted this revision. dfaure added a comment. This indeed seems more logical than the previous version of the patch. Thanks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: ngraham, nicolasfella,

D9399: Fix crash, presumably since Qt 5.10?

apol updated this revision to Diff 24100. apol added a comment. Use QIODevice::skip instead REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9399?vs=24077=24100 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9399 AFFECTED FILES

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: ngraham, nicolasfella, anthonyfieroni, #frameworks

D9406: Fix ASAN warning on TestXdgForeign

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Internally XdgForeign has some delete laters If we clean

D9407: Scope exported/imported objects to the test

davidedmundson created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY m_imported was parented to the TestForeign class, which lasts for all the tests. This caused an

D9407: Scope exported/imported objects to the test

davidedmundson added a reviewer: Plasma. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D9407 To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9405: [Uri Filter Search Provider] readName() of KDesktopFile

broulik created this revision. broulik added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY In https://phabricator.kde.org/R241:6246cc48067845208cf5acd8b798abd68349cf18 this code was ported away

KDE CI: Frameworks kauth kf5-qt5 WindowsMSVCQt5.9 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20WindowsMSVCQt5.9/17/ Project: Frameworks kauth kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 19 Dec 2017 10:14:55 + Build duration: 3 min 59 sec and counting JUnit Tests

D9332: Allow filter places based on alternative application name

mlaurent added a comment. Not commited ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff, mlaurent Cc: mlaurent, aacid, ngraham, #frameworks

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 08:10:35 + Build duration: 16 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/10/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 08:10:35 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 10 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/10/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.7 Date of build: Tue, 19 Dec 2017 08:10:35 + Build duration: 6 min 3 sec and counting JUnit Tests