D9446: WIP: Allow to autogenerate and install categories file
mlaurent added a comment. IT's a WIP as I use file(APPEND...) because I want to generate several categories in one file. But it doesn't work as I don't have idea how to reset file when cmake is started... Do you have an idea ? I will implement autotest and co if we have a solution for it. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent Cc: #frameworks, #build_system
D9446: WIP: Allow to autogenerate and install categories file
mlaurent created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. TEST PLAN Generate kmail categories file REPOSITORY R240 Extra CMake Modules BRANCH autogenerate_categories_file REVISION DETAIL https://phabricator.kde.org/D9446 AFFECTED FILES modules/ECMQtDeclareLoggingCategory.cmake To: mlaurent Cc: #frameworks, #build_system
D8536: Add more hashing algorithms to KPropertiesDialog
petermajchrak added a comment. I can revert it back to the combobox based layout. Don't we have some UX people that could take a look at this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added inline comments. INLINE COMMENTS > velurimithun wrote in kprocesstest.cpp:93 > These strings are going as arguments for QStringList() method that why I used > QString::FromLatin1() ? QStringLiteral works fine with QStringList REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
velurimithun marked an inline comment as done. velurimithun added inline comments. INLINE COMMENTS > mlaurent wrote in kaboutdatatest.cpp:184 > QStringLiteral doen't work here ? Yeah working, I'll change it > mlaurent wrote in kprocesstest.cpp:93 > QStringLiteral These strings are going as arguments for QStringList() method that why I used QString::FromLatin1() REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added inline comments.
INLINE COMMENTS
> desktoptojsontest.cpp:84
> QByteArray input =
> -// include an insignificant group
> -"[Some Group]\n"
> -"Foo=Bar\n"
> -"\n"
> -"[Desktop Entry]\n"
> -// only data inside [Desktop Entry] should be included
> -"Name=Example\n"
> -//empty lines
> -"\n"
> -" \n"
> -// make sure translations are included:
> -"Name[de_DE]=Beispiel\n"
> -// ignore comments:
> -"#Comment=Comment\n"
> -" #Comment=Comment\n"
> -"Categories=foo;bar;a\\;b\n"
> -// As the case is significant, the keys Name and NAME are not
> equivalent:
> -"CaseSensitive=ABC\n"
> -"CASESENSITIVE=abc\n"
> -// Space before and after the equals sign should be ignored:
> -"SpacesBeforeEq =foo\n"
> -"SpacesAfterEq= foo\n"
> -// Space before and after the equals sign should be ignored; the =
> sign is the actual delimiter.
> -// TODO: error in spec (spaces before and after the key??)
> -" SpacesBeforeKey=foo\n"
> -"SpacesAfterKey =foo\n"
> -// ignore trailing spaces
> -"TrailingSpaces=foo \n"
> -// However spaces in the value are significant:
> -"SpacesInValue=Hello, World!\n"
> -// The escape sequences \s, \n, \t, \r, and \\ are supported for
> values of
> -// type string and localestring, meaning ASCII space, newline, tab,
> -// carriage return, and backslash, respectively:
> -"EscapeSequences=So\\sme esc\\nap\\te sequ\\rences\n" //
> make sure that the last n is a literal n not a newline!
> -// the standard keys that are used by plugins, make sure correct
> types are used:
> -"X-KDE-PluginInfo-Category=Examples\n" // string key
> -"X-KDE-PluginInfo-Version=1.0\n"
> -// The multiple values should be separated by a semicolon and the
> value of the key
> -// may be optionally terminated by a semicolon. Trailing empty
> strings must always
> -// be terminated with a semicolon. Semicolons in these values need
> to be escaped using \;.
> -"X-KDE-PluginInfo-Depends=foo,bar,esc\\,aped\n" // string list
> key
> -"X-KDE-ServiceTypes=\n" // empty string list
> -"X-KDE-PluginInfo-EnabledByDefault=true\n" // bool key
> -// now start a new group
> -"[New Group]\n"
> -"InWrongGroup=true\n";
> +// include an insignificant group
> +"[Some Group]\n"
not necessary to change indentation in this patch.
> desktoptojsontest.cpp:167
> QByteArray kdevInput =
> -"[Desktop Entry]\n"
> -"Type = Service\n"
> -"Icon=text-x-c++src\n"
> -"Exec=blubb\n"
> -"Comment=C/C++ Language Support\n"
> -"Comment[fr]=Prise en charge du langage C/C++\n"
> -"Comment[it]=Supporto al linguaggio C/C++\n"
> -"Name=C++ Support\n"
> -"Name[fi]=C++-tuki\n"
> -"Name[fr]=Prise en charge du C++\n"
> -"GenericName=Language Support\n"
> -"GenericName[sl]=Podpora jeziku\n"
> -"ServiceTypes=KDevelop/NonExistentPlugin\n"
> -"X-KDE-Library=kdevcpplanguagesupport\n"
> -"X-KDE-PluginInfo-Name=kdevcppsupport\n"
> -"X-KDE-PluginInfo-Category=Language Support\n"
> -"X-KDevelop-Version=1\n"
> -"X-KDevelop-Language=C++\n"
> -"X-KDevelop-Args=CPP\n"
> -"X-KDevelop-Interfaces=ILanguageSupport\n"
> -
> "X-KDevelop-SupportedMimeTypes=text/x-chdr,text/x-c++hdr,text/x-csrc,text/x-c++src\n"
> -"X-KDevelop-Mode=NoGUI\n"
> -"X-KDevelop-LoadMode=AlwaysOn";
> +"[Desktop Entry]\n"
> +"Type = Service\n"
don't change indent please
> kaboutdatatest.cpp:184
> QLatin1String("copyright"), QLatin1String("hello world"),
> -"http://www.koffice.org;);
> +QString::fromLatin1("http://www.koffice.org;));
> QCOMPARE(data.organizationDomain(), QString::fromLatin1("koffice.org"));
QStringLiteral doen't work here ?
> kprocesstest.cpp:93
> +p.setShellCommand(QStringLiteral("true || false"));
> +QCOMPARE(p.program(), QStringList() << QString::fromLatin1("/bin/sh") <<
> QString::fromLatin1("-c")
> + << QString::fromLatin1("true || false"));
QStringLiteral
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
velurimithun added a comment. I'm getting errors in processtest!! /home/veluri/Qt/5.9.3/gcc_64/include/QtCore/qstringbuilder.h:357: error: no matching function for call to ‘QConcatenable::appendTo(const char [16], QChar*&)’ QConcatenable::appendTo(p.a, out); ^ same kind of errors at 69, 71, 73 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
velurimithun updated this revision to Diff 24199. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24198=24199 REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES autotests/CMakeLists.txt autotests/desktoptojsontest.cpp autotests/kaboutdataapplicationdatatest.cpp autotests/kaboutdatatest.cpp autotests/kautosavefiletest.cpp autotests/kdelibs4migrationtest.cpp autotests/kformattest.cpp autotests/kpluginfactorytest.cpp autotests/kpluginloadertest.cpp autotests/kpluginmetadatatest.cpp autotests/kprocesstest.cpp autotests/kshelltest.cpp autotests/ktexttohtmltest.cpp autotests/kusertest.cpp autotests/multiplugin.cpp To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. Missing all patch... please see "https://community.kde.org/Infrastructure/Phabricator; "Step 2: Updating your diff. After you upload the code the reviewer will take a look and give you some comments. If you get a thumbs up, you can skip this step. But often you will get a review like "looks good, we can take it if you fix problems x, y, z." After you make your changes, you can add an extra commit to the git branch. $ git add -u $ git commit $ arc diff " REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
velurimithun updated this revision to Diff 24198. velurimithun added a comment. Update the code using QStringLiteral REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24197=24198 REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES autotests/kpluginloadertest.cpp autotests/kprocesstest.cpp To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
velurimithun updated this revision to Diff 24197. velurimithun added a comment. Changes are made using QStringLiteral REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24175=24197 REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES autotests/kpluginloadertest.cpp autotests/kprocesstest.cpp To: velurimithun, mlaurent Cc: #frameworks
D9429: Remove unused and duplicated file
apol added a comment. Yes, I didn't notice, sorry. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9429 To: habacker, dfaure, apol Cc: apol, #frameworks
D8173: Use readelf to find project dependencies
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c91c3650968d: Use readelf to find project dependencies (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8173?vs=24185=24192 REVISION DETAIL https://phabricator.kde.org/D8173 AFFECTED FILES tests/CMakeLists.txt tests/ECMToolchainAndroidTest/CMakeLists.txt tests/ECMToolchainAndroidTest/main.c tests/ECMToolchainAndroidTest/testlinkfile/CMakeFiles/testtarget.dir/link.txt tests/ECMToolchainAndroidTest/testlinkfile/outputfake.json toolchain/Android.cmake toolchain/specifydependencies.cmake To: apol, #frameworks, #build_system, aacid Cc: mart
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
habacker added a comment.
In https://phabricator.kde.org/D9423#181574, @kfunk wrote:
> In https://phabricator.kde.org/D9423#181460, @habacker wrote:
>
> > In https://phabricator.kde.org/D9423#181442, @kfunk wrote:
> >
> > > And I agree. There shouldn't be a need to use two different input
files. That's the whole point of `configure_file(...)`: the interpolation of
values happens *inside* the input files.
> >
> >
> > This would be possible by using in the service file something like this
> >
> > [D-BUS Service]
> > Name=org.kde.kiod5
> > Exec=@SOME_PREFIX@kiod5
>
>
> Sounds good.
>
> In the top-level CMakeLists.txt maybe:
>
> if(WIN32)
>set(DBUS_LIBEXECDIR)
> else()
>set(DBUS_LIBEXECDIR ${KDE_INSTALL_FULL_LIBEXECDIR}/kf5/)
> endif()
>
The service template will then look like
[D-BUS Service]
Name=org.kde.kioexecd
Exec=@DBUS_LIBEXECDIR@kiod5
just saw that for kcookiejar5 another variable is required and the above
mentioned cmake fragment needs to be extended to
if(WIN32)
set(DBUS_LIBEXECDIR)
set(DBUS_BINDIR)
else()
set(DBUS_LIBEXECDIR ${KDE_INSTALL_FULL_LIBEXECDIR}/kf5/)
set(DBUS_BINDIR ${CMAKE_INSTALL_PREFIX}/bin/)
endif()
and src/ioslaves/http/kcookiejar/org.kde.kcookiejar5.service.in looks like
shown below
[D-BUS Service]
Name=org.kde.kcookiejar5
Exec=@DBUS_BINDIR@kded5
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9423
To: habacker, dfaure, bcooksley, kfunk
Cc: apol, kfunk, broulik, #frameworks
D7968: Forward QComboBox signals instead of QComboBox lineedit signals
mwolff updated this revision to Diff 24188. mwolff added a comment. - expand test to non-editable combo box - fix wrong signal connection (regression introduced when ported to QOverload<>::of) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7968?vs=23604=24188 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7968 AFFECTED FILES autotests/kurlrequestertest.cpp src/widgets/kurlrequester.cpp To: mwolff, apol, dfaure Cc: #frameworks
D9429: Remove unused and duplicated file
habacker added a comment. Thanks. BTW: If you had done cd git pull --rebase arc patch --nobranch D9429 git push the related commit would be added to this review by default to indicate that is has been pushed. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9429 To: habacker, dfaure, apol Cc: apol, #frameworks
D9429: Remove unused and duplicated file
habacker added a commit: R268:881aadcec98a: Remove unused, duplicated file. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9429 To: habacker, dfaure, apol Cc: apol, #frameworks
D8173: Use readelf to find project dependencies
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D8173_2 REVISION DETAIL https://phabricator.kde.org/D8173 To: apol, #frameworks, #build_system, aacid Cc: mart
D8173: Use readelf to find project dependencies
apol updated this revision to Diff 24185. apol added a comment. Went to albert's place and figured it out REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8173?vs=22498=24185 BRANCH arcpatch-D8173_2 REVISION DETAIL https://phabricator.kde.org/D8173 AFFECTED FILES tests/CMakeLists.txt tests/ECMToolchainAndroidTest/CMakeLists.txt tests/ECMToolchainAndroidTest/main.c tests/ECMToolchainAndroidTest/testlinkfile/CMakeFiles/testtarget.dir/link.txt tests/ECMToolchainAndroidTest/testlinkfile/outputfake.json toolchain/Android.cmake toolchain/specifydependencies.cmake To: apol, #frameworks, #build_system, aacid Cc: mart
D9442: [kcoredirlister] FIx sub path creation
anthonyfieroni created this revision. anthonyfieroni added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/39/testReport/(root)/TestSuite/kiowidgets_kdirmodeltest/ Tests passes REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9442 AFFECTED FILES src/core/kcoredirlister.cpp To: anthonyfieroni, dfaure Cc: #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
colomar added a comment. With that many available algorithms, the combobox solution makes more sense to me as well. For checking a provided checksum, users don't have to use the combobox, anyway. They just paste in the checksum and get a result automatically. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D8536: Add more hashing algorithms to KPropertiesDialog
petermajchrak added a comment. @anthonyfieroni, @elvisangelaccio, @colomar any progress? just want to get a status... this diff seems to be taking quite a long time to get reviewed after making changes... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kaboutdatatest.cpp:48
>
> -static const char AppName[] ="app";
> -static const char ProgramName[] ="ProgramName";
> -static const char ProgramIconName[] ="program-icon";
> -static const char Version[] ="Version";
> -static const char ShortDescription[] = "ShortDescription";
> -static const char CopyrightStatement[] = "CopyrightStatement";
> -static const char Text[] = "Text";
> -static const char HomePageAddress[] ="http://test.no.where/;;
> -static const char HomePageSecure[] = "https://test.no.where/;;
> -static const char OrganizationDomain[] = "no.where";
> -static const char BugsEmailAddress[] = "b...@no.else";
> -static const char LicenseText[] ="free to write, reading forbidden";
> -static const char LicenseFileName[] ="testlicensefile";
> -static const char LicenseFileText[] ="free to write, reading forbidden,
> in the file";
> +static const QString AppName =QString::fromLatin1("app");
> +static const QString ProgramName =QString::fromLatin1("ProgramName");
no we need to keep const char ...[] and use QString::fromLatin1(...) in method
as it's already done previously
> kautosavefiletest.cpp:83
> {
> -QUrl normalFile =
> QUrl::fromLocalFile(QDir::temp().absoluteFilePath("test directory/tîst
> me.txt"));
> +QUrl normalFile =
> QUrl::fromLocalFile(QDir::temp().absoluteFilePath(QLatin1String("test
> directory/tîst me.txt")));
>
QStringLiteral(...)
> kformattest.cpp:36
>
> -QCOMPARE(format.formatByteSize(0), QString("0 B"));
> -QCOMPARE(format.formatByteSize(50), QString("50 B"));
> -QCOMPARE(format.formatByteSize(500), QString("500 B"));
> -QCOMPARE(format.formatByteSize(5000), QString("4.9 KiB"));
> -QCOMPARE(format.formatByteSize(5), QString("48.8 KiB"));
> -QCOMPARE(format.formatByteSize(50), QString("488.3 KiB"));
> -QCOMPARE(format.formatByteSize(500), QString("4.8 MiB"));
> -QCOMPARE(format.formatByteSize(5000), QString("47.7 MiB"));
> -QCOMPARE(format.formatByteSize(5), QString("476.8 MiB"));
> +QCOMPARE(format.formatByteSize(0), QLatin1String("0 B"));
> +QCOMPARE(format.formatByteSize(50), QLatin1String("50 B"));
QStringLiteral here and others.
> kformattest.cpp:308
> testDate = QDate::currentDate().addDays(-7);
> QCOMPARE(format.formatRelativeDate(testDate, QLocale::LongFormat),
> + QString::fromLatin1("Last
> %1").arg(QLocale::c().dayName(testDate.dayOfWeek(), QLocale::LongFormat)));
QStringLiteral here too
> kpluginfactorytest.cpp:34
> {
> -KPluginLoader multiplugin("multiplugin");
> +KPluginLoader multiplugin(QLatin1String("multiplugin"));
> KPluginFactory *factory = multiplugin.factory();
QStringLiteral(...)
> kpluginmetadatatest.cpp:49
> {
> -QString location = KPluginLoader::findPlugin("jsonplugin");
> +QString location =
> KPluginLoader::findPlugin(QLatin1String("jsonplugin"));
> QVERIFY2(!location.isEmpty(),"Could not find jsonplugin");
Same
> kpluginmetadatatest.cpp:207
> QTest::ignoreMessage(QtWarningMsg, "Expected JSON property
> \"String\" to be a string list. Treating it as a list with a single entry:
> \"foo\" ");
> -QCOMPARE(KPluginMetaData::readStringList(jo, "String"),
> QStringList("foo"));
> -QCOMPARE(KPluginMetaData::readStringList(jo, "OneArrayEntry"),
> QStringList("foo"));
> +QCOMPARE(KPluginMetaData::readStringList(jo,
> QLatin1String("String")), QStringList(QLatin1String("foo")));
> +QCOMPARE(KPluginMetaData::readStringList(jo,
> QLatin1String("OneArrayEntry")), QStringList(QLatin1String("foo")));
Same
> kshelltest.cpp:58
> QString me(KUser().loginName());
> -QCOMPARE(KShell::tildeExpand("~"), QDir::homePath());
> -QCOMPARE(KShell::tildeExpand("~/dir"), QString(QDir::homePath() +
> "/dir"));
> -QCOMPARE(KShell::tildeExpand('~' + me), myHomePath());
> -QCOMPARE(KShell::tildeExpand('~' + me + "/dir"), QString(myHomePath() +
> "/dir"));
> +QCOMPARE(KShell::tildeExpand(QString::fromLatin1("~")),
> QDir::homePath());
> +QCOMPARE(KShell::tildeExpand(QString::fromLatin1("~/dir")),
> QString(QDir::homePath() + QString::fromLatin1("/dir")));
QStringLiteral...
> kshelltest.cpp:84
> #else
> -QCOMPARE(KShell::quoteArg("a space"), QString("'a space'"));
> +QCOMPARE(KShell::quoteArg(QString::fromLatin1("a space")),
> QString::fromLatin1("'a space'"));
> #endif
you can change QString::fromLatin1(...) by QStringLiteral in all code that you
modified
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 21 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/21/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Wed, 20 Dec 2017 17:22:25 + Build duration: 6 min 19 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 24 test(s)
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 23 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Dec 2017 17:22:25 + Build duration: 3 min 9 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 20 Dec 2017 17:22:25 + Build duration: 2 min 23 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest
D9437: Match license keys by spdx
This revision was automatically updated to reflect the committed changes. Closed by commit R244:0d417760a53f: Match license keys by spdx (authored by davidedmundson). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9437?vs=24176=24177 REVISION DETAIL https://phabricator.kde.org/D9437 AFFECTED FILES autotests/kaboutdatatest.cpp src/lib/kaboutdata.cpp src/lib/kaboutdata.h To: davidedmundson, apol Cc: #frameworks
D9437: Match license keys by spdx
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9437 To: davidedmundson, apol Cc: #frameworks
D9437: Match license keys by spdx
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KAboutLicense supports exporting a license as an spdx ID. (https://spdx.org/licenses/) However the KAboutLicense::fromKeyword doesn't match We have a lot of metadata where people are using the spdx id rather than the somewhat arbitrary keyword format that KAboutLicense expects. This adds a unit test to make sure all supported license keys match up then expands the keyword list. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9437 AFFECTED FILES autotests/kaboutdatatest.cpp src/lib/kaboutdata.cpp src/lib/kaboutdata.h To: davidedmundson Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
velurimithun updated this revision to Diff 24175. velurimithun added a comment. - use QLating1String REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24143=24175 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES autotests/CMakeLists.txt autotests/desktoptojsontest.cpp autotests/kaboutdataapplicationdatatest.cpp autotests/kaboutdatatest.cpp autotests/kautosavefiletest.cpp autotests/kdelibs4migrationtest.cpp autotests/kformattest.cpp autotests/kpluginfactorytest.cpp autotests/kpluginmetadatatest.cpp autotests/kshelltest.cpp autotests/ktexttohtmltest.cpp autotests/kusertest.cpp autotests/multiplugin.cpp To: velurimithun, mlaurent Cc: #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
apol added a comment.
In https://phabricator.kde.org/D9423#181574, @kfunk wrote:
> In https://phabricator.kde.org/D9423#181460, @habacker wrote:
>
> > In https://phabricator.kde.org/D9423#181442, @kfunk wrote:
> >
> > > And I agree. There shouldn't be a need to use two different input
files. That's the whole point of `configure_file(...)`: the interpolation of
values happens *inside* the input files.
> >
> >
> > This would be possible by using in the service file something like this
> >
> > [D-BUS Service]
> > Name=org.kde.kiod5
> > Exec=@SOME_PREFIX@kiod5
>
>
> Sounds good.
>
> In the top-level CMakeLists.txt maybe:
>
> if(WIN32)
>set(DBUS_LIBEXECDIR)
> else()
>set(DBUS_LIBEXECDIR ${KDE_INSTALL_FULL_LIBEXECDIR}/kf5/)
> endif()
>
>
> ... and then use that everywhere needed.
+1
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9423
To: habacker, dfaure, bcooksley, kfunk
Cc: apol, kfunk, broulik, #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
kfunk added a comment.
In https://phabricator.kde.org/D9423#181460, @habacker wrote:
> In https://phabricator.kde.org/D9423#181442, @kfunk wrote:
>
> > And I agree. There shouldn't be a need to use two different input files.
That's the whole point of `configure_file(...)`: the interpolation of values
happens *inside* the input files.
>
>
> This would be possible by using in the service file something like this
>
> [D-BUS Service]
> Name=org.kde.kiod5
> Exec=@SOME_PREFIX@kiod5
Sounds good.
In the top-level CMakeLists.txt maybe:
if(WIN32)
set(DBUS_LIBEXECDIR)
else()
set(DBUS_LIBEXECDIR ${KDE_INSTALL_FULL_LIBEXECDIR}/kf5/)
endif()
... and then use that everywhere needed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9423
To: habacker, dfaure, bcooksley, kfunk
Cc: kfunk, broulik, #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
kfunk added a comment. @dfaure Opinions? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: kfunk, broulik, #frameworks
D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'
kfunk added a comment. Please let's discuss on https://phabricator.kde.org/D9423 exclusively. This is basically fixing the same issue in a different repository. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: kfunk, vonreth, #windows, apol, #frameworks
D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH arcpatch-D9404 REVISION DETAIL https://phabricator.kde.org/D9404 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'
apol added subscribers: vonreth, kfunk. apol added a comment. @kfunk, @vonreth Will craft applications also benefit from this? Or is it solved in a different way there? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: kfunk, vonreth, #windows, apol, #frameworks
D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'
apol added a subscriber: Windows. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: #windows, apol, #frameworks
D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'
habacker marked an inline comment as done. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: apol, #frameworks
D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'
habacker updated this revision to Diff 24168. habacker added a comment. - added note REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9424?vs=24148=24168 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9424 AFFECTED FILES src/runtime/CMakeLists.txt src/runtime/org.kde.kglobalaccel.service.win.in To: habacker, dfaure, bcooksley, apol Cc: apol, #frameworks
D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'
habacker added a comment. I stumbled over one issue case and did a quick search which locations are also affected by this issue type. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: apol, #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
velurimithun retitled this revision from "Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)" to "Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9421: Remove anchient and broken workaround
This revision was automatically updated to reflect the committed changes. Closed by commit R246:d10d613b33ab: Remove anchient and broken workaround (authored by vonreth). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9421?vs=24145=24164 REVISION DETAIL https://phabricator.kde.org/D9421 AFFECTED FILES src/plugins/aspell/CMakeLists.txt src/plugins/aspell/aspellclient.cpp src/plugins/aspell/aspelldict.cpp To: vonreth, #frameworks, #craft, leinir, apol Cc: apol, #frameworks
D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Wait, why is this needed all of a sudden? Aren't these services used in the rest of win32 applications we have available in https://binary-factory.kde.org/? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: apol, #frameworks
D9429: Remove unused and duplicated file
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Sorry I just saw it and went ahead. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9429 To: habacker, dfaure, apol Cc: apol, #frameworks
D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:66
>
> -configure_file(org.kde.kglobalaccel.service.in
> - ${CMAKE_CURRENT_BINARY_DIR}/org.kde.kglobalaccel.service)
> +if(WIN32)
> +configure_file(org.kde.kglobalaccel.service.win.in
I would add here `#we need a relocatable kglobalaccel5 executable for WIN32`
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9424
To: habacker, dfaure, bcooksley, apol
Cc: apol, #frameworks
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Dec 2017 12:19:43 + Build duration: 7 min 7 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.
habacker added a comment. In https://phabricator.kde.org/D5175#181288, @bcooksley wrote: > I still question how these installs conflict - as all the scenarios where they could conflict should already be taken into account: > > 1. Linux distros, FreeBSD, etc have no co-installability issues here > 2. Windows installs should be one prefix per application, which means KF5 and KDE 4 installs should never collide > 3. macOS is basically the same as Windows, only difference being it's a .app bundle instead > > Can you provide some background please Ralf? see below > Note that the CI already has native Umbrello builds for Windows so cross compilation shouldn't be required. Relating to the jenkins based system: How can I check build internals in case of hidden build issues ? From my 16 year porting KDE experience (https://en.wikipedia.org/wiki/KDE_on_Cygwin) - because of the number of related packages, build systems and possible configuration - this is required often and could not be provided by a build log. You need to inspect for example cmake generated files like include_cxx.rsp which contains the used include directories (a real world example is https://phabricator.kde.org/D9404) Therefore I'm using obs build service. After installing osc (https://en.opensuse.org/openSUSE:OSC) on a linux machine, I run osc co home:rhabacker:branches:windows:mingw:win32:KF541/mingw32-kio cd home:rhabacker:branches:windows:mingw:win32:KF541/mingw32-kio osc build In case of errors I run osc chroot to enter the chrooted build environment to enter package source dir I enter cd /home/abuild/rpmbuild/BUILD/kio-5.41.0 to enter package source dir I use cd /home/abuild/rpmbuild/BUILD/kio-5.41.0/build to continue broken build I run cd /home/abuild/rpmbuild/BUILD/kio-5.41.0/build make I can edit files, clean builds, restart build, make patches to fix issues in build system and so one Doe KDE CI provide shell access to the complete build infrastructure like installed 3rdparty packages, source and build files ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5175 To: habacker, dfaure, ltoscano, bcooksley Cc: cgiboudeaux, #frameworks
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Dec 2017 12:12:39 + Build duration: 7 min 3 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
D9421: Remove anchient and broken workaround
leinir accepted this revision. leinir added a comment. Ha, yes, i concur with Aleix there, workaround-be-gone! ;) (i have a suspicion the reason i thought this worked before is because i was testing on my local machine... which also explains nicely why the packages from BF don't have functioning spell checking for me ;) ) REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D9421 To: vonreth, #frameworks, #craft, leinir, apol Cc: apol, #frameworks
D9421: Remove anchient and broken workaround
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. How cool is it to remove workarounds? :) REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D9421 To: vonreth, #frameworks, #craft, leinir, apol Cc: apol, #frameworks
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 12 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/12/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 20 Dec 2017 12:12:49 + Build duration: 1 min 17 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 22 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/22/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Wed, 20 Dec 2017 12:12:49 + Build duration: 1 min 16 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 21 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/21/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Wed, 20 Dec 2017 12:05:09 + Build duration: 7 min 38 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/19/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Dec 2017 12:05:09 + Build duration: 7 min 29 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 20 Dec 2017 12:08:09 + Build duration: 1 min 18 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 20 Dec 2017 12:05:09 + Build duration: 1 min 31 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
habacker added a comment.
In https://phabricator.kde.org/D9423#181442, @kfunk wrote:
> And I agree. There shouldn't be a need to use two different input files.
That's the whole point of `configure_file(...)`: the interpolation of values
happens *inside* the input files.
This would be possible by using in the service file something like this
[D-BUS Service]
Name=org.kde.kiod5
Exec=@SOME_PREFIX@kiod5
and in CMakeLists.txt
if(WIN32)
set(SOME_PREFIX)
else()
set(SOME_PREFIX ${KDE_INSTALL_FULL_LIBEXECDIR}/kf5/)
endif()
configure_file(org.kde.kiod5.service.in
${CMAKE_CURRENT_BINARY_DIR}/org.kde.kiod5.service)
Any problem with this ?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9423
To: habacker, dfaure, bcooksley, kfunk
Cc: kfunk, broulik, #frameworks
D9386: Mingw32 compile fix
habacker added a comment. In https://phabricator.kde.org/D9386#181297, @dfaure wrote: > That's trivial, isn't it? Rename networking.cpp to networking_unix.cpp, and move to networking.cpp the methods that are platform-independent. Any idea how to share the line Q_GLOBAL_STATIC(Solid::NetworkingPrivate, globalNetworkManager) between platform independent, unix and windows related file. globalNetworkManager is required by all three files ? REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9386 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. And I agree. There shouldn't be a need to use two different input files. That's the whole point of `configure_file(...)` the interpolation of values happens *inside* the input files. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: kfunk, broulik, #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
kfunk added a comment. Could you please squash the commits and just keep this review for all the changes in KIO? Doesn't make sense to have different Phab Diffs for that (makes it harder to review, harder to revert in case, etc.). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley Cc: kfunk, broulik, #frameworks
D9348: Handle positions of LMB clicks on legacy systray icons
This revision was automatically updated to reflect the committed changes. Closed by commit R289:b5e43439386e: Handle positions of LMB clicks on legacy systray icons (authored by volkov). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9348?vs=23963=24159 REVISION DETAIL https://phabricator.kde.org/D9348 AFFECTED FILES src/kstatusnotifieritem.cpp To: volkov, #frameworks, mck182 Cc: ngraham, alexeymin, #frameworks
D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"
habacker updated this revision to Diff 24158. habacker added a comment. - removed unrelated AFTER parameter REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9404?vs=24090=24158 BRANCH arcpatch-D9404 REVISION DETAIL https://phabricator.kde.org/D9404 AFFECTED FILES src/CMakeLists.txt To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D8173: Use readelf to find project dependencies
mart added a comment. here the change works perfectly.. right now, we have building on android broken for everybody, since months, this is not acceptable :/ REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8173 To: apol, #frameworks, #build_system, aacid Cc: mart
D9429: Remove unused and duplicated file
habacker created this revision. habacker added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This file is a duplicate of the same file one directory level above and is not used by the build system REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9429 AFFECTED FILES src/runtime/dbus/org.kde.kglobalaccel.service.in To: habacker, dfaure Cc: #frameworks
D9428: Fix 'Exec line in kcookiejar service file must not have any path prefix on Windows'
habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:388059 FIXED-IN:5.42.0 TEST PLAN cross compiled REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9428 AFFECTED FILES src/ioslaves/http/kcookiejar/CMakeLists.txt src/ioslaves/http/kcookiejar/org.kde.kcookiejar5.service.win.in To: habacker, dfaure, bcooksley Cc: #frameworks
D9427: Fix 'Exec line in kpasswdserver service file must not have any path prefix on Windows'
habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:388060 FIXED-IN:5.42.0 TEST PLAN cross compiled REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9427 AFFECTED FILES src/kpasswdserver/CMakeLists.txt src/kpasswdserver/org.kde.kpasswdserver.service.win.in To: habacker, dfaure, bcooksley Cc: #frameworks
D9426: Fix 'Exec line in kssld service file must not have any path prefix on Windows'
habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:388063 FIXED-IN:5.42.0 TEST PLAN cross compiled REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9426 AFFECTED FILES src/kssld/CMakeLists.txt src/kssld/org.kde.kssld5.service.win.in To: habacker, dfaure, bcooksley Cc: #frameworks
D9290: [kio] Fix create path
dfaure added inline comments.
INLINE COMMENTS
> dfaure wrote in pathhelpers_p.h:31
> It seems to me that path2 cannot start with '/', by contract. It's supposed
> to be relative.
> So I'd say we could even be foolish^H^H^H^Hbrave and make that
>
> Q_ASSERT(!path2.startsWith('/'));
The assert hits during KDirModelTest, says CI. Can you take a look?
QFATAL : KDirModelTest::testRenameDirectory() ASSERT:
"!path2.startsWith(QLatin1Char('/'))" in file
/home/jenkins/workspace/Frameworks kio kf5-qt5
SUSEQt5.10/src/core/../pathhelpers_p.h, line 31
https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/39/testReport/(root)/TestSuite/kiowidgets_kdirmodeltest/
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9290
To: anthonyfieroni, #frameworks, dfaure, hein, aacid
D9425: Fix 'Exec line in kioexecd service file must not have any path prefix on Windows'
habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:388062 FIXED-IN:5.42.0 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9425 AFFECTED FILES src/kioexec/CMakeLists.txt src/kioexec/org.kde.kioexecd.service.win.in To: habacker, dfaure, bcooksley Cc: #frameworks
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/39/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Dec 2017 10:08:19 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 40 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/40/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 20 Dec 2017 10:08:19 + Build duration: 9 min 1 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 20 Dec 2017 10:08:19 + Build duration: 7 min 46 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirmodeltest
D7642: [ksycoca] Use QDateTime::currentDateTimeUtc
broulik abandoned this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D7642 To: broulik, kde-frameworks-devel, dfaure Cc: dfaure, #frameworks
D9018: Don't cause circular linking on Windows
This revision was automatically updated to reflect the committed changes. Closed by commit R246:bdc6562faf73: Dont cause circular linking on Windows (authored by leinir). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9018?vs=23028=24150 REVISION DETAIL https://phabricator.kde.org/D9018 AFFECTED FILES src/plugins/aspell/CMakeLists.txt src/plugins/enchant/CMakeLists.txt src/plugins/hspell/CMakeLists.txt src/plugins/hunspell/CMakeLists.txt src/plugins/nsspellchecker/CMakeLists.txt src/plugins/voikko/CMakeLists.txt To: leinir, #frameworks, apol Cc: vonreth, cgiboudeaux, alexeymin, apol, #frameworks
D9405: [Uri Filter Search Provider] readName() of KDesktopFile
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8a32c8c4aeb9: [Uri Filter Search Provider] readName() of KDesktopFile (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9405?vs=24097=24149 REVISION DETAIL https://phabricator.kde.org/D9405 AFFECTED FILES src/urifilters/ikws/searchprovider.cpp To: broulik, dfaure Cc: #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
broulik added a comment. Is it possible to move that logic into the `.in` file instead of changing the cmake file? Just asking, I don't know cmake well. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley Cc: broulik, #frameworks
D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'
habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:382460 FIXED-IN:5.42.0 TEST PLAN cross compiled REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9424 AFFECTED FILES src/runtime/CMakeLists.txt src/runtime/org.kde.kglobalaccel.service.win.in To: habacker, dfaure, bcooksley Cc: #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:382459 FIXED-IN:5.42.0 TEST PLAN cross compiled REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9423 AFFECTED FILES src/kiod/CMakeLists.txt src/kiod/org.kde.kiod5.service.win.in To: habacker, dfaure, bcooksley Cc: #frameworks
Using KWallet from non-KDE apps (G.Chrome...)
Hi, Is it still possible to query a KWallet for the existence of specific credentials without having to unlock it first? The reason I'm asking (not entirely on-topic here, apologies) is that Google Chrome has been putting up wallet unlock dialogs for a long time now, apparently as soon as it detects a login/authentification mechanism on a page that just got (re)loaded. I've filed a bug report about that (a long time ago), but it never got picked up or even closed as invalid. Thanks, R.
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
mlaurent added a comment. Arguiment from method use QString and not QLatin1String() QString::fromLatin1 returns a QString REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
mlaurent added a comment. KAboutData aboutData2(QString::fromLatin1(AppName2), QString::fromLatin1(ProgramName2), QString::fromLatin1(Version2)); use QString::fromLatin1 is will work REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9386: Mingw32 compile fix
habacker edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9386 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
velurimithun added a comment. /home/veluri/ruqola_dep/kcoreaddons/autotests/kaboutdataapplicationdatatest.cpp:72: error: request for member ‘setOrganizationDomain’ in ‘aboutData2’, which is of non-class type ‘KAboutData(QLatin1String, QLatin1String, QLatin1String)’ aboutData2.setOrganizationDomain(OrganizationDomain2); ^ /home/veluri/ruqola_dep/kcoreaddons/autotests/kaboutdataapplicationdatatest.cpp:73: error: request for member ‘setDesktopFileName’ in ‘aboutData2’, which is of non-class type ‘KAboutData(QLatin1String, QLatin1String, QLatin1String)’ aboutData2.setDesktopFileName(QLatin1String(DesktopFileName2)); ^ /home/veluri/ruqola_dep/kcoreaddons/autotests/kaboutdataapplicationdatatest.cpp:75: error: no matching function for call to ‘KAboutData::setApplicationData(KAboutData (&)(QLatin1String, QLatin1String, QLatin1String))’ KAboutData::setApplicationData(aboutData2); ^ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
mlaurent requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
mlaurent added a comment. Could you paste you compile error here please. INLINE COMMENTS > CMakeLists.txt:1 > -remove_definitions(-DQT_NO_CAST_FROM_ASCII) > +#remove_definitions(-DQT_NO_CAST_FROM_ASCII) > Better to remove it. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9421: Remove anchient and broken workaround
vonreth added reviewers: Frameworks, Craft, leinir. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9421 To: vonreth, #frameworks, #craft, leinir Cc: #frameworks
D9421: Remove anchient and broken workaround
vonreth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The Craft version of aspell is relocatable and this hack is not REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D9421 AFFECTED FILES src/plugins/aspell/CMakeLists.txt src/plugins/aspell/aspellclient.cpp src/plugins/aspell/aspelldict.cpp To: vonreth Cc: #frameworks
D9318: [knewstuff] Limit request cache size
anthonyfieroni added a comment. In https://phabricator.kde.org/D9318#181202, @dfaure wrote: > Well, if this QSet can be huge, then these conversions from QList and to QList are going to take a lot of CPU. > Are you sure it wouldn't be much faster to do a linear search at append time, in exchange for saving all those temporary-containers conversions? Let's do it linear, for now. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9318 To: anthonyfieroni, leinir, #frameworks Cc: dfaure, broulik
D9318: [knewstuff] Limit request cache size
anthonyfieroni updated this revision to Diff 24144. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9318?vs=23934=24144 REVISION DETAIL https://phabricator.kde.org/D9318 AFFECTED FILES src/core/cache.cpp To: anthonyfieroni, leinir, #frameworks Cc: dfaure, broulik
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
velurimithun added a comment. Errors in Kaboutdataappplicationdatatest file REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
velurimithun created this revision. velurimithun added a reviewer: mlaurent. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN Use QStringLiteral or QLatin1String for normal strings REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES autotests/CMakeLists.txt autotests/desktoptojsontest.cpp autotests/kaboutdataapplicationdatatest.cpp autotests/kdelibs4migrationtest.cpp To: velurimithun, mlaurent Cc: #frameworks
