KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Dec 2017 03:54:36 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 03:54:36 + Build duration: 8 min 58 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 47 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/47/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 23 Dec 2017 03:54:36 + Build duration: 6 min 7 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.testtrash
KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/12/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Dec 2017 03:14:46 + Build duration: 4 min 33 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest
D8371: Support for underscores in numeric literals (Python 3.6)
januz added a comment. Thanks for the tips guys! This patch still has two problems (that I'm aware :) ): - I can't get it to match the dot in the float regex. The regex itself is ok (https://regexr.com/3idtj), but it just doesn't work. - The regexes don't work inside lists or dictionaries. I've noticed highlighting for complex numbers doesn't work either though, so it might not be related to this patch. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8371 To: januz, #kate Cc: dhaumann, cullmann, #frameworks, genethomas, vkrause
D8371: Support for underscores in numeric literals (Python 3.6)
januz updated this revision to Diff 24317. januz added a comment. - Tweaked regexes to fit better with the other regex in the file - Version bump - Added autotests and updated references REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8371?vs=20991=24317 BRANCH python_separators REVISION DETAIL https://phabricator.kde.org/D8371 AFFECTED FILES autotests/folding/test.py.fold autotests/html/test.py.html autotests/input/test.py autotests/reference/test.py.ref data/syntax/python.xml To: januz, #kate Cc: dhaumann, cullmann, #frameworks, genethomas, vkrause
D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'
cgiboudeaux added inline comments.
INLINE COMMENTS
> KF5DBusAddonsMacros.cmake:4
> +#
> +# kdbusaddons_generate_dbus_service_file(executable name path)
> +#
kdbusaddons_generate_dbus_service_file(EXECUTABLE NAME PATH) to improve the
readability.
Please also document each parameter.
> KF5DBusAddonsMacros.cmake:6
> +#
> +# This function generates a dbus service file and installs it
> +# into the specified destination.
D-Bus
> KF5DBusAddonsMacros.cmake:9
> +#
> +# On Windows the path is not used because dbus service executables
> +# are always installed in the same directory as dbus-daemon.
D-Bus
> KF5DBusAddonsMacros.cmake:14
> +#
> +# kdbusaddons_generate_dbus_service_file(kded5 org.kde.kded5
> ${CMAKE_INSTALL_PATH}/bin)
> +#
${KDE_INSTALL_FULL_BINDIR}
> KF5DBusAddonsMacros.cmake:23
> +else()
> +set(EXEC ${_path}/${_executable})
> +endif()
You don't check whether _path is absolute. This shall return an error.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D9480
To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks
D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
habacker updated this revision to Diff 24312. habacker added a comment. - remove obsolate service template REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9482?vs=24311=24312 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9482 AFFECTED FILES src/CMakeLists.txt src/org.kde.kded5.service.in To: habacker, dfaure, kfunk Cc: #frameworks
D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'
habacker added a reviewer: kfunk. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D9480 To: habacker, dfaure, kfunk Cc: #frameworks
D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
habacker created this revision. habacker added reviewers: dfaure, kfunk. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN compiled against kdbusaddons development package with related support REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D9482 AFFECTED FILES src/CMakeLists.txt To: habacker, dfaure, kfunk Cc: #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
habacker added a comment. see https://phabricator.kde.org/D9480 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks
D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'
habacker created this revision. habacker added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This function is added to hide platform-specific implementation details when creating dbus service files. TEST PLAN - compiled and installed on unix - build patched kded sorce with this support - Files on windows are created as expected REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9480 AFFECTED FILES CMakeLists.txt KF5DBusAddonsConfig.cmake.in KF5DBusAddonsMacros.cmake dbus.service.in To: habacker, dfaure Cc: #frameworks
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
habacker added a comment. All mentioned git repos are using KDBusAddons as dependency. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 22 Dec 2017 16:15:16 + Build duration: 41 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 22 Dec 2017 15:58:24 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Dec 2017 15:58:24 + Build duration: 4 min 37 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 23 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/23/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Fri, 22 Dec 2017 15:58:24 + Build duration: 1 min 34 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
dfaure added a comment. Can you check if all the frameworks where this would be needed, have kdbusaddons as a dependency? That would certainly be a better option indeed, we already have frameworks providing cmake macros, which keeps things more modular (and keeps ECM more generic for other cmake users...). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 22 Dec 2017 10:18:13 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Dec 2017 10:18:13 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 39 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/39/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Fri, 22 Dec 2017 10:18:13 + Build duration: 9 min 9 sec and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
D9324: [Air theme] Add task bar progress graphic
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3889edd6d6e5: [Air theme] Add task bar progress graphic (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9324?vs=23895=24280#toc REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9324?vs=23895=24280 REVISION DETAIL https://phabricator.kde.org/D9324 AFFECTED FILES src/desktoptheme/air/metadata.desktop src/desktoptheme/air/widgets/tasks.svgz To: broulik, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'
habacker added a comment.
In https://phabricator.kde.org/D9423#182022, @habacker wrote:
> 1. install dbus service file
installing the service file requires a KDE specific path,
${KDE_INSTALL_DBUSSERVICEDIR}, so a KF5 related name seems to be more
descriptive
function(kf5_generate_dbus_service_file _executable _name _path)
set(_file ${CMAKE_CURRENT_BINARY_DIR}/${_name}.service)
set(_template ${CMAKE_CURRENT_LIST_FILE}/KF5DBusServiceTemplate.in)
set(NAME ${_name})
if(WIN32)
set(EXEC ${_executable})
else()
set(EXEC ${_path}/${_executable})
endif()
configure_file(${_template} ${_file})
install(FILES ${_file} DESTINATION ${KDE_INSTALL_DBUSSERVICEDIR})
endfunction()
where KF5DBusServiceTemplate.in looks as
[D-BUS Service]
Name=@NAME@
Exec=@EXEC@
and may be better located in the kdbusaddons repo instead of
extra-cmake-modules ? What is prefered ?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9423
To: habacker, dfaure, bcooksley, kfunk
Cc: apol, kfunk, broulik, #frameworks
