D7660: Fix a regression caused by changing backspace key behavior
safaalfulaij updated this revision to Diff 24349. safaalfulaij added a comment. Fix compilation issues REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=24338&id=24349 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7660 AFFECTED FILES autotests/src/katedocument_test.cpp src/document/katedocument.cpp To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, cullmann Cc: brauch, mwolff, ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 24 Dec 2017 03:49:50 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/48/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Dec 2017 03:49:50 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 49 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/49/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 24 Dec 2017 03:49:50 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.testtrash
D7660: Fix a regression caused by changing backspace key behavior
brauch reopened this revision.
brauch added inline comments.
INLINE COMMENTS
> katedocument_test.cpp:452
> auto view =
> static_cast(doc.createView(nullptr));
> +view.config()->setBackspaceRemoveComposed(true);
> doc.setText(QString::fromUtf8("व्यक्तियों"));
must be view->config ... how did this patch ever compile for you??
> katedocument.cpp:3190
> +}
> +if (!config()->backspaceIndents() || pos) {
> +KTextEditor::Cursor beginCursor(line, 0);
pos is not defined at this place
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7660
To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, cullmann
Cc: brauch, mwolff, ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann,
hein, kwrite-devel, #frameworks
D7660: Fix a regression caused by changing backspace key behavior
brauch added a comment. After this was submitted master doesn't compile for me, and if I fix the compile in the trivial way the test fails. Can you have another look? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, cullmann Cc: brauch, mwolff, ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks
D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
habacker updated this revision to Diff 24345. habacker added a comment. - use KDE_INSTALL_FULL_BINDIR instead of CMAKE_INSTALL_PREFIX REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9482?vs=24312&id=24345 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9482 AFFECTED FILES src/CMakeLists.txt src/org.kde.kded5.service.in To: habacker, dfaure, kfunk Cc: #frameworks
D9494: Highlighting indexer: Warn about empty attributes
dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch extends the highlighting indexer to search for attribute="". Referencing an empty attribute is most likely an error. In fact, this check finds one issue, and one false positive. Still, it's better to fix it properly to ensure conformance. TEST PLAN make test REPOSITORY R216 Syntax Highlighting BRANCH CheckEmptyAttribute (branched from master) REVISION DETAIL https://phabricator.kde.org/D9494 AFFECTED FILES data/syntax/d.xml data/syntax/puppet.xml src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause Cc: #frameworks
D9493: Highlighting indexer: Warn about context switch fallthroughContext="#stay"
dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY A fallthroughContext="#stay" is always wrong if fallthrough="true" is set, since in this case we risk an infinite loop. This patch extends the indexer to check for this mistakes. Luckily, this mistake does not exist in the definition files shipped with the KSyntaxHighlighting framework. TEST PLAN make test, manual testing with fallthroughContext="#stay" REPOSITORY R216 Syntax Highlighting BRANCH InvalidFallthroughContext (branched from master) REVISION DETAIL https://phabricator.kde.org/D9493 AFFECTED FILES src/indexer/katehighlightingindexer.cpp To: dhaumann, vkrause, cullmann Cc: #frameworks
D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
dfaure added a comment. Indeed that was a bug in the .in files, arguably. The executables get installed into KDE_INSTALL_BINDIR (says kde-modules/KDEInstallDirs.cmake), so if we want the full path version of it, it should be KDE_INSTALL_FULL_BINDIR. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D9482 To: habacker, dfaure, kfunk Cc: #frameworks
D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
habacker added a comment. I can update the patch with this path if you want. It came from the service template file Exec=@CMAKE_INSTALL_PREFIX@/bin/kded5 REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D9482 To: habacker, dfaure, kfunk Cc: #frameworks
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 10 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 19:37:23 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated 147.84 KB...]Generating MOC source DUXJVKIIEO/moc_kateundomanager.cppGenerating MOC source 7HEHEGDA3T/moc_kateautoindent.cppGenerating MOC source 7HEHEGDA3T/moc_katebookmarks.cppGenerating MOC source 7HEHEGDA3T/moc_kateglobal.cppGenerating MOC source 7HEHEGDA3T/moc_katetemplatehandler.cppGenerating MOC source RTEFPIXYSN/moc_katehelpbutton.cppGenerating MOC source RTEFPIXYSN/moc_variableeditor.cppGenerating MOC source RTEFPIXYSN/moc_variablelineedit.cppGenerating MOC source RTEFPIXYSN/moc_variablelistview.cppGenerating MOC source OTUN7GXZT4/moc_kateanimation.cppGenerating MOC source OTUN7GXZT4/moc_katefadeeffect.cppGenerating MOC source OTUN7GXZT4/moc_katemessagewidget.cppGenerating MOC source OTUN7GXZT4/moc_katestatusbar.cppGenerating MOC source OTUN7GXZT4/moc_katetextanimation.cppGenerating MOC source OTUN7GXZT4/moc_katetextpreview.cppGenerating MOC source OTUN7GXZT4/moc_kateview.cppGenerating MOC source OTUN7GXZT4/moc_kateviewhelpers.cppGenerating MOC source OTUN7GXZT4/moc_kateviewinternal.cppGenerating MOC source OTUN7GXZT4/moc_wordcounter.cppGenerating MOC source VQRUSF47MT/moc_appcommands.cppGenerating MOC source IIR25LHTFA/moc_configtab.cppGenerating MOC source M2DJSLDKSG/moc_emulatedcommandbar.cppGenerating MOC source M2DJSLDKSG/moc_matchhighlighter.cppGenerating MOC source VQRUSF47MT/moc_keymapper.cppGenerating MOC source VQRUSF47MT/moc_marks.cppGenerating MOC source 7WFH7WAJAT/moc_insertvimode.cppGenerating MOC source 7WFH7WAJAT/moc_modebase.cppGenerating MOC source 7WFH7WAJAT/moc_normalvimode.cppGenerating MOC source 7WFH7WAJAT/moc_visualvimode.cppGenerating MOC compilation mocs_compilation.cpp[ 4%] Built target KF5TextEditor_autogen[ 4%] Generating ui_textareaappearanceconfigwidget.h[ 5%] Generating ui_bordersappearanceconfigwidget.h[ 5%] Generating ui_commandmenuconfigwidget.h[ 5%] Generating ui_commandmenueditwidget.h[ 5%] Generating ui_completionconfigtab.h[ 5%] Generating ui_configwidget.h[ 5%] Generating ui_navigationconfigwidget.h[ 5%] Generating ui_editconfigwidget.h[ 6%] Generating ui_filetypeconfigwidget.h[ 6%] Generating ui_indentationconfigwidget.h[ 6%] Generating ui_opensaveconfigwidget.h[ 7%] Generating ui_opensaveconfigadvwidget.h[ 7%] Generating ui_completionconfigwidget.h[ 7%] Generating ui_searchbarincremental.h[ 7%] Generating ui_searchbarpower.h[ 8%] Generating ui_spellcheckbar.h[ 8%] Generating ui_spellcheckconfigwidget.h[ 8%] Generating ui_howtoimportschema.hScanning dependencies of target KF5TextEditor[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.o[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionconfig.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingtree.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/katedialogs.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katedocument.cpp.o[ 15%] Building CXX object sr
KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 - Build # 68 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/68/
Project:
Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sat, 23 Dec 2017 19:37:23 +
Build duration:
6 min 3 sec and counting
CONSOLE OUTPUT
[...truncated 165.01 KB...]./src/%{APPNAMELC}view.h./src/CMakeLists.txt./src/Messages.sh[ 2%] Built target ktexteditor-plugin[ 2%] Generating ui_textareaappearanceconfigwidget.h[ 2%] Generating ui_bordersappearanceconfigwidget.h[ 2%] Generating ui_commandmenuconfigwidget.h[ 3%] Generating ui_commandmenueditwidget.h[ 2%] Generating ui_completionconfigtab.h[ 2%] Generating ui_navigationconfigwidget.h[ 3%] Generating ui_editconfigwidget.h[ 4%] Generating ui_filetypeconfigwidget.h[ 4%] Generating ui_indentationconfigwidget.h[ 5%] Generating ui_opensaveconfigwidget.h[ 5%] Generating ui_opensaveconfigadvwidget.h[ 5%] Generating ui_completionconfigwidget.h[ 5%] Generating ui_searchbarincremental.h[ 5%] Generating ui_searchbarpower.h[ 6%] Generating ui_spellcheckbar.h[ 6%] Generating ui_spellcheckconfigwidget.h[ 6%] Generating ui_howtoimportschema.h[ 6%] Generating ui_configwidget.hScanning dependencies of target KF5TextEditor[ 7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.obj[ 7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.obj[ 7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.obj[ 7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.objkatesecuretextbuffer.cpp[ 8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.obj[ 8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.obj[ 8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.obj[ 8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.objkatetextline.cppkatetextbuffer.cppkatetextblock.cppkatecompletionwidget.cppkatetextcursor.cppkatetextrange.cppkatetexthistory.cppkatetextfolding.cpp[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.objkatecompletionmodel.cpp[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.objkatecompletiontree.cpp[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.objkateargumenthinttree.cpp[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.obj[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.objkateargumenthintmodel.cppkatecompletiondelegate.cpp[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.objexpandingwidgetmodel.cpp[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.objexpandingdelegate.cpp[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingtree.cpp.objexpandingtree.cpp[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.objkatewordcompletion.cpp[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.objkatekeywordcompletion.cpp[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.objkateconfigpage.cpp[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katedocument.cpp.objkatedocument.cpp[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katebuffer.cpp.objkatebuffer.cpp[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundo.cpp.objkateundo.cpp[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/katemodifiedundo.cpp.objkatemodifiedundo.cpp[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundomanager.cpp.objkateundomanager.cpp[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescript.cpp.objkatescript.cpp[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/kateindentscript.cpp.objkateindentscript.cpp[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katecommandlinescript.cpp.objkatecommandlinescript.cpp[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptmanager.cpp.objkatescriptmanager.cpp[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptaction.cpp.objkatescriptaction.cpp[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptdocument.cpp.objC:\CI\workspace\Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9\src\document\katedocument.cpp(3190): error C2065: 'pos': undeclared identifierjom: C:\CI\workspace\Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9\build\src\CMakeFiles\KF5TextEditor.dir\build.make [src\CMakeFiles\KF5TextEditor.dir\document\katedocument.cpp.o
KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 23 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Dec 2017 19:37:23 + Build duration: 1 min 50 sec and counting CONSOLE OUTPUT [...truncated 153.94 KB...]Generating MOC source 2Q6GNUNQ7E/moc_kateswapfile.cppGenerating MOC source OI5CPPXFUF/moc_katehighlightmenu.cppGenerating MOC source OI5CPPXFUF/moc_katesyntaxmanager.cppGenerating MOC source DUXJVKIIEO/moc_kateundomanager.cppGenerating MOC source 7HEHEGDA3T/moc_kateautoindent.cppGenerating MOC source 7HEHEGDA3T/moc_katebookmarks.cppGenerating MOC source 7HEHEGDA3T/moc_kateglobal.cppGenerating MOC source 7HEHEGDA3T/moc_katetemplatehandler.cppGenerating MOC source RTEFPIXYSN/moc_katehelpbutton.cppGenerating MOC source RTEFPIXYSN/moc_variableeditor.cppGenerating MOC source RTEFPIXYSN/moc_variablelineedit.cppGenerating MOC source RTEFPIXYSN/moc_variablelistview.cppGenerating MOC source OTUN7GXZT4/moc_kateanimation.cppGenerating MOC source OTUN7GXZT4/moc_katefadeeffect.cppGenerating MOC source OTUN7GXZT4/moc_katemessagewidget.cppGenerating MOC source OTUN7GXZT4/moc_katestatusbar.cppGenerating MOC source OTUN7GXZT4/moc_katetextanimation.cppGenerating MOC source OTUN7GXZT4/moc_katetextpreview.cppGenerating MOC source OTUN7GXZT4/moc_kateview.cppGenerating MOC source OTUN7GXZT4/moc_kateviewhelpers.cppGenerating MOC source OTUN7GXZT4/moc_kateviewinternal.cppGenerating MOC source OTUN7GXZT4/moc_wordcounter.cppGenerating MOC source VQRUSF47MT/moc_appcommands.cppGenerating MOC source IIR25LHTFA/moc_configtab.cppGenerating MOC source M2DJSLDKSG/moc_emulatedcommandbar.cppGenerating MOC source M2DJSLDKSG/moc_matchhighlighter.cppGenerating MOC source VQRUSF47MT/moc_keymapper.cppGenerating MOC source VQRUSF47MT/moc_marks.cppGenerating MOC source 7WFH7WAJAT/moc_insertvimode.cppGenerating MOC source 7WFH7WAJAT/moc_modebase.cppGenerating MOC source 7WFH7WAJAT/moc_normalvimode.cppGenerating MOC source 7WFH7WAJAT/moc_visualvimode.cppGenerating MOC compilation mocs_compilation.cpp[ 4%] Built target KF5TextEditor_autogen[ 4%] Generating ui_configwidget.h[ 4%] Generating ui_textareaappearanceconfigwidget.h[ 4%] Generating ui_completionconfigtab.h[ 5%] Generating ui_commandmenueditwidget.h[ 6%] Generating ui_filetypeconfigwidget.h[ 6%] Generating ui_indentationconfigwidget.h[ 6%] Generating ui_opensaveconfigwidget.h[ 7%] Generating ui_opensaveconfigadvwidget.h[ 7%] Generating ui_completionconfigwidget.h[ 7%] Generating ui_searchbarincremental.h[ 7%] Generating ui_searchbarpower.h[ 8%] Generating ui_spellcheckbar.h[ 8%] Generating ui_spellcheckconfigwidget.h[ 8%] Generating ui_howtoimportschema.h[ 8%] Generating ui_editconfigwidget.h[ 8%] Generating ui_navigationconfigwidget.h[ 8%] Generating ui_commandmenuconfigwidget.h[ 8%] Generating ui_bordersappearanceconfigwidget.hScanning dependencies of target KF5TextEditor[ 8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.o[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.o[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.o[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionconfig.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/katedialogs.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katedocument.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katebuffer.cpp.o/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 SUSEQt5.10/src/document/katedocument.cpp:
KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 24 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/24/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Sat, 23 Dec 2017 19:37:23 + Build duration: 1 min 32 sec and counting CONSOLE OUTPUT [...truncated 152.85 KB...]Generating MOC source 2Q6GNUNQ7E/moc_kateswapfile.cppGenerating MOC source OI5CPPXFUF/moc_katehighlightmenu.cppGenerating MOC source OI5CPPXFUF/moc_katesyntaxmanager.cppGenerating MOC source DUXJVKIIEO/moc_kateundomanager.cppGenerating MOC source 7HEHEGDA3T/moc_kateautoindent.cppGenerating MOC source 7HEHEGDA3T/moc_katebookmarks.cppGenerating MOC source 7HEHEGDA3T/moc_kateglobal.cppGenerating MOC source 7HEHEGDA3T/moc_katetemplatehandler.cppGenerating MOC source RTEFPIXYSN/moc_katehelpbutton.cppGenerating MOC source RTEFPIXYSN/moc_variableeditor.cppGenerating MOC source RTEFPIXYSN/moc_variablelineedit.cppGenerating MOC source RTEFPIXYSN/moc_variablelistview.cppGenerating MOC source OTUN7GXZT4/moc_kateanimation.cppGenerating MOC source OTUN7GXZT4/moc_katefadeeffect.cppGenerating MOC source OTUN7GXZT4/moc_katemessagewidget.cppGenerating MOC source OTUN7GXZT4/moc_katestatusbar.cppGenerating MOC source OTUN7GXZT4/moc_katetextanimation.cppGenerating MOC source OTUN7GXZT4/moc_katetextpreview.cppGenerating MOC source OTUN7GXZT4/moc_kateview.cppGenerating MOC source OTUN7GXZT4/moc_kateviewhelpers.cppGenerating MOC source OTUN7GXZT4/moc_kateviewinternal.cppGenerating MOC source OTUN7GXZT4/moc_wordcounter.cppGenerating MOC source VQRUSF47MT/moc_appcommands.cppGenerating MOC source IIR25LHTFA/moc_configtab.cppGenerating MOC source M2DJSLDKSG/moc_emulatedcommandbar.cppGenerating MOC source M2DJSLDKSG/moc_matchhighlighter.cppGenerating MOC source VQRUSF47MT/moc_keymapper.cppGenerating MOC source VQRUSF47MT/moc_marks.cppGenerating MOC source 7WFH7WAJAT/moc_insertvimode.cppGenerating MOC source 7WFH7WAJAT/moc_modebase.cppGenerating MOC source 7WFH7WAJAT/moc_normalvimode.cppGenerating MOC source 7WFH7WAJAT/moc_visualvimode.cppGenerating MOC compilation mocs_compilation.cpp[ 4%] Built target KF5TextEditor_autogen[ 4%] Generating ui_commandmenuconfigwidget.h[ 4%] Generating ui_configwidget.h[ 4%] Generating ui_textareaappearanceconfigwidget.h[ 4%] Generating ui_bordersappearanceconfigwidget.h[ 5%] Generating ui_commandmenueditwidget.h[ 5%] Generating ui_completionconfigtab.h[ 5%] Generating ui_navigationconfigwidget.h[ 5%] Generating ui_editconfigwidget.h[ 6%] Generating ui_filetypeconfigwidget.h[ 6%] Generating ui_indentationconfigwidget.h[ 6%] Generating ui_opensaveconfigwidget.h[ 7%] Generating ui_opensaveconfigadvwidget.h[ 7%] Generating ui_searchbarincremental.h[ 7%] Generating ui_completionconfigwidget.h[ 7%] Generating ui_searchbarpower.h[ 7%] Generating ui_spellcheckconfigwidget.h[ 7%] Generating ui_howtoimportschema.h[ 8%] Generating ui_spellcheckbar.hScanning dependencies of target KF5TextEditor[ 8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.o[ 8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.o[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.o[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.o[ 9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionconfig.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingtree.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.o[ 14%] Building CXX object src/C
D7660: Fix a regression caused by changing backspace key behavior
This revision was automatically updated to reflect the committed changes. Closed by commit R39:c9b412d40334: Fix a regression caused by changing backspace key behavior (authored by safaalfulaij). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=21916&id=24338 REVISION DETAIL https://phabricator.kde.org/D7660 AFFECTED FILES autotests/src/katedocument_test.cpp src/dialogs/katedialogs.cpp src/dialogs/navigationconfigwidget.ui src/document/katedocument.cpp src/utils/kateconfig.cpp src/utils/kateconfig.h To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, cullmann Cc: mwolff, ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks
D9491: Sonnet: fix wrong language for suggestions in mixed-language texts
dfaure created this revision. dfaure added reviewers: sandsmark, mlaurent. Restricted Application added a project: Frameworks. REVISION SUMMARY When AutoDetectLanguage is set, the same document can contain multiple languages. In that case, Highlighter stores the language information into the block's userdata, and changes the spellchecker language at every change. So the suggestions were using whatever was the language of the last block that was checked, which led to pretty random behaviour for the user. Fixed by using a QTextCursor to retrieve the cached language for the word we're showing suggestions for. Includes a separate commit for Loader: honour Settings::defaultClient(), useful for unittests. TEST PLAN Spellchecking in kmail composer, writing text in French and having a signature with word in English. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D9491 AFFECTED FILES autotests/CMakeLists.txt autotests/test_highlighter.cpp src/core/loader.cpp src/ui/highlighter.cpp src/ui/highlighter.h src/ui/spellcheckdecorator.cpp To: dfaure, sandsmark, mlaurent Cc: #kde_pim, #frameworks
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 48 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/48/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 23 Dec 2017 17:32:33 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/27/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 17:32:33 + Build duration: 8 min 45 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.testtrash
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/47/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Dec 2017 17:32:33 + Build duration: 7 min 49 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.testtrash
KDE CI: Frameworks sonnet kf5-qt5 FreeBSDQt5.9 - Build # 9 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks sonnet kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 17:08:53 + Build duration: 52 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
KDE CI: Frameworks sonnet kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks sonnet kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 17:00:23 + Build duration: 1 min 6 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.sonnet-test_suggest
KDE CI: Frameworks sonnet kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Frameworks sonnet kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 16:45:18 + Build duration: 1 min 27 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.sonnet-test_suggest
KDE CI: Frameworks sonnet kf5-qt5 SUSEQt5.7 - Build # 13 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20SUSEQt5.7/13/ Project: Frameworks sonnet kf5-qt5 SUSEQt5.7 Date of build: Sat, 23 Dec 2017 16:45:18 + Build duration: 1 min 8 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/10/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Dec 2017 15:59:38 + Build duration: 5 min 43 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.7 - Build # 10 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/10/ Project: Frameworks krunner kf5-qt5 SUSEQt5.7 Date of build: Sat, 23 Dec 2017 15:59:38 + Build duration: 1 min 28 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 3 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/3/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 15:59:38 + Build duration: 1 min 18 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertestFailed: TestSuite.runnercontexttest
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Dec 2017 15:46:53 + Build duration: 6 min 26 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 40 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/40/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Sat, 23 Dec 2017 15:46:53 + Build duration: 6 min 25 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 15:46:53 + Build duration: 4 min 52 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest
KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 15 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/15/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Sat, 23 Dec 2017 15:43:58 + Build duration: 5 min 21 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
KDE CI: Frameworks sonnet kf5-qt5 FreeBSDQt5.9 - Build # 6 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks sonnet kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 15:44:48 + Build duration: 1 min 0 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.sonnet-test_suggest
KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/15/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Dec 2017 15:43:58 + Build duration: 1 min 26 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
KDE CI: Frameworks sonnet kf5-qt5 SUSEQt5.7 - Build # 12 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20SUSEQt5.7/12/
Project:
Frameworks sonnet kf5-qt5 SUSEQt5.7
Date of build:
Sat, 23 Dec 2017 15:44:48 +
Build duration:
54 sec and counting
CONSOLE OUTPUT
[...truncated 134.35 KB...][ 37%] Building CXX object autotests/CMakeFiles/sonnet-test_filter.dir/test_filter.cpp.o[ 38%] Building CXX object autotests/CMakeFiles/sonnet-test_filter.dir/sonnet-test_filter_autogen/mocs_compilation.cpp.oGenerating MOC source include/moc_configdialog.cppGenerating MOC source include/moc_dictionarycombobox.cppGenerating MOC source EWIEGA46WW/moc_configwidget.cppGenerating MOC source EWIEGA46WW/moc_dialog.cppGenerating MOC source EWIEGA46WW/moc_highlighter.cppGenerating MOC source EWIEGA46WW/moc_spellcheckdecorator.cppGenerating MOC compilation mocs_compilation.cpp[ 38%] Built target KF5SonnetUi_autogen[ 39%] Building CXX object src/plugins/hunspell/CMakeFiles/sonnet_hunspell.dir/hunspelldict.cpp.oScanning dependencies of target sonnet-test_suggest[ 40%] Building CXX object autotests/CMakeFiles/sonnet-test_suggest.dir/test_suggest.cpp.o[ 42%] Linking CXX executable ../bin/sonnet-test_filter[ 43%] Building CXX object autotests/CMakeFiles/sonnet-test_settings.dir/sonnet-test_settings_autogen/mocs_compilation.cpp.o/home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.cpp: In member function 'virtual bool HunspellDict::isCorrect(const QString&) const':/home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.cpp:99:67: warning: 'int Hunspell::spell(const char*, int*, char**)' is deprecated [-Wdeprecated-declarations] int result = m_speller->spell(toDictEncoding(word).constData()); ^In file included from /home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.h:25:0, from /home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.cpp:21:/usr/include/hunspell/hunspell.hxx:131:20: note: declared here H_DEPRECATED int spell(const char* word, int* info = NULL, char** root = NULL);^/home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.cpp: In member function 'virtual QStringList HunspellDict::suggest(const QString&) const':/home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.cpp:111:81: warning: 'int Hunspell::suggest(char***, const char*)' is deprecated [-Wdeprecated-declarations] int nbWord = m_speller->suggest(&selection, toDictEncoding(word).constData()); ^In file included from /home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.h:25:0, from /home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.cpp:21:/usr/include/hunspell/hunspell.hxx:141:20: note: declared here H_DEPRECATED int suggest(char*** slst, const char* word);^~~/home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.cpp:115:44: warning: 'void Hunspell::free_list(char***, int)' is deprecated [-Wdeprecated-declarations] m_speller->free_list(&selection, nbWord);^In file included from /home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.h:25:0, from /home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/src/plugins/hunspell/hunspelldict.cpp:21:/usr/include/hunspell/hunspell.hxx:155:21: note: declared here H_DEPRECATED void free_list(char*** slst, int n); ^[ 43%] Built target sonnet-test_filterScanning dependencies of target gentrigrams[ 44%] Building CXX object data/CMakeFiles/gentrigrams.dir/gentrigrams.cpp.o/home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/autotests/test_suggest.cpp: In member function 'void SuggestTest::aspell_english_data()':/home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/autotests/test_suggest.cpp:49:12: error: 'addRow' is not a member of 'QTest' QTest::addRow("hello") << QStringLiteral("hello") << true << QStringList();^~/home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/autotests/test_suggest.cpp:49:12: note: suggested alternative: 'newRow' QTest::addRow("hello") << QStringLiteral("hello") << true << QStringList();^~newRow/home/jenkins/workspace/Frameworks sonnet kf5-qt5 SUSEQt5.7/autotests/test_suggest.cpp:50:12: error: 'addRow' is not a member of 'QTest' QTest::addRow("helo") << QStringLiteral("helo") << false << QStringList{QStringLiteral("hello"), QStringLiteral("hell"), QStringLiteral("help")};^~/home
KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 15:43:58 + Build duration: 49 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Dec 2017 15:09:38 + Build duration: 3 min 21 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 23 Dec 2017 15:09:38 + Build duration: 2 min 25 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest
D9489: Extend CMAKE_AUTOMOC_MACRO_NAMES also for own build
This revision was automatically updated to reflect the committed changes. Closed by commit R244:6e1f17922f3d: Extend CMAKE_AUTOMOC_MACRO_NAMES also for own build (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9489?vs=24326&id=24327 REVISION DETAIL https://phabricator.kde.org/D9489 AFFECTED FILES CMakeLists.txt KF5CoreAddonsConfig.cmake.in To: kossebau, dfaure, mlaurent Cc: #frameworks
D9489: Extend CMAKE_AUTOMOC_MACRO_NAMES also for own build
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH setautomocmacronamesalsoforownbuild REVISION DETAIL https://phabricator.kde.org/D9489 To: kossebau, dfaure, mlaurent Cc: #frameworks
D9489: Extend CMAKE_AUTOMOC_MACRO_NAMES also for own build
kossebau created this revision. kossebau added reviewers: dfaure, mlaurent. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R244 KCoreAddons BRANCH setautomocmacronamesalsoforownbuild REVISION DETAIL https://phabricator.kde.org/D9489 AFFECTED FILES CMakeLists.txt KF5CoreAddonsConfig.cmake.in To: kossebau, dfaure, mlaurent Cc: #frameworks
D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
dfaure added inline comments.
INLINE COMMENTS
> CMakeLists.txt:34
>
> -configure_file(org.kde.kded5.service.in
> - ${CMAKE_CURRENT_BINARY_DIR}/org.kde.kded5.service)
> -install(FILES ${CMAKE_CURRENT_BINARY_DIR}/org.kde.kded5.service
> -DESTINATION ${KDE_INSTALL_DBUSSERVICEDIR})
> +kdbusaddons_generate_dbus_service_file(kded5 org.kde.kded5
> ${CMAKE_INSTALL_PREFIX}/bin)
>
Shouldn't that be ${KDE_INSTALL_FULL_BINDIR} instead?
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D9482
To: habacker, dfaure, kfunk
Cc: #frameworks
D9332: Allow filter places based on alternative application name
elvisangelaccio added inline comments.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:145
> +KFilePlacesModel *currentModel = model;
> +if (currentModel == nullptr) {
> +currentModel = m_places;
`if (!currentModel)` ?
> kfileplacesmodel.h:69
> +/**
> +* @brief Construct a new KFilePlacesModel with a
> alternativeApplicationName
> +* @param alternativeApplicationName This value will be used to filter
> bookmarks in addition of the actual application name
typo: an alternativeApplicationName
> kfileplacesmodel.h:70
> +* @brief Construct a new KFilePlacesModel with a
> alternativeApplicationName
> +* @param alternativeApplicationName This value will be used to filter
> bookmarks in addition of the actual application name
> +* @param parent Parent object
wording: "in addition to" sound better to me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks
