D9808: fix incorrect emission of signals by kLineEdit

2018-01-10 Thread Anthony Fieroni
anthonyfieroni added reviewers: dhaumann, cullmann. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9808 To: dweatherill, #frameworks, dhaumann, cullmann Cc: anthonyfieroni, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger

D9808: fix incorrect emission of signals by kLineEdit

2018-01-10 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > klineedit.cpp:63 > #endif > -emit q->textEdited(text); > } You mean this is emitted by Qt and this is duplicate one or so? REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9808 To: dweatherill,

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2018-01-10 Thread Laurent Montel
mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. When I try to compile your patch I have this compile error: Do you are sure that you rebuild all ?

D9808: fix incorrect emission of signals by kLineEdit

2018-01-10 Thread Dan Weatherill
dweatherill created this revision. dweatherill added a reviewer: Frameworks. dweatherill added a project: KDevelop. Restricted Application added a project: Frameworks. dweatherill requested review of this revision. REVISION SUMMARY This goes with bug report

Re: Problem in loading QM translations with LANGUAGE="" envar

2018-01-10 Thread Safa Alfulaij
Systemsettings sets that, and there is no ar_BH language, but ar only. That's the standard for Arabic translations. On Jan 10, 2018 10:09 PM, "Albert Astals Cid" wrote: > El dimecres, 10 de gener de 2018, a les 5:49:54 CET, Safa Alfulaij va > escriure: > > Well, I don't want to

Re: Making Purpose part of KF5

2018-01-10 Thread Aleix Pol
On Thu, Nov 9, 2017 at 5:10 PM, Aleix Pol wrote: > Hi, > I would like to include Purpose [1] into the frameworks umbrella. > It's been around for a while now, used by few applications and > reasonably stable. > > Any thoughts? > > Aleix > > [1]

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, alexeymin, genaxxx, emmanuelp

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 29 - Fixed!

2018-01-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/29/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Jan 2018 23:56:27 + Build duration: 15 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 30 - Fixed!

2018-01-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/30/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Thu, 11 Jan 2018 00:01:46 + Build duration: 5 min 40 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 29 - Still Unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/29/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Wed, 10 Jan 2018 23:56:27 + Build duration: 5 min 18 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 29 - Fixed!

2018-01-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 23:59:05 + Build duration: 1 min 48 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 23:56:27 + Build duration: 1 min 59 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 28 - Still Unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/28/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Wed, 10 Jan 2018 23:39:42 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/28/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Jan 2018 23:39:42 + Build duration: 6 min 13 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 40 - Still unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/40/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 10 Jan 2018 23:18:55 + Build duration: 23 min and counting

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/27/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 23:39:42 + Build duration: 1 min 26 sec and counting JUnit

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread David Faure
dfaure closed this revision. REVISION DETAIL https://phabricator.kde.org/D9807 To: dfaure, sitter, apol Cc: cfeck, #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2018-01-10 Thread David Faure
dfaure accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D7270: [FileUndoManager] Enable undoing changes in read-only folders

2018-01-10 Thread David Faure
dfaure accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7270 To: chinmoyr, #frameworks, dfaure

D6830: Make use of kauth helper in copy method of file ioslave

2018-01-10 Thread David Faure
dfaure added a comment. Doesn't execWithElevatedPrivilege call ERR_USER_CANCELED on cancel? That was the idea, at least. I can't check, it's really hard to navigate code spread over many review requests, I can't wait for all of this to be pushed ;-) REPOSITORY R241 KIO BRANCH

D6832: Integrate new file ioslave in KIO job

2018-01-10 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Please keep in mind that we should remove one of the two flags before the end of the month, after people tested this as much as possible ;) I admit that it sucks a bit that I don't

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 35 - Fixed!

2018-01-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/35/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 Date of build: Wed, 10 Jan 2018 23:18:58 + Build duration: 10 min and counting

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 27 - Still unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Jan 2018 23:24:56 + Build duration: 4 min 7 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 27 - Still unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/27/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Wed, 10 Jan 2018 23:18:56 + Build duration: 9 min 10 sec and counting JUnit Tests

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread Harald Sitter
sitter accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D9807 To: dfaure, sitter, apol Cc: cfeck, #frameworks

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 23:23:53 + Build duration: 3 min 14 sec and counting JUnit

D7272: [DropJob] Enable drag and drop in a read-only folder

2018-01-10 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7272 To: chinmoyr, #frameworks, dfaure Cc: mreeves, ngraham

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 26 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Jan 2018 23:18:57 + Build duration: 3 min 37 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 23:18:58 + Build duration: 1 min 42 sec and counting CONSOLE

Re: [kde-build-metadata] /: Introduce temporary dependency on KCoreaddons for Breeze Icons.

2018-01-10 Thread David Faure
On jeudi 11 janvier 2018 00:17:24 CET Ben Cooksley wrote: > Git commit 08e9c4955681587c0391b21550a52525ce37739b by Ben Cooksley. > Committed on 10/01/2018 at 23:17. > Pushed by bcooksley into branch 'master'. > > Introduce temporary dependency on KCoreaddons for Breeze Icons. > This should be

[kde-build-metadata] /: Introduce temporary dependency on KCoreaddons for Breeze Icons.

2018-01-10 Thread Ben Cooksley
Git commit 08e9c4955681587c0391b21550a52525ce37739b by Ben Cooksley. Committed on 10/01/2018 at 23:17. Pushed by bcooksley into branch 'master'. Introduce temporary dependency on KCoreaddons for Breeze Icons. This should be reverted once D9807 has been merged in. Please note that it is generally

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 25 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Jan 2018 23:05:57 + Build duration: 9 min 37 sec and counting CONSOLE

Re: KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 22 - Still Failing!

2018-01-10 Thread Christoph Feck
The stale symlinks have been fixed; thanks Andreas for the prompt fix. The remaining issue is a recent regression that will be fixed with https://phabricator.kde.org/D9807 -- Christoph Feck

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 34 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/34/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 Date of build: Wed, 10 Jan 2018 23:05:57 + Build duration: 6 min 23 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 39 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/39/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 10 Jan 2018 23:05:57 + Build duration: 6 min 50 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 23:05:57 + Build duration: 4 min 43 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 26 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/26/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Wed, 10 Jan 2018 23:05:57 + Build duration: 2 min 26 sec and counting CONSOLE

D9802: Avoid Dolphin crash

2018-01-10 Thread Andreas Krutzler
akrutzler added inline comments. INLINE COMMENTS > michaelh wrote in kcoredirlister.cpp:1233 > I'd like to ask for some help here. > Debugging in KDevelop, trying to step through the code: > it's not possible for me. Sometimes the debugger even crashed. > > - I checked for debugging symbols

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread David Faure
dfaure added a comment. Sample output: * Start testing of DupeTest * Config: Using QtTest library 5.9.2, Qt 5.9.2 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 5.3.1 20160301 [gcc-5-branch revision 233849]) PASS : DupeTest::initTestCase()

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread David Faure
dfaure created this revision. dfaure added reviewers: sitter, apol. dfaure requested review of this revision. REVISION SUMMARY Now using a hand-made loop to avoid the dependency on kcoreaddons introduced by the earlier commit. TEST PLAN bin/dupes from a srcdir with a space, after

D9781: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread David Faure
dfaure added a comment. https://phabricator.kde.org/D9807 (to be applied after reverting this commit) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D9781 To: sitter, dfaure, apol Cc: cfeck, #frameworks

D9781: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread David Faure
dfaure added a comment. I don't either ;) I'll fix this with a micro-handmade-state-machine, I like those. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D9781 To: sitter, dfaure, apol Cc: cfeck, #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 46 - Unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/46/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 21:25:02 + Build duration: 18 min and counting JUnit Tests Name: (root)

Re: Problem in loading QM translations with LANGUAGE="" envar

2018-01-10 Thread Wolfgang Bauer
Am Wed, 10 Jan 2018 20:09:35 +0100, Albert Astals Cid schrieb: > Why not use ar_BH as LANGUAGE? That probably won't help, see my previous reply here (that got delayed by moderation for some reason even though I am subscribed, so you may not have read it yet), or

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, alexeymin, genaxxx, emmanuelp

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh marked 3 inline comments as done. michaelh added inline comments. INLINE COMMENTS > akrutzler wrote in kcoredirlister.cpp:1233 > Yes, i would just comment this out :) Once you are done, undo the comment. I'd like to ask for some help here. Debugging in KDevelop, trying to step through

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 33 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/33/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 Date of build: Wed, 10 Jan 2018 19:55:33 + Build duration: 3 min 8 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 38 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/38/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 10 Jan 2018 19:55:33 + Build duration: 2 min 26 sec and counting

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, alexeymin, genaxxx, emmanuelp

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 24 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Jan 2018 19:55:33 + Build duration: 57 sec and counting CONSOLE OUTPUT

D9802: Avoid Dolphin crash

2018-01-10 Thread Andreas Krutzler
akrutzler added inline comments. INLINE COMMENTS > michaelh wrote in kcoredirlister.cpp:1233 > I'm working with kio right now. Is better to just comment it out for the time > being? Yes, i would just comment this out :) Once you are done, undo the comment. REPOSITORY R241 KIO REVISION

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 25 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/25/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Wed, 10 Jan 2018 19:55:33 + Build duration: 42 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 19:55:33 + Build duration: 34 sec and counting CONSOLE

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > akrutzler wrote in kcoredirlister.cpp:1233 > Q_ASSERT is just executed in debug builds. It wont crash in release builds. > Checkout https://doc-snapshots.qt.io/qt5-dev/qtglobal.html#Q_ASSERT I'm working with kio right now. Is better to just

D9770: Optimization of byteSize(double size)

2018-01-10 Thread Jaime Torres Amate
jtamate updated this revision to Diff 25121. jtamate added a comment. - De-duplication of code in byteSize(double size) Changed the include. There is no need to change the CMakeLists.txt as find_package(KF5CoreAddons ${KF5_DEP_VERSION} REQUIRED) is already included. REPOSITORY

D9781: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread Christoph Feck
cfeck added a comment. CI doesn't like Tier1 frameworks have a dependency on other Tier1 frameworks. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D9781 To: sitter, dfaure, apol Cc: cfeck, #frameworks

D9802: Avoid Dolphin crash

2018-01-10 Thread Andreas Krutzler
akrutzler added inline comments. INLINE COMMENTS > kcoredirlister.cpp:1233 > > -Q_ASSERT(!name.isEmpty()); > if (name.isEmpty()) { Q_ASSERT is just executed in debug builds. It wont crash in release builds. Checkout https://doc-snapshots.qt.io/qt5-dev/qtglobal.html#Q_ASSERT

D9802: Avoid Dolphin crash

2018-01-10 Thread Nathaniel Graham
ngraham added a comment. Hmm, I can't reproduce the crash with Dolphin and KIO from git master. `dolphin tags:/Genre/Drama/` (after created a nested tag Genre/Drama) works fine for me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin,

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Dolphin, Frameworks. michaelh added projects: Dolphin, Frameworks, KDE Applications. michaelh requested review of this revision. REVISION SUMMARY Removed Q_ASSERT TEST PLAN $ dolphin tags:/Genre/Drama/ REPOSITORY R241 KIO BRANCH

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh added a comment. Reason: dolphin crashes when navigation to a nested tag e.g. tags:/Genre/Drama/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: ngraham, michaelh, spoorun, navarromorales, isidorov, firef,

Re: KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 22 - Still Failing!

2018-01-10 Thread Ben Cooksley
On Wed, Jan 10, 2018 at 5:46 PM, Ben Cooksley wrote: > Hi Andreas, > Hi Andreas, > > Please see below. Following your two commits, breeze-icons failed on all > platform/Qt versions monitored by the CI system. > If you could fix that please it would be appreciated. > Your

D9770: Optimization of byteSize(double size)

2018-01-10 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > kjobtrackerformatters.cpp:26 > #include "kjobtrackerformatters_p.h" > +#include "kformat.h" > Isn't KFormat from a different framework? Adjust the include to use style, and check if CMakeLists.txt needs to be adjusted. REPOSITORY R288

Re: Problem in loading QM translations with LANGUAGE="" envar

2018-01-10 Thread Albert Astals Cid
El dimecres, 10 de gener de 2018, a les 5:49:54 CET, Safa Alfulaij va escriure: > Well, I don't want to remove it but it's a must. First it's not right > logically and second is that Qt prefers it over LANG, and use any locale > varient since it has no country name. (QLocale("ar") returns "Arabic

Re: Problem in loading QM translations with LANGUAGE="" envar

2018-01-10 Thread Wolfgang Bauer
Hi, I noticed a similar problem here. My LANG is set to "de_AT.UTF-8", and if LANGUAGE is not set, parts of KDE applications are untranslated (i.e. those frameworks translations that come from .qm files are missing). Sure, setting LANGUAGE to "de" will fix that, but it's not necessarily set on

D9770: Optimization of byteSize(double size)

2018-01-10 Thread Jaime Torres Amate
jtamate updated this revision to Diff 25114. jtamate added a comment. - De-duplication of code in byteSize(double size) In fact Milian Wolff is right. Why so many calls to this function? Copying 20Gb it is called 19.026 times (aproximately 10 times per second) from

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 - Build # 37 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.9/37/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 10 Jan 2018 15:41:22 + Build duration: 41 min and counting

D9794: Provide access to data returned by helper even on error replies

2018-01-10 Thread Alexander Volkov
volkov added a reviewer: Frameworks. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D9794 To: volkov, #frameworks Cc: #frameworks

D9794: Provide access to data returned by helper even on error replies

2018-01-10 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. volkov requested review of this revision. REVISION SUMMARY Helper may provide an additional information about an error in it. REPOSITORY R283 KAuth BRANCH

D9793: Fall back to language name for translations lookup if locale name fails

2018-01-10 Thread Wolfgang Bauer
wbauer added a comment. I don't think bcp47Name makes any sense here. According to the Qt documentation, this "Returns the dash-separated language, script and country (and possibly other BCP47 fields) of this locale as a string" (and "Unlike the uiLanguages() the returned value of the

D9793: Fall back to language name for translations lookup if locale name fails

2018-01-10 Thread Wolfgang Bauer
wbauer created this revision. wbauer added a reviewer: Frameworks. wbauer added a project: Frameworks. Restricted Application added a project: Build System. Restricted Application added a subscriber: Build System. wbauer requested review of this revision. REVISION SUMMARY For locales like

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 24 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/24/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Wed, 10 Jan 2018 15:41:22 + Build duration: 3 min 20 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 15:41:22 + Build duration: 1 min 25 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 23 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Jan 2018 15:41:22 + Build duration: 1 min 2 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 - Build # 32 - Failure!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/32/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.9 Date of build: Wed, 10 Jan 2018 15:41:22 + Build duration: 55 sec and counting CONSOLE

D9781: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R266:08ddec40bf89: do not incorrectly split spaces in paths of duplicate results (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D9116: Make sure to search for Qt5-based qmlplugindump

2018-01-10 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In https://phabricator.kde.org/D9116#186638, @asturmlechner wrote: > Can we move forward with this? ECM provides ECMQueryQmake.cmake. you can try eg: include("${ECM_MODULE_DIR}/ECMQueryQmake.cmake") then calling query_qmake(qt_binaries_dir

D9781: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9781 To: sitter, dfaure, apol Cc: #frameworks

Re: Problem in loading QM translations with LANGUAGE="" envar

2018-01-10 Thread Safa Alfulaij
More investigation shows that it does not work with other locales than the default one (the one that is used in case you don't pass a country code, which, in case of Arabic, is ar_EG). [safa@archlinux]$ LANG=ar_BH.utf8 > [safa@archlinux]$ python testQtLocale.py > b'\xd9\xa2\xd9\xa0 B' >

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

2018-01-10 Thread Ralf Habacker
habacker edited the summary of this revision. habacker edited the test plan for this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9468 To: habacker, dfaure Cc: #frameworks

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

2018-01-10 Thread Ralf Habacker
habacker updated this revision to Diff 25088. habacker added a comment. - fix generating slot access code REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9468?vs=24256=25088 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9468

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

2018-01-10 Thread Michael Heidelbach
michaelh added a comment. Just tried it. Great! > If the need should arise, this could be made more sophisticated by adding support for e.g. ranges and less than/more than operators, but let's keep it simple for now. Yes. E.g. I have a ServiceMenu to concatenate files. So something

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

2018-01-10 Thread Kai Uwe Broulik
broulik added a comment. > How can I fetch a diff that has not been committed yet? It has been :) Either "Download Raw Diff" and then `git apply` or use `arc patch D1234` using arcanist REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9734 To: broulik,

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

2018-01-10 Thread Michael Heidelbach
michaelh added a comment. I overlooked that this was commited today. The general question remains: How can I fetch a diff that has not been committed yet? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9734 To: broulik, #frameworks, dfaure, michaelh, mlaurent

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2018-01-10 Thread Veluri Mithun
velurimithun marked an inline comment as done. velurimithun added a comment. Fixed :) StringEncodings doc helped me to understand encoding and decoding. Still if there any modifications kindly let me know. Thank You. REPOSITORY

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2018-01-10 Thread Veluri Mithun
velurimithun updated this revision to Diff 25076. velurimithun added a comment. - Use QString::fromUtf8(..) to decode an escape sequence like \x21 REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24493=25076 BRANCH complieWithoutRemoveDef

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

2018-01-10 Thread Kai Uwe Broulik
broulik added a comment. You might want to check out https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9734 To: broulik, #frameworks, dfaure, michaelh, mlaurent

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 10:37:46 + Build duration: 40 min and counting JUnit Tests

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

2018-01-10 Thread Michael Heidelbach
michaelh added a comment. +1 This looks like a *very* good idea to me. How can I fetch this? I want to try it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9734 To: broulik, #frameworks, dfaure, michaelh, mlaurent

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Jan 2018 10:37:46 + Build duration: 6 min 4 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 27 - Fixed!

2018-01-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/27/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Wed, 10 Jan 2018 10:37:46 + Build duration: 2 min 47 sec and counting JUnit Tests

D9785: [ConfigModel] Set QML context on ConfigModule

2018-01-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY This will have the ConfigModule use the

D9784: [ConfigModule] Re-use QML context and engine if any

2018-01-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the ConfigModule is created within

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 124 - Fixed!

2018-01-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/124/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 10 Jan 2018 09:55:27 + Build duration: 15 min and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 45 - Fixed!

2018-01-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/45/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 09:39:52 + Build duration: 9 min 39 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 123 - Still Failing!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/123/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 10 Jan 2018 09:44:43 + Build duration: 3 min 48 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 122 - Failure!

2018-01-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/122/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 10 Jan 2018 09:11:05 + Build duration: 33 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 44 - Unstable!

2018-01-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/44/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 10 Jan 2018 09:11:05 + Build duration: 28 min and counting JUnit Tests Name: (root)

Re: duplicate icon in breeze-icons

2018-01-10 Thread Harald Sitter
https://phabricator.kde.org/D9781 On Wed, Jan 10, 2018 at 10:06 AM, Harald Sitter wrote: > Whatever's going on with that output Oo > > On Fri, Jan 5, 2018 at 10:13 AM, David Faure wrote: >> Hello Andreas, >> >> I'm emailing you since you committed some gnumeric

D9781: do not incorrectly split spaces in paths of duplicate results

2018-01-10 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY use kcoreaddons to split fdupes output. fdupes outputs `/space\

D9729: [KPropertiesDialog] Enable word wrap for checksum description

2018-01-10 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8ab0c0dbead7: [KPropertiesDialog] Enable word wrap for checksum description (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9729?vs=24926=25057

  1   2   >