D9899: Android: Add more includes

2018-01-15 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9899

To: aacid, apol
Cc: apol, vkrause, #frameworks, #build_system

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2018-01-15 Thread Laurent Montel 
mlaurent added a comment.


  Ping ?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9420

To: velurimithun, mlaurent
Cc: dfaure, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 88 - Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/88/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 16 Jan 2018 03:52:49 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31556/59391)38%
(18563/48464)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8610/9037)50%
(5314/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8362/14345)50%
(4874/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(510/974)42%
(395/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 69 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/69/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 16 Jan 2018 03:52:49 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 20 - Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/20/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 16 Jan 2018 01:23:19 +
 Build duration:
4 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 21 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/21/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 16 Jan 2018 01:23:19 +
 Build duration:
3 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D9899: Android: Add more includes

2018-01-15 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Never seen this issue, but I'm happy to have it in. If it has regressions we 
can revert it.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9899

To: aacid, apol
Cc: apol, vkrause, #frameworks, #build_system

D9880: Fix build with >=attr-2.4.48

2018-01-15 Thread Andreas Sturmlechner 
asturmlechner added a comment.


  In https://phabricator.kde.org/D9880#191545, @mgallien wrote:
  
  > Are you sure attr/xattr.h is deprecated ?
  
  
  Yep, it is gone in 2.4.48, but the commit that removed it is from 2015: 
http://git.savannah.nongnu.org/cgit/attr.git/commit/?id=7921157890d07858d092f4003ca4c6bae9fd2c38

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D9880

To: asturmlechner, #frameworks, mgallien

D5199: Reflect trash state in iconNameForUrl

2018-01-15 Thread Nathaniel Graham 
ngraham added a comment.


  FWIW, this change did not fix https://bugs.kde.org/show_bug.cgi?id=252483

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5199

To: broulik, hein, dfaure
Cc: ngraham, markg, #frameworks

D9899: Android: Add more includes

2018-01-15 Thread Volker Krause 
vkrause added a comment.


  Sounds familiar: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 
  Your patch looks like a viable workaround to me.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9899

To: aacid
Cc: vkrause, #frameworks, #build_system

D9880: Fix build with >=attr-2.4.48

2018-01-15 Thread Matthieu Gallien 
mgallien added a comment.


  Are you sure attr/xattr.h is deprecated ?
  I did look at what debian provides with version 2.4.47 and there seems to 
have a valid attr/xattr.h file.
  I also did found some partial information by searching the web but nothing 
conclusive.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D9880

To: asturmlechner, #frameworks, mgallien

D9899: Android: Add more includes

2018-01-15 Thread Albert Astals Cid 
aacid created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  Without this i get
  
  In file included from 
/home/tsdgeos/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/bits/stl_algo.h:59:0,
  
from 
/home/tsdgeos/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/algorithm:62,
from 
/home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtCore/qglobal.h:109,
from 
/home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtGui/qtguiglobal.h:43,
from 
/home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtWidgets/qtwidgetsglobal.h:43,
from 
/home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtWidgets/qapplication.h:43,
from 
/home/tsdgeos/devel/binaryQt/5.9.2/android_armv7/include/QtWidgets/QApplication:1,
from /home/tsdgeos/devel/kde/ktuberling/main_mobile.cpp:11:
  
  
/home/tsdgeos/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/cstdlib:72:20:
 fatal error: stdlib.h: No such file or directory
   #include 
  
^
  
  compilation terminated.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9899

AFFECTED FILES
  toolchain/Android.cmake

To: aacid
Cc: #frameworks, #build_system

KDE CI: Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.9 - Build # 17 - Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20WindowsMSVCQt5.9/17/
 Project:
Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 15 Jan 2018 14:56:09 +
 Build duration:
4 hr 11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.ThreadWeaverJobTests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/27/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 17:25:42 +
 Build duration:
1 hr 34 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D9770: Code de-duplication in byteSize(double size)

2018-01-15 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R288:240a9c1f01d0: Code de-duplication in byteSize(double 
size) (authored by jtamate).

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9770?vs=25121&id=25411

REVISION DETAIL
  https://phabricator.kde.org/D9770

AFFECTED FILES
  src/kjobtrackerformatters.cpp

To: jtamate, #frameworks, mwolff
Cc: ngraham, cfeck, mwolff, broulik

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/21/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:55:42 +
 Build duration:
3 hr 10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D9894: [UDisks Device] Show loop device with their backing file name and icon

2018-01-15 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> udisksdevice.cpp:614
> +}
> +return "drive-harddisk";
> +} else if (isSwap()) {

return QStringLiteral("drive-harddisk");

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D9894

To: broulik, #vdg, davidedmundson
Cc: apol, #frameworks

D9895: [UDisks] Ignore non-user mounts

2018-01-15 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, VDG, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This gets rid of all those internal mounts, such as /snap mounts.
  The approach is similar to GVFS which ignores everything outside /media, 
/home/user, and /media/run, cf. 
https://github.com/GNOME/gvfs/blob/master/monitor/udisks2/what-is-shown.txt
  Explicitly creating a mount in /etc/fstab outside of those directories is 
still possible and will always show up.

TEST PLAN
  My snaps no longer show up as "Loop Device"s
  Mounted an ISO file in my home dir, showed up fine
  Plugged in a USB key, showed up fine
  My cifs mount in /etc/fstab still showed up

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D9895

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp
  src/solid/devices/backends/udisks2/udisksstoragevolume.cpp

To: broulik, #plasma, #vdg, #frameworks
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9894: [UDisks Device] Show loop device with their backing file name and icon

2018-01-15 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: VDG, davidedmundson.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Instead of showing generic "Loop Device" for everything, use the backing 
file's file name and mime type icon.

TEST PLAN
  Mounted a random iso file, showed up with file name and ISO icon in Dolphin 
sidebar.
  Before
  F5654058: Screenshot_20180115_185414.png 

  After
  F5654059: Screenshot_20180115_185431.png 

  (This is also in preparation for getting rid of those useless "Loop Devices" 
in the first place)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D9894

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevice.h

To: broulik, #vdg, davidedmundson
Cc: #frameworks

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/22/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:55:12 +
 Build duration:
2 hr 55 min and counting
   JUnit Tests
  Name: (root) Failed: 13 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 37 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testQtSurfaceExtensionFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 68 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/68/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:53:47 +
 Build duration:
2 hr 53 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 - Build # 5 - Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/5/
 Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:55:02 +
 Build duration:
2 hr 48 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.ktextwidgets-krichtextedittest

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/8/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:54:54 +
 Build duration:
2 hr 42 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.ksycocatest

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 6 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/6/
 Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:54:49 +
 Build duration:
2 hr 40 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertestFailed: TestSuite.runnercontexttest

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.9 - Build # 5 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/5/
 Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:54:44 +
 Build duration:
2 hr 39 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/14/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:54:26 +
 Build duration:
2 hr 37 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/26/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:53:53 +
 Build duration:
2 hr 31 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/15/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:52:49 +
 Build duration:
2 hr 27 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

KDE CI: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.9 - Build # 16 - Fixed!

2018-01-15 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsMSVCQt5.9/16/
 Project:
Frameworks kpeople kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 15 Jan 2018 14:54:36 +
 Build duration:
2 hr 12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/34/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 14:51:51 +
 Build duration:
2 hr 14 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable

D9808: fix incorrect emission of signals by kLineEdit

2018-01-15 Thread Dan Weatherill 
dweatherill added a comment.


  I don't have commit access but please let me know if anything else is needed 
before it can be merged.
  
  (for submission)
  Name: Dan Weatherill
  email: dan.weather...@cantab.net

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9808

To: dweatherill, #frameworks, dhaumann, cullmann, dfaure
Cc: ngraham, mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, 
Pilzschaf, akshaydeo, surgenight, arrowdodger

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 19 - Fixed!

2018-01-15 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/19/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 16:19:01 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

Re: KHolidays as Framework (redux)

2018-01-15 Thread Allen Winter 
I'm wrong. the changes are BC since I'm just moving static functions around.
Moving KHolidays anytime you want is fine with me.

On Sunday, January 14, 2018 2:02:48 PM EST Volker Krause wrote:
> On Sunday, 14 January 2018 16:50:08 CET Sandro Knauß wrote:
> > @Volker:  Is there a need to rush releasing KHolidays it under frameworks?
> 
> this request is pending since more than 24 month, not exactly my definition 
> of 
> rushing things ;-)
> 
> We should do the move reasonably early before the next application release 
> IMHO, so we don't collide with the pre-releases there. Apart from that I 
> don't 
> see any particular timing constraints.
> 
> > As far I see it, the include mechanism do not change find_package do not
> > need to change and also the target_libraries do not need to changed also
> > the API is fixed so far -> no changes in kdepim needed.
> 
> Exactly, it's all ready to go since two years.
> 
> > The only thing that
> > changes is the big bump of the version number and there will be some BIC
> > cleanup, so there will be BIC breakage with that move. Distributions need
> > to rebuild everything against the new framework. With only BIC changes
> > there should be no big issue for distributions to ship a uptodate kdepim
> > (17.12.X) with a uptodate KDE frameworks.
> 
> Which BIC changes do you have in mind? The ABI has been stable since August 
> 2015 from what I can see.
> 
> Regards,
> Volker
> 
> > PS: please also inform distributi...@kde.org, if the switch has a fixed
> > date.
> > On Sonntag, 14. Januar 2018 15:59:46 CET Allen Winter wrote:
> > > I don't object to making KHolidays a framework.
> > > I kinda object to the short timeline.
> > > 
> > > I wanted to finish up some BIC cleaning.  No API changes planned at this
> > > time. I'll try to hurry.
> > > 
> > > On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote:
> > > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:
> > > > > On Friday 01 January 2016 18:24:17 David Faure wrote:
> > > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > It's xmas holidays, so it must be time to poke a stick at
> > > > > > > KHolidays
> > > > > > > again
> > > > > > > for inclusion as a Framework. As far as I am aware there are no
> > > > > > > outstanding
> > > > > > > porting issues with KHolidays and it is ready for review to be
> > > > > > > included
> > > > > > > as
> > > > > > > a Tier 1 Framework in the next possible release. What's the next
> > > > > > > step?
> > > > > > 
> > > > > > Please make sure it passes all of the items in this checklist
> > > > > > https://community.kde.org/Frameworks/CreationGuidelines
> > > > > 
> > > > > AFAICS this is followed, apart from using the KF5 version number and
> > > > > actually being marked as a framework, which I guess is pending
> > > > > framework
> > > > > approval.
> > > > 
> > > > This got lost somehow, any objection to executing the move to frameworks
> > > > for 5.43, say end of this week?
> > > > 
> > > > Regards,
> > > > Volker


-- 
Allen Winter | allen.win...@kdab.com | Senior Software Engineer
KDAB (USA) LLC, a KDAB Group company
Tel. USA +1-866-777-KDAB(5322) ext3
KDAB - The Qt, C++ and OpenGL Experts


smime.p7s
Description: S/MIME cryptographic signature

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/20/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 16:19:01 +
 Build duration:
9 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 19 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/19/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 15:36:21 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 36 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/36/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 15:40:11 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 33 - Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/33/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 14:54:59 +
 Build duration:
1 hr 9 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.completion_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(34045/49356)52%
(17872/34204)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4367/4657)50%
(2172/4378)autotests.src.vimode100%
(16/16)100%
(16/16)99%
(5493/5534)58%
(1073/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3116)43%
(1242/2901)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)60%
(1914/3208)49%
(1731/3517)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)58%
(176/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)73%
(888/1218)63%
(595/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 48 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/48/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 14:55:42 +
 Build duration:
1 hr 8 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13219)19%
(1974/10451)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(250/2152)7%
(97/1450)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(827/2911)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1611)28%
(318/1119)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9 - Build # 28 - Fixed!

2018-01-15 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.9/28/
 Project:
Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 15 Jan 2018 14:53:18 +
 Build duration:
1 hr 10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

2018-01-15 Thread Laurent Montel 
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Otherwise all is good. +2 with the QVERIFY(...)

INLINE COMMENTS

> kdatecomboboxtest.cpp:182
> +combo->activateWindow();
> +QTest::qWaitForWindowActive(combo.data());
> +

QVERIFY(QTest::qWa...)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8908

To: dfaure, cfeck, dvratil, mlaurent
Cc: mlaurent, anthonyfieroni, #frameworks, #kde_pim

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.7 - Build # 12 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/12/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 14:54:54 +
 Build duration:
57 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(73/88)83%
(73/88)68%
(5508/8117)48%
(3182/6684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)84%
(1307/1560)45%
(907/2007)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/334)0%
(0/278)src.plugin67%
(2/3)67%
(2/3)49%
(47/96)42%
(44/106)src.services97%
(29/30)97%
(29/30)61%
(1849/3036)41%
(818/1986)src.sycoca83%
(25/30)83%
(25/30)77%
(2143/2794)62%
(1365/2197)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)69%
(33/48)

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.7 - Build # 14 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/14/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 14:54:49 +
 Build duration:
55 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)29%
(411/1441)21%
(182/856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)49%
(53/109)23%
(13/56)src90%
(9/10)90%
(9/10)31%
(358/1156)24%
(169/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/41)0%
(0/4)

KDE CI: Frameworks kpty kf5-qt5 SUSEQt5.7 - Build # 8 - Fixed!

2018-01-15 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20SUSEQt5.7/8/
 Project:
Frameworks kpty kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 14:54:44 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(8/8)100%
(8/8)78%
(449/576)52%
(131/251)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)99%
(116/117)52%
(47/90)src100%
(6/6)100%
(6/6)73%
(333/459)52%
(84/161)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/20/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 14:54:26 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1275/2495)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(328/638)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 21 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/21/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 14:52:49 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 35 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/35/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 14:51:51 +
 Build duration:
48 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/18/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 15:01:25 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/36/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 15:03:09 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 12 - Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/12/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 14:55:17 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: TestSuite.kwindowsystem-kwindowsystemx11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(47/59)80%
(47/59)69%
(6535/9537)47%
(3554/7516)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests89%
(16/18)89%
(16/18)88%
(2777/3161)45%
(1523/3371)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src94%
(15/16)94%
(15/16)51%
(700/1383)42%
(316/747)src.platforms.wayland0%
(0/3)0%
(0/3)0%
(0/71)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)66%
(3051/4633)51%
(1712/3342)tests0%
(0/5)0%
(0/5)0%
(0/279)0%
(0/50)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 18 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/18/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 14:51:45 +
 Build duration:
44 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/45/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 14:55:42 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13223)19%
(1975/10451)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(251/2156)7%
(98/1454)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(827/2907)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1611)28%
(318/1119)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/13/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 14:54:54 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(73/88)83%
(73/88)68%
(5506/8117)48%
(3176/6680)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)84%
(1307/1560)45%
(907/2007)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/334)0%
(0/278)src.plugin67%
(2/3)67%
(2/3)49%
(47/96)42%
(44/106)src.services97%
(29/30)97%
(29/30)61%
(1849/3036)41%
(814/1982)src.sycoca83%
(25/30)83%
(25/30)77%
(2141/2794)62%
(1363/2197)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)69%
(33/48)

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/14/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 14:54:49 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)29%
(411/1441)21%
(182/856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)49%
(53/109)23%
(13/56)src90%
(9/10)90%
(9/10)31%
(358/1156)24%
(169/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/41)0%
(0/4)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/20/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 14:54:26 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1275/2495)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(328/638)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/34/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 14:53:53 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/14)0%
(0/14)0%
(0/847)0%
(0/552)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/7)0%
(0/7)0%
(0/523)0%
(0/414)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/306)0%
(0/134)

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/20/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 14:52:49 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kmimetypetest

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/35/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 14:51:51 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.dupeFailed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(257/305)62%
(157/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)87%
(215/248)63%
(142/224)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/17/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 14:51:45 +
 Build duration:
9 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread David Faure 
dfaure added a comment.


  Done, kwidgetaddons-5.42.1 is out: 
https://download.kde.org/stable/frameworks/5.42/

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9884

To: sars, #frameworks, mlaurent
Cc: dhaumann, dfaure, ltoscano

D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

2018-01-15 Thread David Faure 
dfaure added a comment.


  ping?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8908

To: dfaure, cfeck, dvratil
Cc: anthonyfieroni, #frameworks, #kde_pim

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/25/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 12:28:15 +
 Build duration:
1 hr 48 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Dominik Haumann 
dhaumann added subscribers: dfaure, dhaumann.
dhaumann added a comment.


  @dfaure Can we provide an update to KWidgetAddons? Is this feasible? If not, 
we should at least announce this bug on kde-distro-packag...@kde.org, since 
this breaks Kate.
  
  Second question: How did this happen in the first place? I am asking, since 
we also had quite a bit of breakage in Kate/KTextEditor due to changes from 
old-style connect to new-style connect. Introducing regressions from time to 
time is not good enough, imo.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9884

To: sars, #frameworks, mlaurent
Cc: dhaumann, dfaure, ltoscano

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/20/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 12:09:31 +
 Build duration:
1 hr 51 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D9887: [baloo-widgets] Display releaseYear w/o decimal grouping

2018-01-15 Thread Michael Heidelbach 
This revision was automatically updated to reflect the committed changes.
Closed by commit R824:1dd9509a29f1: [baloo-widgets] Display releaseYear w/o 
decimal grouping (authored by michaelh).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9887?vs=25390&id=25396

REVISION DETAIL
  https://phabricator.kde.org/D9887

AFFECTED FILES
  src/widgetfactory.cpp

To: michaelh, #frameworks, #dolphin, broulik
Cc: elvisangelaccio, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 67 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/67/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 11:33:41 +
 Build duration:
1 hr 50 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-http_jobtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutest

D9888: Make kdesu work when PWD is /usr/bin

2018-01-15 Thread Harald Sitter 
sitter accepted this revision.
sitter added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> suprocess.cpp:122
>  
> -QByteArray command;
> -if (d->superUserCommand == QLatin1String("sudo")) {
> -command = __PATH_SUDO;
> -} else {
> -command = __PATH_SU;
> -}
> -
> -if (QT_ACCESS(command.constData(), X_OK) != 0) {
> -command = 
> QFile::encodeName(QStandardPaths::findExecutable(d->superUserCommand));
> -if (command.isEmpty()) {
> -return check ? SuNotFound : -1;
> -}
> +QByteArray command = 
> QFile::encodeName(QStandardPaths::findExecutable(d->superUserCommand));
> +if (command.isEmpty()) {

Could probably make it `const` now

REPOSITORY
  R299 KDESu

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9888

To: mwolff, dfaure, mpyne, sitter
Cc: sitter, #frameworks

D9888: Make kdesu work when PWD is /usr/bin

2018-01-15 Thread Milian Wolff 
mwolff updated this revision to Diff 25395.
mwolff retitled this revision from "Let kdesu work when __PATH_SU or 
__PATH_SUDO are not defined" to "Make kdesu work when PWD is /usr/bin".
mwolff edited the summary of this revision.
mwolff added a subscriber: sitter.
mwolff added a comment.


  cleanup now that I figured out what happens, thanks @sitter

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9888?vs=25392&id=25395

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9888

AFFECTED FILES
  src/suprocess.cpp

To: mwolff, dfaure, mpyne
Cc: sitter, #frameworks

D9888: Let kdesu work when __PATH_SU or __PATH_SUDO are not defined

2018-01-15 Thread Milian Wolff 
mwolff added a comment.


  FTR:
  
[13:35]  how the hell can kdesu ever work? 
https://phabricator.kde.org/D9888 WTF
[13:35]  does anyone know if I'm missing something?
[13:35]  googling for these macros doesn't show me anything obvious 
either
[13:53]  milian: dead code I'd say. note the `if` following your 
change checks if the file 'false' is exectuable (which it isn't as that'd be 
./false which likely never exists) and then falls back to QSP::findExec(cmd). 
where cmd is macro'd to sudo or su depending on the cmake switch 
KDESU_USE_SUDO_DEFAULT
[13:54]  but it doesn't work for me without this patch
[13:54]  so it cannot be dead code :D
[13:55]  i.e. how can this work for anyone right now?
[13:58]  milian: http://paste.debian.net/1005279/ is how I read the 
original
[13:59]  I'll see why this does not happen on my system
[14:02]  milian: try this for good measure 
http://paste.debian.net/1005280/
[14:02]  yep
[14:03]  mind you, it could be that __PATH_SU/SUDO is actually 
defined somewhere in a system level include which would then make the QT_ACCESS 
pass and break things
[14:03]  I can't find it in my  /usr/include at least
[14:06]  sitter: QT_ACCESS("false", X_OK) == 0 on my system
[14:07]  and no, there's no false in the current PWD
[14:07]  it's in /usr/bin though
[14:07]  I'd also be OK with removing that whole code and 
simplifying it
[14:08]  like you proposed

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D9888

To: mwolff, dfaure, mpyne
Cc: #frameworks

D9712: balooctl status: produce parseable output

2018-01-15 Thread Michael Heidelbach 
michaelh added a reviewer: smithjd.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9712

To: michaelh, #frameworks, vhanda, smithjd
Cc: elvisangelaccio, lueck, dfaure, ngraham

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-15 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 25391.
jtamate added a comment.


  I'm sorry for the inconvenience.
  I'm going to divide the patch in two, the first part only changes lastTimeout 
and should be safe.
  nextTimeout part needs more thinking (if can be done).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9844?vs=25310&id=25391

REVISION DETAIL
  https://phabricator.kde.org/D9844

AFFECTED FILES
  src/core/slavebase.cpp

To: jtamate, #frameworks, dfaure
Cc: fvogt, broulik, ngraham, #dolphin

D9888: Let kdesu work when __PATH_SU or __PATH_SUDO are not defined

2018-01-15 Thread Milian Wolff 
mwolff edited the summary of this revision.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D9888

To: mwolff, dfaure, mpyne
Cc: #frameworks

D9888: Let kdesu work when __PATH_SU or __PATH_SUDO are not defined

2018-01-15 Thread Milian Wolff 
mwolff created this revision.
mwolff added reviewers: dfaure, mpyne.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mwolff requested review of this revision.

REVISION SUMMARY
  I quite frankly don't understand how this code can ever work. My
  system kdesu works fine, but a self-compiled one does not have either
  __PATH_SU nor __PATH_SUDO defined. Thus kdesu always starts
  /usr/bin/false which of course will always fail. You just get the
  super unhelpful "Su returned with an error" dialog shown...
  
  This patch only uses the two macros mentioned above when they are
  defined. If not, we try to launch su/sudo bei their name. This
  makes the code work for me.

REPOSITORY
  R299 KDESu

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9888

AFFECTED FILES
  src/suprocess.cpp

To: mwolff, dfaure, mpyne
Cc: #frameworks

D9887: [baloo-widgets] Display releaseYear w/o decimal grouping

2018-01-15 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  releaseYear (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9887

To: michaelh, #frameworks, #dolphin, broulik
Cc: elvisangelaccio, ngraham

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/24/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 10:14:04 +
 Build duration:
2 hr 13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D9887: [baloo-widgets] Display releaseYear w/o decimal grouping

2018-01-15 Thread Michael Heidelbach 
michaelh created this revision.
michaelh added reviewers: Frameworks, Dolphin.
michaelh added a project: Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  Display release year as e.g. "2010" instead of "2.010"

TEST PLAN
  Visual inspection

REPOSITORY
  R824 Baloo Widgets

BRANCH
  releaseYear (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9887

AFFECTED FILES
  src/widgetfactory.cpp

To: michaelh, #frameworks, #dolphin
Cc: elvisangelaccio, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 86 - Fixed!

2018-01-15 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/86/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 11:33:41 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31548/59390)38%
(18561/48540)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8611/9037)50%
(5309/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8352/14345)50%
(4876/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3852/7797)33%
(1618/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(510/974)42%
(395/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(724/1384)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/19/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 09:23:28 +
 Build duration:
2 hr 45 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 86 - Fixed!

2018-01-15 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/86/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 11:33:41 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31541/59390)38%
(18538/48464)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8611/9037)50%
(5311/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8352/14344)50%
(4869/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3851/7797)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(509/974)42%
(394/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%
(714/138

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Kåre Särs 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:ee34537ff55c: KMultiTabBar: Fix regression in conversion 
to new style connect() (authored by sars).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9884?vs=25380&id=25388

REVISION DETAIL
  https://phabricator.kde.org/D9884

AFFECTED FILES
  src/kmultitabbar.cpp

To: sars, #frameworks, mlaurent
Cc: ltoscano

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Luigi Toscano 
ltoscano reopened this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Give it some time. Right now Phabricator is only observing the repositories, 
not handling them, and this means that an update can land with some delay.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9884

To: sars, #frameworks, mlaurent
Cc: ltoscano

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Kåre Särs 
sars closed this revision.
sars added a comment.


  For some reason this review was not closed automatically by the commit. 
Closing manually.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9884

To: sars, #frameworks, mlaurent

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-15 Thread Fabian Vogt 
fvogt reopened this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Reverted in master as this broke various important ioslaves, like desktop and 
trash.
  
  I believe the issue is that the timeout fires immediately after construction, 
without being configured by the slave.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9844

To: jtamate, #frameworks, dfaure
Cc: fvogt, broulik, ngraham, #dolphin

[kio] src/core: Revert "Don't stat(/etc/localtime) between read() and write() copying files"

2018-01-15 Thread Fabian Vogt 
Git commit 16b21e7223f5bc070dcfd540ede55e5837ccc097 by Fabian Vogt.
Committed on 15/01/2018 at 11:31.
Pushed by fvogt into branch 'master'.

Revert "Don't stat(/etc/localtime) between read() and write() copying files"

This reverts commit f7e00b40a6d35fbfe536cdb99d6f22b643676e5e.

This results in calling special() without the ioslave's consent, breaking
at least the trash and desktop ioslaves.

CCMAIL: jtam...@gmail.com
CCMAIL: kde-frameworks-devel@kde.org

M  +12   -13   src/core/slavebase.cpp

https://commits.kde.org/kio/16b21e7223f5bc070dcfd540ede55e5837ccc097

diff --git a/src/core/slavebase.cpp b/src/core/slavebase.cpp
index b0625a51..4f8a5dad 100644
--- a/src/core/slavebase.cpp
+++ b/src/core/slavebase.cpp
@@ -86,8 +86,6 @@ public:
 QStandardPaths::enableTestMode(true);
 }
 pendingListEntries.reserve(KIO_MAX_ENTRIES_PER_BATCH);
-lastTimeout.start();
-nextTimeout.start();
 }
 ~SlaveBasePrivate()
 {
@@ -112,9 +110,8 @@ public:
 KConfigGroup *configGroup;
 QUrl onHoldUrl;
 
-QElapsedTimer lastTimeout;
-QElapsedTimer nextTimeout;
-qint64 nextTimeoutMsecs;
+QDateTime lastTimeout;
+QDateTime nextTimeout;
 KIO::filesize_t totalSize;
 KRemoteEncoding *remotefile;
 enum { Idle, InsideMethod, FinishedCalled, ErrorCalled } m_state;
@@ -276,9 +273,9 @@ SlaveBase::~SlaveBase()
 void SlaveBase::dispatchLoop()
 {
 while (!d->exit_loop) {
-if (d->nextTimeout.isValid() && 
(d->nextTimeout.hasExpired(d->nextTimeoutMsecs))) {
+if (d->nextTimeout.isValid() && (d->nextTimeout < 
QDateTime::currentDateTime())) {
 QByteArray data = d->timeoutData;
-d->nextTimeout.restart();
+d->nextTimeout = QDateTime();
 d->timeoutData = QByteArray();
 special(data);
 }
@@ -287,7 +284,7 @@ void SlaveBase::dispatchLoop()
 
 int ms = -1;
 if (d->nextTimeout.isValid()) {
-ms = qMax(d->nextTimeout.elapsed() - d->nextTimeoutMsecs, 1);
+ms = 
qMax(QDateTime::currentDateTime().msecsTo(d->nextTimeout), 1);
 }
 
 int ret = -1;
@@ -532,11 +529,13 @@ void SlaveBase::processedSize(KIO::filesize_t _bytes)
 {
 bool emitSignal = false;
 
+QDateTime now = QDateTime::currentDateTime();
+
 if (_bytes == d->totalSize) {
 emitSignal = true;
 } else {
 if (d->lastTimeout.isValid()) {
-emitSignal = d->lastTimeout.hasExpired(100); // emit size 10 times 
a second
+emitSignal = d->lastTimeout.msecsTo(now) >= 100; // emit size 10 
times a second
 } else {
 emitSignal = true;
 }
@@ -545,7 +544,7 @@ void SlaveBase::processedSize(KIO::filesize_t _bytes)
 if (emitSignal) {
 KIO_DATA << KIO_FILESIZE_T(_bytes);
 send(INF_PROCESSED_SIZE, data);
-d->lastTimeout.restart();
+d->lastTimeout = now;
 }
 
 //d->processed_size = _bytes;
@@ -1047,11 +1046,11 @@ int SlaveBase::readData(QByteArray &buffer)
 void SlaveBase::setTimeoutSpecialCommand(int timeout, const QByteArray &data)
 {
 if (timeout > 0) {
-d->nextTimeoutMsecs = timeout*1000; // from seconds to miliseconds
+d->nextTimeout = QDateTime::currentDateTime().addSecs(timeout);
 } else if (timeout == 0) {
-d->nextTimeoutMsecs = 1000;
+d->nextTimeout = QDateTime::currentDateTime().addSecs(1);// 
Immediate timeout
 } else {
-d->nextTimeoutMsecs = 1;
+d->nextTimeout = QDateTime();// Canceled
 }
 
 d->timeoutData = data;

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

2018-01-15 Thread David Faure 
dfaure added a comment.


  I'm 100% sure the same rules applies, because the "limitations" of operator[] 
come from C++ and therefore apply to all associative containers.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9824

To: mwolff, dfaure, rjvbb, #kdevelop
Cc: markg, #frameworks

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Laurent Montel 
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  indeed good catch

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9884

To: sars, #frameworks, mlaurent

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/33/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 10:19:26 +
 Build duration:
5 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/14)0%
(0/14)0%
(0/847)0%
(0/552)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/7)0%
(0/7)0%
(0/523)0%
(0/414)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/306)0%
(0/134)

D9884: KMultiTabBar: Fix regression in conversion to new style connect()

2018-01-15 Thread Kåre Särs 
sars created this revision.
sars added reviewers: Frameworks, mlaurent.
Restricted Application added a project: Frameworks.
sars requested review of this revision.

REVISION SUMMARY
  The conversion to new style connect introduced a bug. The old connect 
properly used the base class signal while the new connect connects to the 
derived signal which actually should be emitted as a result of the base class 
signal.

TEST PLAN
  Kate can now open/close the tool views when clicking on the sidebar buttons.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9884

AFFECTED FILES
  src/kmultitabbar.cpp

To: sars, #frameworks, mlaurent

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/32/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 10:14:04 +
 Build duration:
5 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/14)0%
(0/14)0%
(0/847)0%
(0/552)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/7)0%
(0/7)0%
(0/523)0%
(0/414)src.libkirigami0%
(0/5)0%
(0/5)0%
(0/306)0%
(0/134)

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

2018-01-15 Thread Mark Gaiser 
markg added inline comments.

INLINE COMMENTS

> dfaure wrote in kdirwatch.cpp:721
> .insert(e->wd, e) is a hair faster, says Effective STL Item 24 :)

m_inotify_wd_to_entry is a QHash, not a std::unordered_map ;)
Not sure if the same rules from that book apply to Qt (i doubt it).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9824

To: mwolff, dfaure, rjvbb, #kdevelop
Cc: markg, #frameworks

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-15 Thread Jaime Torres Amate 
jtamate abandoned this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

To: jtamate, #frameworks, dfaure
Cc: ngraham, mmustac

D9770: Code de-duplication in byteSize(double size)

2018-01-15 Thread Jaime Torres Amate 
jtamate retitled this revision from "Optimization of byteSize(double size)" to 
"Code de-duplication in byteSize(double size)".
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.

REPOSITORY
  R288 KJobWidgets

BRANCH
  performance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9770

To: jtamate, #frameworks, mwolff
Cc: ngraham, cfeck, mwolff, broulik

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.9 - Build # 12 - Fixed!

2018-01-15 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.9/12/
 Project:
Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 09:03:58 +
 Build duration:
1 hr 6 min and counting

D4361: [Containment] Move contains() check inside NDEBUG

2018-01-15 Thread Kai Uwe Broulik 
broulik abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4361

To: broulik, #plasma
Cc: bshah, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9821: Use QSignalSpy::wait instead of QTest::wait where possible

2018-01-15 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Oh, right. I see. Still very strange that QTRY_COMPARE_WITH_TIMEOUT behaves 
differently (if more signals are coming in than expected, the current (old) 
code could have caught them too, during the 50ms. Actually that might explain 
some of the flakiness I sometimes saw
  
  OK, that's another reason for your patch, which stops as soon as the last 
signal is emitted.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9821

To: mwolff, dfaure
Cc: #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 47 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/47/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 15 Jan 2018 09:33:19 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3557/13218)19%
(1973/10451)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(250/2152)7%
(97/1450)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(827/2911)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1611)28%
(317/1119)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D9770: Optimization of byteSize(double size)

2018-01-15 Thread Milian Wolff 
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  - do not ever profile a debug build, the results are completely bogus
  - do not use callgrind, use perf
  
  that said, I'm OK with this patch but the commit message should not talk 
about performance, but rather about code de-duplication. I doubt this has such 
a bit effect in a release build.

REPOSITORY
  R288 KJobWidgets

BRANCH
  performance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9770

To: jtamate, #frameworks, mwolff
Cc: ngraham, cfeck, mwolff, broulik

D9784: [ConfigModule] Re-use QML context and engine if any

2018-01-15 Thread Kai Uwe Broulik 
broulik closed this revision.
broulik added a comment.


  
https://cgit.kde.org/kdeclarative.git/commit/?id=84a370ce2c3ac48be9e8745a93cd347bba463323

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9784

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/44/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 09:39:32 +
 Build duration:
3 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13223)19%
(1975/10451)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(251/2156)7%
(98/1454)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(827/2907)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1611)28%
(318/1119)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 66 - Still unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/66/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 09:03:20 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.testtrash

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

2018-01-15 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/43/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Jan 2018 09:23:28 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13221)19%
(1975/10449)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(251/2156)7%
(98/1454)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(827/2907)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1611)28%
(318/1119)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1966)18%
(306/1701)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

  1   2   >