D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

[Ben Cooksley]

bcooksley added subscribers: zimmerman, bcooksley.
bcooksley added a comment.


  @rjvbb Please mind your language. From my perspective what you are asking of 
@mwolff here is quite unreasonable - I can't see any reason why incremental 
improvements, piece by piece would be unacceptable here.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9824

To: mwolff, dfaure, rjvbb, #kdevelop
Cc: bcooksley, zimmerman, markg, #frameworks

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 1 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/1/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 18 Jan 2018 07:07:38 +
 Build duration:
2 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.menutest

Re: Python bindings using cppyy (was: An update on Python bindings)

[Ben Cooksley]

On Sun, Jan 14, 2018 at 7:05 AM, Shaheed Haque  wrote:
> Thanks to some upstream fixes, I have the cppyy-based bindings for KF5 and
> also Qt5 (see below) showing signs of life. Notes:

Hi Shaheed,

>
> The packaging has advanced to the point where I think ECM-based
> framework-by-framework bindings are a real possibility, with both Py2 and
> Py3. AFAICS, this addresses the main feedback received to date.
> With reference to the remark about tracking dependencies between frameworks,
> apologies for the delayed response as I somehow missed the email. I note
> that the dependencies currently in CMake often seem incomplete. I'll bring
> that to the community separately.
> There is one issue still open upstream
> (https://bitbucket.org/wlav/cppyy/issues/16/pragma-link-defined_in-seems-to-select).
> However, I don't consider this to be a showstopper...we might even be able
> to live with it as is.
> For me, the jury is still out on PyQt versus a new set of cppyy-based Qt
> bindings. Clearly PyQt is solid and mature, but the limitations really
> concern me (if anybody wants to know more, I'm happy to discuss, but let's
> do that in another thread please). Now, given that there are examples in the
> wild of interoperating cppyy/cling/ROOT with PyQt, I'm going to sidestep
> this question but am playing with a cppyy-based approach. At this point, all
> of Qt has basic cppyy-based bindings, and the next step is to tackle things
> like finding a way to express the object ownership/destruction rules in a
> more-or-less systematic way.
> On the P2/P3 question, I'm presently still committed to both P2 and P3. I
> *have* had a couple of minor occasions where P3-only might have been nice
> *for my code*, but if I do find an issue that tips the balance, or I find
> some serious benefit *for the bindings*, I'll drop P2. One possible such
> benefit would be if I can see a sane way to address PEP484 type hints.
>
> To get here, I had to build a subset of the tooling I previously had
> developed for the SIP-based approach. The big difference is the absence of
> any need to support customisation of the generated bindings. I am hopeful
> that in the worst case, there might be some minimal customisation (known as
> Pythonisations in cppyy parlance) such as for #4 above, but nothing like the
> scale needed for SIP.
>
> The core tooling is not specific to KF5 or KDE or Qt5, and is developed in
> upstream cppyy over on bitbucket.org. The core tooling is built around
> CMake, notably for the generation phase and the C++ library build.
>
> The PoC extends the core tooling with Pythonic packaging and installation
> using pip/wheels, also from CMake. As before I would look for help to get an
> ECM equivalent, possibly based on the same approach but perhaps including CI
> and distribution via PyPi.

Once the necessary changes and tooling have been landed into the
Frameworks (including ECM) repositories we can certainly look into any
changes that are needed on the CI system. I think the Python
development packages should already be installed though, courtesy of
the needs of other KDE software (these might be Python 3 ones though).

In regards to PyPi - are you thinking of source packages here, or binaries?

If it's sources, then it's something that would need to be handled as
part of the Frameworks release process (ideally someone other than
David would look after it, making sure each one that was being
uploaded worked). For binaries, that would be best handled by the
Binary Factory.

>
> Finally, now would be a good time for anybody else who wants to get involved
> to step up, especially as a new job limits my free time.
>
> Thanks, Shaheed

Cheers,
Ben Cooksley
KDE Sysadmin

>
> P.S. Not to stoke the the P2/P3 wars unnecessarily, but while I know that
> upstream Clang just added P3 support in the clang 5.0 release, current
> Ubuntu only packages it for 2.7.14. So I won't be moving yet...
>
> On 5 November 2017 at 13:23, Boudewijn Rempt  wrote:
>>
>> On Sat, 4 Nov 2017, Chris Burel wrote:
>>
>> > I think this is a remarkably short sighted statement. It assumes that
>> > people that would use these bindings have no existing Python codebase at
>> > all, and can afford to start a brand new project. The reality is much
>> > different.
>> >
>> > Let's take a specific example. I have 6 years experience writing Python
>> > for the visual effects industry. We have a 10 year old Python 2 codebase. 
>> > We
>> > also use an application from Autodesk called Maya. It has been a Qt 4
>> > application with Python 2 embedded since 2012. In 2016 they jumped to qt 5
>> > and pyside2. Now Autodesk knows that companies have built large codebase
>> > around their product that requires Python 2. What would've happened if
>> > pyside2 did not support Python 2.7? They'd be stuck either forcing all 
>> > their
>> > customers to move to Python 3 and risk people not wanting the new version 
>> > of
>> > the software, or 

Dependency Loop: Purpose

[Ben Cooksley]

Hi all,

I've been examining the dependencies for Purpose, and it appears that
it has build time dependencies on 'kaccounts-integration' and
'kdeconnect-kde'

This creates an effective dependency loop as these two projects are
dependent on Frameworks.

Any suggestions to fix this? If it is for a plugin i'd suggest that
the plugins in question be relocated into those projects as Frameworks
really shouldn't depend on things in Applications or Extragear.

This also increases the risk of CI breakage as those projects, along
with everything they depend on is now required by Frameworks.

Cheers,
Ben

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 91 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/91/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Thu, 18 Jan 2018 06:30:26 +
 Build duration:
8 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31542/59385)38%
(18553/48540)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8611/9037)50%
(5311/10603)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8341/14344)50%
(4868/9712)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3848/7794)33%
(1617/4880)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(509/974)42%
(394/938)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1364)0%
(0/1513)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(71/258)8%
(17/220)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 90 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/90/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 17 Jan 2018 03:59:57 +
 Build duration:
1 day 2 hr and counting
   CONSOLE OUTPUT
  [...truncated 231.08 KB...]Generating MOC source include/hostinfo.mocGenerating MOC source include/moc_job_base.cppGenerating MOC source include/moc_job_p.cppGenerating MOC source include/moc_kcoredirlister.cppGenerating MOC source include/moc_kcoredirlister_p.cppGenerating MOC source include/moc_klocalsocket.cppGenerating MOC source include/moc_knfsshare.cppGenerating MOC source include/moc_kpasswdserverloop_p.cppGenerating MOC source include/kprotocolmanager.mocGenerating MOC source include/moc_ksambashare.cppGenerating MOC source include/moc_kssld_interface.cppGenerating MOC source include/moc_ktcpsocket.cppGenerating MOC source include/moc_listjob.cppGenerating MOC source include/moc_mimetypejob.cppGenerating MOC source include/moc_mkdirjob.cppGenerating MOC source include/moc_mkpathjob.cppGenerating MOC source include/moc_multigetjob.cppGenerating MOC source include/moc_restorejob.cppGenerating MOC source include/moc_scheduler.cppGenerating MOC source include/moc_scheduler_p.cppGenerating MOC source include/moc_simplejob.cppGenerating MOC source include/moc_slaveinterface.cppGenerating MOC source include/moc_specialjob.cppGenerating MOC source include/moc_statjob.cppGenerating MOC source include/storedtransferjob.mocGenerating MOC source include/moc_storedtransferjob.cppGenerating MOC source include/moc_transferjob.cppGenerating MOC source EWIEGA46WW/moc_connectionbackend_p.cppGenerating MOC source EWIEGA46WW/moc_connectionserver.cppGenerating MOC source EWIEGA46WW/moc_dataprotocol_p.cppGenerating MOC source EWIEGA46WW/moc_dataslave_p.cppGenerating MOC source EWIEGA46WW/moc_davjob.cppGenerating MOC source EWIEGA46WW/moc_faviconscache_p.cppGenerating MOC source EWIEGA46WW/moc_idleslave.cppGenerating MOC source EWIEGA46WW/moc_kdirnotify.cppGenerating MOC source EWIEGA46WW/moc_sessiondata_p.cppGenerating MOC source EWIEGA46WW/moc_slave.cppGenerating MOC source EWIEGA46WW/moc_slaveconfig.cppGenerating MOC source EWIEGA46WW/moc_usernotificationhandler_p.cppGenerating MOC compilation mocs_compilation.cpp[  8%] Built target KF5KIOCore_autogenScanning dependencies of target KF5KIONTLM[  8%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/kntlm.cpp.o[  8%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/des.cpp.o[  8%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/KF5KIONTLM_autogen/mocs_compilation.cpp.o[  8%] Linking CXX shared library ../../bin/libKF5KIONTLM.so[  8%] Built target KF5KIONTLM[  9%] Generating kcookieserverinterface.mocScanning dependencies of target kcookiejar5[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookieserverinterface.cpp.o[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/main.cpp.o[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookiejar5_autogen/mocs_compilation.cpp.o[  9%] Linking CXX executable ../../../../bin/kcookiejar5[  9%] Built target kcookiejar5[  9%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/protocoltojson_autogen/mocs_compilation.cpp.o[  9%] Generating kcookieserveradaptor.moc[ 10%] Linking CXX executable ../../bin/protocoltojson[ 10%] Built target protocoltojsonScanning dependencies of target ktelnetservice5[ 10%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice.cpp.oScanning dependencies of target kded_kcookiejar[ 10%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookiejar.cpp.o[ 10%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice5_autogen/mocs_compilation.cpp.o[ 10%] Linking CXX executable ../../../bin/ktelnetservice5[ 10%] Built target ktelnetservice5Scanning dependencies of target lockingtest[ 10%] Building CXX object src/ioslaves/trash/tests/CMakeFiles/lockingtest.dir/lockingtest.cpp.o[ 10%] Building CXX object src/ioslaves/trash/tests/CMakeFiles/lockingtest.dir/__/kinterprocesslock.cpp.o[ 11%] Building CXX object src/ioslaves/trash/tests/CMakeFiles/lockingtest.dir/lockingtest_autogen/mocs_compilation.cpp.o[ 11%] Linking CXX executable ../../../../bin/lockingtest[ 11%] Built target lockingtestScanning dependencies of target kpac_dhcp_helper[ 12%] Building C object src/kpac/CMakeFiles/kpac_dhcp_helper.dir/kpac_dhcp_helper.c.o[ 12%] Building CXX object src/kpac/CMakeFiles/kpac_dhcp_helper.dir/kpac_dhcp_helper_autogen/mocs_compilation.cpp.o[ 12%] Linking CXX executable ../../bin/kpac_dhcp_helper[ 12%] Built target kpac_dhcp_helperScanning dependencies of target httpheaderdispositiontest[ 12%] Building CXX object autotests/http/CMakeFiles/httpheaderdispositiontest.dir/httpheaderdispositiontest.cpp.o[ 12%] Building CXX 

D9712: balooctl status: translatable message

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  translated

REVISION DETAIL
  https://phabricator.kde.org/D9712

To: michaelh, #frameworks, vhanda, smithjd, lueck, lbeltrame
Cc: ltoscano, lbeltrame, elvisangelaccio, lueck, dfaure, ngraham

D9712: balooctl status: translatable message

[Burkhard Lück]

lueck added a comment.


  i18n looks ok, thanks

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9712

To: michaelh, #frameworks, vhanda, smithjd, lueck
Cc: ltoscano, lbeltrame, elvisangelaccio, lueck, dfaure, ngraham

D9950: [KUser] Check whether .face.icon is actually readable before returning it

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9950

To: broulik, #frameworks, davidedmundson, apol
Cc: ngraham

D9951: [KUserProxy] Adjust to accounts service

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM

INLINE COMMENTS

> kuserproxy.cpp:66
> +if (path == m_user.faceIconPath() || path == QDir::homePath() + 
> QLatin1String("/.face.icon")
> +|| path == accountsServiceIconPath + QLatin1String("/") + 
> m_user.loginName()) {
>  // we need to force updates, even when the path doesn't change,

QLatin1Char('/')

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9951

To: broulik, #plasma
Cc: apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D9793: Fall back to language name for translations lookup if locale name fails

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9793

To: wbauer, #frameworks, aacid
Cc: aacid, safaalfulaij, #build_system

D9951: [KUserProxy] Adjust to accounts service

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9951

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9951: [KUserProxy] Adjust to accounts service

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9951

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9951: [KUserProxy] Adjust to accounts service

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The avatar can also lie in the accounts service directory. Monitor there and 
also monitor for removal.
  Also in the handler check all paths we monitor rather than `faceIconPath` 
which might be empty due to the file having been removed.
  
  BUG: 384107

TEST PLAN
  - Created an avatar, showed up in Kickoff right away
  - Deleted an avatar, default icon showed up in Kickoff right away
  
  However, together with https://phabricator.kde.org/D9950 changing between 
avatars now throws ```QML Image: Error decoding: 
file:///var/lib/AccountsService/icons/kaiuwe: Dieser Typ von Bilddaten wird 
nicht unterstützt```. Oh ffs.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D9951

AFFECTED FILES
  src/qmlcontrols/kcoreaddons/kuserproxy.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9950: [KUser] Check whether .face.icon is actually readable before returning it

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Here `.face.icon` is a symlink to `.face` and when I remove my avatar in user 
manager, the `.face` is removed and `.face.icon` becomes a stale symlink.

TEST PLAN
  Where is the bug? :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9950

AFFECTED FILES
  src/lib/util/kuser_unix.cpp

To: broulik, #frameworks, davidedmundson

D9712: balooctl status: translatable message

[Michael Heidelbach]

michaelh retitled this revision from "balooctl status: produce parseable 
output" to "balooctl status: translatable message".
michaelh edited the summary of this revision.
michaelh added a reviewer: lueck.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9712

To: michaelh, #frameworks, vhanda, smithjd, lueck
Cc: ltoscano, lbeltrame, elvisangelaccio, lueck, dfaure, ngraham

D9822: Add benchmarks for KDirWatch

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9822

To: mwolff, dfaure
Cc: #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: alexeymin, aacid, #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Randy Kron]

rkron updated this revision to Diff 25540.
rkron added a comment.


  After reviewing the kio commit where similar changes were made, I changed 
QFile::exists to QFileInfo::exists as was done in kio and have updated my 
patch. I should have looked at kio before my first submission. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9928?vs=25487=25540

REVISION DETAIL
  https://phabricator.kde.org/D9928

AFFECTED FILES
  src/plasma/svg.cpp

To: rkron, #frameworks, davidedmundson
Cc: alexeymin, aacid, #frameworks

D9793: Fall back to language name for translations lookup if locale name fails

[Wolfgang Bauer]

wbauer updated this revision to Diff 25536.
wbauer edited the summary of this revision.
wbauer edited the test plan for this revision.
wbauer added a comment.


  Leave bcp47Name() in for compatibility, add const.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9793?vs=25091=25536

REVISION DETAIL
  https://phabricator.kde.org/D9793

AFFECTED FILES
  modules/ECMQmLoader.cpp.in
  tests/ECMPoQmToolsTest/check.cmake.in

To: wbauer, #frameworks
Cc: aacid, safaalfulaij, #build_system

D1231: Add Remote Access interface to KWayland

[Roman Gilg]

romangg added a reviewer: romangg.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, 
plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D9793: Fall back to language name for translations lookup if locale name fails

[Wolfgang Bauer]

wbauer marked an inline comment as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9793

To: wbauer, #frameworks
Cc: aacid, safaalfulaij, #build_system

D9286: don't multiply svg sizes by devicepixelratio

[David Edmundson]

davidedmundson added a comment.


  I handle scaling everyewhere except for Plasma which does it's own thing.
  
  
  
  I'm not convinced by this patch:
  
  If this was Qt's devicePixelRatio this would definitely 100% make sense as 
there we write all UI code in logical sizes.
  
  But in Plasma it's up to the developer to convert everything from logical 
pixles to devicePixels themselves, so it does makes sense to multiply surely?
  
  On wayland we have both systems going at once.
  Which sounds super broken, but it just about works because 
Units.devicePixelRatio is (implicitly) divided through by Qt's devicePixelRatio.
  
  Units.devicePixelRatio should be exactly 1, because (unless explicitly 
overridden) our logical DPI is set to 96.(96/96 =1)
  
  So this patch shouldn't be affecting anything?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9286

To: mart, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/72/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 17 Jan 2018 08:52:09 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D9938: [Uri Filter Search Provider] Avoid double delete

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e0f3fac05287: [Uri Filter Search Provider] Avoid double 
delete (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9938?vs=25523=25524

REVISION DETAIL
  https://phabricator.kde.org/D9938

AFFECTED FILES
  src/urifilters/ikws/ikwsopts.cpp

To: broulik, dfaure
Cc: #frameworks

D9938: [Uri Filter Search Provider] Avoid double delete

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Oops.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9938

To: broulik, dfaure
Cc: #frameworks

D9938: [ikws search provider] Avoid double delete

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Since 
https://phabricator.kde.org/R241:6246cc48067845208cf5acd8b798abd68349cf18 the 
`SearchProviderRegistry` does that leading to a double delete on KCM 
destruction.
  
  BUG: 388983

TEST PLAN
  Opened KCM, closed KCM, no crash

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9938

AFFECTED FILES
  src/urifilters/ikws/ikwsopts.cpp

To: broulik, dfaure
Cc: #frameworks

D9938: [Uri Filter Search Provider] Avoid double delete

[Kai Uwe Broulik]

broulik retitled this revision from "[ikws search provider] Avoid double 
delete" to "[Uri Filter Search Provider] Avoid double delete".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9938

To: broulik, dfaure
Cc: #frameworks

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

[Alexey Min]

alexeymin added a comment.


  There was a similar fix commited somewhere (don't remember, in KIO?) related 
to QFile in newer Qt complaining about empty filenames passed, so this is 
probably fine too...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9928

To: rkron, #frameworks, davidedmundson
Cc: alexeymin, aacid, #frameworks

D9286: don't multiply svg sizes by devicepixelratio

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9286

To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart