D10046: unset maintainer

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH no-maintainer REVISION DETAIL https://phabricator.kde.org/D10046 To: sitter, apol, aacid Cc: #frameworks

D10058: KateView unit test: simplify finding KateViewInternal

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Less duplication => good! REPOSITORY R39 KTextEditor BRANCH SimplyTest (branched from master) REVISION DETAIL https://phabricator.kde.org/D10058 To: dhaumann, cullmann Cc:

D10054: Fix: View jumps when Scroll past end of document is enabled

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yeah, logic did seem to be flawed. To only look at the line makes sense. +1 for unit test ;=) (aka Fleißsternchen) REPOSITORY R39 KTextEditor BRANCH FixScrollPastEnd

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

rjvbb set the repository for this revision to R245 Solid. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7401 To: rjvbb, #frameworks, kfunk Cc: ngraham, kfunk, anthonyfieroni, cgilles, kde-mac

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

rjvbb updated this revision to Diff 25846. rjvbb marked 3 inline comments as done. rjvbb added a comment. updated as requested/discussed. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7401?vs=21187=25846 REVISION DETAIL https://phabricator.kde.org/D7401 AFFECTED FILES

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

rjvbb marked 10 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > kfunk wrote in iokitdevice.cpp:463 > Returning inside the case statements would make this code clearer as well. I don't share that opinion and think that multiple exit points do not make the code more

D9332: Allow filter places based on alternative application name

aacid added a comment. Probably the @since needs updating REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff, mlaurent Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks

D9966: [KIO] Fix issues with sharing of file descriptor

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fdreceiver.cpp:42 > +std::cerr << "Invalid socket address" << std::endl; > +return; > +} Missing ::close(m_socketDes); m_socketDes =

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr updated this revision to Diff 25839. chinmoyr added a comment. 1.Check for overflow condition. In such case file operation will terminate. 2.Return actual length of buffer 3.Use QStandardPaths::RuntimeLocation for socket creation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D9332: Allow filter places based on alternative application name

ngraham added a comment. Is this commitable now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff, mlaurent Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/76/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 18:02:37 + Build duration: 7 min 25 sec and counting JUnit Tests Name:

D10045: Don't assert on empty names

dfaure added a comment. Good point, done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10045 To: mwolff, dfaure Cc: dhaumann, #frameworks

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann updated this revision to Diff 25837. dhaumann added a comment. - Add unit test for scroll past end of document REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10054?vs=25830=25837 BRANCH FixScrollPastEnd (branched from master) REVISION

D10058: KateView unit test: simplify finding KateViewInternal

dhaumann created this revision. dhaumann added a reviewer: cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. dhaumann requested review of this revision. REVISION SUMMARY See title TEST PLAN make test REPOSITORY R39

D10045: Don't assert on empty names

dhaumann added a comment. @dfaure It seems to me there is some know-how in your head that you should add as comment to the ASSERT then ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10045 To: mwolff, dfaure Cc: dhaumann, #frameworks

Re: KHolidays as Framework (redux)

Another question: there are holiday files in the git repo. Are these files compiled in as resource or loaded via filesystem? If these files are not added as resource, this probably breaks on Windows and OSX. Best regards Dominik Am 20.01.2018 17:37 schrieb "Dominik Haumann"

D10045: Don't assert on empty names

dfaure added a comment. That assert is there to catch a horrible bug in the kioslave. UDS_NAME is NOT supposed to be empty, ever. Which kioslave was this about? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10045 To: mwolff, dfaure Cc: #frameworks

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/27/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 17:09:37 + Build duration: 4 min 39 sec and counting JUnit Tests Name:

D9958: balooctl status: Produce parseable output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a7150492b691: balooctl status: Produce parseable output (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9958?vs=25591=25833 REVISION DETAIL

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 16:27:02 + Build duration: 14 min and counting JUnit Tests

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann created this revision. dhaumann added a reviewer: cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. dhaumann requested review of this revision. REVISION SUMMARY This patch fixes a corner case for the following

D10053: Fix typo

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6ad30db92316: Fix typo (authored by romangg). Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D9894: [UDisks Device] Show loop device with their backing file name and icon

This revision was automatically updated to reflect the committed changes. Closed by commit R245:3e9c2791fd3f: [UDisks Device] Show loop device with their backing file name and icon (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9894?vs=25407=25827#toc REPOSITORY

D9895: [UDisks] Ignore non-user mounts

This revision was automatically updated to reflect the committed changes. Closed by commit R245:1384f275ab2f: [UDisks] Ignore non-user mounts (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9895?vs=25408=25828 REVISION DETAIL

D9895: [UDisks] Ignore non-user mounts

broulik edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9895 To: broulik, #plasma, #vdg, #frameworks, bshah Cc: mart, ngraham, sitter, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10053: Fix typo

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D10053 To: romangg, #plasma,

D10053: Fix typo

romangg added a reviewer: Plasma. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10053 To: romangg, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10053: Fix typo

romangg created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. romangg requested review of this revision. REVISION SUMMARY Fix a typo REPOSITORY R127 KWayland BRANCH master REVISION

D9894: [UDisks Device] Show loop device with their backing file name and icon

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. , showed up with file name a REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9894 To: broulik, #vdg, davidedmundson, bshah Cc: bshah, apol, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/27/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 14:59:21 + Build duration: 10 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/54/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 14:59:21 + Build duration: 8 min 45 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/51/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 14:59:21 + Build duration: 6 min 9 sec and counting

D9286: don't multiply svg sizes by devicepixelratio

This revision was automatically updated to reflect the committed changes. Closed by commit R242:af00946f81c6: dont multiply svg sizes by devicepixelratio (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9286?vs=23759=25823

D9895: [UDisks] Ignore non-user mounts

bshah accepted this revision as: bshah. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9895 To: broulik, #plasma, #vdg, #frameworks, bshah Cc: mart, ngraham, sitter, plasma-devel, ZrenBot, progwolff, lesliezhai,

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/39/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 14:08:20 + Build duration: 5 min 32 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/39/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 14:08:09 + Build duration: 5 min 44 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/37/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 14:07:56 + Build duration: 2 min 35 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/38/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 14:02:21 + Build duration: 5 min 57 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/38/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 14:02:21 + Build duration: 5 min 47 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/36/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 14:02:22 + Build duration: 2 min 57 sec and counting JUnit

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/5/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 13:35:31 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/5/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 13:35:31 + Build duration: 18 min and counting CONSOLE OUTPUT

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/5/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 23 Jan 2018 13:35:31 + Build duration: 9 min 6 sec and counting CONSOLE

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 13:35:31 + Build duration: 3 min 6 sec and counting JUnit Tests

D10034: [Purpose Menu] Create QQmlApplicationEngine on demand

This revision was automatically updated to reflect the committed changes. Closed by commit R495:d6452fc298f8: [Purpose Menu] Create QQmlApplicationEngine on demand (authored by broulik). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D10026: Fix loading NotifyByExecute

This revision was automatically updated to reflect the committed changes. Closed by commit R289:269045273695: Fix loading NotifyByExecute (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10026?vs=25772=25812 REVISION DETAIL

D4405: [KFilePreviewGenerator] Add ignoreMaximumSize

broulik abandoned this revision. broulik added a comment. This isn't really neccessary anymore as KIO ignores maximum size for `:local` consistently now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4405 To: broulik, emmanuelp, hein, dfaure Cc: #frameworks

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 13:17:16 + Build duration: 6 min 10 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/35/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 13:17:16 + Build duration: 4 min 23 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/37/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 13:17:16 + Build duration: 4 min 5 sec and counting JUnit Tests

D10045: Don't assert on empty names

mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This removes an assertion I just hit. Note how the code below

D10044: actually install the new animations context

This revision was automatically updated to reflect the committed changes. Closed by commit R266:c6fcf84e1ac8: actually install the new animations context (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10044?vs=25807=25810 REVISION

D10046: unset maintainer

sitter created this revision. sitter added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY Alex isn't really active right now, so untag him as maintainer and

D10044: actually install the new animations context

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10044 To: sitter, apol Cc: apol, #frameworks

D10044: actually install the new animations context

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/R266:495829b2b0fea458bfa01a996d23181d254e3521 introduced a new

D10026: Fix loading NotifyByExecute

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10026 To: broulik, #frameworks, hein

D9951: [KUserProxy] Adjust to accounts service

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. with Aleix's comment addressed in both places. (or just put the slash on accountsServiceIconPath) REPOSITORY R296 KDeclarative REVISION DETAIL

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil marked 2 inline comments as done. dvratil added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:450 > You're not actually sending the serial number or eisa anywhere.. > > The others do it in sendGeometry (including the manufacturer) > > When you do

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil updated this revision to Diff 25806. dvratil marked an inline comment as done. dvratil added a comment. Fix versioning REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10040?vs=25802=25806 BRANCH master REVISION DETAIL

D10034: [Purpose Menu] Create QQmlApplicationEngine on demand

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D10034 To: broulik, apol Cc: #frameworks

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a dependent revision: D10042: Parse EDID on the backend side. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: dvratil, graesslin, sebas Cc: davidedmundson, plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff,

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson added inline comments. INLINE COMMENTS > outputdevice.xml:32 > > > you need to bump this > outputdevice_interface.cpp:450 > SETTER(setModel, const QString&, model) > +SETTER(setSerialNumber, const QString&, serialNumber) > +SETTER(setEisaId, const QString&, eisaId)

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a dependent revision: D10041: Improve EDID information on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: dvratil, graesslin, sebas Cc: plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff, lesliezhai,

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil created this revision. dvratil added reviewers: graesslin, sebas. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. dvratil requested review of this revision. REPOSITORY R127 KWayland BRANCH

D9286: don't multiply svg sizes by devicepixelratio

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I'm 100% convinced Plasma needs to multiply it as it does everything in device pixels. However: void FrameSvgItem::updateDevicePixelRatio()

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/50/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 11:46:31 + Build duration: 8 min 38 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 11:46:31 + Build duration: 6 min 48 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/53/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 11:46:31 + Build duration: 2 min 51 sec and counting

D9223: [Plasma Dialog] Call window effects only if visible

broulik closed this revision. broulik added a comment. https://cgit.kde.org/plasma-framework.git/commit/?id=f3cd5d55fa323e65c0b01794a59b801d2716634a REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9223 To: broulik, #plasma, graesslin, apol Cc:

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 11:30:21 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 51 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/51/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 23 Jan 2018 11:30:21 + Build duration: 9 min 42 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 11:30:21 + Build duration: 6 min 50 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/32/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 11:30:21 + Build duration: 4 min 4 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 50 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/50/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 23 Jan 2018 11:08:01 + Build duration: 8 min 17 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/31/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 11:08:01 + Build duration: 7 min 22 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 11:08:01 + Build duration: 6 min 43 sec and counting JUnit

D9895: [UDisks] Ignore non-user mounts

mart added a comment. +100 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9895 To: broulik, #plasma, #vdg, #frameworks Cc: mart, ngraham, sitter, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10024: Add supportedSchemes feature

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. ship it with the extra check Aleix noted REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure, mart Cc: mart, apol,

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 11:08:01 + Build duration: 3 min 35 sec and counting JUnit Tests

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

mlaurent added a comment. I made a fix. I wait a rebuild on windows to see if it's ok REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: bcooksley, dfaure, #frameworks

D10034: [Purpose Menu] Create QQmlApplicationEngine on demand

broulik created this revision. broulik added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY Loading the QML file accounts for 2% of Spectacle's startup time.

Re: KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 2 - Still Unstable!

On Tue, Jan 23, 2018 at 4:58 AM, Aleix Pol wrote: > How could I reproduce this? I can only reproduce it with a system without > QT_PLUGIN_PATH > properly defined. > Hi Aleix, To my knowledge the CI system sets QT_PLUGIN_PATH properly. The best way to reproduce this would in

KDE CI: Frameworks kholidays kf5-qt5 SUSEQt5.7 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20SUSEQt5.7/2/ Project: Frameworks kholidays kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 08:59:55 + Build duration: 5 min 37 sec and counting JUnit Tests

KDE CI: Frameworks kholidays kf5-qt5 SUSEQt5.10 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20SUSEQt5.10/2/ Project: Frameworks kholidays kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 08:59:55 + Build duration: 1 min 44 sec and counting JUnit Tests

D10024: Add supportedSchemes feature

mwolff added a comment. In https://phabricator.kde.org/D10024#194431, @apol wrote: > Makes sense I guess. > > Sounds like it would be useful to set this through kiosk, would that work? Probably, but I have zero experience about kiosk. I'd have to read the defaults from a

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

bcooksley added a comment. This fails to build on Windows, please see https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/49/consoleText Can you please look into and commit a fix for this as soon as possible? REPOSITORY R244 KCoreAddons REVISION DETAIL

KDE CI: Frameworks kholidays kf5-qt5 SUSEQt5.7 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20SUSEQt5.7/1/ Project: Frameworks kholidays kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 08:28:36 + Build duration: 1 min 52 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kholidays kf5-qt5 FreeBSDQt5.9 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20FreeBSDQt5.9/1/ Project: Frameworks kholidays kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 08:28:38 + Build duration: 1 min 4 sec and counting JUnit Tests

KDE CI: Frameworks kholidays kf5-qt5 WindowsMSVCQt5.9 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20WindowsMSVCQt5.9/1/ Project: Frameworks kholidays kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 23 Jan 2018 08:28:18 + Build duration: 1 min 51 sec and counting JUnit

KDE CI: Frameworks kholidays kf5-qt5 SUSEQt5.10 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20SUSEQt5.10/1/ Project: Frameworks kholidays kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Jan 2018 08:28:37 + Build duration: 1 min 30 sec and counting JUnit Tests

D9983: Don't stat(/etc/localtime) between read() and write() copying files

lbeltrame added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9983 To: jtamate, #frameworks, dfaure Cc: fvogt, ngraham