D9207: Don't load KDE platform module in kglobalaccel5
hein abandoned this revision. hein added a comment. As mentioned, I'm OK with abandoning it. I think the change is hygienic, but it's also a micro-optimization. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 98 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/98/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Feb 2018 04:19:47 + Build duration: 44 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 117 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/117/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 07 Feb 2018 04:19:47 + Build duration: 29 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)67% (295/442)67% (295/442)53% (31482/59477)38% (18477/48788)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (73/73)100% (73/73)94% (8536/9082)48% (5196/10727)autotests.http100% (9/9)100% (9/9)100% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src100% (1/1)100% (1/1)100% (5/5)75% (3/4)src.core84% (101/120)84% (101/120)58% (8338/14343)50% (4868/9712)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets79% (30/38)79% (30/38)49% (3872/7837)33% (1634/4920)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (5/5)100% (5/5)52% (512/976)42% (414/996)src.ioslaves.file.kauth0% (0/3)0% (0/3)0% (0/104)0% (0/75)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1365)0% (0/1515)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1783/4338)35% (1375/3979)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (631/1333)55% (649/1174)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/258)8% (19/242)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash67% (8/12)67% (8/12)52%
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 118 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/118/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Feb 2018 04:19:47 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)67% (295/442)67% (295/442)53% (31487/59478)38% (18479/48712)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (73/73)100% (73/73)94% (8536/9082)48% (5199/10727)autotests.http100% (9/9)100% (9/9)100% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src100% (1/1)100% (1/1)100% (5/5)75% (3/4)src.core84% (101/120)84% (101/120)58% (8338/14343)50% (4869/9708)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets79% (30/38)79% (30/38)49% (3873/7837)33% (1635/4920)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (5/5)100% (5/5)52% (511/976)41% (413/996)src.ioslaves.file.kauth0% (0/3)0% (0/3)0% (0/104)0% (0/75)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1365)0% (0/1515)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1788/4338)35% (1373/3979)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (631/1333)55% (649/1174)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/258)8% (19/242)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash67% (8/12)67% (8/12)5
D10355: Use the new KPackage::fileUrl() method to load mainscripts.
malteveerman added a reviewer: Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D10355 To: malteveerman, #frameworks Cc: #frameworks, michaelh, ngraham
D10355: Use the new KPackage::fileUrl() method to load mainscripts.
malteveerman edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D10355 To: malteveerman Cc: #frameworks, michaelh, ngraham
D10355: Use the new KPackage::fileUrl() method to load mainscripts.
malteveerman created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. malteveerman requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D10355 AFFECTED FILES src/kdeclarative/qmlobject.cpp To: malteveerman Cc: #frameworks, michaelh, ngraham
Re: Possible regression in kio with data loss
On Tue, Feb 6, 2018 at 4:17 PM, Jaime wrote: > Hi all, this is becoming urgent if next release is this weekend. > It still happens to me (with kio just compiled from master) > If it is then add the KIO master (aka, David Faure) in cc :) As i just did. > > > 2018-02-05 8:18 GMT+01:00 Jaime : > >> >> >> 2018-02-04 23:42 GMT+01:00 Albert Astals Cid : >> >>> El dissabte, 20 de gener de 2018, a les 11:56:34 CET, Jaime va escriure: >>> > Hi, >>> >>> Is it me or noone reacted to a "data loss regression" email? >>> >>> That's pretty sad. >>> >>> > >>> > Last weekend I did the following: >>> > * build kio using kdesrc-build >>> > * copy the resulting bin/kf5/file.so to >>> /usr/lib64/qt5/plugins/kf5/kio >>> > * ldconfig >>> > * restart the session >>> > Just to be sure that all processes are using the new kio. >>> > >>> > I copied files to an ntfs filesystem and the files were copied and >>> the >>> > messages about rights where shown. >>> >>> How are you copying the files? Dolphin? kdecp5? something else? >>> >> >> With dolphin, drag&drop. >> >> Probably I'm wrong, but isn't this addressed in >> https://phabricator.kde.org/D10233 ? >> >> >>> Cheers, >>> Albert >>> >>> > >>> > Today I've done the same as last weekend, but when I copy a file to >>> the >>> > same filesystem, there is a message that the owner can't be changed, >>> and >>> > the resulting file has always 0 bytes (screenshot attached). If I move >>> the >>> > file, the original file content is lost, and also the destination has 0 >>> > bytes. >>> > >>> > This can be reproduced also in a loopback vfat, created following the >>> > next steps: >>> > >>> > dd if=/dev/zero of=fat.fs bs=1024 count=5120 >>> > (create the file fat.fs with only 5 MB) >>> > /usr/sbin/mkfs.vfat fat.fs >>> > (create the filesystem) >>> > sudo mount -t vfat -o uid=,fmask=0007,dmask=,rw,noexec,loop >>> fat.fs >>> > /mnt >>> > (mount being root the owner) >>> > >>> > try to copy any file to /mnt >>> > >>> > sudo umount /mnt >>> > (don't forget to umount it when the tests are finished). >>> > >>> > Best Regards. >>> >>> >>> >>> >>> >> >
D10333: Introduce K_PLUGIN_CLASS_WITH_JSON
kossebau added a comment. Makes sense to me to have a shorter version for the common case of just one registered plugin. Less boilerplate :) Please add a note in the API dox that this macro is for the case of just one plugin class, and link to K_PLUGIN_FACTORY_WITH_JSON for the case someone wants multiple plugins (yes, there are some use-cases for that). Please also add K_PLUGIN_CLASS_WITH_JSON (or whatever name it will be in the end) to the list KCoreAddons_AUTOMOC_MACRO_NAMES in the toplevel CMakeLists.txt. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10333 To: aacid Cc: kossebau, apol, #frameworks, michaelh, ngraham
D10339: Drop obsolete version checks
This revision was automatically updated to reflect the committed changes. Closed by commit R306:faf16778ea6b: Drop obsolete version checks (authored by heikobecker). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10339?vs=26646&id=26660 REVISION DETAIL https://phabricator.kde.org/D10339 AFFECTED FILES src/browserextension.h src/liveconnectextension.h To: heikobecker, #frameworks, apol Cc: michaelh, ngraham
D9207: Don't load KDE platform module in kglobalaccel5
graesslin added a comment. In https://phabricator.kde.org/D9207#201848, @hein wrote: > Well, the maintainer spoke out against it, so not much I can do. Please be aware that I am no longer the maintainer of kglobalaccel. Nevertheless I recommend against it as the risk of breakage is high especially as nobody notices breakage during the frameworks dev cycle. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10339: Drop obsolete version checks
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D10339 To: heikobecker, #frameworks, apol Cc: michaelh, ngraham
D10325: [KFileWidget] Hide places frame and header
apol added inline comments.
INLINE COMMENTS
> kfilewidget.cpp:1351
> placesDock = new QDockWidget(i18nc("@title:window", "Places"), q);
> -placesDock->setFeatures(QDockWidget::DockWidgetClosable);
> +placesDock->setFeatures(QDockWidget::NoDockWidgetFeatures);
> +placesDock->setTitleBarWidget(new
> KDEPrivate::KFileWidgetDockTitleBar(placesDock));
Does it really make sense that it's a dock if it can't be interacted with?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
Re: Possible regression in kio with data loss
Hi all, this is becoming urgent if next release is this weekend. It still happens to me (with kio just compiled from master) 2018-02-05 8:18 GMT+01:00 Jaime : > > > 2018-02-04 23:42 GMT+01:00 Albert Astals Cid : > >> El dissabte, 20 de gener de 2018, a les 11:56:34 CET, Jaime va escriure: >> > Hi, >> >> Is it me or noone reacted to a "data loss regression" email? >> >> That's pretty sad. >> >> > >> > Last weekend I did the following: >> > * build kio using kdesrc-build >> > * copy the resulting bin/kf5/file.so to /usr/lib64/qt5/plugins/kf5/kio >> > * ldconfig >> > * restart the session >> > Just to be sure that all processes are using the new kio. >> > >> > I copied files to an ntfs filesystem and the files were copied and the >> > messages about rights where shown. >> >> How are you copying the files? Dolphin? kdecp5? something else? >> > > With dolphin, drag&drop. > > Probably I'm wrong, but isn't this addressed in > https://phabricator.kde.org/D10233 ? > > >> Cheers, >> Albert >> >> > >> > Today I've done the same as last weekend, but when I copy a file to >> the >> > same filesystem, there is a message that the owner can't be changed, and >> > the resulting file has always 0 bytes (screenshot attached). If I move >> the >> > file, the original file content is lost, and also the destination has 0 >> > bytes. >> > >> > This can be reproduced also in a loopback vfat, created following the >> > next steps: >> > >> > dd if=/dev/zero of=fat.fs bs=1024 count=5120 >> > (create the file fat.fs with only 5 MB) >> > /usr/sbin/mkfs.vfat fat.fs >> > (create the filesystem) >> > sudo mount -t vfat -o uid=,fmask=0007,dmask=,rw,noexec,loop >> fat.fs >> > /mnt >> > (mount being root the owner) >> > >> > try to copy any file to /mnt >> > >> > sudo umount /mnt >> > (don't forget to umount it when the tests are finished). >> > >> > Best Regards. >> >> >> >> >> >
D10343: Create containment on specified screen
hoffmannrobert edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10343 To: hoffmannrobert Cc: #frameworks, michaelh, ngraham
D9983: Don't stat(/etc/localtime) between read() and write() copying files
jtamate marked 2 inline comments as done. jtamate added a comment. So, good to go? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9983 To: jtamate, #frameworks, dfaure Cc: fvogt, ngraham, michaelh
D10124: Faster simplejob start
jtamate added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks, mwolff, dfaure Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh
D10124: Faster simplejob start
broulik added a comment. So, good to go? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks, mwolff Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh
D10343: Create containment on specified screen
hoffmannrobert edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10343 To: hoffmannrobert Cc: #frameworks, michaelh, ngraham
D10343: Create containment on specified screen
hoffmannrobert created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. hoffmannrobert requested review of this revision. REVISION SUMMARY Add methods used by Plasma::Containment *ShellCorona::addPanel(const QString &plugin) (see plasma-workspace): Containment *createContainmentForScreen(int screenNum, const QString &name, const QVariantList &args = QVariantList()); Containment *addContainmentForScreen(int screenNum, const QString &name, const QVariantList &args, uint id, bool delayedInit = false); void Containment::setLastScreen(int screen); These are needed to create panels on the current screen in multi-monitor environments, so panels can be created on all desired screens. Currently it is only possible to have panels on one screen. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D10343 AFFECTED FILES src/plasma/containment.cpp src/plasma/containment.h src/plasma/corona.cpp src/plasma/corona.h src/plasma/private/corona_p.h To: hoffmannrobert Cc: #frameworks, michaelh, ngraham
D8351: API dox: add note about calling setApplicationDomain after QApp creation
kossebau added a comment. In https://phabricator.kde.org/D8351#201926, @ilic wrote: > Yes, I guess in the end it's the simplest way to look at it. > > One thing though: I'd add at least another sentence claryfing that unlike an i18n* call, a ki18n* can happen at any time, and only its toString method should be called after Q*App instance creation (because that's when translation happens and locale is queried). Makes sense to me, will see to add that (with some post-commit review ;) ). If you have some phrasing proposal, would be happy to have something to copy (lazy me). REPOSITORY R249 KI18n BRANCH addNoteAboutCallingSetAppDomainAfterQApp REVISION DETAIL https://phabricator.kde.org/D8351 To: kossebau, #frameworks, ilic, ltoscano, dfaure Cc: dfaure, michaelh, ngraham
D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.
markg created this revision. markg added reviewers: dfaure, mwolff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY This allows the compiler to generate: - Move constructor - Move assingment - Copy constructor - Copy assignment - Destructor This in turn allows further KFileItem optimization throughout KIO and Dolphin. Also added a quite minimal test to see if move semantics work. As implemented now it roughly follows the "rule-of-five-default": http://scottmeyers.blogspot.nl/2014/03/a-concern-about-rule-of-zero.html I was tempted to go for the "rule-of-zero" which means not implementing any of those functions (thus the compiler generates them), but that - in my opinion - is not really clear as it's easy to add the destructor and then be surprised by not having move semantics anymore. TEST PLAN New test for move semantics (it passes, would probably pass without as well but just be a copy). Existing relevant tests (kfileitemtest and kdirmodeltest) all pass just fine. Running the new "testMove" through callgrind shows that the move constructor and assignment operator are really being used by that test. REPOSITORY R241 KIO BRANCH kfileitem_move REVISION DETAIL https://phabricator.kde.org/D10341 AFFECTED FILES autotests/kfileitemtest.cpp autotests/kfileitemtest.h src/core/kfileitem.cpp src/core/kfileitem.h To: markg, dfaure, mwolff Cc: #frameworks, michaelh, ngraham
D10340: Clean up old, unreachable code
heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY Nepomuk is never searched for, so the removed code wasn't used in a long time. Furthermore Nepomuk is pretty dead. REPOSITORY R306 KParts BRANCH cleanupnepomuk REVISION DETAIL https://phabricator.kde.org/D10340 AFFECTED FILES src/CMakeLists.txt src/browserrun_p.h To: heikobecker, #frameworks Cc: michaelh, ngraham
D8351: API dox: add note about calling setApplicationDomain after QApp creation
ilic added a comment. Yes, I guess in the end it's the simplest way to look at it. One thing though: I'd add at least another sentence claryfing that unlike an i18n* call, a ki18n* can happen at any time, and only its toString method should be called after Q*App instance creation (because that's when translation happens and locale is queried). REPOSITORY R249 KI18n BRANCH addNoteAboutCallingSetAppDomainAfterQApp REVISION DETAIL https://phabricator.kde.org/D8351 To: kossebau, #frameworks, ilic, ltoscano, dfaure Cc: dfaure, michaelh, ngraham
D10339: Drop obsolete version checks
heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY Frameworks already require Qt 5.7.0. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D10339 AFFECTED FILES src/browserextension.h src/liveconnectextension.h To: heikobecker, #frameworks Cc: michaelh, ngraham
D8351: API dox: add note about calling setApplicationDomain after QApp creation
kossebau added a comment. In https://phabricator.kde.org/D8351#161562, @ilic wrote: > Well... it's a tough situation. It is not by design that `i18n` calls should in any way depend on creation of `QApplication`, and also any library may place an `i18n` call before the main program creates `QApplication`. The only solution I see is that environment is rechecked at every `i18n` call. This would be easy to do (just replacing every `s->languages` with a newly implemented `s->getLanguages()`), but I've no idea what would be the performance hit of that. Thanks for reply, @ilic, sorry for not having picked up immediately, as I agree it's tough and I set the topic aside a little to have some thoughts develop in the back of my mind. One problem that i see with rechecking the environment at every i18n call is that this potentially could result in inconsistent UI. Because the average applications using KI18n is not written to support switching UI localization on the fly. Incl. KXMLGUI's language switching support, which only injects its settings at a roughly defined point in time, as part of the post-handlers of the Q*App instance creation. So I would agree with @dfaure that for the current KI18n usage (which is somewhat coupled with KXMLGUI's language switching support) we should just stick formally to what technically is needed right now: only doing UI locale-based things after the Q*App instance is created and thus after everything related to localization is setup and prepared (and will stay to the end of the Q*App instance lifetime. So would push this change upcoming WE, Feb 10/11, finally, unless someone objects. ((In time for Qt6/KF6 we should perhaps revisit this and hopefully have some people work on adding proper infrastructure and usage patterns to allow such switching UI localization on the fly. It's pretty sad that Web apps, which are younger, are better here)) REPOSITORY R249 KI18n BRANCH addNoteAboutCallingSetAppDomainAfterQApp REVISION DETAIL https://phabricator.kde.org/D8351 To: kossebau, #frameworks, ilic, ltoscano, dfaure Cc: dfaure, michaelh, ngraham
D10325: [KFileWidget] Hide places frame and header
markg added a comment.
In https://phabricator.kde.org/D10325#201884, @broulik wrote:
> > Would it be possible to show it as if it were locked? That would solve
all the issues with it, right?
>
> I don't get it. That "lock" feature is entirely a Dolphin invention. It
does exactly what I do here:
>
> void DolphinDockWidget::setLocked(bool lock)
> {
> ...
> if (lock) {
> ...
> setTitleBarWidget(m_dockTitleBar);
> setFeatures(QDockWidget::NoDockWidgetFeatures);
>
>
> with `m_dockTitleBar` being a custom widget for some added padding
Looks like i was looking at the wrong picture. I was looking as your
**after** image and comparing that to the "locked" state in dolphin.
The image i was expecting is the one you call "crammed at the top" :)
Imho, the "crammed at the top" version looks best as the "after" one just has
some weird empty room above the panel now. But feel free to use the one you
think fits best.
A suggestion though if you do choose for the "after" version. Would it be
possible to rearrange the layout then?
So:
- move the actions to the top, right above the panel.
- move the location bar next to the actions
I think that would look nice :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10325: [KFileWidget] Hide places frame and header
broulik updated this revision to Diff 26642. broulik retitled this revision from "RFC: [KFileWidget] Hide places frame and header" to "[KFileWidget] Hide places frame and header". broulik edited the test plan for this revision. broulik added a comment. - Add custom widget for added spacing, fixes the items glued to the top when borders are enabled, see updated Test Plan for new screenshots REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10325?vs=26590&id=26642 REVISION DETAIL https://phabricator.kde.org/D10325 AFFECTED FILES src/filewidgets/CMakeLists.txt src/filewidgets/kfilewidget.cpp src/filewidgets/kfilewidgetdocktitlebar.cpp src/filewidgets/kfilewidgetdocktitlebar_p.h To: broulik, #plasma, #vdg, #frameworks, ngraham, mart Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7864: Basic support for PHP and Python fenced code blocks in Markdown
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Fine with me. The approach doesn't scale though, so maybe we need to look into better support for this kind of syntax nesting if we want this for many more languages here (similar problems exist in other nest-able languages too). REPOSITORY R216 Syntax Highlighting BRANCH markdown-code-blocks (branched from master) REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek, #framework_syntax_highlighting, vkrause Cc: cullmann, dhaumann, cfeck, kwrite-devel, #frameworks, michaelh, ngraham
D10325: RFC: [KFileWidget] Hide places frame and header
broulik added a comment.
> Would it be possible to show it as if it were locked? That would solve all
the issues with it, right?
I don't get it. That "lock" feature is entirely a Dolphin invention. It does
exactly what I do here:
void DolphinDockWidget::setLocked(bool lock)
{
...
if (lock) {
...
setTitleBarWidget(m_dockTitleBar);
setFeatures(QDockWidget::NoDockWidgetFeatures);
with `m_dockTitleBar` being a custom widget for some added padding
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9207: Don't load KDE platform module in kglobalaccel5
hein added a comment. Well, the maintainer spoke out against it, so not much I can do. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10325: RFC: [KFileWidget] Hide places frame and header
mart accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks, ngraham, mart Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 116 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/116/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Tue, 06 Feb 2018 09:48:53 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)67% (295/442)67% (295/442)53% (31502/59479)38% (18484/48788)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (73/73)100% (73/73)94% (8536/9082)48% (5197/10727)autotests.http100% (9/9)100% (9/9)100% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src100% (1/1)100% (1/1)100% (5/5)75% (3/4)src.core84% (101/120)84% (101/120)58% (8347/14344)50% (4875/9712)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets79% (30/38)79% (30/38)49% (3879/7838)33% (1636/4920)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (5/5)100% (5/5)52% (511/976)41% (413/996)src.ioslaves.file.kauth0% (0/3)0% (0/3)0% (0/104)0% (0/75)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1365)0% (0/1515)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1788/4338)35% (1373/3979)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (631/1333)55% (649/1174)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/258)8% (19/242)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash67% (8/12)67% (8/12)52%
D9207: Don't load KDE platform module in kglobalaccel5
mart added a comment. can this be resurrected? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart, graesslin Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/117/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Feb 2018 09:48:53 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)67% (295/442)67% (295/442)53% (31485/59478)38% (18475/48712)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (73/73)100% (73/73)94% (8536/9082)48% (5195/10727)autotests.http100% (9/9)100% (9/9)100% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src100% (1/1)100% (1/1)100% (5/5)75% (3/4)src.core84% (101/120)84% (101/120)58% (8337/14343)50% (4866/9708)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets79% (30/38)79% (30/38)49% (3872/7837)33% (1634/4920)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (5/5)100% (5/5)52% (511/976)41% (413/996)src.ioslaves.file.kauth0% (0/3)0% (0/3)0% (0/104)0% (0/75)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1365)0% (0/1515)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1783/4338)35% (1375/3979)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (631/1333)55% (649/1174)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/258)8% (19/242)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash67% (8/12)67% (8/12)5
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 97 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/97/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Feb 2018 09:48:53 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest
D10257: KUrlMimeData: fix handling of PreferLocalUrls
mwolff added inline comments.
INLINE COMMENTS
> kurlmimedata.cpp:67
> +QList uris;
> +const QByteArray ba =
> mimeData->data(QString::fromLatin1(s_kdeUriListMime));
> +// Code from qmimedata.cpp
future cleanup: remove all the `QString::fromLatin1(s_...)` in this file with a
call to `QString kdeUriListMime() { return QStringLiteral("..."); }`
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D10257
To: dfaure, mwolff, jtamate, markg
Cc: markg, ngraham, #frameworks, michaelh
D10106: Relocate the Baloo database to the XDG cache location.
michaelh added a reviewer: Baloo. michaelh added a project: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10106 To: smithjd, #baloo Cc: ltoscano, michaelh, ngraham, #frameworks, ashaposhnikov, spoorun, alexeymin
D10024: Add supportedSchemes feature
This revision was automatically updated to reflect the committed changes. Closed by commit R241:6ab218dba91f: Add supportedSchemes feature (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10024?vs=25891&id=26632#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10024?vs=25891&id=26632 REVISION DETAIL https://phabricator.kde.org/D10024 AFFECTED FILES autotests/kdiroperatortest.cpp autotests/kfileplacesmodeltest.cpp src/filewidgets/kdiroperator.cpp src/filewidgets/kdiroperator.h src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesmodel.h src/filewidgets/kfilewidget.cpp src/filewidgets/kfilewidget.h To: mwolff, #plasma, dfaure, mart Cc: ngraham, mart, apol, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
D10045: remote: don't create entries with empty names
This revision was automatically updated to reflect the committed changes. Closed by commit R241:4d153df7359c: remote: don't create entries with empty names (authored by mwolff). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10045?vs=26203&id=26633 REVISION DETAIL https://phabricator.kde.org/D10045 AFFECTED FILES src/ioslaves/remote/remoteimpl.cpp src/ioslaves/remote/remoteimpl.h To: mwolff, dfaure Cc: dhaumann, #frameworks, michaelh, ngraham
D10024: Add supportedSchemes feature
mwolff added a comment. I've committed this now. If someone tells me how to add KIOSK support, I can add that later on as needed REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure, mart Cc: ngraham, mart, apol, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Feb 2018 09:37:33 + Build duration: 9 min 20 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 39 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/39/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 06 Feb 2018 09:37:33 + Build duration: 8 min 16 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Feb 2018 09:37:33 + Build duration: 3 min 23 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest
D10335: balooctl monitor: Exit w/o valid dbus interface
alexeymin added a comment.
`quit()` and `exit(0)` do the same thing - they all stop event loop, caused
by `QCoreApplication::exec()`.
And I don't understand how does timer help? What is happening without
singleshot timer?
INLINE COMMENTS
> monitorcommand.cpp:55
> +m_out << i18n("Baloo died") << endl;
> +QCoreApplication::instance()->exit(0);
> +});
`QCoreApplication::exit()` is a static member function and can be called
directly without using `instance()`.
`instance()->quit()` is exactly the same as `exit(0)` so I don't understand
this change. It does not change anything and looks not correct.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D10335
To: michaelh, #baloo, #frameworks
Cc: alexeymin, michaelh, ngraham
KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 31 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/31/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Feb 2018 09:05:18 + Build duration: 3 min 19 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest
D10205: fileindexerconfig: Introduce canBeSearched()
This revision was automatically updated to reflect the committed changes. Closed by commit R293:114874660e65: fileindexerconfig: Introduce canBeSearched() (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10205?vs=26264&id=26630 REVISION DETAIL https://phabricator.kde.org/D10205 AFFECTED FILES src/file/fileindexerconfig.cpp src/file/fileindexerconfig.h To: michaelh, #frameworks, #dolphin, #baloo, mgallien, ngraham Cc: ashaposhnikov, michaelh, spoorun, ngraham, alexeymin
D10335: balooctl monitor: Exit w/o valid dbus interface
michaelh added a comment. This is the second time I could "resolve" a problem by throwing in a oneshot timer, see also https://phabricator.kde.org/D9590. I have the feeling something else is wrong here and regard this more as a workaround than a solution. Please comment. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10335 To: michaelh, #baloo, #frameworks Cc: michaelh, ngraham
D10335: balooctl monitor: Exit w/o valid dbus interface
michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Exit the application instead of just stopping the event loop TEST PLAN $ balooctl monitor || echo "failed" REPOSITORY R293 Baloo BRANCH exit_monitor REVISION DETAIL https://phabricator.kde.org/D10335 AFFECTED FILES src/tools/balooctl/monitorcommand.cpp To: michaelh, #baloo, #frameworks Cc: michaelh, ngraham
