D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-11 Thread Eike Hein
hein added a comment. Yeah, I had a feeling there were other design considerations here, but they're not documented/commented in the code so the only way to find out was to show you a patch :) You want this virtual method where? In KRun? And then Plasma should subclass KRun?

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 111 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/111/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 12 Feb 2018 04:15:49 + Build duration: 27 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 129 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/129/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 12 Feb 2018 04:15:49 + Build duration: 24 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/131/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 12 Feb 2018 04:15:49 + Build duration: 23 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/48/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 12 Feb 2018 02:14:45 + Build duration: 7 min 9 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 43 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/43/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Mon, 12 Feb 2018 02:14:45 + Build duration: 6 min 15 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/32/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 12 Feb 2018 02:14:45 + Build duration: 4 min 47 sec and counting JUnit

D10365: New icon for Elisa music player

2018-02-11 Thread Paul Lesur
paullesur added a comment. In D10365#203797 , @januz wrote: > Agree with the text not being useful for small sizes, but it could look good for a large logo-style image (like say, a 256px logo on the wiki/homepage). > A cassette is

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-11 Thread Jaime Torres Amate
jtamate added a comment. In D9840#204587 , @dfaure wrote: > Can you strace vivaldi to see what it's doing? It must be doing something wrong if it's triggering so much I/O. This is related to https://phabricator.kde.org/D10342 I've

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-11 Thread Friedrich W . H . Kossebau
kossebau added a comment. "This (hopefully) fixes the build failure noticed in the FreeBSD (and some linuxes)" - leaves the question: why should it exactly fix it? :) From discussion of last week on irc, it seemed that the actual problem is that the generated make files do not contain

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-11 Thread Tobias C . Berner
tcberner added reviewers: bshah, dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure Cc: #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-11 Thread Tobias C . Berner
tcberner created this revision. tcberner added reviewers: FreeBSD, mpyne. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. tcberner requested review of this revision. REVISION SUMMARY This creates a custom target 'desktop_to_json_X'

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 130 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/130/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Feb 2018 20:21:10 + Build duration: 13 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 128 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/128/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 11 Feb 2018 20:09:22 + Build duration: 16 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 110 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/110/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Feb 2018 20:13:36 + Build duration: 9 min 19 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 129 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/129/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Feb 2018 20:00:49 + Build duration: 20 min and counting JUnit Tests Name: (root)

D10414: Add move semantics support to KIO::UDSEntry.

2018-02-11 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I actually see little point in verifying that *compiler generated* code copies all members correctly. We can trust the compiler :-) So, to me this looks ok (minus the last

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 109 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/109/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Feb 2018 20:00:49 + Build duration: 12 min and counting JUnit Tests Name:

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-11 Thread David Faure
dfaure added a comment. Can you strace vivaldi to see what it's doing? It must be doing something wrong if it's triggering so much I/O. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks, dfaure Cc: ngraham, mmustac, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 127 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/127/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 11 Feb 2018 20:00:49 + Build duration: 8 min 31 sec and counting JUnit Tests Name:

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-11 Thread David Faure
dfaure added a comment. (FWIW I tested my desktop file in dolphin, not in plasma) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

2018-02-11 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. If only it was that simple, I would have done this years ago. Download http://www.davidfaure.fr/2018/weirdcommand.desktop and then running that desktop file, without and then

D10433: Add QML support for Prison

2018-02-11 Thread Volker Krause
vkrause updated this revision to Diff 26950. vkrause added a comment. Address review comments. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10433?vs=26907=26950 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10433 AFFECTED FILES

D10433: Add QML support for Prison

2018-02-11 Thread Volker Krause
vkrause added a comment. In D10433#204528 , @broulik wrote: > Cool! Would allow us to get rid of the custom barcode stuff in Plasma's clipboard plasmoid. > > Does barcode generation need to be in a separate thread? The Plasma codes does it,

D10312: FileUndoManager: don't delete non-existing local files

2018-02-11 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > elvisangelaccio wrote in fileundomanager.cpp:404 > You mean just an `emit undoAvailable(false);` ? Yep. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10312 To: elvisangelaccio, dfaure Cc: ngraham, #frameworks, michaelh

D10433: Add QML support for Prison

2018-02-11 Thread Kai Uwe Broulik
broulik added a comment. Cool! Would allow us to get rid of the custom barcode stuff in Plasma's clipboard plasmoid. Does barcode generation need to be in a separate thread? The Plasma codes does it, not sure how big of a performance impact this has? INLINE COMMENTS >

D10446: Add KLanguageName

2018-02-11 Thread Albert Astals Cid
aacid added a comment. With this i can finally stop using kdelibs4support in KTuberling REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid Cc: #frameworks, michaelh

D10446: Add KLanguageName

2018-02-11 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. aacid requested review of this revision. REVISION SUMMARY KLanguageName is a helper namespace that returns the name of a given language code. REPOSITORY

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

2018-02-11 Thread René J . V . Bertin
rjvbb added a comment. Thanks Gilles. Please remember that perfect is the enemy of good and that further improvements can always be applied down the road. This patch touches only Mac and concerns very specific functionality that is used by only very few applications (besides

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

2018-02-11 Thread Gilles Caulier
cgilles added a comment. PING again to KF5 core developpers ... We need to advance with this very important patch to support properly Apple device with Solid. This will permit to use Apple hardware as well, as under Linux. Please review, fix, and validate this non negligible job,

D9973: ktooltipwidget: Fix tooltip positioning

2018-02-11 Thread Michael Heidelbach
michaelh marked an inline comment as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham Cc: cfeck, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

2018-02-11 Thread Michael Heidelbach
michaelh updated this revision to Diff 26940. michaelh added a comment. - Clean code REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9973?vs=26717=26940 BRANCH tooltip_and_test REVISION DETAIL https://phabricator.kde.org/D9973 AFFECTED FILES

D10432: Set minimum size on 1D barcodes as well

2018-02-11 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:278c6def9d32: Set minimum size on 1D barcodes as well (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10432?vs=26895=26939 REVISION DETAIL

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Fabian Vogt
fvogt added a comment. In D10437#204377 , @chinmoyr wrote: > The whole work is being done inside KIO::Job. If the application uses regular Jobs then I can't see how it can fake it. By not using KIO or using a modified KIO. Never assume

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > slavebase.h:957 > + */ > +bool mAppChanged; > Will break ABI, add new member variables only in SlaveBasePrivate REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10437 To: chinmoyr, #frameworks, dfaure,

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. In D10437#204417 , @markg wrote: > Could you provide steps to reproduce what you try to fix? Steps: create files /opt/{a,b} open kioslavetest delete /opt/a open ksysguard and send interrupt signal to

D9973: ktooltipwidget: Fix tooltip positioning

2018-02-11 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > ktooltippositiontest.cpp:141 > +KToolTipWidget tooltip; > +tooltip.showBelow(targetRect, contentWidget, transientParent); > +QRect tooltipRect(tooltip.frameGeometry()); `QVERIFY(QTest::qWaitForWindowActive());` ? ​ REPOSITORY R236

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-11 Thread Jaime Torres Amate
jtamate added a comment. > ! In D9840#203803 , @ngraham wrote: > Do any of the active or recently-landed patches address this? No, but I have one in https://phabricator.kde.org/D10342 REPOSITORY R309 KService REVISION DETAIL

D7175: Redesign CMake syntax

2018-02-11 Thread Alex Turbov
turbov updated this revision to Diff 26933. turbov added a comment. Updates for CMake 3.11 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=23100=26933 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Mark Gaiser
markg added a comment. In D10437#204416 , @chinmoyr wrote: > In D10437#204402 , @markg wrote: > > > I just tried this: > > kdesu gwenview (type root password and go to the root homefolder). > >

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. In D10437#204402 , @markg wrote: > I just tried this: > kdesu gwenview (type root password and go to the root homefolder). > In gwenview i can now go to that folder. > In dolphin (started as user, not root) i

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Fabian Vogt
fvogt added a comment. In D10437#204413 , @chinmoyr wrote: > In D10437#204382 , @fvogt wrote: > > > In D10437#204377 , @chinmoyr wrote: > > > > > The

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. In D10437#204382 , @fvogt wrote: > In D10437#204377 , @chinmoyr wrote: > > > The whole work is being done inside KIO::Job. If the application uses regular Jobs then I

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Mark Gaiser
markg added a comment. I just tried this: kdesu gwenview (type root password and go to the root homefolder). In gwenview i can now go to that folder. In dolphin (started as user, not root) i can't get into that folder. I don't really see what you try to fix here as it seems to be

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/47/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Feb 2018 12:44:02 + Build duration: 10 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 42 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/42/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Sun, 11 Feb 2018 12:44:02 + Build duration: 9 min 19 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still Unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/31/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Feb 2018 12:44:02 + Build duration: 3 min 53 sec and counting JUnit

D10444: Improve KLanguageButton::insertLanguage when no name is passed

2018-02-11 Thread Albert Astals Cid
aacid updated this revision to Diff 26924. aacid added a comment. Do not return "without name" in nameFromEntryFile An empty string is better so the fallback ifs try to get a name for the language code REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. The whole work is being done inside KIO::Job. If the application uses regular Jobs then I can't see how it can fake it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10437 To: chinmoyr, #frameworks, dfaure, fvogt Cc: michaelh

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Fabian Vogt
fvogt added a comment. If I'm not mistaken, the application sends its own pid to the slave. This means it could just fake it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10437 To: chinmoyr, #frameworks, dfaure, fvogt Cc: michaelh

D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

2018-02-11 Thread Albert Astals Cid
aacid added a comment. together with https://phabricator.kde.org/D10444 fixes https://bugs.kde.org/show_bug.cgi?id=390078 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D10445 To: aacid Cc: #frameworks, michaelh

D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

2018-02-11 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. aacid requested review of this revision. REVISION SUMMARY KLanguageButton::insertLanguage already knows how to figure out the name of a language, so no need

D10444: Improve KLanguageButton::insertLanguage when no name is passed

2018-02-11 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. aacid requested review of this revision. REVISION SUMMARY Move the reading of kf5_entry.desktop from KLanguageButton::loadAllLanguages to

D10432: Set minimum size on 1D barcodes as well

2018-02-11 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D10432 To: vkrause, #frameworks, svuorela Cc: michaelh

D10433: Add QML support for Prison

2018-02-11 Thread Volker Krause
vkrause updated this revision to Diff 26907. vkrause added a comment. Address review comments. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10433?vs=26896=26907 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10433 AFFECTED FILES

D10437: Limit the use of file.so for privilege operation to one application

2018-02-11 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: Frameworks, dfaure, fvogt. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY After successful authorization for privilege execution the whole session gets full root-level

D10433: Add QML support for Prison

2018-02-11 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > davidedmundson wrote in barcodequickitem.cpp:37 > Is createBarcode a heavy function? It sounds like it could be. > > If so I'd recommend using QQmlParserStatus so you don't generate it 4 times > on startup as each property gets set. Right,

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

2018-02-11 Thread Eike Hein
hein added a comment. Sanity check question: Did you make sure this doesn't introduce an extra render when things start up? (Initial vs. change.) Otherwise makes sense (and finally fixes some Wayland uglyness I've been annoyed by ...). REPOSITORY R242 Plasma Framework (Library)