D10365: New icon for Elisa music player

2018-02-14 Thread Matthieu Gallien
mgallien added a comment. In D10365#205750 , @andreask wrote: > can we get it now to master? > > @paullesur is hopefully interested in other icon's too. @paullesur do you have a KDE contributor account ? If not, I cannot push due to

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2018-02-14 Thread Jeremy Whiting
whiting added a comment. Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting

D10512: try to preload certain applets in a smart way

2018-02-14 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > appletquickitem.cpp:789 > +if (!d->applet->isContainment()) { > +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), > qMin(d->preloadWeight() + s_preloadWeightIncrement, 100)); > +} I was also wondering

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.7 - Build # 17 - Still Unstable!

2018-02-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/17/ Project: Frameworks krunner kf5-qt5 SUSEQt5.7 Date of build: Wed, 14 Feb 2018 21:08:50 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

2018-02-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/17/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Wed, 14 Feb 2018 21:08:50 + Build duration: 3 min 58 sec and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Unstable!

2018-02-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 14 Feb 2018 21:08:50 + Build duration: 1 min 45 sec and counting JUnit Tests

D10511: Update krunner plugin template

2018-02-14 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R308:cd4f8c4fd6b7: Update krunner plugin template (authored by kossebau). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10511?vs=27159=27185 REVISION DETAIL

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10518: Use QWidget to see if the window is visible

2018-02-14 Thread Andrius Štikonas
stikonas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D10518 To: apol, #frameworks, stikonas Cc: stikonas, michaelh

D10518: Use QWidget to see if the window is visible

2018-02-14 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 27182. apol removed a reviewer: stikonas. apol added a comment. This revision now requires review to proceed. Properly detect the window state when not on X11 KWindowInfo doesn't support most features on Wayland (or any other backend) so we provide an

D10518: Use QWidget to see if the window is visible

2018-02-14 Thread Andrius Štikonas
stikonas accepted this revision. stikonas added a comment. This revision is now accepted and ready to land. Works for me. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D10518 To: apol, #frameworks, stikonas Cc: stikonas, michaelh

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas reclaimed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas abandoned this revision. stikonas added a comment. Le's close it in favour of https://phabricator.kde.org/D10518 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin,

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas updated this revision to Diff 27181. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10495?vs=27106=27181 REVISION DETAIL https://phabricator.kde.org/D10495 AFFECTED FILES src/kstatusnotifieritem.cpp To: stikonas, wbauer, #plasma,

D10518: Use QWidget to see if the window is visible

2018-02-14 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY Instead of using KWindowInfo::mappingState that won't give reliable information about the window on wayland. TEST PLAN

D10512: try to preload certain applets in a smart way

2018-02-14 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > appletquickitem.cpp:789 > +if (!d->applet->isContainment()) { > +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), > qMin(d->preloadWeight() + s_preloadWeigthIncrement, 100)); > +} So if you ever

D10511: Update krunner plugin template

2018-02-14 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R308 KRunner BRANCH updaterunnertemplate REVISION DETAIL https://phabricator.kde.org/D10511 To: kossebau, broulik Cc: #frameworks, michaelh

D10512: try to preload certain applets in a smart way

2018-02-14 Thread Nathaniel Graham
ngraham added a comment. Let's keep in mind the PR aspect of this: if we end up 30 MB heavier and a few seconds slower on a cold boot for a new install, advanced users who frequent internet forums and write reviews will notice this, but they probably won't notice that some widgets open more

D10512: try to preload certain applets in a smart way

2018-02-14 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > apol wrote in appletquickitem.cpp:87 > Isn't X-Plasma-PreloadWeight for that? It's to have some default weights without having to populate every desktop file REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10512: try to preload certain applets in a smart way

2018-02-14 Thread Kai Uwe Broulik
broulik added a comment. Cool! Since this is all applet quick item stuff it will just work™ with applet within system tray? Would be nice to have some `qCInfo` in there somewhere so we can better understand what it's doing, when it's increasing/decreasing the rating, when it's

D10494: update handle- icons for kirigami

2018-02-14 Thread Alessandro Longo
alex-l added a comment. +1 for 3-dots icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Nathaniel Graham
ngraham added a comment. In D8056#206326 , @simgunz wrote: > I was thinking to discuss the possibility to make a new KDE UI component for collapsible headers so that it can be used in multiple places. Maybe I can open a task for discussing this

D10512: try to preload certain applets in a smart way

2018-02-14 Thread Aleix Pol Gonzalez
apol added a comment. It sounds like it should be the shell who decides what needs preloading, rather than the framework guessing it. INLINE COMMENTS > appletquickitem.cpp:87 > +//some applet types we want a bigger weight > +if

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Henrik Fehlauer
rkflx added a comment. Great to hear. Hopefully you'll find the right balance between chasing the big goals and doing small changes here and there to learn the trade for achieving the former ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Simone Gaiarin
simgunz added a comment. In D8056#206303 , @rkflx wrote: > @simgunz Thanks again for your patience (first commit in July!). Hope to see more patches from you in the future (both large* like this one, but also smaller things**), as you both have

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 114 - Still Unstable!

2018-02-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/114/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 14 Feb 2018 17:20:14 + Build duration: 29 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 134 - Still Unstable!

2018-02-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/134/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 14 Feb 2018 17:20:14 + Build duration: 9 min 17 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 132 - Still Unstable!

2018-02-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/132/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 14 Feb 2018 17:20:14 + Build duration: 7 min 47 sec and counting JUnit Tests Name:

D10251: [RFC] Use mipmap filtering in window thumbnails

2018-02-14 Thread Nathaniel Graham
ngraham added a comment. Crisper would definitely be nicer too, but if that's too hard, this is already a big visual win even in its current state. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: ngraham,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e3af26bbb1e7: Improve usability of Open With dialog by adding option to filter the… (authored by simgunz, committed by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Nathaniel Graham
ngraham added a comment. In D8056#206303 , @rkflx wrote: > *) I know Nate would love to get collapsible headers in Dolphin's sidebar… *completely coincidental mention* https://bugs.kde.org/show_bug.cgi?id=389803 :) Allow me to echo

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2018-02-14 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. @simgunz Thanks again for your patience (first commit in July!). Hope to see more patches from you in the future (both large* like this one, but also smaller things**), as you both have a good eye for usability as well as the means to

D10512: try to preload certain applets in a smart way

2018-02-14 Thread Marco Martin
mart updated this revision to Diff 27169. mart added a comment. - correct typo REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27163=27169 BRANCH mart/preload REVISION DETAIL https://phabricator.kde.org/D10512 AFFECTED

D10512: try to preload certain applets in a smart way

2018-02-14 Thread Marco Martin
mart updated this revision to Diff 27163. mart added a comment. - silence warnings REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27162=27163 BRANCH mart/preload REVISION DETAIL https://phabricator.kde.org/D10512 AFFECTED

D10512: try to preload certain applets in a smart way

2018-02-14 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY preload popups of some applets after init in the

D10511: Update krunner plugin template

2018-02-14 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY - clean-up CMakeLists.txt from unused things - move

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

2018-02-14 Thread Nathaniel Graham
ngraham added reviewers: Kate, cullmann. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for doing this, Marijo. It's much appreciated. I'll let the Kate folks comment too. REPOSITORY R39 KTextEditor REVISION DETAIL

D10508: Add icons for KStandardActions Deselect and Replace

2018-02-14 Thread Nathaniel Graham
ngraham added a comment. Thanks for the image; now I can feature it in this coming weekend's Usability & Productivity post! REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10508 To:

D10508: Add icons for KStandardActions Deselect and Replace

2018-02-14 Thread Marijo Mustac
mmustac edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10508 To: mmustac, #frameworks, ngraham Cc: michaelh

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

2018-02-14 Thread Marijo Mustac
mmustac created this revision. mmustac added reviewers: KTextEditor, ngraham. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. mmustac requested review of this revision. REVISION SUMMARY This patch adds some more icons to the menus.

D10508: Add icons for KStandardActions Deselect and Replace

2018-02-14 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R265:5bd125e26d0b: Add icons for KStandardActions Deselect and Replace (authored by mmustac, committed by ngraham). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D10508: Add icons for KStandardActions Deselect and Replace

2018-02-14 Thread Nathaniel Graham
ngraham added a comment. Yep, I just wanted to make sure you knew how to deploy it properly to test. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10508 To: mmustac, #frameworks, ngraham Cc: michaelh

D10508: Add icons for KStandardActions Deselect and Replace

2018-02-14 Thread Marijo Mustac
mmustac added a comment. I can't access the link at the moment but changed the title according ;) And kate picks up this change automatically because they relay on this framework already or did I get you wrong? REPOSITORY R265 KConfigWidgets REVISION DETAIL

D10508: Add icons for KStandardActions Deselect and Replace

2018-02-14 Thread Marijo Mustac
mmustac retitled this revision from "[KStandardAction] Add additional icons to menus" to "Add icons for KStandardActions Deselect and Replace". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10508 To: mmustac, #frameworks, ngraham Cc: michaelh

D10508: [KStandardAction] Add additional icons to menus

2018-02-14 Thread Nathaniel Graham
ngraham added a comment. Also, you don't need "[KStandardAction]" in the title. A better commit message would indicate the actual icons. Maybe something like this: "Add icons for KStandardActions Deselect and Replace" See

D10508: [KStandardAction] Add additional icons to menus

2018-02-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great! Do you know how to deploy this patch such that apps e.g. Kate can pick up the change? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10508

D10508: [KStandardAction] Add additional icons to menus

2018-02-14 Thread Marijo Mustac
mmustac created this revision. mmustac added reviewers: Frameworks, ngraham. Restricted Application added a project: Frameworks. mmustac requested review of this revision. REVISION SUMMARY I added also here the icons for the "replace" and "deselect" action. REPOSITORY R265 KConfigWidgets

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas added a comment. Well, basically when you click on any KF5 application (e.g. Konversation, KGpg, Akregator, etc...) in the system tray, nothing happens. This does no happen with Qt5-only programs. Clicking on system tray there always brings the window up. From what I can see

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-02-14 Thread Milian Wolff
mwolff added a comment. I guess this can be abandoned now that the real culprit was found, no? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks, dfaure Cc: mwolff, ngraham, mmustac, michaelh