D8958: Fix unintentional breadcrumb menu item activation

aleksejshilin added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8958 To: aleksejshilin, #frameworks, dfaure Cc: broulik, ngraham, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. So what's the conclusion here? Is this only a bug in kcm_lookandfeel or do we think that some follow-on changes are still required in `kcoreaddons_desktop_to_json`? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner,

D10587: Restore KTextEditor Document Dbus bindings

anthonyfieroni added a comment. In D10587#207885 , @lukedashjr wrote: > I don't think I would know how to make these changes. I was only able to get this to work because it was mostly a simple revert. It should be same: at

D10592: fix RTL appearance for ComboBox

mvourlakos marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10592: fix RTL appearance for ComboBox

mvourlakos updated this revision to Diff 27382. mvourlakos added a comment. - improve semantics REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10592?vs=27373=27382 BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D10592

D10587: Restore KTextEditor Document Dbus bindings

asturmlechner added a comment. This change has history, for reference: https://git.reviewboard.kde.org/r/129398/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10587 To: lukedashjr, cullmann, dhaumann, gregormi Cc: anthonyfieroni, #ktexteditor, #kate,

D10595: Adding ctp file extension to the PHP syntax highlighting

martonmiklos created this revision. martonmiklos added a reviewer: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. martonmiklos requested review of this revision. REVISION SUMMARY ctp extension is used by

D10592: fix RTL appearance for ComboBox

safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > -LayoutMirroring.enabled: true > +// HACK: When the ComboBox is not inside the base Item, it does > not inherit > +// the LayoutMirroring options.

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. @safaalfulaij I created the following for this: https://phabricator.kde.org/D10592 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel, #frameworks,

D10592: fix RTL appearance for ComboBox

mvourlakos created this revision. mvourlakos added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY - when the combobox isnt

D10591: forcefully activate popup windows when they open

davidedmundson added a comment. What would this code do if the device notifier is expanded but on the desktop? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10591 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, michaelh,

D10591: forcefully activate popup windows when they open

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY if an applet is requiresattention, always give the

D10587: Restore KTextEditor Document Dbus bindings

lukedashjr added a comment. In D10587#207874 , @anthonyfieroni wrote: > It will not break compatibility or you should supposed how? Kate and KWrite present in same repo, so the code can be shared, but yes it will not have this feature in other

D10587: Restore KTextEditor Document Dbus bindings

anthonyfieroni added a comment. It will not break compatibility or you should supposed how? Kate and KWrite present in same repo, so the code can be shared, but yes it will not have this feature in other apps that uses KTextEditor. But you can read @cullmann wrote in bug report that it

D10587: Restore KTextEditor Document Dbus bindings

lukedashjr added a comment. In D10587#207857 , @anthonyfieroni wrote: > You can try to add DBus in Kate (application) rather than KTextEditor (framework). Won't that break compatibility? (and fail to cover KWrite or other similar

D10587: Restore KTextEditor Document Dbus bindings

anthonyfieroni added a comment. You can try to add DBus in Kate (application) rather than KTextEditor (framework). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10587 To: lukedashjr, cullmann, dhaumann, gregormi Cc: anthonyfieroni, #ktexteditor, #kate,

D10578: balooctl monitor: Wait for dbus interface

michaelh added a comment. In D10578#207745 , @alexeymin wrote: > Can you add simple instructions how to reproduce full testing scenario? See test plan REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10578 To:

D10578: balooctl monitor: Wait for dbus interface

michaelh updated this revision to Diff 27360. michaelh marked an inline comment as done. michaelh edited the summary of this revision. michaelh edited the test plan for this revision. michaelh added a comment. - balooctl monitor: Use QCoreApplication::exit() - balooctl monitor: Explicit

D10578: balooctl monitor: Wait for dbus interface

michaelh edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10578 To: michaelh, dfaure Cc: alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella

D10587: Restore KTextEditor Document Dbus bindings

lukedashjr created this revision. lukedashjr added reviewers: cullmann, dhaumann, gregormi. lukedashjr added projects: KTextEditor, Kate, Frameworks. Restricted Application added a subscriber: Frameworks. lukedashjr requested review of this revision. REVISION SUMMARY Enable access to the

D10578: balooctl monitor: Wait for dbus interface

alexeymin added a comment. Can you add simple instructions how to reproduce full testing scenario? INLINE COMMENTS > monitorcommand.cpp:75 > +//TODO: Wait again for dbus interface > +QCoreApplication::instance()->exit(0); > +}); No need to call `instance()`

D10335: balooctl monitor: Exit w/o valid dbus interface

michaelh abandoned this revision. michaelh added a comment. Superseded by D10578 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10335 To: michaelh, #baloo, #frameworks Cc: alexeymin, michaelh

D10335: balooctl monitor: Exit w/o valid dbus interface

michaelh added a comment. @alexeymin: Sorry, for the huge delay. > And I don't understand how does timer help? What is happening without singleshot timer? I don't quite understand either. Without it you won't get your prompt back until you Ctrl+C. REPOSITORY R293 Baloo

D10578: balooctl monitor: Wait for dbus interface

michaelh created this revision. michaelh added a reviewer: dfaure. michaelh added a project: Baloo. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY If baloo is not running,

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. Latte config window is a Plasma::ConfigView, so it inherates a QQuickView REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh,

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. Reported: https://bugreports.qt.io/browse/QTBUG-66446 Although this is really unlikly to happen, a widget having a combobox, but this is the case of Latte where the whole config overlay is just a `MouseArea`. REPOSITORY R242 Plasma Framework (Library)

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D9275#207623 , @mvourlakos wrote: > Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3 :) Ok, I can assume that Latte doens't have a

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart,

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. I've done some more testing and read some Qt docs. `Popup` item get reparented to the window once displayed, so LayoutMirroring is applied to it only at that point (applying it to the contentItem). So my comments above about `Popup` not inheerting `Item` are

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/50/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 16 Feb 2018 08:37:34 + Build duration: 8 min 53 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/34/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 16 Feb 2018 08:37:34 + Build duration: 3 min 45 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/45/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Fri, 16 Feb 2018 08:37:34 + Build duration: 4 min 5 sec and counting JUnit Tests

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

dfaure added inline comments. INLINE COMMENTS > job.cpp:328 > > -switch (m_operationType) { > -case ChangeAttr: > -m_caption = i18n("Change Attribute"); > -m_message = i18n("Root privileges are required to change file > attributes. " > - "Do you

D10569: Bump shared-mime-info to 1.3

pino closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10569 To: pino, dfaure Cc: #frameworks, michaelh

D10551: autotest for crashing in KArchiveDirectory::addEntry

dfaure added inline comments. INLINE COMMENTS > karchivetest.cpp:1169 > + > +QVERIFY(zip.open(QIODevice::ReadOnly)); > +} Maybe do a directory listing too, to check if the duplicate name appears twice? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D10551 To:

D10569: Bump shared-mime-info to 1.3

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Hi Pino ! Good idea. REPOSITORY R244 KCoreAddons BRANCH bump-smi-1.0 REVISION DETAIL https://phabricator.kde.org/D10569 To: pino, dfaure Cc: #frameworks, michaelh