D10670: Reduce plasmashell frozen time

2018-02-19 Thread Jaime Torres Amate
jtamate added a comment. In D10670#209823 , @mwolff wrote: > ok, looking at the reasoning in the other commit: > > - you need to extend the commit message here Will be done. > - you need to provide a comment in the code the

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 25 - Still unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/25/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 20 Feb 2018 06:53:52 + Build duration: 27 min and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 22 - Fixed!

2018-02-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Feb 2018 06:53:52 + Build duration: 22 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 23 - Still unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/23/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Tue, 20 Feb 2018 06:53:52 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 22 - Fixed!

2018-02-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Feb 2018 06:53:52 + Build duration: 1 min 23 sec and counting JUnit Tests

D10671: Fix auto-mount regression

2018-02-19 Thread Dmitry Khlestkov
dkhlestkov added a comment. In D10671#209868 , @ngraham wrote: > we will need an email address to land this patch if it is accepted How do I provide it? I see no corresponding input field. REPOSITORY R245 Solid REVISION DETAIL

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 24 - Failure!

2018-02-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/24/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 20 Feb 2018 06:01:57 + Build duration: 20 min and counting CONSOLE OUTPUT

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 22 - Failure!

2018-02-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/22/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Tue, 20 Feb 2018 06:01:57 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 21 - Failure!

2018-02-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Feb 2018 06:01:57 + Build duration: 6 min 0 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 21 - Failure!

2018-02-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Feb 2018 06:01:57 + Build duration: 5 min 7 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/53/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Feb 2018 00:06:36 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 53 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/53/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Tue, 20 Feb 2018 00:06:36 + Build duration: 6 min 37 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 50 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/50/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Feb 2018 00:06:36 + Build duration: 3 min 2 sec and counting JUnit

D10646: Support case-insensitive WordDetect

2018-02-19 Thread jonathan poelen
jpoelen added a comment. It seems that KTextEditor does not have the problem because KateHlWordDetect is based on KateHlStringDetect which uses the inSensitive parameter. INLINE COMMENTS > rule_p.h:249 > QString m_word; > +Qt::CaseSensitivity m_caseSensitivity; > }; Yes, but it

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Nathaniel Graham
ngraham added a comment. I would prefer to have the cleanup behavior happen by default, if we end up making this optional. It would be nice if we could also also handle the `KIO::ERR_DISK_FULL` case. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To:

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Dmitri Ovodok
dmitrio marked an inline comment as done. dmitrio added a comment. In D10663#209708 , @meven wrote: > Add this to your commit message > FIXED-IN: 5.44 Thank you, added it to the description. In D10663#209711

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Dmitri Ovodok
dmitrio updated this revision to Diff 27582. dmitrio edited the summary of this revision. dmitrio added a comment. Add a flag which turns off cleaning up on job cancel. Use m_currentDestURL instead of obtaining the destination file name from an iterator. REPOSITORY R241 KIO CHANGES

D10671: Fix auto-mount regression

2018-02-19 Thread Nathaniel Graham
ngraham added a comment. FWIW we will need an email address to land this patch if it is accepted. In the future, if you use Arc to submit the patch , this step won't be necessary. REPOSITORY R245 Solid

D10671: Fix auto-mount regression

2018-02-19 Thread Dmitry Khlestkov
dkhlestkov added a comment. yes, this would be safe REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: rikmills, #frameworks, michaelh

D10671: Fix auto-mount regression

2018-02-19 Thread Rik Mills
rikmills added a comment. I assume this would be safe to backport to 5.43, should it be accepted? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: rikmills, #frameworks, michaelh

D10671: Fix auto-mount regression

2018-02-19 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, broulik. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: #frameworks, michaelh

D10671: Fix auto-mount regression

2018-02-19 Thread Dmitry Khlestkov
dkhlestkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. dkhlestkov requested review of this revision. REVISION SUMMARY BUG: 389479 Devices with empty path stopped auto-mounting after commit

D10292: change 32px icons for playlist shuffle and repeat

2018-02-19 Thread Andreas Kainz
andreask requested changes to this revision. andreask added a comment. This revision now requires changes to proceed. only in 16px there is no circle and in general I'm not really happy to have no circle around the icon. maybe for repeat and shuffle it will work but play/pause are more

D10293: remove view-media-playlist from preferences icons

2018-02-19 Thread Andreas Kainz
andreask accepted this revision. andreask added a comment. This revision is now accepted and ready to land. I added the colored icon for elisa but I understood if you don't like it. personally I'm not 100% happy with large monochrome icons. REPOSITORY R266 Breeze Icons BRANCH

D10279: add 24px media-album-cover icon

2018-02-19 Thread Andreas Kainz
andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH media-album-cover REVISION DETAIL https://phabricator.kde.org/D10279 To: astippich, #breeze, #vdg, andreaska, andreask Cc: ngraham, #frameworks, michaelh

D10670: Reduce plasmashell frozen time

2018-02-19 Thread Milian Wolff
mwolff added a comment. ok, looking at the reasoning in the other commit: - you need to extend the commit message here - you need to provide a comment in the code the clarifies what's going on here in general, I don't see how such a comparison can be so costly - the real problem

D10670: Reduce plasmashell frozen time

2018-02-19 Thread Milian Wolff
mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. what? this is totally unsafe - the reinterpret_cast below shouldn't be done on anything that has event names other than the previously used one... REPOSITORY R242 Plasma

D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

2018-02-19 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D10445 To: aacid, apol Cc: #frameworks, michaelh

D10444: Improve KLanguageButton::insertLanguage when no name is passed

2018-02-19 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R265:b1e30535eca4: Improve KLanguageButton::insertLanguage when no name is passed (authored by aacid). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D10627: Reduce plasmashell frozen time to almost nothing

2018-02-19 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e1fe26f1fc78: Reduce plasmashell frozen time to almost nothing (authored by jtamate). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10627?vs=27453=27577

D10670: Reduce plasmashell frozen time

2018-02-19 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY Third part of

D10669: Reduce plasmashell frozen time

2018-02-19 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Plasma, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY Second part of

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/51/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Feb 2018 19:41:15 + Build duration: 8 min 35 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 46 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/46/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Mon, 19 Feb 2018 19:41:15 + Build duration: 7 min 14 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 35 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/35/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 19 Feb 2018 19:41:15 + Build duration: 3 min 34 sec and counting JUnit

D10664: kcoreaddons_desktop_to_json: note the generated file in the build log

2018-02-19 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R244:a9656a0e4542: kcoreaddons_desktop_to_json: note the generated file in the build log (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-19 Thread Friedrich W . H . Kossebau
kossebau added a comment. In D10665#209765 , @apol wrote: > :P could you look into an actual fix? :/ The fix seems needed in automoc AFAICT. Nothing I have ever looked at, and no resources spare to do now. At least I invested so far

D10629: Avoid a double emitResult()

2018-02-19 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4b68374192ac: Avoid a double emitResult() (authored by jtamate). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10629?vs=27523=27571 REVISION DETAIL

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-19 Thread Aleix Pol Gonzalez
apol added a comment. :P could you look into an actual fix? :/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10665 To: kossebau, #frameworks, apol Cc: michaelh

D10664: kcoreaddons_desktop_to_json: note the generated file in the build log

2018-02-19 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH logjsoncreation REVISION DETAIL https://phabricator.kde.org/D10664 To: kossebau, apol Cc: #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 67 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/67/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 19 Feb 2018 18:45:00 + Build duration: 20 min and counting JUnit

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

2018-02-19 Thread Méven Car
meven abandoned this revision. meven added a comment. Abandoned in favor of https://phabricator.kde.org/D10663 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: dmitrio, ltoscano, ngraham, #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/64/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Feb 2018 18:45:00 + Build duration: 11 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 40 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/40/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 19 Feb 2018 18:45:00 + Build duration: 8 min 23 sec and counting

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes. Closed by commit R242:1ff405cca5b3: fix RTL appearance for ComboBox (authored by mvourlakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10592?vs=27382=27568

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

2018-02-19 Thread Nathaniel Graham
ngraham added a comment. Feel free to abandon the revision. Click the Add Action... pop-up menu that's above the comments box, and select "Abandon Revision." REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: dmitrio, ltoscano, ngraham,

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-19 Thread Friedrich W . H . Kossebau
kossebau edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10665 To: kossebau, #frameworks, apol Cc: michaelh

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > appletquickitem.cpp:57-68 > +if (s_preloadPolicy == Uninitialized) { > +if (qEnvironmentVariableIsSet("PLASMA_PRELOAD_POLICY")) { > +const QString policy = >

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Safa Alfulaij
safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Now since I'm a reviewer, sure :) REPOSITORY R242 Plasma Framework (Library) BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma,

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Méven Car
meven added a comment. It was suggested on IRC to hide this behavior behind a flag such as the jobFlag enum, so that it can be opt-in/opt-out in applications. We could consider changing the job state during the clean up, something like d->state == STATE_CLEANING_INCOMPLETE_FILE

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:6cbea20bf9f7: try to preload certain applets in a smart way (authored by mart). REPOSITORY R242 Plasma Framework

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/63/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Feb 2018 17:34:50 + Build duration: 24 min and counting JUnit

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Anthony Fieroni
anthonyfieroni edited reviewers, added: dfaure; removed: Dolphin. anthonyfieroni added a comment. It looks D10635 is duplicate. INLINE COMMENTS > copyjob.cpp:559 > +if (d->state == STATE_COPYING_FILES && d->m_bFileCopyingIsInProcess) { > +

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Méven Car
meven added a comment. Add this to your commit message FIXED-IN: 5.44 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, #dolphin Cc: meven, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-19 Thread Friedrich W . H . Kossebau
kossebau added a comment. And given what I think I learned here; also created D10665 to remove the seemingly effectless rules for depending the source's object file on the JSON file. REPOSITORY R244 KCoreAddons REVISION DETAIL

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

2018-02-19 Thread Méven Car
meven added a comment. In D10635#209656 , @dmitrio wrote: > I have also done some work on this issue, and my solution for this includes mechanism that should avoid deletion of existing data. I have uploaded

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 39 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/39/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 19 Feb 2018 17:34:50 + Build duration: 9 min 20 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 66 - Still Unstable!

2018-02-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/66/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 19 Feb 2018 17:34:50 + Build duration: 7 min 9 sec and counting JUnit

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-19 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, apol. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY The JSON file argument passed to K_PLUGIN_FACTORY_WITH_JSON ends up being used with the macro

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Michail Vourlakos
mvourlakos added a comment. > Sure. Go ahead and commit. is it possible to give first the green light by accepting the review? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart, safaalfulaij Cc: safaalfulaij,

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Michail Vourlakos
mvourlakos added a reviewer: safaalfulaij. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart, safaalfulaij Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Safa Alfulaij
safaalfulaij added a comment. In D10592#209670 , @mvourlakos wrote: > @safaalfulaij is there a green light for this? Sure. Go ahead and commit. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Marco Martin
mart updated this revision to Diff 27559. mart added a comment. - just PLASMA_PRELOAD_POLICY REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27558=27559 BRANCH arcpatch-D10512 REVISION DETAIL

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Marco Martin
mart updated this revision to Diff 27558. mart added a comment. - always delay preloading REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27557=27558 BRANCH arcpatch-D10512 REVISION DETAIL https://phabricator.kde.org/D10512

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Marco Martin
mart added a comment. In D10512#209679 , @ngraham wrote: > If by default this slows down plasmashell's loading in favor of making widgets load faster, I'm against it. People will notice the drawbacks of the former more than the benefits of the

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Nathaniel Graham
ngraham added a comment. If by default this slows down plasmashell's loading in favor of making widgets load faster, I'm against it. People will notice the drawbacks of the former more than the benefits of the latter. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Kai Uwe Broulik
broulik added a comment. lgtm REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10512 To: mart, #plasma Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Marco Martin
mart updated this revision to Diff 27557. mart added a comment. - cache env var reading REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27554=27557 BRANCH arcpatch-D10512 REVISION DETAIL https://phabricator.kde.org/D10512

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > appletquickitem.cpp:55 > { > +if (qEnvironmentVariableIsSet("KDE_PLASMA_PRELOAD_POLICY")) { > +const QByteArray policy = qgetenv("KDE_PLASMA_PRELOAD_POLICY"); Cache the result in a static to read it only once? >

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Michail Vourlakos
mvourlakos added a comment. @safaalfulaij is there a green light for this? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

D10664: kcoreaddons_desktop_to_json: note the generated file in the build log

2018-02-19 Thread Friedrich W . H . Kossebau
kossebau created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Being a known and explicitly generated build artifact, it helps understanding the build

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, #dolphin Cc: #frameworks, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, #dolphin Cc: #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

2018-02-19 Thread Dmitri Ovodok
dmitrio added a comment. I have also done some work on this issue, and my solution for this includes mechanism that should avoid deletion of existing data. I have uploaded my proposal to Phabricator too — hope it will be useful. REPOSITORY R241 KIO

D10512: try to preload certain applets in a smart way

2018-02-19 Thread Marco Martin
mart updated this revision to Diff 27554. mart added a comment. control with an env variable can be either always off, always on or adaptive REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27263=27554 BRANCH

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Dmitri Ovodok
dmitrio created this revision. dmitrio added a project: Frameworks. dmitrio requested review of this revision. REVISION SUMMARY BUG: 383764 Remove a partially copied file if copyjob was cancelled in the middle of file copying. File is considered to be in the process of being copied

D10661: indexerconfig: Expose canBeSearched function

2018-02-19 Thread Michael Heidelbach
michaelh added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10661 To: michaelh, #baloo, #dolphin, dfaure Cc: #frameworks, michaelh

D10578: balooctl monitor: Wait for dbus interface

2018-02-19 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > dfaure wrote in monitorcommand.cpp:53 > Hmm, why not just use QDbusServiceWatcher's signals, to connect to > serviceRegistered, if the service isn't available when we start? The idea to do it that way came to late. :-) I'll make an update

D10512: try to preload certain applets in a smart way

2018-02-19 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > appletquickitem.cpp:51 > +DefaultLauncherPreloadWeight = 100, > +DelayedPreloadWeight = 25, > +PreloadWeightIncrement = 5, So by default we preload /everything/ then over time your session gets faster as you don't use stuff?

D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

2018-02-19 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D10445 To: aacid, apol Cc: #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

2018-02-19 Thread Friedrich W . H . Kossebau
kossebau added a comment. BTW, for the related issue of moc not being re-run on the regeneration of the JSON file, I managed to get some test case to narrow this to automoc possibly and just reported it as https://gitlab.kitware.com/cmake/cmake/issues/17750 REPOSITORY R244 KCoreAddons

D10662: indexerconfig: Describe some functions

2018-02-19 Thread Michael Heidelbach
michaelh added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10662 To: michaelh, #baloo Cc: #frameworks, michaelh

D10662: indexerconfig: Describe some functions

2018-02-19 Thread Michael Heidelbach
michaelh created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH publicdescriptions (branched from master) REVISION DETAIL

D10661: indexerconfig: Expose canBeSearched function

2018-02-19 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Baloo, Dolphin. michaelh added a project: Frameworks. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Make D10205 public

D10444: Improve KLanguageButton::insertLanguage when no name is passed

2018-02-19 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R265 KConfigWidgets BRANCH arcpatch-D10444_1 REVISION DETAIL https://phabricator.kde.org/D10444 To: aacid, apol Cc: apol, #frameworks, michaelh

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

2018-02-19 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. Good idea REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol Cc: ngraham, michaelh

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

2018-02-19 Thread David Edmundson
davidedmundson added a comment. IMHO if we're fixing it, I'd go all-in and port from introspect to GetManagedObjects on the object manager. You get rid of all XML parsing and you'd get the initial properties in the same call (instead of an additional one per iface) You could even do

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

2018-02-19 Thread Nathaniel Graham
ngraham added a comment. These kinds of changes to Solid are going to need some *ahem* solid testing (I just kill myself sometimes) to avoid regressions, like the one we had in https://bugs.kde.org/show_bug.cgi?id=389479 REPOSITORY R245 Solid REVISION DETAIL

D10658: [UDisksDeviceBackend] Avoid double lookup

2018-02-19 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > udisksdevicebackend.cpp:55 > { > -if (s_backends.contains(udi)) { > -DeviceBackend *backend = s_backends.value(udi); > -s_backends.remove(udi); > -

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

2018-02-19 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol Cc: michaelh

D10653: Set IconItem default to smooth=true

2018-02-19 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D10653 To: davidedmundson, #plasma, apol Cc: plasma-devel, #frameworks,

D10658: [UDisksDeviceBackend] Avoid double lookup

2018-02-19 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY `QMap::value()` would return a `nullptr` if there is no such element. It is also perfectly valid

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

2018-02-19 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY The Qt Xml module is not actively maintained anymore and docs suggest to use QXmlStreamReader.

D10591: forcefully activate popup windows when they open

2018-02-19 Thread Marco Martin
mart added a comment. another way, may be adding a default kwin rule or script which lets every plasma window go trough REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10591 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks,

D10433: Add QML support for Prison

2018-02-19 Thread Volker Krause
vkrause added a comment. The interface for outputting barcodes is currently QImage. The problem is that QtQuick cannot directly consume a QImage without custom glue code (image provider, custom item, etc), unlike e.g. a QLabel. Using an image provider would allow standard Image elements to

D10591: forcefully activate popup windows when they open

2018-02-19 Thread Marco Martin
mart added a comment. In D10591#207905 , @davidedmundson wrote: > What would this code do if the device notifier is expanded but on the desktop? giving desktop window focus, which means we should also either check window flags or the

D10340: Clean up old, unreachable code

2018-02-19 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R306:7387d21c4516: Clean up old, unreachable code (authored by heikobecker). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10340?vs=26647=27537 REVISION DETAIL

D10654: [KUrlNavigatorPlacesSelector] Use KFilePlacesModel::convertedUrl

2018-02-19 Thread Henrik Fehlauer
rkflx added a comment. This fix looks pretty much just like a patch I have lying around somewhere. Still I wonder whether we should monkey-patch all present and future users of `KFilePlacesModel` instead of fixing a single location? Last time I looked at it this was Baloo (e.g.

D10654: [KUrlNavigatorPlacesSelector] Use KFilePlacesModel::convertedUrl

2018-02-19 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, elvisangelaccio. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY Fixes opening recent and search URLs from it. TEST PLAN Disabled Places sidebar in Dolphin,

D10653: Set IconItem default to smooth=true

2018-02-19 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This changes between

  1   2   >