D10670: Reduce plasmashell frozen time

[Jaime Torres Amate]

jtamate added a comment.


  In D10670#209823 , @mwolff wrote:
  
  > ok, looking at the reasoning in the other commit:
  >
  > - you need to extend the commit message here
  
  
  Will be done.
  
  > - you need to provide a comment in the code the clarifies what's going on 
here
  
  Will be done.
  
  > in general, I don't see how such a comparison can be so costly - the real 
problem would be too many native events, no? did you maybe profile a debug 
build or something?
  
  A qstrcmp is more expensive than a single cpu instruction in i586 builds 
(debug or release), unless it uses SSE4 instruction in the x64 world.
  
  Unfortunately I haven't found what causes so many native events.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff
Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 25 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/25/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Tue, 20 Feb 2018 06:53:52 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 22 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/22/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 20 Feb 2018 06:53:52 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/56)30%
(17/56)21%
(443/2101)21%
(264/1246)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)97%
(150/155)62%
(117/188)src100%
(8/8)100%
(8/8)68%
(205/302)47%
(111/235)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
(6/10)tests0%
   

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 23 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/23/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 20 Feb 2018 06:53:52 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/56)30%
(17/56)18%
(387/2093)18%
(227/1246)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)86%
(132/154)52%
(97/188)src100%
(8/8)100%
(8/8)62%
(183/297)43%
(101/235)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)38%
(20/52)50%
(24/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)88%
(43/49)50%
  

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 22 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/22/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 20 Feb 2018 06:53:52 +
 Build duration:
1 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D10671: Fix auto-mount regression

[Dmitry Khlestkov]

dkhlestkov added a comment.


  In D10671#209868 , @ngraham wrote:
  
  > we will need an email address to land this patch if it is accepted
  
  
  How do I provide it? I see no corresponding input field.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 24 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/24/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Tue, 20 Feb 2018 06:01:57 +
 Build duration:
20 min and counting
   CONSOLE OUTPUT
  [...truncated 278.76 KB...][Frameworks purpose kf5-qt5 WindowsMSVCQt5.9] Running batch scriptC:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.5.6** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.0.16 - empower your cores[  0%] Automatic MOC for target KF5Purpose[  1%] Built target KF5Purpose_autogen[  2%] Automatic MOC for target ReviewboardHelpers[  2%] Built target ReviewboardHelpers_autogen[  3%] Automatic MOC for target PhabricatorHelpers[  3%] Built target PhabricatorHelpers_autogen[  3%] Built target moveqmldir[ 11%] Built target KF5Purpose[ 14%] Built target ReviewboardHelpers[ 18%] Built target PhabricatorHelpers[ 19%] Automatic MOC for target alternativesmodeltest[ 19%] Built target alternativesmodeltest_autogen[ 20%] Automatic MOC for target KF5PurposeWidgets[ 21%] Built target KF5PurposeWidgets_autogen[ 21%] Automatic MOC for target purposeprocess[ 21%] Built target purposeprocess_autogen[ 22%] Automatic MOC for target saveasplugin[ 22%] Built target saveasplugin_autogen[ 22%] Automatic MOC for target imgurplugin[ 22%] Built target imgurplugin_autogen[ 23%] Automatic MOC for target pastebinplugin[ 23%] Built target pastebinplugin_autogen[ 24%] Automatic MOC for target ktpsendfileplugin[ 24%] Built target ktpsendfileplugin_autogen[ 25%] Automatic MOC for target kdeconnectplugin[ 25%] Built target kdeconnectplugin_autogen[ 26%] Automatic MOC for target emailplugin[ 26%] Built target emailplugin_autogen[ 27%] Automatic MOC for target purposequickplugin[ 28%] Built target purposequickplugin_autogen[ 29%] Automatic MOC for target sharetool[ 30%] Built target sharetool_autogen[ 31%] Automatic MOC for target rbpurposequickplugin[ 31%] Built target rbpurposequickplugin_autogen[ 32%] Automatic MOC for target reviewboardplugin[ 32%] Built target reviewboardplugin_autogen[ 33%] Automatic MOC for target testphabricator[ 33%] Built target testphabricator_autogen[ 34%] Automatic MOC for target phabricatorplugin[ 34%] Built target phabricatorplugin_autogen[ 35%] Automatic MOC for target phabricatorquickplugin[ 35%] Built target phabricatorquickplugin_autogen[ 38%] Built target alternativesmodeltest[ 43%] Built target KF5PurposeWidgets[ 47%] Built target purposeprocess[ 51%] Built target saveasplugin[ 55%] Built target imgurplugin[ 57%] Built target pastebinplugin[ 60%] Built target ktpsendfileplugin[ 63%] Built target kdeconnectplugin[ 65%] Built target emailplugin[ 70%] Built target purposequickplugin[ 74%] Built target sharetool[ 80%] Built target rbpurposequickplugin[ 82%] Built target reviewboardplugin[ 85%] Built target testphabricator[ 88%] Built target phabricatorplugin[ 92%] Built target phabricatorquickplugin[ 93%] Automatic MOC for target menutest[ 93%] Built target menutest_autogen[ 94%] Automatic MOC for target menudemo[ 94%] Built target menudemo_autogen[ 97%] Built target menutest[100%] Built target menudemoInstall the project...-- Install configuration: "Debug"-- Installing: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-divert/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Purpose/KF5PurposeConfig.cmake-- Installing: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-divert/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Purpose/KF5PurposeConfigVersion.cmake-- Installing: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-divert/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Purpose/KF5PurposeTargets.cmake-- Installing: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-divert/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Purpose/KF5PurposeTargets-debug.cmake-- Installing: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-divert/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/include/KF5/purpose/purpose_version.hCMake Error at cmake_install.cmake:61 (file):  file INSTALL cannot find "C:/CI/workspace/Frameworks purpose kf5-qt5  WindowsMSVCQt5.9/purpose.categories".jom: C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9\build\Makefile [install] Error 1[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] bat[Frameworks 

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 22 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/22/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 20 Feb 2018 06:01:57 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   CONSOLE OUTPUT
  [...truncated 8.44 MB...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/install-build.py --product Frameworks --project purpose --branchGroup kf5-qt5 --platform SUSEQt5.7 --installTo /home/jenkins//install-prefix/ --divertTo '/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/install-divert/'[  1%] Automatic MOC for target KF5Purpose[  2%] Automatic MOC for target nextcloudplugin[  3%] Automatic MOC for target PhabricatorHelpers[  4%] Automatic MOC for target youtubeplugin[  5%] Automatic MOC for target ReviewboardHelpers[  5%] Built target KF5Purpose_autogen[  5%] Built target PhabricatorHelpers_autogen[  5%] Built target nextcloudplugin_autogen[  5%] Built target youtubeplugin_autogen[  5%] Built target ReviewboardHelpers_autogen[  8%] Built target PhabricatorHelpers[ 16%] Built target KF5Purpose[ 19%] Built target ReviewboardHelpers[ 19%] Built target moveqmldir[ 20%] Automatic MOC for target testphabricator[ 21%] Automatic MOC for target purposeprocess[ 21%] Automatic MOC for target alternativesmodeltest[ 22%] Automatic MOC for target phabricatorquickplugin[ 23%] Automatic MOC for target KF5PurposeWidgets[ 23%] Built target testphabricator_autogen[ 24%] Automatic MOC for target saveasplugin[ 24%] Built target alternativesmodeltest_autogen[ 25%] Built target phabricatorquickplugin_autogen[ 25%] Automatic MOC for target imgurplugin[ 25%] Built target purposeprocess_autogen[ 25%] Built target saveasplugin_autogen[ 25%] Built target KF5PurposeWidgets_autogen[ 26%] Automatic MOC for target ktpsendfileplugin[ 26%] Built target imgurplugin_autogen[ 26%] Automatic MOC for target pastebinplugin[ 30%] Built target youtubeplugin[ 31%] Automatic MOC for target kdeconnectplugin[ 34%] Built target nextcloudplugin[ 34%] Built target ktpsendfileplugin_autogen[ 35%] Automatic MOC for target reviewboardplugin[ 35%] Built target pastebinplugin_autogen[ 36%] Automatic MOC for target rbpurposequickplugin[ 36%] Built target kdeconnectplugin_autogen[ 37%] Automatic MOC for target phabricatorplugin[ 37%] Built target reviewboardplugin_autogen[ 40%] Built target testphabricator[ 40%] Built target rbpurposequickplugin_autogen[ 41%] Automatic MOC for target emailplugin[ 42%] Automatic MOC for target purposequickplugin[ 46%] Built target phabricatorquickplugin[ 46%] Built target phabricatorplugin_autogen[ 47%] Automatic MOC for target sharetool[ 47%] Built target emailplugin_autogen[ 52%] Built target KF5PurposeWidgets[ 52%] Built target purposequickplugin_autogen[ 52%] Built target sharetool_autogen[ 55%] Built target alternativesmodeltest[ 57%] Built target saveasplugin[ 60%] Built target purposeprocess[ 62%] Built target ktpsendfileplugin[ 64%] Built target kdeconnectplugin[ 68%] Built target imgurplugin[ 71%] Built target pastebinplugin[ 76%] Built target rbpurposequickplugin[ 78%] Built target reviewboardplugin[ 81%] Built target phabricatorplugin[ 84%] Built target emailplugin[ 88%] Built target purposequickplugin[ 89%] Automatic MOC for target menudemo[ 93%] Built target sharetool[ 94%] Automatic MOC for target menutest[ 94%] Built target menudemo_autogen[ 94%] Built target menutest_autogen[ 97%] Built target menudemo[100%] Built target menutestInstall the project...-- Install configuration: "Debug"-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Purpose/KF5PurposeConfig.cmake-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Purpose/KF5PurposeConfigVersion.cmake-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Purpose/KF5PurposeTargets.cmake-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Purpose/KF5PurposeTargets-debug.cmake-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.7/install-divert/home/jenkins/install-prefix/include/KF5/purpose/purpose_version.hCMake Error at cmake_install.cmake:71 (file):  file INSTALL cannot find "/home/jenkins/workspace/Frameworks purpose  kf5-qt5 SUSEQt5.7/purpose.categories".make: *** [Makefile:74: install] Error 1[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.7] Running shell 

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 21 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/21/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 20 Feb 2018 06:01:57 +
 Build duration:
6 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   CONSOLE OUTPUT
  [...truncated 462.50 KB...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/install-build.py --product Frameworks --project purpose --branchGroup kf5-qt5 --platform SUSEQt5.10 --installTo /home/jenkins//install-prefix/ --divertTo '/home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/install-divert/'[  1%] Automatic MOC for target KF5Purpose[  1%] Built target KF5Purpose_autogen[  1%] Built target moveqmldir[  9%] Built target KF5Purpose[ 10%] Automatic MOC for target PhabricatorHelpers[ 10%] Built target PhabricatorHelpers_autogen[ 10%] Automatic MOC for target alternativesmodeltest[ 10%] Built target alternativesmodeltest_autogen[ 11%] Automatic MOC for target purposeprocess[ 11%] Built target purposeprocess_autogen[ 12%] Automatic MOC for target saveasplugin[ 12%] Built target saveasplugin_autogen[ 13%] Automatic MOC for target imgurplugin[ 13%] Built target imgurplugin_autogen[ 13%] Automatic MOC for target pastebinplugin[ 13%] Built target pastebinplugin_autogen[ 14%] Automatic MOC for target ktpsendfileplugin[ 14%] Built target ktpsendfileplugin_autogen[ 15%] Automatic MOC for target kdeconnectplugin[ 15%] Built target kdeconnectplugin_autogen[ 18%] Built target PhabricatorHelpers[ 19%] Automatic MOC for target emailplugin[ 19%] Built target emailplugin_autogen[ 20%] Automatic MOC for target purposequickplugin[ 20%] Built target purposequickplugin_autogen[ 21%] Automatic MOC for target sharetool[ 21%] Built target sharetool_autogen[ 24%] Built target alternativesmodeltest[ 27%] Built target purposeprocess[ 29%] Built target saveasplugin[ 33%] Built target imgurplugin[ 36%] Built target pastebinplugin[ 38%] Built target ktpsendfileplugin[ 40%] Built target kdeconnectplugin[ 41%] Automatic MOC for target testphabricator[ 41%] Built target testphabricator_autogen[ 42%] Automatic MOC for target phabricatorplugin[ 42%] Built target phabricatorplugin_autogen[ 43%] Automatic MOC for target phabricatorquickplugin[ 43%] Built target phabricatorquickplugin_autogen[ 46%] Built target emailplugin[ 51%] Built target purposequickplugin[ 55%] Built target sharetool[ 58%] Built target testphabricator[ 61%] Built target phabricatorplugin[ 65%] Built target phabricatorquickplugin[ 66%] Automatic MOC for target KF5PurposeWidgets[ 66%] Built target KF5PurposeWidgets_autogen[ 67%] Automatic MOC for target ReviewboardHelpers[ 67%] Built target ReviewboardHelpers_autogen[ 71%] Built target KF5PurposeWidgets[ 74%] Built target ReviewboardHelpers[ 75%] Automatic MOC for target menudemo[ 75%] Built target menudemo_autogen[ 76%] Automatic MOC for target rbpurposequickplugin[ 76%] Built target rbpurposequickplugin_autogen[ 79%] Built target menudemo[ 84%] Built target rbpurposequickplugin[ 85%] Automatic MOC for target reviewboardplugin[ 85%] Built target reviewboardplugin_autogen[ 86%] Automatic MOC for target menutest[ 86%] Built target menutest_autogen[ 88%] Built target reviewboardplugin[ 90%] Built target menutest[ 91%] Automatic MOC for target nextcloudplugin[ 91%] Built target nextcloudplugin_autogen[ 92%] Automatic MOC for target youtubeplugin[ 92%] Built target youtubeplugin_autogen[ 95%] Built target nextcloudplugin[100%] Built target youtubepluginInstall the project...-- Install configuration: "Debug"-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Purpose/KF5PurposeConfig.cmake-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Purpose/KF5PurposeConfigVersion.cmake-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Purpose/KF5PurposeTargets.cmake-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Purpose/KF5PurposeTargets-debug.cmake-- Installing: /home/jenkins/workspace/Frameworks purpose kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/purpose/purpose_version.hCMake Error at cmake_install.cmake:71 (file):  file INSTALL cannot find "/home/jenkins/workspace/Frameworks purpose  kf5-qt5 SUSEQt5.10/purpose.categories".make: *** [Makefile:74: install] Error 1[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u 

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 21 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/21/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 20 Feb 2018 06:01:57 +
 Build duration:
5 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 237.47 KB...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[Frameworks purpose kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/install-build.py --product Frameworks --project purpose --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --installTo /usr/home/jenkins//install-prefix/ --divertTo '/usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/install-divert/'[  1%] Automatic MOC for target KF5Purpose[  2%] Automatic MOC for target nextcloudplugin[  3%] Automatic MOC for target ReviewboardHelpers[  4%] Automatic MOC for target youtubeplugin[  4%] Built target ReviewboardHelpers_autogen[  4%] Built target KF5Purpose_autogen[  4%] Built target nextcloudplugin_autogen[  4%] Built target youtubeplugin_autogen[  5%] Automatic MOC for target PhabricatorHelpers[ 13%] Built target KF5Purpose[ 13%] Built target moveqmldir[ 13%] Built target PhabricatorHelpers_autogen[ 16%] Built target ReviewboardHelpers[ 16%] Automatic MOC for target alternativesmodeltest[ 17%] Automatic MOC for target purposeprocess[ 18%] Automatic MOC for target saveasplugin[ 19%] Automatic MOC for target KF5PurposeWidgets[ 19%] Built target alternativesmodeltest_autogen[ 20%] Automatic MOC for target imgurplugin[ 20%] Built target purposeprocess_autogen[ 20%] Built target KF5PurposeWidgets_autogen[ 20%] Automatic MOC for target pastebinplugin[ 20%] Built target saveasplugin_autogen[ 20%] Built target imgurplugin_autogen[ 24%] Built target youtubeplugin[ 24%] Built target pastebinplugin_autogen[ 25%] Automatic MOC for target ktpsendfileplugin[ 25%] Built target ktpsendfileplugin_autogen[ 26%] Automatic MOC for target kdeconnectplugin[ 27%] Automatic MOC for target rbpurposequickplugin[ 30%] Built target nextcloudplugin[ 31%] Automatic MOC for target reviewboardplugin[ 31%] Built target kdeconnectplugin_autogen[ 31%] Built target rbpurposequickplugin_autogen[ 31%] Built target reviewboardplugin_autogen[ 32%] Automatic MOC for target emailplugin[ 33%] Automatic MOC for target purposequickplugin[ 36%] Built target PhabricatorHelpers[ 37%] Automatic MOC for target sharetool[ 37%] Built target emailplugin_autogen[ 37%] Built target purposequickplugin_autogen[ 40%] Built target alternativesmodeltest[ 40%] Built target sharetool_autogen[ 44%] Built target KF5PurposeWidgets[ 48%] Built target imgurplugin[ 52%] Built target purposeprocess[ 55%] Built target pastebinplugin[ 57%] Built target saveasplugin[ 59%] Built target kdeconnectplugin[ 61%] Built target reviewboardplugin[ 66%] Built target rbpurposequickplugin[ 67%] Automatic MOC for target testphabricator[ 69%] Built target ktpsendfileplugin[ 69%] Built target testphabricator_autogen[ 70%] Automatic MOC for target phabricatorquickplugin[ 71%] Automatic MOC for target phabricatorplugin[ 74%] Built target emailplugin[ 74%] Built target phabricatorquickplugin_autogen[ 78%] Built target purposequickplugin[ 79%] Automatic MOC for target menudemo[ 79%] Built target phabricatorplugin_autogen[ 79%] Built target menudemo_autogen[ 83%] Built target sharetool[ 84%] Automatic MOC for target menutest[ 87%] Built target testphabricator[ 91%] Built target phabricatorquickplugin[ 91%] Built target menutest_autogen[ 94%] Built target phabricatorplugin[ 97%] Built target menudemo[100%] Built target menutestInstall the project...-- Install configuration: "Debug"-- Installing: /usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/lib/cmake/KF5Purpose/KF5PurposeConfig.cmake-- Installing: /usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/lib/cmake/KF5Purpose/KF5PurposeConfigVersion.cmake-- Installing: /usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/lib/cmake/KF5Purpose/KF5PurposeTargets.cmake-- Installing: /usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/lib/cmake/KF5Purpose/KF5PurposeTargets-debug.cmake-- Installing: /usr/home/jenkins/workspace/Frameworks purpose kf5-qt5 FreeBSDQt5.9/install-divert/usr/home/jenkins/install-prefix/include/KF5/purpose/purpose_version.hCMake Error at cmake_install.cmake:66 (file):  file INSTALL cannot find "/usr/home/jenkins/workspace/Frameworks purpose  kf5-qt5 FreeBSDQt5.9/purpose.categories".gmake: *** [Makefile:129: install] Error 1[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks purpose kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py 

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/53/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 20 Feb 2018 00:06:36 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(237/306)60%
(152/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(195/249)61%
(137/224)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/53/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 20 Feb 2018 00:06:36 +
 Build duration:
6 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(237/306)60%
(152/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(195/249)61%
(137/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/50/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 20 Feb 2018 00:06:36 +
 Build duration:
3 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.scalable

D10646: Support case-insensitive WordDetect

[jonathan poelen]

jpoelen added a comment.


  It seems that KTextEditor does not have the problem because KateHlWordDetect 
is based on KateHlStringDetect which uses the inSensitive parameter.

INLINE COMMENTS

> rule_p.h:249
>  QString m_word;
> +Qt::CaseSensitivity m_caseSensitivity;
>  };

Yes, but it is in any case overwritten by doLoad(). StringDetect and others do 
not have this initialization either, should I also make the modification?
In fact, I do not think it's relevant because the analysis tools would no 
longer detect "uninitialized" variables in the case, for example, of calling 
doMatch before doLoad.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  word_insensitive

REVISION DETAIL
  https://phabricator.kde.org/D10646

To: jpoelen, dhaumann
Cc: dhaumann, #frameworks, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Nathaniel Graham]

ngraham added a comment.


  I would prefer to have the cleanup behavior happen by default, if we end up 
making this optional.
  
  It would be nice if we could also also handle the `KIO::ERR_DISK_FULL` case.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure
Cc: ngraham, anthonyfieroni, meven, #frameworks, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Dmitri Ovodok]

dmitrio marked an inline comment as done.
dmitrio added a comment.


  In D10663#209708 , @meven wrote:
  
  > Add this to your commit message
  >  FIXED-IN: 5.44
  
  
  Thank you, added it to the description.
  
  In D10663#209711 , @anthonyfieroni 
wrote:
  
  > It looks D10635  is duplicate.
  
  
  In fact, this revision is a duplicate of D10635 
. I am a bit surprised why this one has a 
smaller number :)
  
  In D10663#209720 , @meven wrote:
  
  > It was suggested on IRC to hide this behavior behind a flag such as the 
jobFlag enum, so that it can be opt-in/opt-out in applications.
  
  
  I agree with this proposal, but I can suggest that the added flag should 
rather turn off the new behavior, so the default behavior will be to do this 
cleanup on job cancel.
  However, if more people think that it should not be turned on by default, it 
would be easy to change this diff to achieve an opposite behavior.
  
  In D10663#209720 , @meven wrote:
  
  > We could consider changing the job state during the clean up, something like
  >
  >   d->state == STATE_CLEANING_INCOMPLETE_FILE
  >
  
  
  For now, I see no point in this change, since, to avoid breaking a logic of 
doKill() method, the deletion job is currently launched not as subjob, but as a 
separate job. So, after doKill() execution the CopyJob does nothing anymore (as 
it is supposed to be) and has no need in tracking its state. Feel free to 
correct me if I am wrong.

INLINE COMMENTS

> meven wrote in copyjob.cpp:559
> I believe this is because files are copied in sequence, so at any given time 
> only the first file is being copied.
> 
> Maybe you could use m_currentSrcURL to avoid accessing the iterator.

You are right, updated a diff.

On the question on deleting first file only, yes, we need to delete only the 
file that was being copied before the user canceled the job. Perhaps using 
m_currentDestURL would make this intention more clear.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure
Cc: anthonyfieroni, meven, #frameworks, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Dmitri Ovodok]

dmitrio updated this revision to Diff 27582.
dmitrio edited the summary of this revision.
dmitrio added a comment.


  Add a flag which turns off cleaning up on job cancel.
  Use m_currentDestURL instead of obtaining the destination file name from an 
iterator.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10663?vs=27546=27582

REVISION DETAIL
  https://phabricator.kde.org/D10663

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h
  src/core/job_base.h

To: dmitrio, #frameworks, dfaure
Cc: anthonyfieroni, meven, #frameworks, michaelh

D10671: Fix auto-mount regression

[Nathaniel Graham]

ngraham added a comment.


  FWIW we will need an email address to land this patch if it is accepted. In 
the future, if you use Arc to submit the patch 
,
 this step won't be necessary.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh

D10671: Fix auto-mount regression

[Dmitry Khlestkov]

dkhlestkov added a comment.


  yes, this would be safe

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: rikmills, #frameworks, michaelh

D10671: Fix auto-mount regression

[Rik Mills]

rikmills added a comment.


  I assume this would be safe to backport to 5.43, should it be accepted?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: rikmills, #frameworks, michaelh

D10671: Fix auto-mount regression

[Nathaniel Graham]

ngraham added reviewers: Frameworks, broulik.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: #frameworks, michaelh

D10671: Fix auto-mount regression

[Dmitry Khlestkov]

dkhlestkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
dkhlestkov requested review of this revision.

REVISION SUMMARY
  BUG: 389479
  Devices with empty path stopped auto-mounting after commit 
1384f275ab2f1ad1841753ee163af6d1b0bb952b 
.
  This diff fixes the regression by checking if the path is empty.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: dkhlestkov
Cc: #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Andreas Kainz]

andreask requested changes to this revision.
andreask added a comment.
This revision now requires changes to proceed.


  only in 16px there is no circle and in general I'm not really happy to have 
no circle around the icon. maybe for repeat and shuffle it will work but 
play/pause are more intuitive with circle than without.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: andreask, ngraham, #frameworks, michaelh

D10293: remove view-media-playlist from preferences icons

[Andreas Kainz]

andreask accepted this revision.
andreask added a comment.
This revision is now accepted and ready to land.


  I added the colored icon for elisa but I understood if you don't like it. 
personally I'm not 100% happy with large monochrome icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  delete_playlist_preferences

REVISION DETAIL
  https://phabricator.kde.org/D10293

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: andreask, #frameworks, michaelh

D10279: add 24px media-album-cover icon

[Andreas Kainz]

andreask accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  media-album-cover

REVISION DETAIL
  https://phabricator.kde.org/D10279

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: ngraham, #frameworks, michaelh

D10670: Reduce plasmashell frozen time

[Milian Wolff]

mwolff added a comment.


  ok, looking at the reasoning in the other commit:
  
  - you need to extend the commit message here
  - you need to provide a comment in the code the clarifies what's going on here
  
  in general, I don't see how such a comparison can be so costly - the real 
problem would be too many native events, no? did you maybe profile a debug 
build or something?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff
Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  what? this is totally unsafe - the reinterpret_cast below shouldn't be done 
on anything that has event names other than the previously used one...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff
Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D10445

To: aacid, apol
Cc: #frameworks, michaelh

D10444: Improve KLanguageButton::insertLanguage when no name is passed

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:b1e30535eca4: Improve KLanguageButton::insertLanguage 
when no name is passed (authored by aacid).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10444?vs=27027=27578

REVISION DETAIL
  https://phabricator.kde.org/D10444

AFFECTED FILES
  src/klanguagebutton.cpp

To: aacid, apol
Cc: apol, #frameworks, michaelh

D10627: Reduce plasmashell frozen time to almost nothing

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e1fe26f1fc78: Reduce plasmashell frozen time to almost 
nothing (authored by jtamate).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10627?vs=27453=27577

REVISION DETAIL
  https://phabricator.kde.org/D10627

AFFECTED FILES
  shell/screenpool.cpp

To: jtamate, #frameworks, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Third part of https://phabricator.kde.org/D10627

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10670

AFFECTED FILES
  src/plasma/private/effectwatcher.cpp

To: jtamate, #frameworks, #plasma
Cc: plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10669: Reduce plasmashell frozen time

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Second part of https://phabricator.kde.org/D10627

REPOSITORY
  R278 KWindowSystem

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10669

AFFECTED FILES
  src/platforms/xcb/kxmessages.cpp

To: jtamate, #plasma, #frameworks
Cc: plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/51/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 19 Feb 2018 19:41:15 +
 Build duration:
8 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/46/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 19 Feb 2018 19:41:15 +
 Build duration:
7 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/35/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 19 Feb 2018 19:41:15 +
 Build duration:
3 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

D10664: kcoreaddons_desktop_to_json: note the generated file in the build log

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:a9656a0e4542: kcoreaddons_desktop_to_json: note the 
generated file in the build log (authored by kossebau).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10664?vs=27556=27573

REVISION DETAIL
  https://phabricator.kde.org/D10664

AFFECTED FILES
  KF5CoreAddonsMacros.cmake

To: kossebau, apol
Cc: #frameworks, michaelh

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D10665#209765 , @apol wrote:
  
  > :P could you look into an actual fix? :/
  
  
  The fix seems needed in automoc AFAICT. Nothing I have ever looked at, and no 
resources spare to do now.
  
  At least I invested so far into filing a bug report to cmake with a test case 
to demo the issue, see the linked 
https://gitlab.kitware.com/cmake/cmake/issues/17750 ("automoc: dependencies 
added with AUTOGEN_TARGET_DEPENDS do not trigger moc re-run if Q_OBJECT is 
inside C++ preprocessor macro") :) so hoping the experts can pick up this 
quickly and do what is needed.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10665

To: kossebau, #frameworks, apol
Cc: michaelh

D10629: Avoid a double emitResult()

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4b68374192ac: Avoid a double emitResult() (authored by 
jtamate).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10629?vs=27523=27571

REVISION DETAIL
  https://phabricator.kde.org/D10629

AFFECTED FILES
  dataengines/notifications/notificationaction.cpp
  klipper/clipboardjob.cpp

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

[Aleix Pol Gonzalez]

apol added a comment.


  :P could you look into an actual fix? :/

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10665

To: kossebau, #frameworks, apol
Cc: michaelh

D10664: kcoreaddons_desktop_to_json: note the generated file in the build log

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  logjsoncreation

REVISION DETAIL
  https://phabricator.kde.org/D10664

To: kossebau, apol
Cc: #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 67 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/67/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 19 Feb 2018 18:45:00 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13329)19%
(1978/10539)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2004)18%
(306/1745)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Méven Car]

meven abandoned this revision.
meven added a comment.


  Abandoned in favor of https://phabricator.kde.org/D10663

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: dmitrio, ltoscano, ngraham, #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/64/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 19 Feb 2018 18:45:00 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/1)19%
(1979/10539)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2004)18%
(306/1745)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/40/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 19 Feb 2018 18:45:00 +
 Build duration:
8 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1ff405cca5b3: fix RTL appearance for ComboBox (authored 
by mvourlakos).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10592?vs=27382=27568

REVISION DETAIL
  https://phabricator.kde.org/D10592

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Nathaniel Graham]

ngraham added a comment.


  Feel free to abandon the revision. Click the Add Action... pop-up menu that's 
above the comments box, and select "Abandon Revision."

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: dmitrio, ltoscano, ngraham, #frameworks, michaelh

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

[Friedrich W . H . Kossebau]

kossebau edited the test plan for this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10665

To: kossebau, #frameworks, apol
Cc: michaelh

D10512: try to preload certain applets in a smart way

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:57-68
> +if (s_preloadPolicy == Uninitialized) {
> +if (qEnvironmentVariableIsSet("PLASMA_PRELOAD_POLICY")) {
> +const QString policy = 
> QString::fromUtf8(qgetenv("PLASMA_PRELOAD_POLICY")).toLower();
> +if (policy == QStringLiteral("aggressive")) {
> +s_preloadPolicy = Aggressive;
> +} else if (policy == QStringLiteral("none")) {
> +s_preloadPolicy = None;

So Adaptive can a default even environment variable is not setted?
Furthermore you can make a static function to access value

  AppletQuickItemPrivate::PreloadPolicy AppletQuickItemPrivate::appletPolicy()
  {
  static const PreloadPolicy preloadPolicy = []() -> PreloadPolicy {
  if (qEnvironmentVariableIsSet("PLASMA_PRELOAD_POLICY")) {
  const QString policy = 
QString::fromUtf8(qgetenv("PLASMA_PRELOAD_POLICY")).toLower();
  if (policy == QStringLiteral("aggressive")) {
  return Aggressive;
  } else if (policy == QStringLiteral("none")) {
  return None;
  }
  }
  return Adaptive;
  }();
  return preloadPolicy;
  }

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, broulik, apol, ngraham, plasma-devel, 
#frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D10592: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij accepted this revision.
safaalfulaij added a comment.
This revision is now accepted and ready to land.


  Now since I'm a reviewer, sure :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Méven Car]

meven added a comment.


  It was suggested on IRC to hide this behavior behind a flag such as the 
jobFlag enum, so that it can be opt-in/opt-out in applications.
  
  We could consider changing the job state during the clean up, something like
  
d->state == STATE_CLEANING_INCOMPLETE_FILE

INLINE COMMENTS

> anthonyfieroni wrote in copyjob.cpp:559
> Why only first not all?

I believe this is because files are copied in sequence, so at any given time 
only the first file is being copied.

Maybe you could use m_currentSrcURL to avoid accessing the iterator.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure
Cc: anthonyfieroni, meven, #frameworks, michaelh

D10512: try to preload certain applets in a smart way

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6cbea20bf9f7: try to preload certain applets in a smart 
way (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27559=27561

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/63/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 19 Feb 2018 17:34:50 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3558/13332)19%
(1978/10539)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2004)18%
(306/1745)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Anthony Fieroni]

anthonyfieroni edited reviewers, added: dfaure; removed: Dolphin.
anthonyfieroni added a comment.


  It looks D10635  is duplicate.

INLINE COMMENTS

> copyjob.cpp:559
> +if (d->state == STATE_COPYING_FILES && d->m_bFileCopyingIsInProcess) {
> +QList::Iterator it = d->files.begin();
> +const QUrl dest = (*it).uDest;

Why only first not all?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure, #dolphin
Cc: anthonyfieroni, meven, #frameworks, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Méven Car]

meven added a comment.


  Add this to your commit message
  FIXED-IN: 5.44

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, #dolphin
Cc: meven, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Friedrich W . H . Kossebau]

kossebau added a comment.


  And given what I think I learned here; also created D10665 
 to remove the seemingly effectless rules 
for  depending the source's object file on the JSON file.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Méven Car]

meven added a comment.


  In D10635#209656 , @dmitrio wrote:
  
  > I have also done some work on this issue, and my solution for this includes 
mechanism that should avoid deletion of existing data. I have uploaded 
 my proposal to Phabricator too — hope it 
will be useful.
  
  
  I already like better your proposal than mine. I wish I had reimplemented 
doKill as you did.
  
  We should consider closing this revision in favor of 
https://phabricator.kde.org/D10663 that needs polish though IMHO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: dmitrio, ltoscano, ngraham, #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/39/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 19 Feb 2018 17:34:50 +
 Build duration:
9 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 66 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/66/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 19 Feb 2018 17:34:50 +
 Build duration:
7 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3557/13328)19%
(1977/10539)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2004)18%
(306/1745)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, apol.
Restricted Application added a project: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  The JSON file argument passed to K_PLUGIN_FACTORY_WITH_JSON ends up
  being used with the macro Q_PLUGIN_METADATA, which is a no-code macro
  at the C++ level and only used to note information used by moc for the
  generated moc file.
  
  So when the content of the JSON file has changed, this will not change
  anything in the preprocessed source file itself. It will only change the
  content of the moc file generated based on it, which already is noted
  as dependency to the object file due to being a file included by the
  source.
  
  This code possibly was added hoping to solve the issue of cmake's automoc
  not properly dealing with Q_OBJECT macros hidden away in other C++
  preprocessor macros. But it misses to catch the issue that it is the
  generated moc file which needs to be regenerated on a change of the JSON
  file, not just the object file.
  Regenerating the moc file is something only automoc decides about when
  being run and which seems not influenced by CMakeLists.txt rules.
  
  Cmp. https://gitlab.kitware.com/cmake/cmake/issues/17750

TEST PLAN
  Projects like plasma-desktop still build as before.
  Editing desktop files/JSON files still results in same (broken) rebuild
  behaviour.

REPOSITORY
  R244 KCoreAddons

BRANCH
  removeeffectlessOBJECT_DEPENDS

REVISION DETAIL
  https://phabricator.kde.org/D10665

AFFECTED FILES
  KF5CoreAddonsMacros.cmake

To: kossebau, #frameworks, apol
Cc: michaelh

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  > Sure. Go ahead and commit.
  
  is it possible to give first the green light by accepting the review?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a reviewer: safaalfulaij.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added a comment.


  In D10592#209670 , @mvourlakos 
wrote:
  
  > @safaalfulaij is there a green light for this?
  
  
  Sure. Go ahead and commit.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27559.
mart added a comment.


  - just PLASMA_PRELOAD_POLICY

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27558=27559

BRANCH
  arcpatch-D10512

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27558.
mart added a comment.


  - always delay preloading

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27557=27558

BRANCH
  arcpatch-D10512

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart added a comment.


  In D10512#209679 , @ngraham wrote:
  
  > If by default this slows down plasmashell's loading in favor of making 
widgets load faster, I'm against it. People will notice the drawbacks of the 
former more than the benefits of the latter.
  
  
  with the trick of the QTimer,  it shows an usable desktop actually before 
things are preloaded, then starting doing its things in the background.
  thesting on the local systems, plasma seems to stay fluid even while it's 
actually performing the preload in the background, so shouldn't be noticeable 
there.
  of course, needs to be tried by many people with systems more or less 
performant

INLINE COMMENTS

> broulik wrote in appletquickitem.cpp:55
> Cache the result in a static to read it only once?

in a static?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Nathaniel Graham]

ngraham added a comment.


  If by default this slows down plasmashell's loading in favor of making 
widgets load faster, I'm against it. People will notice the drawbacks of the 
former more than the benefits of the latter.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Kai Uwe Broulik]

broulik added a comment.


  lgtm

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27557.
mart added a comment.


  - cache env var reading

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27554=27557

BRANCH
  arcpatch-D10512

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:55
>  {
> +if (qEnvironmentVariableIsSet("KDE_PLASMA_PRELOAD_POLICY")) {
> +const QByteArray policy = qgetenv("KDE_PLASMA_PRELOAD_POLICY");

Cache the result in a static to read it only once?

> appletquickitem.cpp:57
> +const QByteArray policy = qgetenv("KDE_PLASMA_PRELOAD_POLICY");
> +if (policy == "Aggressive") {
> +preloadPolicy = Aggressive;

case insensitive?

> appletquickitem.cpp:653
> +const int delay = qrand() % ((max + 1) - min) + min;
> +QTimer::singleShot(delay, [this, delay]() {
> +qCInfo(LOG_PLASMAQUICK) << "Delayed preload of " << 
> d->applet->title() << "after" << (qreal)delay/1000 << "seconds";

Still missing `this` context:

  QTimer::singleShot(delay, this, [this, delay]() {

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  @safaalfulaij is there a green light for this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10664: kcoreaddons_desktop_to_json: note the generated file in the build log

[Friedrich W . H . Kossebau]

kossebau created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Being a known and explicitly generated build artifact, it helps
  understanding the build process to see when the JSON file is generated.
  It also creates consistency with similar build artifacts (e.g. source files
  generated from UI files or JSON files created from kpackage desktop files).

REPOSITORY
  R244 KCoreAddons

BRANCH
  logjsoncreation

REVISION DETAIL
  https://phabricator.kde.org/D10664

AFFECTED FILES
  KF5CoreAddonsMacros.cmake

To: kossebau
Cc: #frameworks, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, #dolphin
Cc: #frameworks, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Nathaniel Graham]

ngraham added reviewers: Frameworks, Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, #dolphin
Cc: #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Dmitri Ovodok]

dmitrio added a comment.


  I have also done some work on this issue, and my solution for this includes 
mechanism that should avoid deletion of existing data. I have uploaded 
 my proposal to Phabricator too — hope it 
will be useful.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: dmitrio, ltoscano, ngraham, #frameworks, michaelh

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27554.
mart added a comment.


  control with an env variable
  
  can be either always off, always on or adaptive

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27263=27554

BRANCH
  arcpatch-D10512

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Dmitri Ovodok]

dmitrio created this revision.
dmitrio added a project: Frameworks.
dmitrio requested review of this revision.

REVISION SUMMARY
  BUG: 383764
  
  Remove a partially copied file if copyjob was cancelled in the middle of file 
copying.
  
  File is considered to be in the process of being copied after some data block 
is actually written (or, to be more precise, slotProcessedSize is called). This 
should help us avoid cleaning up by mistake files that existed before the 
operation. This also means that in some very rare occasions when user cancels 
copying in the very beginning of the operation cleaning up procedure may not 
work — which is, I believe, the best result we can obtain without more 
significant code changes.
  
  Unlike this proposal , my option does not 
include handling of the full disk or any other errors. In its current state it 
applies only to the case when job gets killed by user.

TEST PLAN
  While I am not sure about automated testing, various manual testing scenarios 
can be suggested:
  
  I.
  
  1. Start copying a large file(s) to  empty directory
  2. Cancel copying
  3. File which copying was cancelled should **not** be present at the 
destination.
  
  II.
  
  1. Start copying a large file(s) to the directory with existing files with 
colliding names
  2. Cancel copying (not via "File exists" dialog)
  3. Original file should be present at the destination
  
  One may also want to test behavior in situation when it is not possible to 
delete the file.
  For example:
  
  1. Start copying a file to some network folder
  2. Turn off network connection
  3. Cancel copying
  4. File deletion UI should appear in the notifications area. You should now 
be able to cancel deletion or wait a bit for an error message.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h

To: dmitrio
Cc: #frameworks, michaelh

D10661: indexerconfig: Expose canBeSearched function

[Michael Heidelbach]

michaelh added a reviewer: dfaure.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10661

To: michaelh, #baloo, #dolphin, dfaure
Cc: #frameworks, michaelh

D10578: balooctl monitor: Wait for dbus interface

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> dfaure wrote in monitorcommand.cpp:53
> Hmm, why not just use QDbusServiceWatcher's signals, to connect to 
> serviceRegistered, if the service isn't available when we start?

The idea to do it that way came to late. :-) 
I'll make an update soon.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure, alexeymin
Cc: cfeck, alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella

D10512: try to preload certain applets in a smart way

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:51
> +DefaultLauncherPreloadWeight = 100,
> +DelayedPreloadWeight = 25,
> +PreloadWeightIncrement = 5,

So by default we preload /everything/ then over time your session gets faster 
as you don't use stuff?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10445

To: aacid, apol
Cc: #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Friedrich W . H . Kossebau]

kossebau added a comment.


  BTW, for the related issue of moc not being re-run on the regeneration of the 
JSON file, I managed to get some test case to narrow this to automoc possibly 
and just reported it as https://gitlab.kitware.com/cmake/cmake/issues/17750

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10662: indexerconfig: Describe some functions

[Michael Heidelbach]

michaelh added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10662

To: michaelh, #baloo
Cc: #frameworks, michaelh

D10662: indexerconfig: Describe some functions

[Michael Heidelbach]

michaelh created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  publicdescriptions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10662

AFFECTED FILES
  src/lib/indexerconfig.h

To: michaelh
Cc: #frameworks, michaelh

D10661: indexerconfig: Expose canBeSearched function

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: Baloo, Dolphin.
michaelh added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  Make D10205  public
  
  CCBUG:388656

REPOSITORY
  R293 Baloo

BRANCH
  expose_canbesearched (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10661

AFFECTED FILES
  src/lib/indexerconfig.cpp
  src/lib/indexerconfig.h

To: michaelh, #baloo, #dolphin
Cc: #frameworks, michaelh

D10444: Improve KLanguageButton::insertLanguage when no name is passed

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R265 KConfigWidgets

BRANCH
  arcpatch-D10444_1

REVISION DETAIL
  https://phabricator.kde.org/D10444

To: aacid, apol
Cc: apol, #frameworks, michaelh

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Good idea

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10657

To: broulik, #frameworks, davidedmundson, apol
Cc: ngraham, michaelh

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

[David Edmundson]

davidedmundson added a comment.


  IMHO if we're fixing it, I'd go all-in and port from introspect to 
GetManagedObjects on the object manager.
  
  You get rid of all XML parsing and you'd get the initial properties in the 
same call (instead of an additional one per iface)
  You could even do all devices in one call with that.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10657

To: broulik, #frameworks, davidedmundson, apol
Cc: ngraham, michaelh

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

[Nathaniel Graham]

ngraham added a comment.


  These kinds of changes to Solid are going to need some *ahem* solid testing 
(I just kill myself sometimes) to avoid regressions, like the one we had in 
https://bugs.kde.org/show_bug.cgi?id=389479

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10657

To: broulik, #frameworks, davidedmundson, apol
Cc: ngraham, michaelh

D10658: [UDisksDeviceBackend] Avoid double lookup

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> udisksdevicebackend.cpp:55
>  {
> -if (s_backends.contains(udi)) {
> -DeviceBackend *backend = s_backends.value(udi);
> -s_backends.remove(udi);
> -delete backend;
> -}
> +delete s_backends.take(udi);
>  }

Here it was triple look-up! ;)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10658

To: broulik, #frameworks, davidedmundson, apol
Cc: apol, michaelh

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10657

To: broulik, #frameworks, davidedmundson, apol
Cc: michaelh

D10653: Set IconItem default to smooth=true

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10653

To: davidedmundson, #plasma, apol
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10658: [UDisksDeviceBackend] Avoid double lookup

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  `QMap::value()` would return a `nullptr` if there is no such element.
  It is also perfectly valid to delete a `nullptr`

TEST PLAN
  Compiles, devices still work

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10658

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevicebackend.cpp

To: broulik, #frameworks, davidedmundson
Cc: michaelh

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  The Qt Xml module is not actively maintained anymore and docs suggest to use 
QXmlStreamReader.
  This saves 3 ms startup time for Dolphin.

TEST PLAN
  My devices still show up. In the original code is an isNull check for the 
element, is this something we should still have?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10657

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevicebackend.cpp

To: broulik, #frameworks, davidedmundson
Cc: michaelh

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart added a comment.


  another way, may be adding a default kwin rule or script which lets every 
plasma window go trough

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10433: Add QML support for Prison

[Volker Krause]

vkrause added a comment.


  The interface for outputting barcodes is currently QImage. The problem is 
that QtQuick cannot directly consume a QImage without custom glue code (image 
provider, custom item, etc), unlike e.g. a QLabel. Using an image provider 
would allow standard Image elements to consume the barcode, I decided against 
that approach though as the "API" in that case is an URL, ie. you'd need to 
encode the content, the type and any other parameter inside a single URL. This 
might be conceptually cleaner, but as an "API" it is just plain ugly.
  
  Supporting custom AbstractBarcode subclasses is indeed something I haven't 
thought about. It would probably require you to obtain an instance somehow and 
pass that into the Barcode element as an opaque handle as far as QML is 
concerned. This would need an additional property on the Barcode element, not a 
big deal I think. I'm reluctant to add this blindly now though, given I have no 
actual test-case for this.
  
  Therefore, for me the choice here is mostly about where to put the necessary 
glue code, with the alternative being my application (I don't think a tier2 
KF5PrisonQuick makes sense for this). With Plasma apparently having similar 
needs sharing this somewhere seems sensible though.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D10433

To: vkrause, #frameworks, svuorela
Cc: broulik, davidedmundson, michaelh

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart added a comment.


  In D10591#207905 , @davidedmundson 
wrote:
  
  > What would this code do if the device notifier is expanded but on the 
desktop?
  
  
  giving desktop window focus, which means we should also either check window 
flags or the applet formfactor... (tough i would still like a smarter solution)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10340: Clean up old, unreachable code

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R306:7387d21c4516: Clean up old, unreachable code (authored by 
heikobecker).

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10340?vs=26647=27537

REVISION DETAIL
  https://phabricator.kde.org/D10340

AFFECTED FILES
  src/CMakeLists.txt
  src/browserrun_p.h

To: heikobecker, #frameworks, dfaure
Cc: elvisangelaccio, michaelh

D10654: [KUrlNavigatorPlacesSelector] Use KFilePlacesModel::convertedUrl

[Henrik Fehlauer]

rkflx added a comment.


  This fix looks pretty much just like a patch I have lying around somewhere. 
Still I wonder whether we should monkey-patch all present and future users of 
`KFilePlacesModel` instead of fixing a single location? Last time I looked at 
it this was Baloo (e.g. `TimelineProtocol::listDir`, `parseTimelineUrl` etc., 
but I might be wrong on the connection to the `search:/` case).
  
  In D10245#199667 , @rkflx wrote:
  
  > When fixing the fallout from D8332  I 
discovered what you are changing here will propagate to every app using 
`KUrlNavigator`, which is quite common. (Meanwhile I gave up on adding fixes 
like 50e6fa3ffc49 
 
everywhere, because I realized this has to be solved at Baloo level.)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10654

To: broulik, #frameworks, elvisangelaccio
Cc: rkflx, michaelh

D10654: [KUrlNavigatorPlacesSelector] Use KFilePlacesModel::convertedUrl

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, elvisangelaccio.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Fixes opening recent and search URLs from it.

TEST PLAN
  Disabled Places sidebar in Dolphin, clicked the url navigator places selector 
and successfully opened the "Search for Images" place. Before Dolphin would 
complain that "search" isn't a known protocol

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10654

AFFECTED FILES
  src/filewidgets/kurlnavigatorplacesselector.cpp

To: broulik, #frameworks, elvisangelaccio
Cc: michaelh

D10653: Set IconItem default to smooth=true

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This changes between linear and nearest neighbour filtering.
  
  Docs for QtQuick say:
  In Qt Quick 2, this property has minimal impact on performance.
  
  Generally we round to icon size anyway and resize the underlying images
  anyway, so this will have no impact.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10653

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart