D10512: try to preload certain applets in a smart way

2018-02-20 Thread Anthony Fieroni
anthonyfieroni added inline comments.

INLINE COMMENTS

> mart wrote in appletquickitem.cpp:57-68
> > So Adaptive can a default even environment variable is not setted?
> 
> yes, adaptive is the default
> 
> > Furthermore you can make a static function to access value
> 
> it's done anyways only once as preloadPolicy is already a static?

But if PLASMA_PRELOAD_POLICY is not setted s_preloadPolicy stays Uninitialized, 
no? But since you check against >= Adaptive it's still ok :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, broulik, apol, ngraham, plasma-devel, 
#frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart


D10691: [kactivities-stats] Fix plasmashell crash when database is broken

2018-02-20 Thread Ivan Čukić
ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  Well, in a library that 99% relies on a database, having no database is not 
something that can be gracefully handled (the returned nullptr is asserted on 
as well in the function that calls ::instance in ResultSet :) - because of 
this, I'm changing to 'Request Changes').
  
  Graceful handling instead of qFatal/Q_ASSERT could be implemented so that all 
models and queries return empty sets. Which would be useless, but as I said, I 
don't have anything against that.
  
  When we get the bug reports about empty favourites, there will be an 
additional test step "Hi, do you have this message in the plasmashell output 
'Database can not be opened...'" :)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein, ivan
Cc: ivan, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10691: [kactivities-stats] Fix plasmashell crash when database is broken

2018-02-20 Thread Eike Hein
hein added a comment.


  @ivan So you wrote a method that can return null, but the call sites aren't 
actually prepared to handle that gracefully? :) But I was waiting for your 
review for that context.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein
Cc: ivan, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10691: [kactivities-stats] Fix plasmashell crash when database is broken

2018-02-20 Thread Ivan Čukić
ivan added a comment.


  @hein
  
  This is not really as simple as 'accept without a comment'.
  
  I don't mind this patch to be merged, but keep in mind that it just turns 
users for which plasma crashes (for which we get an explicit message as to why) 
into users who do not have certain parts of Plasma working where the error 
message will get lost in the Plasma's log. Now, as a maintainer of said parts 
of Plasma, that is your call.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein
Cc: ivan, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven added a reviewer: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin
Cc: ngraham, #frameworks, michaelh


D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven retitled this revision from "bug 390748 Always use a job to delete files 
to avoid freezing process waiting on IO" to "BUG: 390748 Always use a job to 
delete files to avoid freezing process waiting on IO".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham
Cc: ngraham, #frameworks, michaelh


D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven edited the summary of this revision.
meven edited reviewers, added: ngraham; removed: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin
Cc: ngraham, #frameworks, michaelh


D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven edited the summary of this revision.
meven edited the test plan for this revision.
meven added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, #dolphin, dfaure
Cc: ngraham, #frameworks, michaelh


D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for the patch! Please remove "bug 390748" from the title and instead 
add "BUG: 390748" to its own line in the Summary section. See 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, #dolphin
Cc: ngraham, #frameworks, michaelh


D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Nathaniel Graham
ngraham added a reviewer: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, #dolphin
Cc: #frameworks, michaelh


D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Nathaniel Graham
ngraham added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks
Cc: #frameworks, michaelh


D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
meven requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  bug-390748-make-kio-delete-asynchronous

REVISION DETAIL
  https://phabricator.kde.org/D10702

AFFECTED FILES
  src/core/deletejob.cpp

To: meven
Cc: #frameworks, michaelh


D10681: preload the expander (the dialog) too

2018-02-20 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:295
> +qint64 time = 0;
> +if (QLoggingCategory::defaultCategory()->isInfoEnabled()) {
> +time = QDateTime::currentMSecsSinceEpoch();

You should check the PlasmaQuick category, not the default one

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10681

To: mart, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10694: epubextractor: Handle multiple subjects better

2018-02-20 Thread Michael Heidelbach
michaelh added a comment.


  The only component I could find to be affected by this change is 
`baloo-widgets`. I have already adapted it to this change. And yes, it will 
handle both.
  It will take a some time to publish it because some other stuff has to get 
reviewed first.
  I you know of any component or application using the epub-extractor of 
KFileMetadata apart from baloo-widgets please let me know.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, 
nicolasfella, firef, andrebarros, alexeymin, emmanuelp


D10591: forcefully activate popup windows when they open

2018-02-20 Thread Kai Uwe Broulik
broulik added a comment.


  If we were to do this, we need to first make Device Notifier not freak out 
when you have a wonky USB cable.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10671: Fix auto-mount regression

2018-02-20 Thread Dmitry Khlestkov
dkhlestkov added a comment.


  dsx@yandex.ru

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh


D10694: epubextractor: Handle multiple subjects better

2018-02-20 Thread Matthieu Gallien
mgallien added a comment.


  In D10694#210409 , @michaelh wrote:
  
  > @mgallien Then they won't benefit from this until a file is reindexed. 
  >  Users with baloo disabled will benefit, because in that case 
`baloo_filemetadata_temp_extractor` will extract the data on-the-fly.
  >  Reindexing just the ebooks can be done with:
  >
  >   find ~/EBooks/ -type f -name "*.epub" | { mapfile -t; balooctl clear 
"${MAPFILE[@]}";  balooctl index "${MAPFILE[@]}"; }
  >  
  >
  
  
  Could you also add a test for the compatibility with current unmodified code 
? I would like to be sure that we do not introduce any incompatibility.
  
  I am still not convinced we should change the extractors without an automatic 
solution for the reindexing case. You will have to ensure everybody can use the 
property both as a string and a stringlist forever.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, 
nicolasfella, firef, andrebarros, alexeymin, emmanuelp


D10671: Fix auto-mount regression

2018-02-20 Thread Nathaniel Graham
ngraham added a comment.


  In D10671#209941 , @dkhlestkov 
wrote:
  
  > In D10671#209868 , @ngraham 
wrote:
  >
  > > we will need an email address to land this patch if it is accepted
  >
  >
  > How do I provide it? I see no corresponding input field.
  
  
  Just put it in a comment here.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh


D10694: epubextractor: Handle multiple subjects better

2018-02-20 Thread Michael Heidelbach
michaelh added a comment.


  @mgallien Then they won't benefit from this until a file is reindexed. 
  Users with baloo disabled will benefit, because in that case 
`baloo_filemetadata_temp_extractor` will extract the data on-the-fly.
  Reindexing just the ebooks can be done with:
  
find ~/EBooks/ -type f -name "*.epub" | { mapfile -t; balooctl clear 
"${MAPFILE[@]}";  balooctl index "${MAPFILE[@]}"; }

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, 
nicolasfella, firef, andrebarros, alexeymin, emmanuelp


D10694: epubextractor: Handle multiple subjects better

2018-02-20 Thread Matthieu Gallien
mgallien added a comment.


  The problem with any changes to the extractors its that the baloo database of 
users will not be refreshed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, 
nicolasfella, firef, andrebarros, alexeymin, emmanuelp


D10694: epubextractor: Handle multiple subjects better

2018-02-20 Thread Michael Heidelbach
michaelh created this revision.
michaelh added reviewers: mgallien, dfaure.
michaelh added projects: Baloo, Dolphin, Frameworks.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  Instead of returing one long word of ';'-concatenated subjects,
  which is unwrappable return a list of strings and let the consumer handle it.
  
  This will facilitate e.g. dolphin's tooltips display of multiple subjects.
  
  - Add more subjects to test.epub

TEST PLAN
  unit test
  visual inspection in dolphin with adapted baloo-widgets

REPOSITORY
  R286 KFileMetaData

BRANCH
  multi-subject (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10694

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/samplefiles/test.epub
  src/extractors/epubextractor.cpp

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, 
nicolasfella, firef, andrebarros, alexeymin, emmanuelp


D10691: [kactivities-stats] Fix plasmashell crash when database is broken

2018-02-20 Thread Eike Hein
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10691: Fix plasmashell crash when database is broken

2018-02-20 Thread Nathaniel Graham
ngraham added reviewers: Plasma, Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10691: [kactivities-stats] Fix plasmashell crash when database is broken

2018-02-20 Thread Kamil Piwowarski
kpiwowarski retitled this revision from "Fix plasmashell crash when database is 
broken" to "[kactivities-stats] Fix plasmashell crash when database is broken".

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10691: Fix plasmashell crash when database is broken

2018-02-20 Thread Kamil Piwowarski
kpiwowarski created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kpiwowarski requested review of this revision.

REVISION SUMMARY
  BUG:390774

TEST PLAN
  Compiled and plasmashell doesn't crash when open kicker

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10691

AFFECTED FILES
  src/common/database/Database.cpp

To: kpiwowarski
Cc: #frameworks, michaelh


D10684: [Drop Job] Create proper trash file on linking

2018-02-20 Thread Eike Hein
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10684

To: broulik, #frameworks, #plasma, hein
Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10684: [Drop Job] Create proper trash file on linking

2018-02-20 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Plasma wants to remove the default trash icon on the desktop.
  This change ensures dropping Trash from e.g. Dolphin will result in a fully 
functional (i.e. reflecting trash state and proper "Trash" label) trash icon 
being dropped.

TEST PLAN
  Dropped "Trash" place from Dolphin to desktop, got a "Trash" icon with proper 
icon.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10684

AFFECTED FILES
  src/core/copyjob.cpp

To: broulik, #frameworks, #plasma
Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 42 - Still Unstable!

2018-02-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/42/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 20 Feb 2018 13:56:27 +
 Build duration:
55 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D10518: Use QWidget to see if the window is visible

2018-02-20 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:09e848b68d7c: Use QWidget to see if the window is visible 
(authored by apol).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10518?vs=27182=27612

REVISION DETAIL
  https://phabricator.kde.org/D10518

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: apol, #frameworks, stikonas
Cc: stikonas, michaelh


KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

2018-02-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/66/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 20 Feb 2018 13:56:27 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13340)19%
(1979/10549)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1755)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 69 - Still Unstable!

2018-02-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/69/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 20 Feb 2018 13:56:27 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13336)19%
(1978/10549)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1755)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D10681: preload the expander (the dialog) too

2018-02-20 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8346b3e76ab8: preload the expander (the dialog) too 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10681?vs=27605=27606#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10681?vs=27605=27606

REVISION DETAIL
  https://phabricator.kde.org/D10681

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10681: preload the expander (the dialog) too

2018-02-20 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> appletquickitem.cpp:294
> +{
> +qint64 time = QDateTime::currentMSecsSinceEpoch();
> +createFullRepresentationItem();

wrap this line in QLoggingCategory::isInfoEnabled

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/preload

REVISION DETAIL
  https://phabricator.kde.org/D10681

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10681: preload the expander (the dialog) too

2018-02-20 Thread Marco Martin
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  when preloading, preload the expander as well, and reparent the
  full representation to it, so we have a scene schanged less.
  also do a create() of that window (may be worth to do create()
  automatically in every Dialog?)

TEST PLAN
  the first open is visibly a lot faster now

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/preload

REVISION DETAIL
  https://phabricator.kde.org/D10681

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

2018-02-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/65/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 20 Feb 2018 10:18:16 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13334)19%
(1979/10541)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2005)18%
(306/1747)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 68 - Still Unstable!

2018-02-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/68/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 20 Feb 2018 10:18:16 +
 Build duration:
5 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13330)19%
(1978/10541)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2005)18%
(306/1747)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 41 - Still Unstable!

2018-02-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/41/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 20 Feb 2018 10:18:16 +
 Build duration:
4 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D10669: Reduce plasmashell frozen time

2018-02-20 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10669

To: jtamate, #plasma, #frameworks, mart
Cc: plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10512: try to preload certain applets in a smart way

2018-02-20 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in appletquickitem.cpp:57-68
> So Adaptive can a default even environment variable is not setted?
> Furthermore you can make a static function to access value
> 
>   AppletQuickItemPrivate::PreloadPolicy AppletQuickItemPrivate::appletPolicy()
>   {
>   static const PreloadPolicy preloadPolicy = []() -> PreloadPolicy {
>   if (qEnvironmentVariableIsSet("PLASMA_PRELOAD_POLICY")) {
>   const QString policy = 
> QString::fromUtf8(qgetenv("PLASMA_PRELOAD_POLICY")).toLower();
>   if (policy == QStringLiteral("aggressive")) {
>   return Aggressive;
>   } else if (policy == QStringLiteral("none")) {
>   return None;
>   }
>   }
>   return Adaptive;
>   }();
>   return preloadPolicy;
>   }

> So Adaptive can a default even environment variable is not setted?

yes, adaptive is the default

> Furthermore you can make a static function to access value

it's done anyways only once as preloadPolicy is already a static?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, broulik, apol, ngraham, plasma-devel, 
#frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart


D10671: Fix auto-mount regression

2018-02-20 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  I added a similar check in Storage Volume but did not here.. :/
  
  I can confirm that those "Loop Devices" are still ignored, which is good.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh