D10851: autotests: Introduce aliases DocId, DeviceId and Inode

michaelh created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Find and replace `quint64` with `DocId` Add `#include "idutils.h"` until it compiles see:

D10124: Faster simplejob start

jtamate added a comment. In D10124#213918 , @dfaure wrote: > This commit leads to > > 20:29:06.184 okteta(12932) QObject::connect|?libKF5KIOCore.so.5? QObject::connect: No such slot KIO::ListJob::slotTotalSize(KIO::filesize_t) in /d/kd

CI & Binary Factory maintenance

Hi all, To permit extensive maintenance on the underlying nodes which support the CI system & Binary Factory, I have temporarily disabled the mechanism which triggers builds on the CI and have brought the Binary Factory into a halted state. During this time builds will not be triggered as they no

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 55 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/55/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Feb 2018 02:19:38 + Build duration: 1 day 5 hr and counting CONSOLE OUTPUT

D10825: Introduce aliases DocId, DeviceId and Inode

michaelh updated this revision to Diff 28088. michaelh marked an inline comment as done. michaelh edited the summary of this revision. michaelh added a comment. - Merge branch 'flexible-docid' of git://anongit.kde.org/baloo into aliases - Correct indentation REPOSITORY R293 Baloo CHANGES

D10825: Introduce aliases DocId, DeviceId and Inode

michaelh marked an inline comment as done. michaelh added a comment. @alexeymin , @ngraham: I asked IRC:kdevelop how to turn `-Wstrict-aliasing` on and was pointed to cmake docs. If this setting is defined in one of the cmake-files, why do they differ? Could it be an internal setting of the I

D10849: Add template for Plasma wallpaper with QML extension

kossebau created this revision. kossebau added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Allows to quickly start a new wallpaper which also wants to use

D10848: Templates: consistent naming, fix translation catalog names & more

kossebau created this revision. kossebau added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY - remove unneeded cmake includes - consistently use org.kde.p

D10414: Add move semantics support to KIO::UDSEntry.

bcooksley added a comment. Uploading a new diff is the right thing to do in this case, however that won't be truly representative of what was landed in the end unless this is first reverted. (Objective being the complete, updated diff being shown here) REPOSITORY R241 KIO REVISION DETAI

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

ngraham added a comment. In D10663#213898 , @dfaure wrote: > Better make it happen all the time, and better make it work right. A flag almost sounds like a excuse for a half-hearted feature ("if it works badly in case XYZ, then apps can just opt

D10757: Reset QLocale internals when we have a custom app language

apol added a comment. Go for it +1 I'd still try to add the needed API in Qt though. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D10757 To: aacid, apol, ilic Cc: lueck, #frameworks, michaelh

D10825: Introduce aliases DocId, DeviceId and Inode

ngraham added a comment. Nice job, looks good. No compilation warnings for me, no test failures, and all functionality that I tested still works. I found a few minor formatting issues; see the below comments. INLINE COMMENTS > idtreedb.cpp:76 > > -QVector IdTreeDB::get(quint64 docId) > -{

D10757: Reset QLocale internals when we have a custom app language

aacid updated this revision to Diff 28076. aacid added a comment. Now includes an auto test. It's not amazing since it doesn't totally reproduce the real world scenario but should be close enough. Had to make two functions be exported but since the header is not installed and it's o

D10829: Use DocumentId class

alexeymin added a comment. In D10829#213553 , @michaelh wrote: > That's great. Any clues to solve this? > > [ 35%] Building CXX object src/file/extractor/autotests/CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o > [ 35%] Linking CXX e

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/76/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 21:41:42 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/73/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Feb 2018 21:31:34 + Build duration: 14 min and counting JUnit Tes

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/75/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 21:23:29 + Build duration: 18 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/49/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 21:31:34 + Build duration: 6 min 9 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/72/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Feb 2018 21:23:29 + Build duration: 6 min 39 sec and counting JUn

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/48/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 21:23:29 + Build duration: 4 min 52 sec and counting

D10732: Help automoc to find metadata JSON files referenced in the code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:c03c2d526593: Help automoc to find metadata JSON files referenced in the code (authored by kossebau). CHANGED PRIOR TO

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/23/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 20:58:34 + Build duration: 2 min 25 sec and counting JUnit Tests Nam

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Feb 2018 20:58:34 + Build duration: 1 min 46 sec and counting JUnit Tests N

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 20:58:34 + Build duration: 1 min 18 sec and counting JUnit Tests

D10733: Help automoc to find metadata JSON files referenced in the code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R290:108ed2839cb2: Help automoc to find metadata JSON files referenced in the code (authored by kossebau). REPOSITORY R29

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau added a comment. Given there was no principal objection and this code is following the pattern of D10724 , going to push now as well, so it gets some more field-testing before next weeks tagging. REPOSITORY R242 Plasma Framework (Library) REVIS

D10733: Help automoc to find metadata JSON files referenced in the code

kossebau added a comment. Given this code is the same as D10724 , going to push now as well, so it gets some more field-testing before next weeks tagging. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D10733 To: kossebau, #fram

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. I seem to be making a mess of this commit. Sorry for that. https://p.sc2.nl/B13Etcldf with the changes. Regarding arc to push a change back here again, how do you do that for something that is already committed? REPOSITORY R241 KIO REVISION DETAIL https://ph

D10414: Add move semantics support to KIO::UDSEntry.

dfaure added inline comments. INLINE COMMENTS > dfaure wrote in udsentrytest.cpp:235 > That's rather overkill (and a wrong use of the QUrl API). You want to use > QFileInfo for this. The comment is marked as done, but the code that was pushed still uses QUrl. > dfaure wrote in udsentrytest.cpp

D10826: Introduce DocumentId class

michaelh added a comment. @svuorela: Thank you very much. I will try you suggestion as soon as I'm able to get the tests compiled. INLINE COMMENTS > svuorela wrote in documentid.h:34 > Does it need to be exported? Is things outside of the baloo engine need to > access this? (or is it just a

D10124: Faster simplejob start

dfaure added a comment. This commit leads to 20:29:06.184 okteta(12932) QObject::connect|?libKF5KIOCore.so.5? QObject::connect: No such slot KIO::ListJob::slotTotalSize(KIO::filesize_t) in /d/kde/src/5/frameworks/kio/src/core/listjob.cpp:289 Please fix ;) REPOSITORY R241 KIO REV

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

dfaure requested changes to this revision. dfaure added a comment. I don't like the idea of a flag for this in the API. It just moves the problem (of whether it's safe / a good idea to clean up) to the applications, who are not in a better place to decide about this. Better make it happen all

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#213845 , @dfaure wrote: > "unlink() in most of the modern filesystems is not affected by the size of the file" doesn't match my experience, I have seen konqueror/dolphin freeze for 10s while deleting a 8GB file (

D10702: Always use a job to delete files to avoid freezing process waiting on IO

dfaure requested changes to this revision. dfaure added a comment. "unlink() in most of the modern filesystems is not affected by the size of the file" doesn't match my experience, I have seen konqueror/dolphin freeze for 10s while deleting a 8GB file (on a somewhat old system, no SSD). And t

D10826: Introduce DocumentId class

svuorela added a comment. A quick review of some quirks and weirdnesses in c++ INLINE COMMENTS > documentid.cpp:67 > +#if(0) > +// Due to operator DeviceIdAndInode(), apparently the following > +// became obsolete. if you make operator DeviceIdAndInode explicit, you probably end up with a bi

D10803: handle more tags in taglibextractor

michaelh added a comment. In D10803#213767 , @astippich wrote: > I don't know dolphin works, but given how KFileMetadata is designed, the new tags should be ignored until explicit support is added in dolphin. Please try that. For unknown

D10803: handle more tags in taglibextractor

mgallien added a subscriber: dfaure. mgallien added inline comments. INLINE COMMENTS > astippich wrote in properties.h:168 > I noticed the typo as well, but I think this is a matter of API > compatibility, so I left it unchanged. Matthieu should know. It is part of the source compatibility prom

D10803: handle more tags in taglibextractor

astippich added a comment. I don't know dolphin works, but given how KFileMetadata is designed, the new tags should be ignored until explicit support is added in dolphin. INLINE COMMENTS > michaelh wrote in properties.h:164 > ? Oops, seems like a wrong copy & paste :) will fix > michaelh

D10803: handle more tags in taglibextractor

michaelh added a comment. Nice! How do the infopanel or tooltips of dolphin look with this? INLINE COMMENTS > properties.h:164 > /** > - * The language the document is written in. This directly maps to the > + * The language the document is written in. Thiof a media file.s > dir

D10694: epubextractor: Handle multiple subjects better

mgallien added a comment. In D10694#210509 , @michaelh wrote: > The only component I could find to be affected by this change is `baloo-widgets`. I have already adapted it to this change. And yes, it will handle both. > It will take a some ti

D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a comment. In D10807#213250 , @rkflx wrote: > What about users who manually create and mount FUSE-type encrypted directories? Plasma Vault is just a nice interface for this workflow, after all. Good point. > A more gen

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 13:16:12 + Build duration: 38 min and counting JUnit Tests Nam

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/29/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 13:37:42 + Build duration: 5 min 17 sec and counting JUnit Tests Name

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 28 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/28/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 13:16:12 + Build duration: 11 min and counting JUnit Tests Name: (ro

D10823: idutils: Fix typo

This revision was automatically updated to reflect the committed changes. Closed by commit R293:fa08a62b0fdf: idutils: Fix typo (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10823?vs=27999&id=28027 REVISION DETAIL https://phabricator.k

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R127:2dfe16d774c7: [server] Properly handle the situation when the DataSource for a drag gets… (authored by graesslin). Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOS

D10823: idutils: Fix typo

adridg accepted this revision. adridg added a comment. I'm so happy :) This is partly to help @michaelh get into the swing of things, with writing a patch, pushing it to review, getting it okayed .. a bit of "this is the process". Of course later there's no need for typo-fix reviews that

D10829: Use DocumentId class

michaelh added a comment. That's great. Any clues to solve this? [ 35%] Building CXX object src/file/extractor/autotests/CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o [ 35%] Linking CXX executable ../../../../bin/extractorIOTest CMakeFiles/extractorIOTest.dir/__/iohandler.cp

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/44/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 12:03:21 + Build duration: 15 min and counting JUnit Tests Name

D10829: Use DocumentId class

michaelh updated this revision to Diff 28013. michaelh added a comment. - idutils: Use DocumentId constructor - DocumentId: Add 'QDebug operator<<' REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10829?vs=28008&id=28013 BRANCH use-class (branched from fle

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 12:03:21 + Build duration: 10 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/43/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Feb 2018 12:03:21 + Build duration: 7 min 0 sec and counting JUnit Tests

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

chinmoyr removed a dependent revision: D10437: Update file ioslave's temporary authorization list. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10641 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh, kmorwinski

D10437: Update file ioslave's temporary authorization list

chinmoyr edited dependencies, added: D10818: Store PolicyKit action which the slave is authorized to perform; removed: D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10437 To: chinmoyr

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 43 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/43/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 11:54:51 + Build duration: 5 min 15 sec and counting CONSOLE OUTPUT

D10818: Store PolicyKit action which the slave is authorized to perform

chinmoyr added a dependent revision: D10437: Update file ioslave's temporary authorization list. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10818 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10568: Handle privilege operation confirmation prompts in SlaveBase

chinmoyr added a dependent revision: D10818: Store PolicyKit action which the slave is authorized to perform. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10568 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh, kmorwinski

D10818: Store PolicyKit action which the slave is authorized to perform

chinmoyr added a dependency: D10568: Handle privilege operation confirmation prompts in SlaveBase. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10818 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10568: Handle privilege operation confirmation prompts in SlaveBase

chinmoyr removed a dependent revision: D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10568 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh, kmorwinski

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

chinmoyr removed a dependency: D10568: Handle privilege operation confirmation prompts in SlaveBase. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10641 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh, kmorwinski

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

chinmoyr added a dependency: D10820: Send slave's polkit authorization status to the host. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10641 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh, kmorwinski

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 11:54:51 + Build duration: 2 min 28 sec and counting CONSOLE OU

D10820: Send slave's polkit authorization status to the host

chinmoyr added a dependent revision: D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10829: Use DocumentId class

michaelh added a comment. @alexeymin: Could you use inline comments, please. That would help me a lot. And: thank you for your comments. It is really nice to have someone commenting without me poking first. ;-) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 42 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/42/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Feb 2018 11:54:51 + Build duration: 1 min 47 sec and counting CONSOLE OUTPUT

D10820: Send slave's polkit authorization status to the host

chinmoyr edited the summary of this revision. chinmoyr added a dependency: D10818: Store PolicyKit action which the slave is authorized to perform. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10818: Store PolicyKit action which the slave is authorized to perform

chinmoyr added a dependent revision: D10820: Send slave's polkit authorization status to the host. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10818 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10820: Send slave's polkit authorization status to the host

chinmoyr added a dependent revision: D10822: Store temporary authorization status in IdleSlave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10822: Store temporary authorization status in IdleSlave

chinmoyr edited the summary of this revision. chinmoyr added a dependency: D10820: Send slave's polkit authorization status to the host. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10822 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 42 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/42/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 11:42:16 + Build duration: 6 min 51 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/27/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 11:42:16 + Build duration: 4 min 36 sec and counting CONSOLE OU

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 41 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/41/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Feb 2018 11:42:16 + Build duration: 2 min 1 sec and counting CONSOLE OUTPUT

D10829: Use DocumentId class

alexeymin added a comment. To solve this warning you need to fix DocumentId class, add operator<<() for QDebug. In D10826 add: `QDebug operator<<(QDebug stream, const Baloo::DocumentId &docId);` outside of baloo namespace, don't forget to `#include

D9211: Iterate over initializer_lists to avoid mem allocs

dhaumann closed this revision. dhaumann added a comment. Committed with https://cgit.kde.org/ktexteditor.git/commit/?id=ac8f9f61a0d160a04fd46cb7f87b1509987892aa REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9211 To: dhaumann, mwolff, apol Cc: ngraham, #framewor

D9211: Iterate over initializer_lists to avoid mem allocs

dhaumann marked 2 inline comments as done. REPOSITORY R39 KTextEditor BRANCH AvoidAllocs (branched from master) REVISION DETAIL https://phabricator.kde.org/D9211 To: dhaumann, mwolff, apol Cc: ngraham, #frameworks, michaelh, kevinapavew, kmorwinski, demsking, cullmann, sars, dhaumann

D9211: Iterate over initializer_lists to avoid mem allocs

dhaumann marked 8 inline comments as done. dhaumann added a comment. Mark comments as done. INLINE COMMENTS > mwolff wrote in katedocument.cpp:109 > you want to return `std::distance(list.begin(), it)` here Good catch! REPOSITORY R39 KTextEditor BRANCH AvoidAllocs (branched from master

D10825: Introduce aliases DocId, DeviceId and Inode

michaelh added inline comments. INLINE COMMENTS > idutils.h:49 > +return *(reinterpret_cast(arr)); > } > @alexeymin: This will become return DocumentId(devId, inode); The warning should be gone after that. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10825

D10825: Introduce aliases DocId, DeviceId and Inode

michaelh added a comment. In D10825#213478 , @alexeymin wrote: > This gives a bunch of warnings like > > src/engine/idutils.h:48:43: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] >

D10825: Introduce aliases DocId, DeviceId and Inode

alexeymin added a comment. This gives a bunch of warnings like src/engine/idutils.h:48:43: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] return *(reinterpret-cast(arr)); Were these before...? REPOSITORY R293 Baloo REVISI

D10437: Update file ioslave's temporary authorization list

chinmoyr updated this revision to Diff 28009. chinmoyr retitled this revision from "Revoke authorization of file ioslave before it is used by another process" to "Update file ioslave's temporary authorization list". chinmoyr edited the summary of this revision. chinmoyr added a comment. Updat

D10823: idutils: Fix typo

michaelh added a comment. In D10823#213409 , @alexeymin wrote: > Maybe such kinds of changes can be committed without review? ;) This is to make @adridg happy. The real fun starts, when you take a look at the stack of this. I need t

D10826: Introduce DocumentId class

michaelh added a dependent revision: D10829: Use DocumentId class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10826 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10829: Use DocumentId class

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10829: Use DocumentId class

michaelh added a dependency: D10826: Introduce DocumentId class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10829: Use DocumentId class

michaelh created this revision. michaelh added reviewers: adridg, Baloo, Frameworks. michaelh added a project: Baloo. Restricted Application added a project: Frameworks. michaelh requested review of this revision. TEST PLAN library compiles test compile produces linker error REPOSITORY R293

D10826: Introduce DocumentId class

michaelh added a dependency: D10825: Introduce aliases DocId, DeviceId and Inode. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10826 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10825: Introduce aliases DocId, DeviceId and Inode

michaelh added a dependent revision: D10826: Introduce DocumentId class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10825 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10826: Introduce DocumentId class

michaelh created this revision. michaelh added reviewers: adridg, Baloo, Frameworks. michaelh added projects: Baloo, Frameworks. michaelh requested review of this revision. REVISION SUMMARY This class shall successively replace the current DocId(quint64) to gain more flexibility. - Account

D10823: idutils: Fix typo

alexeymin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH typo (branched from flexible-docid) REVISION DETAIL https://phabricator.kde.org/D10823 To: michaelh, adridg, #baloo, #frameworks, alexeymin Cc: alexeymin, ashaposhnikov, michael

D10823: idutils: Fix typo

alexeymin added a comment. Maybe such kinds of changes can be committed without review? ;) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10823 To: michaelh, adridg, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10825: Introduce aliases DocId, DeviceId and Inode

michaelh created this revision. michaelh added reviewers: adridg, Baloo, Frameworks. michaelh added a project: Baloo. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY This is the first step of porting away from using quint64 as Docu

D10825: Introduce aliases DocId, DeviceId and Inode

michaelh added a dependency: D10823: idutils: Fix typo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10825 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10823: idutils: Fix typo

michaelh added a dependent revision: D10825: Introduce aliases DocId, DeviceId and Inode. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10823 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10824: Delete IdleSlave having temporary authorization

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY IdleSlave with temporary authorization can be easily misused.

D10822: Store temporary authorization status in IdleSlave

chinmoyr added a dependent revision: D10824: Delete IdleSlave having temporary authorization. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10822 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10823: idutils: Fix typo

michaelh added a comment. Let's start slowly REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10823 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10823: idutils: Fix typo

michaelh created this revision. michaelh added reviewers: adridg, Baloo, Frameworks. michaelh added projects: Baloo, Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH typo (branched from flexible-docid) REVISION DETAIL https://phabricator.kde.org/D10823

D10822: Store temporary authorization status in IdleSlave

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY It will be used by klauncher to decide whether or not to kill

D10759: Use QLocale instead of QLocale::system

aacid abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10759 To: aacid, apol, ilic Cc: kossebau, apol, #frameworks, #build_system, michaelh, kmorwinski

D10758: Use QLocale instead of QLocale::system

aacid abandoned this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D10758 To: aacid, apol, ilic Cc: lueck, #frameworks, michaelh, kmorwinski

  1   2   >