KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/6/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 03 Mar 2018 04:27:29 + Build duration: 28 min and counting CONSOLE OUTPUT

D10803: handle more tags in taglibextractor

ngraham added a comment. Phew, what a conversation! For the issue of the rating, perhaps we could sync the tag metadata with the baloo metadata, if the baloo rating metadata is already empty. I might even go so far as to overwrite the baloo rating metadata with the tag rating metadata;

D10857: Change qSort to std::sort in simplifiedUrlList

markg added a comment. In D10857#216725 , @dfaure wrote: > I cannot confirm that stable_sort is faster, on the contrary. http://www.davidfaure.fr/2018/qsort_performance.cpp updated, says (repeatedly) > "std::sort took: 5003 ms" >

D10857: Change qSort to std::sort in simplifiedUrlList

jtamate added a comment. I've found the problem. The problem is qSort itself. Chaning qSort to qStableSort I've got normal times in the test case, select 50.000 files and pressing Shift+Supr. Also in the small test, the times, running under callgrind are: qSort: between 33148 and

D10803: handle more tags in taglibextractor

michaelh added inline comments. INLINE COMMENTS > taglibextractortest.cpp:82 > > QCOMPARE(resultFlac.properties().value(Property::Title), > QVariant(QStringLiteral("Title"))); > QCOMPARE(resultFlac.properties().value(Property::Artist), > QVariant(QStringLiteral("Artist"))); Just a