D10776: Make it possible to generate po files in parallel

sitter added a comment. Ingenious code! You left some debug clutter behind though. Also, the if i statement is inconsistent between the two files `if (i EQUAL ${numberOfProcesses})` vs. `if (i GREATER ${numberOfProcesses})` INLINE COMMENTS > build-pofiles.cmake:45 > +

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 140 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/140/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Mar 2018 04:22:17 + Build duration: 45 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 06 Mar 2018 04:22:17 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 160 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/160/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 06 Mar 2018 04:22:17 + Build duration: 10 min and counting JUnit Tests Name: (root)

D10989: Check for nullptr in indexForNode

mpyne added a comment. I'm not sure the job could have been deleted before `KDialogJobUiDelegate::showErrorMessage()` since much of the call stack before then involves making method calls on the job. KDirLister::handleError(KIO::Job*) (kdirlister.cpp:81) makes a call to `job->error()`

D10168: Use nullptr for passing a null pointer to crc32

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. Actually `-Wzero-as-null-pointer-constant` is probably a good idea, and this is a correct fix. A decade ago when everything was going from 32 to 64-bits, we ran into a JuK crash bug because

D11080: Make org.kde. components include a donate URL

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY AppStream can offer information to donate about a product, we better point our happy users to the right direction. TEST

D11077: [Icon Item] Remove unused variables

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11077 To: broulik, #plasma, davidedmundson Cc: #frameworks, michaelh

D11077: [Icon Item] Remove unused variables

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. TEST PLAN Compiles REPOSITORY R242 Plasma Framework (Library) REVISION

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Mon, 05 Mar 2018 22:02:35 + Build duration: 5 min 6 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 05 Mar 2018 22:02:35 + Build duration: 2 min 3 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/4/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Mon, 05 Mar 2018 22:02:35 + Build duration: 1 min 19 sec and counting JUnit Tests

D11067: Fix 3 more cases of incorrect parameter to findProtocol

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kprotocolmanager.cpp:1141 > +} > KProtocolInfoPrivate *prot = findProtocol(url); > if (!prot) { You could move the check to inside

D11067: Fix 3 more cases of incorrect parameter to findProtocol

jtamate added a comment. The backtraces: deleting characters from the beginning #10 0x7fdc893f249a in KProtocolInfoFactory::findProtocol (this=0x7fdc896b9720 <(anonymous namespace)::Q_QGS_kProtocolInfoFactoryInstance::innerFunction()::holder>, protocol=...) at

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/61/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 05 Mar 2018 19:58:35 + Build duration: 8 min 32 sec and counting JUnit Tests

D11067: Fix 3 more cases of incorrect parameter to findProtocol

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY deleting characters from the beginning in a url in dolphin trying to use this url: ~:/ REPOSITORY R241

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/5/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Mon, 05 Mar 2018 19:58:34 + Build duration: 5 min 8 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/44/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 05 Mar 2018 19:58:34 + Build duration: 3 min 52 sec and counting JUnit

D11037: balooctl: checkDb should also verify the last known url for the documentId.

smithjd added a comment. This change includes orphan file entries as invalid database entries in checkFsTree(). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11037 To: smithjd, #baloo Cc: michaelh, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd marked 7 inline comments as done. smithjd added a comment. All mounts must be manually made available by the user before running this option, or all files on a previously available mount will be removed from the index. INLINE COMMENTS > michaelh wrote in transaction.cpp:271 > Can

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd updated this revision to Diff 28747. smithjd added a comment. Review changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=28656=28747 BRANCH master-purgeDb (branched from master) REVISION DETAIL https://phabricator.kde.org/D11038

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 05 Mar 2018 18:27:23 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 159 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/159/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 05 Mar 2018 18:27:23 + Build duration: 12 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 139 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/139/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 05 Mar 2018 18:27:23 + Build duration: 8 min 50 sec and counting JUnit Tests Name:

D11044: Don't try to find an icon for an empty url

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8ba93b82e451: Dont try to find an icon for an empty url (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11044?vs=28690=28739 REVISION DETAIL

D10824: Delete IdleSlave having temporary authorization

chinmoyr added a comment. I haven't yet tried your patch (which btw involves the http ioslave right?) but I am quite sure that exit() is not called for file ioslave after interrupting the application. I have placed the debug statements inside exit() as well as before every exit() call and I

D11055: Pack python bindings into right dirs

arojas added a comment. The sip part is distro-specific. At least in Arch we don't have separate sip/sip3 directories (what's the point? sip files are independent of the python version) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D11055 To: McPain,

D10744: Use correct directory to lookup trigrams in windows build dir

This revision was automatically updated to reflect the committed changes. Closed by commit R246:e07142e27819: Use correct directory to lookup trigrams in windows build dir (authored by vonreth). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D9973: ktooltipwidget: Fix tooltip positioning

michaelh marked 2 inline comments as done. michaelh added a comment. If had known I would mess up the inline comments, I would not have moved the code in this step. Sorry. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio,

D9973: ktooltipwidget: Fix tooltip positioning

michaelh marked 2 inline comments as done. michaelh added inline comments. INLINE COMMENTS > elvisangelaccio wrote in ktooltippositiontest.cpp:65 > Weird comma position :p Old habits, sorry. > elvisangelaccio wrote in ktooltippositiontest.cpp:136 > This should be a QCOMPARE We're letting go

D9973: ktooltipwidget: Fix tooltip positioning

michaelh updated this revision to Diff 28731. michaelh marked 12 inline comments as done. michaelh added a comment. - Apply suggested changes - Join ktooltippositiontest and ktooltipwidgettest - Remove negative x constraint - Make some variables const REPOSITORY R236 KWidgetsAddons

D9141: Setup QQmlEngine only once in QmlObject

This revision was automatically updated to reflect the committed changes. Closed by commit R296:0ecea38b5998: Setup QQmlEngine only once in QmlObject (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9141?vs=28691=28728#toc REPOSITORY R296 KDeclarative CHANGES

Re: Fallback Icon Theme

On Sun, Mar 4, 2018 at 7:30 PM, Martin Kostolný wrote: > If there is a better way of solving our situation, please tell us :). Someone needs to file bug reports against adwaita so the missing icons can get added. That is the proper solution to an incomplete icon set. It's

D10989: Check for nullptr in indexForNode

jtamate added a comment. > I tried testing > > kdialog --getexistingdirectory smb:// > > but this gives an error here "Unable to find any workgroups in your local network." even with samba started locally. Don't know why. I get always a crash trying kdialog

D10776: Make it possible to generate po files in parallel

apol updated this revision to Diff 28724. apol added a comment. Make sure we don't run more than nproc processes at the same time REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=27871=28724 BRANCH master REVISION DETAIL

D11055: Pack python bindings into right dirs

apol added inline comments. INLINE COMMENTS > FindPythonModuleGeneration.cmake:448 > if (GPB_SIP_DEPENDS MATCHES PyKF5) > - set(_kf5_python_prefix > ${CMAKE_INSTALL_PREFIX}/lib/python${pyversion${pyversion}_maj_min}/${GPB_INSTALL_DIR_SUFFIX}) > +

D11054: Add media status icons

romangg added a dependent revision: D11056: [mediacontroller applet] Use media playback status icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11054 To: romangg, #plasma, #frameworks, #vdg Cc: michaelh

D10776: Make it possible to generate po files in parallel

sitter added a comment. As discussed on telegram: the proposed change makes it a different problem. Now instead of running serial all the time, it'd fork bomb all the time (peaks at 3671 forks for plasma-desktop 5.12 when run on a fairly fast system with SSD). Also, missing adjustment

D11055: Pack python bindings into right dirs

McPain created this revision. McPain added a reviewer: vkrause. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. McPain requested review of this revision. REVISION SUMMARY 1. Python modules are packed into

D11049: Remove frame around media action icons

romangg added a dependent revision: D11054: Add media status icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg Cc: mart, #frameworks, michaelh

D11054: Add media status icons

romangg added a dependency: D11049: Remove frame around media action icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11054 To: romangg, #plasma, #frameworks, #vdg Cc: michaelh

D11054: Add media status icons

romangg created this revision. romangg added reviewers: Plasma, Frameworks, VDG. Restricted Application added a project: Frameworks. romangg requested review of this revision. REVISION SUMMARY This is used to show the state of a media playing process. These icons are introduced to

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. Ping REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter Cc: #frameworks, michaelh

D9141: Setup QQmlEngine only once in QmlObject

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. i like it now REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9141 To: broulik, #plasma, mart Cc: davidedmundson, hein, mart, plasma-devel, #frameworks,

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10769 To: broulik, #plasma, mart Cc: mart, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed,

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

mart added a comment. did you try if after removing it, repeatedly showing and hiding, the dialog does not appear in the taskbar, even for an instant? (if so, good to go for me) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10769 To: broulik,

D10863: [KRecentDocument] Use QGuiApplication::desktopFileName()

mart accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10863 To: broulik, #frameworks, #plasma, hein, aleksejshilin, mart Cc: michaelh

D11044: Don't try to find an icon for an empty url

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11044 To: jtamate, #frameworks, dfaure Cc: broulik, michaelh

D10446: Add KLanguageName

markg added a comment. Isn't this better suited for KCoreAddons? On a related note, i did make this bug report for Qt: https://bugreports.qt.io/browse/QTBUG-64942 with regard to ISO 3166 country names. But language names also came up, see this

D11049: Remove frame around media action icons

mart added a comment. as a pure code review, +1 from me as i see style="fill:currentColor;fill-opacity:1;stroke:none" remained inalterated so you did fix the mess inkscape likes to do with it :) as style, i definitely like it more without circles around, final approval is by Andreas.

D11050: Remove frames around media buttons

mart added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11050 To: romangg, #frameworks, #plasma Cc: mart, michaelh

D11050: Remove frames around media buttons

romangg edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11050 To: romangg, #frameworks, #plasma Cc: michaelh

D11050: Remove frames around media buttons

romangg added a dependency: D11049: Remove frame around media action icons. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11050 To: romangg, #frameworks, #plasma Cc: michaelh

D11050: Remove frames around media buttons

romangg created this revision. romangg added reviewers: Frameworks, Plasma. Restricted Application added a project: Frameworks. romangg requested review of this revision. REVISION SUMMARY We were inconsistent on that and it can get in way with placement on buttons. Mirrors a change in

D11049: Remove frame around media action icons

romangg added a dependent revision: D11050: Remove frames around media buttons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg Cc: #frameworks, michaelh

D9141: Setup QQmlEngine only once in QmlObject

broulik updated this revision to Diff 28691. broulik edited the test plan for this revision. broulik added a comment. - Use protected constructor with pseudo argument instead of flags REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9141?vs=23360=28691

D11044: Don't try to find an icon for an empty url

jtamate updated this revision to Diff 28690. jtamate added a comment. Checking for empty url at the top of the method. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11044?vs=28680=28690 REVISION DETAIL https://phabricator.kde.org/D11044 AFFECTED FILES

D11049: Remove frame around media action icons

romangg added reviewers: Breeze, VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11049 To: romangg, #breeze, #vdg Cc: #frameworks, michaelh

D11049: Remove frame around media action icons

romangg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. romangg requested review of this revision. REVISION SUMMARY We were inconsistent on that and it can get in way with placement on buttons. Also Research

D11044: Don't try to find an icon for an empty url

jtamate added a comment. In D11044#218896 , @dfaure wrote: > Wait, who's calling KIO::iconNameForUrl() with an empty URL? This should be an assert or an early-return at the top of that method, not nested into one specific if(). Even the very

D11013: Detect incorrect paramenter in findProtocol

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yes, but please don't push this until you have fixed the caller in your testcase, and used a Plasma/KF5 session with these asserts enabled for 2 weeks. Thanks ;) REPOSITORY R241 KIO

D11044: Don't try to find an icon for an empty url

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Wait, who's calling KIO::iconNameForUrl() with an empty URL? This should be an assert or an early-return at the top of that method, not nested into one specific if(). Even the

D11044: Don't try to find an icon for an empty url

broulik added a comment. Shouldn't it check emptiness of the url scheme specifically? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11044 To: jtamate, #frameworks, dfaure Cc: broulik, michaelh

D11037: balooctl: checkDb should also verify the last known url for the documentId.

michaelh added a comment. `balooctl checkDb` is no more. See D10778 . We could turn it into a separate executable like 'balooDbDebug' or so. It should be made clear then that it is for developers only. REPOSITORY R293 Baloo REVISION DETAIL

D11013: Detect incorrect paramenter in findProtocol

jtamate added a dependent revision: D11044: Don't try to find an icon for an empty url. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11013 To: jtamate, #frameworks, dfaure Cc: michaelh

D11044: Don't try to find an icon for an empty url

jtamate added a dependency: D11013: Detect incorrect paramenter in findProtocol. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11044 To: jtamate, #frameworks, dfaure Cc: michaelh

D11044: Don't try to find an icon for an empty url

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY The message kf5.kio.core: Refilling KProtocolInfoFactory cache in the hope to find "" was produced when

D11013: Detect incorrect paramenter in findProtocol

jtamate updated this revision to Diff 28679. jtamate retitled this revision from "Remove trailing data in the protocol parameter in findProtocol" to "Detect incorrect paramenter in findProtocol". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate

D11038: balooctl: Add pruneDb option to remove stale file index entries.

michaelh added a comment. Baloo is in bad need for something like this. Unfortunately in cannot be done so easily. We have to account for indexed net shares and removable drives which are only temporarily unavailable. Files on those should not be removed. And most likely some user

D4911: add Baloo DBus signals for moved or removed files

cullmann added a comment. > I did some test today on tbaloo and noticed one problem when fetching the results from a query. The paths are encoded like URLs but without the scheme. I had to modify my code to use it. Apart from that, nice work. It just works. Are you still interested to work

D10997: Fix conversion of AccessPoint flags to capabilities

This revision was automatically updated to reflect the committed changes. Closed by commit R282:641f26a3d48d: Fix conversion of AccessPoint flags to capabilities (authored by fvogt). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10997?vs=28512=28676

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate added a comment. In D10742#218222 , @markg wrote: > In D10742#218171 , @dfaure wrote: > > > Can someone explain to me how switching from pointers to values is making anything faster, or is a