KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 78 - Still Unstable!

2018-03-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/78/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 20 Mar 2018 04:19:43 +
 Build duration:
6 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 103 - Still Unstable!

2018-03-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/103/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 20 Mar 2018 04:19:43 +
 Build duration:
4 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3522/13404)18%
(1954/10571)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)51%
(585/1140)27%
(406/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2243)7%
(102/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1441/3500)28%
(825/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(541/2009)17%
(298/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%

D11484: Fix combobox breakage

2018-03-19 Thread Michail Vourlakos 
mvourlakos added a comment.


  thank you, it works just fine now...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11484

To: ngraham, broulik, #plasma, mvourlakos, davidedmundson
Cc: #frameworks, michaelh, ngraham

D11491: Don't calculate attribute() twice.

2018-03-19 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: Frameworks, Kate.
Restricted Application added projects: Kate, Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  "kateTextLine" neither "i" shouldn't have changed since the first call to 
attribute two lines ago.

TEST PLAN
  Open a XML file with 4 lines and a line of 566039 characters long.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11491

AFFECTED FILES
  src/spellcheck/spellcheck.cpp

To: jtamate, #frameworks, #kate
Cc: michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D11489: Make concatenated strings wrappable

2018-03-19 Thread Michael Heidelbach 
michaelh created this revision.
michaelh added reviewers: mgallien, Baloo, Frameworks.
Restricted Application added projects: Frameworks, Baloo.
michaelh requested review of this revision.

REVISION SUMMARY
  Change concatenation of epub subjects to facilitate line wrapping

REPOSITORY
  R286 KFileMetaData

BRANCH
  wrappable

REVISION DETAIL
  https://phabricator.kde.org/D11489

AFFECTED FILES
  src/extractors/epubextractor.cpp

To: michaelh, mgallien, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, 
alexeymin

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 77 - Still Unstable!

2018-03-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/77/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 19 Mar 2018 15:40:44 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 102 - Still Unstable!

2018-03-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/102/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 19 Mar 2018 15:40:45 +
 Build duration:
9 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3558/13406)19%
(1978/10571)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2243)7%
(102/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2011)17%
(305/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D11287: Introduce baloodb CLI tool

2018-03-19 Thread Michael Heidelbach 
michaelh added inline comments.

INLINE COMMENTS

> ngraham wrote in main.cpp:65
> Any reason not to use a std::vector instead?

No reason. Will change to std::vector.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11484: Fix combobox breakage

2018-03-19 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11484

To: ngraham, broulik, #plasma, mvourlakos, davidedmundson
Cc: #frameworks, michaelh, ngraham

D11487: simple optimization of TextLineData::attribute

2018-03-19 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 29925.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  Same results, but more concise syntax with the range-based for.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11487?vs=29921=29925

REVISION DETAIL
  https://phabricator.kde.org/D11487

AFFECTED FILES
  src/buffer/katetextline.h

To: jtamate, #frameworks, #kate
Cc: cullmann, michaelh, kevinapavew, ngraham, demsking, sars, dhaumann

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-03-19 Thread Jaime Torres Amate 
jtamate planned changes to this revision.
jtamate added a comment.


  I've noticed this creates/exposes some crashes in other code/tests, for 
example in kdirmodeltest the second and later times the test is run.
  I'll check all the failing tests (given enough time).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: mwolff, markg, michaelh, ngraham

D11487: simple optimization of TextLineData::attribute

2018-03-19 Thread Christoph Cullmann 
cullmann added a comment.


  Looks reasonable.
  Could one use a C++11 range-based for?
  Given the container is const in that context, it won't detach, or?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11487

To: jtamate, #frameworks, #kate
Cc: cullmann, michaelh, kevinapavew, ngraham, demsking, sars, dhaumann

D11484: Fix combobox breakage

2018-03-19 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-combobox-breakage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11484

To: ngraham, broulik, #plasma, mvourlakos, davidedmundson
Cc: #frameworks, michaelh, ngraham

D11487: simple optimization of TextLineData::attribute

2018-03-19 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: Frameworks, Kate.
Restricted Application added projects: Kate, Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  Instead of getting the element to check 4 to 5 times each time, using the 
constant iterator, do it only one.
  
  From 76,84% of cpu F5758695: kate_before.png 

  
  to 19.12% of cpu F5758696: kate_after.png 

  
  in callgrind.

TEST PLAN
  Open a XML file with 4 lines an a line of 566039 characters long.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11487

AFFECTED FILES
  src/buffer/katetextline.h

To: jtamate, #frameworks, #kate
Cc: michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D11287: Introduce baloodb CLI tool

2018-03-19 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> michaelh wrote in main.cpp:161
> To point this out. I'm **not** the maintainer of baloo. Maybe better remove 
> this?

I think you sort of are Baloo's de facto maintainer (which is a good thing, and 
you've earned the position)!

> main.cpp:65
> +
> +const auto commands = QVector{
> +Command{

Any reason not to use a std::vector instead?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11287: Introduce baloodb CLI tool

2018-03-19 Thread Michael Heidelbach 
michaelh marked 4 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11287: Introduce baloodb CLI tool

2018-03-19 Thread Michael Heidelbach 
michaelh added inline comments.

INLINE COMMENTS

> mlaurent wrote in main.cpp:135
> very hard to read it.
> Could you split in several QString so it will more easy to check it's if ok :)

I had trouble myself :)

> main.cpp:161
> + i18n("(c) 2018, Michael Heidelbach"));
> +aboutData.addAuthor(i18n("Michael Heidelbach"), i18n("Maintainer"), 
> QStringLiteral("ottw...@gmail.com"));
> +KAboutData::setApplicationData(aboutData);

To point this out. I'm **not** the maintainer of baloo. Maybe better remove 
this?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11287: Introduce baloodb CLI tool

2018-03-19 Thread Michael Heidelbach 
michaelh updated this revision to Diff 29914.
michaelh added a comment.


  - Improve readability and apply other suggested changes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11287?vs=29694=29914

BRANCH
  sanitize-cmd (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11287

AFFECTED FILES
  src/tools/CMakeLists.txt
  src/tools/baloodb/CMakeLists.txt
  src/tools/baloodb/Messages.sh
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 157 - Still Unstable!

2018-03-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/157/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 19 Mar 2018 13:20:29 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 28 - Still Unstable!

2018-03-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/28/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 19 Mar 2018 13:20:29 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(295/444)66%
(295/444)53%
(31615/59677)38%
(18566/48926)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests99%
(72/73)99%
(72/73)94%
(8559/9141)48%
(5232/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8414/14352)50%
(4901/9728)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3890/7876)33%
(1635/4932)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 178 - Still Unstable!

2018-03-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/178/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 19 Mar 2018 13:20:29 +
 Build duration:
6 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31572/59677)38%
(18544/48930)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8594/9142)48%
(5248/10833)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8345/14351)50%
(4873/9724)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3890/7876)33%
(1635/4932)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D11484: Fix combobox breakage

2018-03-19 Thread Nathaniel Graham 
ngraham added a reviewer: mvourlakos.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11484

To: ngraham, broulik, #plasma, mvourlakos
Cc: #frameworks, michaelh, ngraham

D11484: Fix combobox breakage

2018-03-19 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: broulik, Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  
https://cgit.kde.org/plasma-framework.git/commit/?id=a21bc11fe11651f6d211489ebfc8435cef877194
 erroneously added `renderType` properties to PlasmaComponents3 ComboBoxes, but 
QML ComboBoxes don't have this property, which broke Latte Dock's settings. 
This patch removes it.
  
  BUG: 392026

TEST PLAN
  - Deployed, added Latte Dock, ran Plasmashell with and without 
`PLASMA_USE_QT_SCALING=1`, and with and without a HiDPI scale factor
  - Opened Latte Dock's settings window. In all cases, Latte Dock's settings 
window appeared normally and all comboboxes rendered properly
  - Opened Folder View settings and verified that all ComboBoxes there looked 
and worked fine, too

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-combobox-breakage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11484

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmastyle/ComboBoxStyle.qml

To: ngraham, broulik, #plasma
Cc: #frameworks, michaelh, ngraham

D11044: Don't try to find an icon for an empty url

2018-03-19 Thread David Faure 
dfaure added a comment.


  https://commits.kde.org/kio/e6723cdac2b713081417aa198f3cede8c68b78e0, now 
with unittests.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11044

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh, ngraham

D11287: Introduce baloodb CLI tool

2018-03-19 Thread Laurent Montel 
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:103
> +QStringLiteral("devices"), 
> +i18n("List devices "),
> +QStringList{},

extra space at the end of i18n

> main.cpp:112
> +QStringList names;
> +for (const auto c : commands) {
> +names.append(c.name);

const auto  ?

> main.cpp:124
> +}
> +return QStringList() ;
> +}

coding style: remove space after()

> main.cpp:131
> +auto options = getOptions(c.name);
> +QString optionStr = options.count() == 0
> +? QString()

options.count() == 0 => isEmpty()

> main.cpp:135
> +
> +auto str = QStringLiteral("%1 %2")
> +.arg(QStringLiteral("%1%2%3")

very hard to read it.
Could you split in several QString so it will more easy to check it's if ok :)

> main.cpp:203
> +const bool missingOnly = parser.isSet(QStringLiteral("missing-only"));
> +const QString pattern = args.size() > 0
> +? args.at(0)

!isEmpty()

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

D11044: Don't try to find an icon for an empty url

2018-03-19 Thread David Faure 
dfaure added a comment.


  Kai-Uwe was right, this should actually check for scheme.isEmpty(). Otherwise 
typing ~ in kfilewidget (which leads to a relative URL without scheme) hits 
this same assert again. I hate relative URLs... I'll change it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11044

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

2018-03-19 Thread Kai Uwe Broulik 
broulik added a comment.


  In D11331#226852 , @dollinger 
wrote:
  
  > I updated the diff, but unfortunately I'm not sure where to add that enum 
you @broulik mentioned since there is already one in `frontend\battery.h`:
  
  
  I think you can add an enum to `upower.h` and use it instead of the defines. 
I thought we already linked against UPower and could just use its header but we 
don't and I don't want to change that to avoid a dependency increase.
  
enum UPowerBatteryType {
UPowerBatteryTypeBattery,
UPowerBatteryTypeUps,
UPowerBatteryTypeMouse,
...
UPowerBatteryTypeGamingInput
};

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D10203: documenturldb: Temporarily remove Q_ASSERT, ignore empty filenames instead

2018-03-19 Thread Michael Heidelbach 
michaelh abandoned this revision.
michaelh added a comment.


  Done in D11285 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10203

To: michaelh, dfaure, vhanda, #frameworks, #baloo, mgallien
Cc: ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, 
alexeymin

D11038: balooctl: Add clean option to remove stale file index entries

2018-03-19 Thread Michael Heidelbach 
michaelh added a comment.


  In D11038#228996 , @smithjd wrote:
  
  > In D11038#228379 , @michaelh 
wrote:
  >
  > > - I wonder how you can run this. Please make sure you build the `debug 
target`. Comment out the respective `Q_ASSERT`s and mark them with a `FIXME`.
  >
  >
  > Works for me.
  
  
  Hmm,...
  
ASSERT: "!p.name.isEmpty()" in file 
/home/otto/baloo/src/engine/documenturldb.cpp, line 143
*** Programm hat Signal SIGABRT (Aborted) empfangen ***
  
  After commenting that out:
  
ASSERT: "!p.name.isEmpty()" in file 
/home/otto/baloo/src/engine/documenturldb.cpp, line 205
*** Programm hat Signal SIGABRT (Aborted) empfangen ***
  
  After commenting that out it seems to work, but:
  
$ balooctl clean
...
Database has corrupted entries baloo may misbehave, please recreate the DB 
by running $ balooctl disable && balooctl enable
Database has corrupted entries baloo may misbehave, please recreate the DB 
by running $ balooctl disable && balooctl enable
Purged 60129544208 //Kareshi Kanojo no Jijou
ASSERT: "!path.name.isEmpty()" in file 
/home/otto/baloo/src/engine/documenturldb.h, line 115
*** Programm hat Signal SIGABRT (Aborted) empfangen ***
  
  After commenting that out:
  
$ balooctl clean
...
Purged 168397082036537349 //Little Witch Academia - 08.mkv
Empty filename passed to function
Purged 168428194779629573 
Empty filename passed to function
Purged 215610373326243845 
Empty filename passed to function
Purged 215614303221319685 
*** Normal beendet ***
  
  Second run:
  
$ balooctl clean
Empty filename passed to function
Purged 148657949215033349 
*** Normal beendet ***
  
  Do you have an idea, why the `Q_ASSERT`s get in the way on my system, but not 
on yours?
  
  >> speakers. I don't know. For me it would be easier if this command would be 
called just clean.
  > 
  > Fixed.
  
  Thank you.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11038

To: smithjd, #baloo, #frameworks, michaelh
Cc: michaelh, ashaposhnikov, astippich, spoorun, nicolasfella, ngraham, 
alexeymin