KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Mar 2018 05:50:19 + Build duration: 1 min 31 sec and counting

D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS

This revision was automatically updated to reflect the committed changes. Closed by commit R278:cc5d6fde1aba: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11414?vs=29760=30083#toc REPOSITORY R278

Re: Review Request 128456: [KNotifications] Re-enable NotifyByLogfile plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128456/#review103870 --- As of commit

Re: Review Request 128456: [KNotifications] Re-enable NotifyByLogfile plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128456/ --- (Updated March 20, 2018, 9:04 p.m.) Status -- This change has been

Re: Review Request 128456: [KNotifications] Re-enable NotifyByLogfile plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128456/ --- (Updated March 20, 2018, 9:04 p.m.) Status -- This change has been

D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH fix-fullscreen-monitors REVISION DETAIL https://phabricator.kde.org/D11414 To: graesslin, #frameworks, #kwin, #plasma, davidedmundson Cc: michaelh, ngraham

D11513: DBus runner servicename wildcard support

davidedmundson updated this revision to Diff 30077. davidedmundson marked an inline comment as done. davidedmundson added a comment. Update &[]operator to .value() REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11513?vs=30005=30077 BRANCH dbus_runner

D11513: DBus runner servicename wildcard support

davidedmundson marked an inline comment as done. davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in dbusrunner.cpp:57 > Should we support asterisk at an arbitrary position? But that makes it a lot > more complex and main usecase is finding all `org.foo.bar-somepid` I'd

Re: Experimental class in baloo

On Tue, Mar 20, 2018 at 9:43 AM, Michael Heidelbach wrote: > Hi! > > I've recently introduced a new class for baloo > . > It is mainly for debugging. As it is accompanied with a command line

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/107/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Mar 2018 23:55:52 + Build duration: 6 min 52 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/82/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 23:55:52 + Build duration: 5 min 52 sec and counting

D11295: Use ecm_setup_qtplugin_macro_names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:f018779459e0: Use ecm_setup_qtplugin_macro_names (authored by kossebau). REPOSITORY R242 Plasma Framework (Library)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/33/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Mar 2018 23:47:47 + Build duration: 2 min 18 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Tue, 20 Mar 2018 23:47:47 + Build duration: 1 min 32 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/27/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 23:47:47 + Build duration: 1 min 9 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/48/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 23:41:57 + Build duration: 5 min 39 sec and counting JUnit

D11296: Use ecm_setup_qtplugin_macro_names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R290:eb91dd14aee1: Use ecm_setup_qtplugin_macro_names (authored by kossebau). REPOSITORY R290 KPackage CHANGES SINCE

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/65/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Mar 2018 23:41:57 + Build duration: 4 min 30 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Tue, 20 Mar 2018 23:41:57 + Build duration: 4 min 36 sec and counting JUnit Tests

D11294: Use ecm_setup_qtplugin_macro_names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R244:8b7db6c41328: Use ecm_setup_qtplugin_macro_names (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE

D11452: sanitizer: Improve device listing

smithjd added a comment. Could you please make your tab spacing conform to the style of the codebase? This should also be fixed in baloodb. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks Cc: smithjd, ashaposhnikov, michaelh,

D8532: [WIP] Restrict file extractor with Seccomp

davidk added a comment. In D8532#215476 , @michaelh wrote: > I don't know Seccomp. But as far as I understood this, the same concers apply to the `baloo_file_temp_extractor` baloo-widgets is using. Naivly I suggest to implement this

Experimental class in baloo

Hi! I've recently introduced a new class for baloo . It is mainly for debugging. As it is accompanied with a command line tool it may be useful for users too. It is still in an experimental state and it's

D11529: Balooctl: Deindex unfound files with check command.

smithjd retitled this revision from "Balooctl: Deindex unfound files with check command. Deindexing is skipped for file paths containing an unmounted mount point." to "Balooctl: Deindex unfound files with check command.". REPOSITORY R293 Baloo REVISION DETAIL

D11510: [KPropertiesDialog] Support Checksum tab for any local path

elvisangelaccio accepted this revision as: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11510 To: broulik, #frameworks, dfaure, elvisangelaccio, hein Cc: michaelh, ngraham

D11529: Balooctl: Deindex unfound files with check command. Deindexing is skipped for file paths containing an unmounted mount point.

smithjd created this revision. smithjd added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-filedeindexer REVISION DETAIL

D11510: [KPropertiesDialog] Support Checksum tab for any local path

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11510 To: broulik, #frameworks, dfaure, elvisangelaccio, hein Cc: michaelh, ngraham

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 18:11:56 + Build duration: 55 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/32/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Mar 2018 18:11:56 + Build duration: 1 min 46 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Tue, 20 Mar 2018 18:11:56 + Build duration: 1 min 31 sec and counting JUnit Tests

D10670: Reduce plasmashell frozen time

davidedmundson accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10670 To: jtamate, #frameworks, #plasma, mwolff, davidedmundson Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, ngraham, lesliezhai, ali-mohamed,

D11513: DBus runner servicename wildcard support

broulik added a comment. Cool! INLINE COMMENTS > dbusrunner.cpp:57 > > -m_interface = new OrgKdeKrunner1Interface(serviceName, path, > QDBusConnection::sessionBus(), this); > +if (requestedServiceName.endsWith(QLatin1Char('*'))) { > +requestedServiceName.chop(1); Should

D11513: DBus runner servicename wildcard support

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY A requested feature was to allow a runner to query N services for results. i.e

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/106/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Mar 2018 15:53:15 + Build duration: 9 min 6 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/81/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 15:53:15 + Build duration: 5 min 31 sec and counting

D11511: [KPropertiesDialog] Support X-KDE-Protocols

broulik updated this revision to Diff 30001. broulik added a comment. - Add `PropertyDef` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11511?vs=3=30001 REVISION DETAIL https://phabricator.kde.org/D11511 AFFECTED FILES

D11511: [KPropertiesDialog] Support X-KDE-Protocols

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY This allows to specify multiple protocols supported by the `KPropertiesDialogPlugin` similar to

D11510: [KPropertiesDialog] Support Checksum tab for any local path

broulik created this revision. broulik added reviewers: Frameworks, dfaure, elvisangelaccio. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY `computeChecksum` was already called with `localPath()` so check for it not being empty

D11487: optimization of TextLineData::attribute

jtamate added a comment. In D11487#229906 , @mwolff wrote: > can you publish the test file and how you measured it? Then I can test it with perf too, to confirm the impact. I'm sorry, I can't. It contains too much private information to

D11487: optimization of TextLineData::attribute

jtamate added a comment. In D11487#229889 , @cullmann wrote: > Hmm, does it really get that much faster or is the stuff just moved to the subroutines? The sum of the subroutines time is lower than the routine time as shown in

D11506: baloodb: Add experimental message

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH experimental REVISION DETAIL https://phabricator.kde.org/D11506 To: michaelh, #baloo, #frameworks, ngraham Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun,

D11487: optimization of TextLineData::attribute

mwolff added a comment. can you publish the test file and how you measured it? Then I can test it with perf too, to confirm the impact. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11487 To: jtamate, #frameworks, #kate Cc: mwolff, cullmann, michaelh,

D9400: use kpackage_install_bundled_package

apol added a comment. In D9400#229861 , @mart wrote: > using directly kpackage_install_bundled_package for every plasmoid one must do kpackage_install_bundled_package(analog-clock org.kde.plasma.analogclock "plasmoids"

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/105/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Mar 2018 13:57:24 + Build duration: 11 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/80/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 13:57:24 + Build duration: 6 min 13 sec and counting

D9400: use kpackage_install_bundled_package

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:7af18926322e: use kpackage_install_bundled_package (authored by mart). REPOSITORY R242 Plasma Framework (Library)

D9400: use kpackage_install_bundled_package

mart updated this revision to Diff 29993. mart added a comment. 2 macros REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9400?vs=24078=29993 BRANCH phab/bundled REVISION DETAIL https://phabricator.kde.org/D9400 AFFECTED FILES

D11487: optimization of TextLineData::attribute

cullmann added a comment. Hmm, does it really get that much faster or is the stuff just moved to the subroutines? I would not have thought that something is faster than simple linear scan for a short vector. REPOSITORY R39 KTextEditor REVISION DETAIL

D9400: use kpackage_install_bundled_package

mart added a comment. In D9400#229866 , @davidedmundson wrote: > My concern here is compiling lts with new frameworks gets affected, and at that point it's too late to do any applet fixes. what about doing a second plasma macro

D9400: use kpackage_install_bundled_package

davidedmundson added a comment. My concern here is compiling lts with new frameworks gets affected, and at that point it's too late to do any applet fixes. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9400 To: mart, #plasma Cc: davidedmundson,

D9400: use kpackage_install_bundled_package

mart added a comment. using directly kpackage_install_bundled_package for every plasmoid one must do kpackage_install_bundled_package(analog-clock org.kde.plasma.analogclock "plasmoids" ${PLASMA_RELATIVE_DATA_INSTALL_DIR}) I would still go with this form. REPOSITORY R242 Plasma

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/104/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Mar 2018 11:45:12 + Build duration: 5 min 59 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/79/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 11:45:12 + Build duration: 5 min 32 sec and counting

D11506: baloodb: Add experimental message

michaelh updated this revision to Diff 29984. michaelh added a comment. Make message const REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11506?vs=29983=29984 BRANCH experimental REVISION DETAIL https://phabricator.kde.org/D11506 AFFECTED FILES

D11506: baloodb: Add experimental message

michaelh edited the test plan for this revision. michaelh added reviewers: Baloo, Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11506 To: michaelh, #baloo, #frameworks Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham,

D11506: baloodb: Add experimental message

michaelh created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH experimental REVISION DETAIL https://phabricator.kde.org/D11506

D11452: sanitizer: Improve device listing

michaelh updated this revision to Diff 29981. michaelh added a comment. Rebase on master REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=29827=29981 BRANCH sanitize-devices (branched from master) REVISION DETAIL

D11487: optimization of TextLineData::attribute

jtamate updated this revision to Diff 29975. jtamate retitled this revision from "simple optimization of TextLineData::attribute" to "optimization of TextLineData::attribute". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment.

D11287: Introduce baloodb CLI tool

This revision was automatically updated to reflect the committed changes. michaelh marked 2 inline comments as done. Closed by commit R293:b050c0ab0ef7: Introduce baloodb CLI tool (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D11287: Introduce baloodb CLI tool

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH sanitize-cmd (branched from master) REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks, mlaurent Cc: mlaurent, ngraham, ashaposhnikov,

D11491: Don't calculate attribute() twice.

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11491 To: jtamate, #frameworks, #kate, dhaumann Cc: dhaumann, michaelh, kevinapavew,

D11287: Introduce baloodb CLI tool

mlaurent added inline comments. INLINE COMMENTS > michaelh wrote in CMakeLists.txt:16 > @mlaurent Is it worth the effort to change this for the other cli tools > accordingly? It's the default variable. But don't chnage it in this patch. Perhaps in the future as you are the baloo maintainer :)

D11287: Introduce baloodb CLI tool

michaelh marked 7 inline comments as done. michaelh added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:16 > install(TARGETS baloodb ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) @mlaurent Is it worth the effort to change this for the other cli tools accordingly? > mlaurent

D11287: Introduce baloodb CLI tool

michaelh updated this revision to Diff 29969. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11287?vs=29914=29969 BRANCH sanitize-cmd (branched from master) REVISION DETAIL

D11287: Introduce baloodb CLI tool

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:16 > + > +install(TARGETS baloodb DESTINATION ${BIN_INSTALL_DIR}) install(TARGETS baloodb ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) >