KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.9 - Build # 44 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.9/44/
 Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 01 Apr 2018 23:03:51 +
 Build duration:
1 hr 42 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)

D11529: Balooctl: Deindex unfound files with check command.

[James Smith]

smithjd updated this revision to Diff 31136.
smithjd added a comment.


  - Ignore the symlink target, only remove the index entry if the link is 
removed.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11529?vs=30804&id=31136

BRANCH
  master-filedeindexer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11529

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/indexcleaner.cpp
  src/file/indexerstate.h
  src/tools/balooctl/main.cpp

To: smithjd, #baloo, vhanda, michaelh, broulik
Cc: mgallien, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 70 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/70/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 01 Apr 2018 23:03:51 +
 Build duration:
5 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)86%
(36/42)86%
(36/42)78%
(2327/2966)66%
(1725/2609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(512/526)59%
(346/582)examples0%
(0/2)0%
(0/2)0%
(0/210)0%
(0/106)src.cli0%
(0/1)0%
(0/1)0%
(0/69)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)77%
(184/240)73%
(167/228)src.lib90%
(27/30)90%
(27/30)85%
(1631/1921)73%
(1212/1663)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/11/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 01 Apr 2018 23:03:51 +
 Build duration:
4 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)86%
(36/42)86%
(36/42)78%
(2327/2966)66%
(1725/2609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(512/526)59%
(346/582)examples0%
(0/2)0%
(0/2)0%
(0/210)0%
(0/106)src.cli0%
(0/1)0%
(0/1)0%
(0/69)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)77%
(184/240)73%
(167/228)src.lib90%
(27/30)90%
(27/30)85%
(1631/1921)73%
(1212/1663)

D11874: change 24px view-media-artist icon

[Alexander Stippich]

astippich added a comment.


  Before
  F5781105: Screenshot_20180401_222839.png 

  After
  F5781107: Screenshot_20180401_222817.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11874

To: astippich, #vdg
Cc: #frameworks, michaelh, ngraham

D11874: change 24px view-media-artist icon

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: VDG.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
astippich requested review of this revision.

REVISION SUMMARY
  the 24px version of the view-media-artist icon is the only one that links to 
im-invisible-user, while lower resolutions link to im-user.
  change the 24px version accordingly

REPOSITORY
  R266 Breeze Icons

BRANCH
  media-artist

REVISION DETAIL
  https://phabricator.kde.org/D11874

AFFECTED FILES
  icons-dark/actions/24/view-media-artist.svg
  icons/actions/24/view-media-artist.svg

To: astippich, #vdg
Cc: #frameworks, michaelh, ngraham

D11838: Turn on line numbers by default

[Michel Ludwig]

mludwig added a comment.


  In D11838#238269 , @ngraham wrote:
  
  > That said, I'm still struggling to understand what the problems is with 
line numbers in Kile. Most of the editors listed at 
https://beebom.com/best-latex-editors/ have line numbers on by default, 
including TeXmaker, which is what all of my scientist friends use. Screens are 
wider than ever before, and average users are going to just maximize the window 
anyway, making the small amount of horizontal space taken up by the line 
numbers a non-issue.
  
  
  On that website four screenshots out of eight show line numbers. And 
especially in TeXmaker's case, I wouldn't call the amount of space needed for 
line numbers small.
  
  The point is that line numbers do not bring much added value when editing 
LaTeX documents. To reduce clutter on Kile's user interface, line numbers 
should not be shown by default. It's not just a question of horizontal screen 
space, but also of usefulness/usability.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11838

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: brauch, mludwig, kfunk, dhaumann, #frameworks, michaelh, kevinapavew, 
ngraham, demsking, cullmann, sars

D11838: Turn on line numbers by default

[Sven Brauch]

brauch added a comment.


  For KDevelop this is fine, I don't think we have any objection.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11838

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: brauch, mludwig, kfunk, dhaumann, #frameworks, michaelh, kevinapavew, 
ngraham, demsking, cullmann, sars

D11838: Turn on line numbers by default

[Nathaniel Graham]

ngraham added a comment.


  So what's our path forward here? Is there a way to only turn on line numbers 
for Kate itself, and not for the katepart?
  
  That said, I'm still struggling to understand what the problems is with line 
numbers in Kile. Most of the editors listed at 
https://beebom.com/best-latex-editors/ have line numbers on by default, 
including TeXmaker, which is what all of my scientist friends use. Screens are 
wider than ever before, and average users are going to just maximize the window 
anyway, making the small amount of horizontal space taken up by the line 
numbers a non-issue.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11838

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: mludwig, kfunk, dhaumann, #frameworks, michaelh, kevinapavew, ngraham, 
demsking, cullmann, sars

D11869: epubextractor: Add property ReleaseYear

[Michael Heidelbach]

michaelh created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  Make epub-file properties more consistent with other media types which all 
provide ReleaseYear.

TEST PLAN
  make test

REPOSITORY
  R286 KFileMetaData

BRANCH
  releaseyear (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11869

AFFECTED FILES
  autotests/epubextractortest.cpp
  src/extractors/epubextractor.cpp

To: michaelh
Cc: mgallien, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

D11863: Add virt-manager icons

[Nathaniel Graham]

ngraham added subscribers: andreaska, ngraham.
ngraham accepted this revision.
ngraham added a reviewer: andreaska.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good to me! Nice use of the Breeze icon style. @andreaska?

REPOSITORY
  R266 Breeze Icons

BRANCH
  virt-manager_icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11863

To: ndavis, #vdg, ngraham, andreaska
Cc: ngraham, andreaska, #frameworks, michaelh

D11863: Add virt-manager icons

[Noah Davis]

ndavis added a comment.


  Screenshot of how they look in use
  F5780916: Screenshot_20180401_120901.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11863

To: ndavis, #vdg
Cc: #frameworks, michaelh, ngraham

D11863: Add virt-manager icons

[Noah Davis]

ndavis added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11863

To: ndavis, #vdg
Cc: #frameworks, michaelh, ngraham

D11863: Add virt-manager icons

[Noah Davis]

ndavis created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ndavis requested review of this revision.

REVISION SUMMARY
  48px color and 22px, 16px monochrome icons for the system tray

REPOSITORY
  R266 Breeze Icons

BRANCH
  virt-manager_icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11863

AFFECTED FILES
  icons-dark/apps/16/virt-manager.svg
  icons-dark/apps/22/virt-manager.svg
  icons-dark/apps/48/virt-manager.svg
  icons/apps/16/virt-manager.svg
  icons/apps/22/virt-manager.svg
  icons/apps/48/virt-manager.svg

To: ndavis
Cc: #frameworks, michaelh, ngraham

Re: Changes to networkmanager-qt - breakage in plasma-workspace

[Christophe Giboudeaux]

Hi,

On vendredi 30 mars 2018 00:21:41 CEST Ben Cooksley wrote:
> Hi Jan,
> 
> It seems that as part of your recent changes to networkmanager-qt to
> increase the dependency to 1.0.0 you've made some other changes which
> mean the appropriate include paths are no longer being provided to
> projects that depend on networkmanager-qt.
> 
> This has the unfortunate effect that plasma-workspace is no longer
> able to build on the CI system.
> 

FTR:

I pushed an emergency fix last night. plasma-nm and plasma-workspace can be 
built without issue.

Christophe