D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

[Nathaniel Graham]

ngraham added reviewers: Frameworks, Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio, #frameworks, #dolphin
Cc: meven, ltoscano, #frameworks, michaelh, bruns

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added a comment.


  I took a crack at accessing `statx` directly, but I'm waay out of my 
depth here and will need some help making this actually work. There doesn't 
seem to be a glibc wrapper for `statx` yet, so we have to access it directly, 
which is messy and I haven't figured out how to make it work yet, though I 
think I might be on the right track.
  
  As such, this patch is presented--currently in non-working form, sadly--for 
discussion and hopefully instructional purposes. If someone else with more 
domain knowledge wants to grab this and do it right themselves, please feel 
free!
  
  Problems that need to be overcome:
  
  - On my Neon test system with kernel 5.13, `__NR_statx` isn't actually 
available in `/usr/include/unistd.h`; it's only available in 
`/usr/src/linux-headers-4.13.0-38-generic/arch/x86/include/generated/uapi/asm/unistd_64.h
  - The `check_function_exists(statx HAVE_STATX)` CMake command returns 0 even 
though statx is available.
  - The file KIOSlave crashes in `../sysdeps/unix/syscall-template.S:84` when I 
try to run Dolphin with this patch for KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: meven, ltoscano, #frameworks, michaelh, bruns

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

[Nathaniel Graham]

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt 
and kernel versions support it" to "[WIP/assistance needed] Populate 
UDS_CREATION_TIME on Linux if statx system call is available".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: meven, ltoscano, #frameworks, michaelh, bruns

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

[Nathaniel Graham]

ngraham updated this revision to Diff 32762.
ngraham added a comment.


  Attempt so far unsuccessfully to use statx directly

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7423?vs=21871=32762

BRANCH
  arcpatch-D7423

REVISION DETAIL
  https://phabricator.kde.org/D7423

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file.cpp

To: ngraham, dfaure, broulik, elvisangelaccio
Cc: meven, ltoscano, #frameworks, michaelh, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/35/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 03:39:28 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/56)30%
(17/56)20%
(423/2108)20%
(252/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)87%
(135/155)55%
(104/188)src100%
(8/8)100%
(8/8)68%
(205/303)47%
(111/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)67%
(32/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)88%
(43/49)50%
   

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/11/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 22 Apr 2018 03:39:28 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/56)30%
(17/56)19%
(409/2102)20%
(251/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)85%
(132/155)54%
(102/188)src100%
(8/8)100%
(8/8)69%
(205/298)51%
(120/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)38%
(20/52)50%
(24/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)88%
(43/49)50%
 

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 205 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/205/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 03:38:53 +
 Build duration:
4 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  FYI: I undid the wonky manual UI sizing that @broulik objected to. In 
hindsight, not the best approach.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Okay, this patch is back to where we started, with nothing changed except 
centering the icon. Hopefully we can commit it now. I'll move the discussion 
over how to redesign the dialog itself to a separate task.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey updated this revision to Diff 32758.
sharvey added a comment.


  - Merge branch 'master' into align-lock-icon
  - Undo manual resizing of ser combo box & password error box

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12311?vs=32498=32758

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12424: Install pri file for qmake support & document it in metainfo.yaml

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  installprifile

REVISION DETAIL
  https://phabricator.kde.org/D12424

To: kossebau, #build_system, lbeltrame
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12423: Install pri file for qmake support & document it in metainfo.yaml

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  installprifile

REVISION DETAIL
  https://phabricator.kde.org/D12423

To: kossebau, #build_system, lbeltrame
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12423: Install pri file for qmake support & document it in metainfo.yaml

[Friedrich W . H . Kossebau]

kossebau added a dependency: D12424: Install pri file for qmake support & 
document it in metainfo.yaml.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12423

To: kossebau, #build_system
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12424: Install pri file for qmake support & document it in metainfo.yaml

[Friedrich W . H . Kossebau]

kossebau added a dependent revision: D12423: Install pri file for qmake support 
& document it in metainfo.yaml.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12424

To: kossebau, #build_system
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12424: Install pri file for qmake support & document it in metainfo.yaml

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Build System.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows to use KFileMetaDataBaloo in qmake-based projects with
  Qt += KFileMetaData

REPOSITORY
  R286 KFileMetaData

BRANCH
  installprifile

REVISION DETAIL
  https://phabricator.kde.org/D12424

AFFECTED FILES
  metainfo.yaml
  src/CMakeLists.txt

To: kossebau, #build_system
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12420

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

[Nathaniel Graham]

ngraham updated this revision to Diff 32748.
ngraham added a comment.


  Move the warnings to their own line so they're not missed, and also to 
improve the presentation

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12420?vs=32732=32748

BRANCH
  more-serious-delete-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12420

AFFECTED FILES
  src/widgets/jobuidelegate.cpp

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REVISION DETAIL
  https://phabricator.kde.org/D12422

To: ngraham, #frameworks, #dolphin
Cc: michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

[Nathaniel Graham]

ngraham updated this revision to Diff 32747.
ngraham added a comment.


  Move the warnings to their own line so they're not missed, and also to 
improve the presentation

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12422?vs=32742=32747

BRANCH
  prettier-trach-and-delete-dialogs-for-single-items (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12422

AFFECTED FILES
  src/widgets/jobuidelegate.cpp

To: ngraham, #frameworks, #dolphin
Cc: michaelh, bruns

D12423: Install pri file for qmake support & document it in metainfo.yaml

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Build System.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows to use Baloo in qmake-based projects with Qt += Baloo

REPOSITORY
  R293 Baloo

BRANCH
  installprifile

REVISION DETAIL
  https://phabricator.kde.org/D12423

AFFECTED FILES
  metainfo.yaml
  src/lib/CMakeLists.txt

To: kossebau, #build_system
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

[Nathaniel Graham]

ngraham added a dependent revision: D12422: Use a regular dialog rather than a 
list dialog when trashing or deleting a single file.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12420

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
ngraham set the repository for this revision to R241 KIO.
ngraham added a dependency: D12420: Make the warning text for deletion 
operations emphasize its permanency and irreversibility.
Restricted Application added a project: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12422

To: ngraham, #frameworks, #dolphin
Cc: michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch uses a regular-style dialog instead of a list-style dialog when 
the user is trying to trash or delete only a single item. It looks a bit nicer 
than showing a dialog that has a list with only a single item in it.
  
  I know I've come across a bugzilla ticket requesting this while triaging KIO 
bugs recently, but now I can't find it anymore...

TEST PLAN
  Made sure that trash and deletion operations all still work. Here's how it 
looks:
  
  Delete a single file:
  
  Delete multiple files:
  
  Trash a single file:
  
  Trash multiple files:

BRANCH
  prettier-trach-and-delete-dialogs-for-single-items (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12422

AFFECTED FILES
  src/widgets/jobuidelegate.cpp

To: ngraham, #frameworks, #dolphin

D10980: updated hanle icon

[Nathaniel Graham]

ngraham added a comment.


  I really don't like that icon at all, I'm afraid. It has no meaning to me. It 
doesn't suggest directionality, movement, or dragging.
  
  How about something more like this:
  
  F5816766: arrow.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10980

To: andreask, mart
Cc: mart, ngraham, #frameworks, michaelh, bruns

D10980: updated hanle icon

[Marco Martin]

mart added a comment.


  F5816754: Screenshot_20180421_214512.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10980

To: andreask, mart
Cc: ngraham, #frameworks, michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12420

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin, elvisangelaccio.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

TEST PLAN
  [image goes here]

REPOSITORY
  R241 KIO

BRANCH
  more-serious-delete-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12420

AFFECTED FILES
  src/widgets/jobuidelegate.cpp

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Nathaniel Graham]

ngraham added a comment.


  Me too. Let's not let the perfect be the enemy of the good here. @rkflx, are 
you satisfied with this now?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D11828: Simplify orPostingIterator and make it faster

[Stefan Brüns]

bruns marked 8 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in orpostingiterator.cpp:28
> `, m_nextId(ULONG_LONG_MAX)` ?

Currently the only reserved value is `0`, and I prefer to keep it as is.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11828

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D10075: Make pacakge usefull for cross compilation

[Sandro Knauß]

knauss added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in CMakeLists.txt:45
> the 3rd parameter is a bool. This change won't do what you expect.
> 
> (https://cmake.org/cmake/help/v3.0/command/option.html)

well it compiles like I expected it... but yeah I see this is a bug not a 
feature :)

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10075

To: knauss, #frameworks, skelly
Cc: cgiboudeaux, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Alex Nemeth]

anemeth added a comment.


  The same thing with the scrollbar area constantly reserved can be reproduced 
on Windows in a standalone Qt app using QListView, so it is definitely a Qt 
issue.
  It could be fixed by creating a new widget for this, but I'm not up for that 
task.
  
  F5816535: Képkivágás.PNG 
  
  I think the current solution is "good enough".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12384: Fix double margins around DownloadDialog

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:25b78145d247: Fix double margins around DownloadDialog 
(authored by kossebau).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12384?vs=32653=32722

REVISION DETAIL
  https://phabricator.kde.org/D12384

AFFECTED FILES
  src/downloaddialog.cpp

To: kossebau, leinir, davidedmundson
Cc: #frameworks, michaelh, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/60/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 21 Apr 2018 15:16:36 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/77/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 21 Apr 2018 15:16:36 +
 Build duration:
6 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/21/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 21 Apr 2018 15:16:36 +
 Build duration:
3 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

D7929: [WIP] Add new Column View option to KDirOperator

[Nathaniel Graham]

ngraham added a comment.


  Ah, what a shame.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7929

To: fvogt, #frameworks
Cc: dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks, 
michaelh, bruns

D7929: [WIP] Add new Column View option to KDirOperator

[Fabian Vogt]

fvogt abandoned this revision.
fvogt added a comment.


  In D7929#251013 , @ngraham wrote:
  
  > We're doing a UI and usability overhaul of the Open & Save dialogs in 
T8552: Polish Open/Save dialogs , and I 
think perhaps we should revisit this. I'm very strongly in favor of adding 
column-based navigation to both `KDirOperator` and also Dolphin (though I 
understand that's much more difficult). However I don't think it's the end of 
the world if we can only add it to the open/save dialogs for now, since 
navigation is the primary use case for these dialogs. On MacOS, column view is 
practically the only mode I use for navigation, since it's so much faster than 
the others.
  >
  > Is there anything we can do to ease the difficulty of the Qt contribution 
process for you, @fvogt?
  
  
  I don't think there is - I don't really want to maintain a component in Qt 
which I'm not even very familiar with (I only used it once, here).
  
  That combined with the design issues this currently has (hidden dirs etc.) 
makes this not easy to get into shape. The current patch state is more a PoC 
than a finished product...
  So I'll abandon this diff for now.
  
  Having it as part of dolphin would be nicer,  as the open/save dialog is per 
default too small to have more than two columns visible at a time.
  
  So once this is part of dolphin I'll reconsider this and maybe work on it 
some more.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7929

To: fvogt, #frameworks
Cc: dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks, 
michaelh, bruns

D12384: Fix double margins around DownloadDialog

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fixextramarginarounddownladdialog

REVISION DETAIL
  https://phabricator.kde.org/D12384

To: kossebau, leinir, davidedmundson
Cc: #frameworks, michaelh, bruns

D7929: [WIP] Add new Column View option to KDirOperator

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7929

To: fvogt, #frameworks
Cc: dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks, 
michaelh, bruns

D7929: [WIP] Add new Column View option to KDirOperator

[Nathaniel Graham]

ngraham added a comment.


  We're doing a UI and usability overhaul of the Open & Save dialogs in T8552: 
Polish Open/Save dialogs , and I think 
perhaps we should revisit this. I'm very strongly in favor of adding 
column-based navigation to both `KDirOperator` and also Dolphin (though I 
understand that's much more difficult). However I don't think it's the end of 
the world if we can only add it to the open/save dialogs for now, since 
navigation is the primary use case for these dialogs. On MacOS, column view is 
practically the only mode I use for navigation, since it's so much faster than 
the others.
  
  Is there anything we can do to ease the difficulty of the Qt contribution 
process for you, @fvogt?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7929

To: fvogt, #frameworks
Cc: dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks, 
michaelh, bruns

D12327: Show Detailed Tree View by default

[Nathaniel Graham]

ngraham added a comment.


  In D12327#250944 , @rkflx wrote:
  
  > In D12327#250911 , @ngraham 
wrote:
  >
  > > In fact, if we integrated the Up button into the `KURLNavigator` widget, 
it would solve some issues automatically (e.g. lack of up button in Gwenview). 
I could see some people complaining about it though, because then the 
navigation buttons would be in two different vertical planes (since the URL 
navigator is always below the toolbar). Maybe we could live with that though?
  >
  >
  > One plane for history-related navigation (back, forward), and one plane for 
navigation related to directory hierarchy (up, breadcrumb). Seems even more 
logical to me than grouping back/forward/up.
  >
  >  ---
  >
  > Let's wait until @elvisangelaccio has had time to comment again on the 
matter.
  
  
  Yeah, I could definitely get behind it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12327: Show Detailed Tree View by default

[Henrik Fehlauer]

rkflx added a comment.


  In D12327#250911 , @ngraham wrote:
  
  > In fact, if we integrated the Up button into the `KURLNavigator` widget, it 
would solve some issues automatically (e.g. lack of up button in Gwenview). I 
could see some people complaining about it though, because then the navigation 
buttons would be in two different vertical planes (since the URL navigator is 
always below the toolbar). Maybe we could live with that though?
  
  
  One plane for history-related navigation (back, forward), and one plane for 
navigation related to directory hierarchy (up, breadcrumb). Seems even more 
logical to me than grouping back/forward/up.
  
  ---
  
  Let's wait until @elvisangelaccio has had time to comment again on the matter.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

[Nathaniel Graham]

ngraham added a comment.


  In D12389#250931 , @alexeymin 
wrote:
  
  > Stupid question, what happens if dolphin is not installed?
  
  
  I answered that in the comment above yours. :) KConfig seems to handle it 
without issue. But test it out and see for yourself!

REPOSITORY
  R241 KIO

BRANCH
  dolphin_thumbs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12389

To: anemeth, #frameworks, #vdg, ngraham, #dolphin
Cc: alexeymin, ngraham, #frameworks, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

[Alexey Min]

alexeymin added a comment.


  Stupid question, what happens if dolphin is not installed?

REPOSITORY
  R241 KIO

BRANCH
  dolphin_thumbs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12389

To: anemeth, #frameworks, #vdg, ngraham, #dolphin
Cc: alexeymin, ngraham, #frameworks, michaelh, bruns

D12327: Show Detailed Tree View by default

[Nathaniel Graham]

ngraham added a comment.


  In D12327#250898 , @rkflx wrote:
  
  > In D12327#250864 , @ngraham 
wrote:
  >
  > > - Bandwagon: Windows and macOS's default details style views allow 
expansion by default too
  >
  >
  > I'm all for going tree-style, but honestly I don't see expansion in 
Windows? Are we testing different versions? (In case they are fictitious, that 
would not help your point.)
  
  
  Ah, you're right, never mind. In Windows 10, even with 8 (8!) view modes, 
none of them allow tree-style expansion.
  
  In D12327#250898 , @rkflx wrote:
  
  > In D12327#250864 , @ngraham 
wrote:
  >
  > > I think it's best to have two buttons, each corresponding to a very 
different style of view that's optimized for a clear use case.
  >
  >
  > That would be ideal, of course.
  
  
  Yes I think we should shoot for that, if possible.
  
  > In D12327#250875 , @ngraham 
wrote:
  > 
  >> Or, a compromise: If we wanted to go all the way and have Dolphin-style 
options (Icons View, Compact view, Detailed view), I could support that for 
consistency's sake as long as we have three buttons like Dolphin does, rather 
than a combobox or a drop-down menu. That would still run into the technical 
challenges that I outlined above though.
  > 
  > 
  > As hinted at before, I could agree to that. However, we need more space 
then. How about moving Up, i.e. only a single button, in front of the 
breadcrumb bar? Would help in Dolphin too, and has been seen in Windows before, 
while avoiding some of the problems with moving every navigation button there, 
like you proposed elsewhere.
  
  In fact, if we integrated the Up button into the `KURLNavigator` widget, it 
would solve some issues automatically (e.g. lack of up button in Gwenview). I 
could see some people complaining about it though, because then the navigation 
buttons would be in two different vertical planes (since the URL navigator is 
always below the toolbar). Maybe we could live with that though?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12327: Show Detailed Tree View by default

[Henrik Fehlauer]

rkflx added a comment.


  In D12327#250864 , @ngraham wrote:
  
  > - Bandwagon: Windows and macOS's default details style views allow 
expansion by default too
  
  
  I'm all for going tree-style, but honestly I don't see expansion in Windows? 
Are we testing different versions? (In case they are fictitious, that would not 
help your point.)
  
  > You've previously argued that allowing access to advanced functionality via 
the Settings manu is fine, and it will of course all remain there.
  
  You are right of course. I was going for a fallback option here: If we cannot 
agree to your original proposal, accessing the view modes via a dedicated 
button would still be preferable over having to go into an additional submenu 
in the generic settings button, though.
  
  > I think it's best to have two buttons, each corresponding to a very 
different style of view that's optimized for a clear use case.
  
  That would be ideal, of course.
  
  In D12327#250875 , @ngraham wrote:
  
  > Or, a compromise: If we wanted to go all the way and have Dolphin-style 
options (Icons View, Compact view, Detailed view), I could support that for 
consistency's sake as long as we have three buttons like Dolphin does, rather 
than a combobox or a drop-down menu. That would still run into the technical 
challenges that I outlined above though.
  
  
  As hinted at before, I could agree to that. However, we need more space then. 
How about moving Up, i.e. only a single button, in front of the breadcrumb bar? 
Would help in Dolphin too, and has been seen in Windows before, while avoiding 
some of the problems with moving every navigation button there, like you 
proposed elsewhere.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Definitely a visual improvement! Let's wait for a few more opinions regarding 
whether this is the right approach technically.

REPOSITORY
  R241 KIO

BRANCH
  image_smooth_downscale (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg, ngraham
Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

D12327: Show Detailed Tree View by default

[Nathaniel Graham]

ngraham added a comment.


  Or, a compromise: If we wanted to go all the way and have Dolphin-style 
options (Icons View, Compact view, Detailed view), I could support that for 
consistency's sake as long as we have three buttons like Dolphin does, rather 
than a combobox or a drop-down menu. That would still run into the technical 
challenges that I outlined above though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12327: Show Detailed Tree View by default

[Nathaniel Graham]

ngraham added a comment.


  Reasons to change the default to Detailed View or Detailed Tree View:
  
  - Ergonomics: the current default requires side-scrolling for long lists, 
which is almost never ideal
  - Usefulness: by showing the details columns by default (which also makes 
sorting more discoverable for this view), we're helping users find their 
content by more than just the filename
  - Bandwagon: Windows and GNOME do it (macOS probably would if they didn't 
have column view)
  
  Reasons to use Detailed Tree View as the default instead of Detailed View:
  
  - Usefulness: allowing expansion is a useful feature
  - Flexibility: allowing expansion helps advanced users navigate the hierarchy 
using the arrows to expand and collapse nodes, while allowing normal users to 
completely ignore the arrows and just navigate by clicking on folders and using 
the back button in the toolbar
  - Consistency: Dolphin's default default-style view allows expansion by 
default
  - Bandwagon: Windows and macOS's default details style views allow expansion 
by default too
  
  
  
  In D12327#250801 , @rkflx wrote:
  
  > One more idea: We could go all the way to a Windows style file dialog, i.e. 
use a single button to switch views, which has //all// options in it:
  >
  > - Short View > Next to Filename (needs new name)
  > - Short View > Above to Filename (needs new name)
  > - Detailed View
  > - [ ] Show tree expanders which would be disabled for Above Filename (needs 
better wording, of course)
  >
  >   ---
  >
  >   Edit 1: With this it would be easier to access all modes, so there would 
be less need to do a controversial change of default.
  >
  >   Edit 2: Hm I like this idea quite a lot, actually. @ngraham Could you 
give it a chance?
  
  
  Sorry, I'm not a big fan of this. I feel like that would dilute the 
task-centric focus that we're going for here. You've previously argued that 
allowing access to advanced functionality via the Settings manu is fine, and it 
will of course all remain there. The point of the toolbar is to allow quick 
access to a pre-selected, curated assortment of the functionality that we the 
developers deem most useful by default. For advanced users who feel constrained 
by this, the toolbar should simple be editable.
  
  Technically, it's somewhat problematic because your proposal would break the 
nice tidy 1:1 mapping of modes that the file dialog provides to modes that 
`KDirOperator` provides.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12327: Show Detailed Tree View by default

[Henrik Fehlauer]

rkflx added a comment.


  One more idea: We could go all the way to a Windows style file dialog, i.e. 
use a single button to switch views, which has //all// options in it:
  
  - Short View > Next to Filename (needs new name)
  - Short View > Above to Filename (needs new name)
  - Detailed View
  - Tree View
  - Detailed Tree View
  
  Or, consolidating a bit:
  
  - Short View > Next to Filename (needs new name)
  - Short View > Above to Filename (needs new name)
  - Detailed View
  - [ ] Show tree expanders which would be disabled for Above Filename (needs 
better wording, of course)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12327: Show Detailed Tree View by default

[Henrik Fehlauer]

rkflx added a comment.


  In D12327#250797 , 
@elvisangelaccio wrote:
  
  > But Detailed View and Detailed Tree View are two different things, no? (I'm 
not even sure Windows supports the latter)
  
  
  That's correct, Windows does not support the latter. In D12077 
 the button was added (sadly Nate thought 
it was enough to ask on IRC and Telegram regarding my suggestion to wait for 
one extra approval…), where we used the Tree variant for the more detailed view.
  
  We could backtrack on that and use the non-tree variant, but personally I 
find it quite fitting for this mode to also allow expanding folders without 
navigating there, as it might allow to find things faster when not having to go 
back. Admittedly it adds some amount of visual noise.
  
  Thoughts?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12327: Show Detailed Tree View by default

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D12327#250786 , @rkflx wrote:
  
  > In D12327#250761 , 
@elvisangelaccio wrote:
  >
  > > I'm not sure I agree with this change
  >
  >
  > At least it's not a -1 yet, so maybe we can convince you once everything is 
in place…!?
  >
  > > afaik Windows does not show the tree view by default in its file dialogs 
(unless you are referring to `FolderBrowserDialog` from .Net)
  >
  > Testing Internet Explorer, Paint and Notepad, all show this detailed view 
(Explorer too!). Only when switching to the Pictures folder the view is changed 
to "text under icons". For a non-Microsoft app I tested Firefox, which also has 
detailed view. If you asked me, I'd say that's the default experience people 
get on Windows.
  
  
  But Detailed View and Detailed Tree View are two different things, no? (I'm 
not even sure Windows supports the latter)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12342: Update CMakeLists.txt

[Elvis Angelaccio]

elvisangelaccio removed a reviewer: Frameworks.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D12342

To: michaelh, #baloo, #dolphin, elvisangelaccio, #frameworks
Cc: ashaposhnikov, astippich, spoorun

D12342: Update CMakeLists.txt

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> michaelh wrote in CMakeLists.txt:4
> There is not indication that `baloo-widgets` is an Application. Yet it 
> resides in the `kde/applications` folder. Shouldn't it be moved into 
> `frameworks`?

It probably should, but in order to become a proper framework it has to satisfy 
the strict frameworks requirements: 
https://community.kde.org/Frameworks/Policies

In the meantime, if want to use the automatic versioning from release scripts 
(which is a good idea), we need to use the script of KDE Applications as 
described here: 
https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D12342

To: michaelh, #baloo, #dolphin, #frameworks, elvisangelaccio
Cc: ashaposhnikov, astippich, spoorun

D12327: Show Detailed Tree View by default

[Henrik Fehlauer]

rkflx added a comment.


  In D12327#250761 , 
@elvisangelaccio wrote:
  
  > I'm not sure I agree with this change
  
  
  At least it's not a -1 yet, so maybe we can convince you once everything is 
in place…!?
  
  > afaik Windows does not show the tree view by default in its file dialogs 
(unless you are referring to `FolderBrowserDialog` from .Net)
  
  Testing Internet Explorer, Paint and Notepad, all show this detailed view 
(Explorer too!). Only when switching to the Pictures folder the view is changed 
to "text under icons". For a non-Microsoft app I tested Firefox, which also has 
detailed view. If you asked me, I'd say that's the default experience people 
get on Windows.
  
  Nevertheless, copying Windows is not the main point. We should switch 
defaults if we determine it's the best for KDE's apps. Reasons for that might 
be:
  
  - Vertical scrolling is awkward, often people don't realize they can use 
their scroll wheel or touchpad and resort to move the scrollbar instead.
  - Continuously reading and scrolling a vertical list may allow finding a file 
faster than jumping back and forth in the vertical-and-horizontal placement 
with more horizontal scrolling in between.
  - Sorting is more natural, with quicker access (thus used more often) to 
toggle between time and name based sorting.
  - Clear separation between the details mode and the more visual Simple View. 
We cannot turn on "text under icons", a bigger icon size and thumbnails if 
Simple View was to stay the default mode, because that would not work well for 
the general use case and show too view items at once.
  
  @ngraham Anything I missed?
  
  As a sort of compromise we could keep the current default, but add a third 
button like in Dolphin. That needs more space, has some caveats and is more 
complicated to implement, though. Food for thought.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12327: Show Detailed Tree View by default

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I'm not sure I agree with this change, and afaik Windows does not show the 
tree view by default in its file dialogs (unless you are referring to 
`FolderBrowserDialog` from .Net)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth added a comment.


  I hit the resizing performance issue without this patch too, so it's 
unrelated to this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 204 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/204/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 21 Apr 2018 07:14:05 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 226 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/226/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 21 Apr 2018 07:14:05 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29942/59674)36%
(17658/48987)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7400/9127)42%
(4550/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7907/14348)48%
(4672/9747)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3874/7858)33%
(1631/4934)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/75/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 21 Apr 2018 07:14:05 +
 Build duration:
7 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29971/59674)36%
(17663/48983)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7400/9127)42%
(4550/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7957/14349)48%
(4692/9751)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3870/7857)33%
(1632/4934)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
  

D12228: kdirlister new connect syntax

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ee0a0f1ef323: kdirlister new connect syntax (authored by 
jtamate).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12228?vs=32663=32686#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12228?vs=32663=32686

REVISION DETAIL
  https://phabricator.kde.org/D12228

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#250688 , @bruns wrote:
  
  > Gnome-disks does, and so do other programs.
  
  
  Gnome-disks uses UDisks to do everything and can't do anything on its own. So 
available features are very limited (not even resizing partitions).
  I suspect it is significantly less portable (e.g. to FreeBSD).
  That's why gnome-disks was written from scratch (with fewer features than 
gparted that it was supposedly replacing).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12306: Filepicker dialog proper grid icon layout

[Henrik Fehlauer]

rkflx added a comment.


  In D12306#250724 , @ngraham wrote:
  
  > Ooh, centering when there's only one column is a nice touch.
  
  
  Not sure what you mean? The whole patch is about centering everything, that's 
still happening obviously. The revert was only about a bug affecting Oxygen 
(small offset after changing window width), which made it worse for every other 
style.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns