KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 141 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/141/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 23 Apr 2018 03:28:19 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13515)18%
(1978/10693)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/452)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2316)7%
(102/1554)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 116 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/116/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 23 Apr 2018 03:28:20 +
 Build duration:
5 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.9 - Build # 19 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20FreeBSDQt5.9/19/
 Project:
Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 23 Apr 2018 03:27:14 +
 Build duration:
25 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on FreeBSDQt5.9Running on FreeBSD Builder 1 in /usr/home/jenkins/workspace/Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.9[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/frameworkintegration > git init /usr/home/jenkins/workspace/Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.9 # timeout=10Fetching upstream changes from git://anongit.kde.org/frameworkintegration > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/frameworkintegration +refs/heads/*:refs/remotes/origin/* # timeout=120ERROR: Error cloning remote repo 'origin'hudson.plugins.git.GitException: Command "git fetch --tags --progress git://anongit.kde.org/frameworkintegration +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: fatal: read error: Connection reset by peer	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1996)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1715)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:405)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:614)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 1		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)		at sun.reflect.GeneratedMethodAccessor396.invoke(Unknown Source)		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)		at java.lang.reflect.Method.invoke(Method.java:498)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)		at com.sun.proxy.$Proxy90.execute(Unknown Source)		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1120)		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1160)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:113)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:85)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:75)		at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1$1.call(AbstractSynchronousNonBlockingStepExecution.java:47)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1.run(AbstractSynchronousNonBlockingStepExecution.java:44)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: Error cloning remote repo 'origin'[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  In D12311#250731 , @stikonas wrote:
  
  > In D12311#250688 , @bruns wrote:
  >
  > > Gnome-disks does, and so do other programs.
  >
  >
  > Gnome-disks uses UDisks to do everything and can't do anything on its own. 
So available features are very limited (not even resizing partitions).
  >  I suspect it is significantly less portable (e.g. to FreeBSD).
  >  That's why gnome-disks was written from scratch (with fewer features than 
gparted that it was supposedly replacing) and it wasn't the case of somebody 
porting gparted to udisks .
  
  
  Resizing: 
http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32861.
jpoelen added a comment.


  I am completely lost with `arc diff`. The command adds files that I did not 
normally modify in this branch and specifiying a reference commit does not seem 
to work.
  
  I ended up doing everything through a new branch, sorry to rot the history 
like this :/.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=32860&id=32861

BRANCH
  sql2

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32860.
jpoelen added a comment.


  - SQL: various improvements and fix if/case/loop/end detection with SQL 
(Oracle)
  - add sql tests
  - update kateversion to 5.0 and allows multiple spaces for "end if", "end 
case" and "end loop"
  - autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are 
restored

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=32855&id=32860

BRANCH
  sql2

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32855.
jpoelen added a comment.


  - diff with the proper branch

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=32853&id=32855

BRANCH
  new_sql_oracle

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32853.
jpoelen added a comment.


  - autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are 
restored

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=32852&id=32853

BRANCH
  new_sql_oracle

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

[jonathan poelen]

jpoelen updated this revision to Diff 32852.
jpoelen added a comment.


  - SQL: various improvements and fix if/case/loop/end detection with SQL 
(Oracle)
  - add sql tests
  - update kateversion to 5.0 and allows multiple spaces for "end if", "end 
case" and "end loop"

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11470?vs=29866&id=32852

BRANCH
  new_sql_oracle

REVISION DETAIL
  https://phabricator.kde.org/D11470

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  autotests/folding/test.sql.fold
  autotests/folding/test.sql_oracle.fold
  autotests/html/test.sql.html
  autotests/html/test.sql_oracle.html
  autotests/input/highlight.sh
  autotests/input/highlight.sh.syntax
  autotests/input/test.sql
  autotests/input/test.sql_oracle
  autotests/reference/test.sql.ref
  autotests/reference/test.sql_oracle.ref
  data/syntax/sql-mysql.xml
  data/syntax/sql-oracle.xml
  data/syntax/sql-postgresql.xml
  data/syntax/sql.xml
  src/indexer/katehighlightingindexer.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey retitled this revision from "[WIP] Add "SkipSwitcher" to API" to "Add 
"SkipSwitcher" to API".

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

[Scott Harvey]

sharvey added a subscriber: davidedmundson.
sharvey added a comment.


  Removed `[WIP]` from title at suggestion of @davidedmundson .

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Henrik Fehlauer]

rkflx edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  grid_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  Thanks, my patch from above has been applied, so LGTM now.
  
  Any additional objections or comments from #frameworks 
? If not, I'll commit this on 
Wednesday on behalf of @anemeth.
  
  ---
  
  @anemeth Will review https://phabricator.kde.org/D12328 and 
https://phabricator.kde.org/D12321 in the next days, sorry for the delay…

REPOSITORY
  R241 KIO

BRANCH
  grid_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 140 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/140/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 20:07:33 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13515)18%
(1978/10693)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/452)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2316)7%
(102/1554)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 115 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/115/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 20:07:33 +
 Build duration:
2 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/21/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 22 Apr 2018 19:42:18 +
 Build duration:
8 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(237/306)56%
(141/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(195/249)56%
(126/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 73 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/73/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 19:42:18 +
 Build duration:
4 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 77 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/77/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 19:42:18 +
 Build duration:
1 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(237/306)56%
(141/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)78%
(195/249)56%
(126/224)

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.10/11/
 Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.10
 Date of build:
Sun, 22 Apr 2018 19:42:17 +
 Build duration:
55 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 139 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/139/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 18:36:07 +
 Build duration:
7 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3556/13515)18%
(1977/10693)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/452)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2316)7%
(102/1554)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 114 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/114/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 18:36:07 +
 Build duration:
5 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D12378: Properly search for NetworkManager

[Jan Grulich]

jgrulich updated this revision to Diff 32836.
jgrulich edited the summary of this revision.
jgrulich added a comment.


  Do not use prefix for NM header and remove unnecessary workarounds

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12378?vs=32641&id=32836

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12378

AFFECTED FILES
  cmake/modules/FindNetworkManager.cmake
  src/solid-networkstatus/kded/CMakeLists.txt
  src/solid-networkstatus/kded/networkmanagerstatus.cpp
  src/solid-networkstatus/kded/networkmanagerstatus.h

To: jgrulich, #frameworks
Cc: #frameworks, michaelh, bruns

D11137: overflow-menu as view-more-symbolic, and horizontal

[Nathaniel Graham]

ngraham added a comment.


  This change broke the CI: 
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/76/
  
[ 62%] Building CXX object 
autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o
./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: 
namespace error : Namespace prefix inkscape for connector-curvature on path is 
not defined
sodipodi:nodetypes="ccc" />
^
./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: 
namespace error : Namespace prefix sodipodi for nodetypes on path is not defined
sodipodi:nodetypes="ccc" />
^
./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace 
error : Namespace prefix inkscape for connector-curvature on path is not defined
sodipodi:nodetypes="ccc" />
^
./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace 
error : Namespace prefix sodipodi for nodetypes on path is not defined
sodipodi:nodetypes="ccc" />
^

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11137

To: mart, #vdg, andreaska
Cc: ngraham, Fuchs, #frameworks, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 230 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/230/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 17:18:57 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29931/59686)36%
(17660/48993)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7400/9127)42%
(4554/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7897/14351)48%
(4668/9749)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3872/7867)33%
(1632/4938)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(522/1008)42%
(418/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

D12448: Fix KCompletionBox on wayland

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R284:fbb5609001ab: Fix KCompletionBox on wayland (authored by 
apol).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12448?vs=32805&id=32833

REVISION DETAIL
  https://phabricator.kde.org/D12448

AFFECTED FILES
  src/kcompletionbox.cpp

To: apol, #frameworks, davidedmundson
Cc: anthonyfieroni, michaelh, bruns

D12448: Fix KCompletionBox on wayland

[Aleix Pol Gonzalez]

apol added a comment.


  In D12448#251908 , @anthonyfieroni 
wrote:
  
  > Why not
  >
  >   static const auto flags = qGuiApp->platformName() == 
QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | 
Qt::FramelessWindowHint | Qt::BypassWindowManagerHint) :
  > 
  Qt::WindowFlags(Qt::Window | Qt::FramelessWindowHint | 
Qt::BypassWindowManagerHint);
  >   q->setWindowFlags(flags);
  >
  >
  > It's not need to check in every completion construction.
  
  
  It's not blocking or anything, I don't see a reason to cache the value.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12448

To: apol, #frameworks, davidedmundson
Cc: anthonyfieroni, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/79/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 22 Apr 2018 17:18:57 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29990/59686)36%
(17681/48989)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7400/9127)42%
(4552/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7958/14351)48%
(4692/9753)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3872/7867)33%
(1632/4938)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
   

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 208 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/208/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 17:18:57 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D12448: Fix KCompletionBox on wayland

[Anthony Fieroni]

anthonyfieroni added a comment.


  Why not
  
static const auto flags = qGuiApp->platformName() == 
QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | 
Qt::FramelessWindowHint | Qt::BypassWindowManagerHint) :

Qt::WindowFlags(Qt::Window | Qt::FramelessWindowHint | 
Qt::BypassWindowManagerHint);
q->setWindowFlags(flags);
  
  It's not need to check in every completion construction.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12448

To: apol, #frameworks, davidedmundson
Cc: anthonyfieroni, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12389

To: anemeth, #frameworks, #vdg, ngraham, #dolphin
Cc: elvisangelaccio, alexeymin, ngraham, #frameworks, michaelh, bruns

D12448: Fix KCompletionBox on wayland

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  It's a bit cheeky, but it's the only soltuion that doesn't require an 
invasive patch inverting the way input is eventFiltered.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12448

To: apol, #frameworks, davidedmundson
Cc: michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 229 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/229/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 15:24:42 +
 Build duration:
6 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29909/59686)36%
(17655/48993)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7400/9127)42%
(4561/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7897/14351)48%
(4669/9749)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3872/7867)33%
(1632/4938)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 207 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/207/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 15:24:42 +
 Build duration:
5 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/78/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 22 Apr 2018 15:24:42 +
 Build duration:
4 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29972/59687)36%
(17676/48989)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7398/9127)42%
(4551/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7958/14352)48%
(4696/9753)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3872/7867)33%
(1632/4938)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1374/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
 

D11768: Add Desktop and Downloads to the default list of Places

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: abetts, huoni, markg, fabiank, progwolff, broulik, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1
  
  One more reason to move this stuff from the Dolphin settings into a KCM...

REPOSITORY
  R241 KIO

BRANCH
  dolphin_thumbs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12389

To: anemeth, #frameworks, #vdg, ngraham, #dolphin
Cc: elvisangelaccio, alexeymin, ngraham, #frameworks, michaelh, bruns

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

[Nathaniel Graham]

ngraham removed a dependent revision: D11768: Add Desktop and Downloads to the 
default list of Places.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: rkflx, davidedmundson, michaelh, sharvey, elvisangelaccio, abetts, 
rizzitello, bruns

D11768: Add Desktop and Downloads to the default list of Places

[Nathaniel Graham]

ngraham removed a dependency: D11767: Remove Recently Saved This Month and 
Recently Saved Last Month entries by default.

REPOSITORY
  R241 KIO

BRANCH
  add-desktop-and-downloads (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: abetts, huoni, markg, fabiank, progwolff, broulik, michaelh, bruns

D11768: Add Desktop and Downloads to the default list of Places

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  add-desktop-and-downloads (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: abetts, huoni, markg, fabiank, progwolff, broulik, michaelh, bruns

D11768: Add Desktop and Downloads to the default list of Places

[Nathaniel Graham]

ngraham added a task: T8349: Improve Places panel usability and presentation.

REPOSITORY
  R241 KIO

BRANCH
  add-desktop-and-downloads (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: abetts, huoni, markg, fabiank, progwolff, broulik, michaelh, bruns

D11768: Add Desktop and Downloads to the default list of Places

[Nathaniel Graham]

ngraham added a comment.


  Heh, thanks. Renato said he'd fix the tests soon, FWIW.

REPOSITORY
  R241 KIO

BRANCH
  add-desktop-and-downloads (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: abetts, huoni, markg, fabiank, progwolff, broulik, michaelh, bruns

D11768: Add Desktop and Downloads to the default list of Places

[Mark Gaiser]

markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Blocking it any longer seems rude to me :)

REPOSITORY
  R241 KIO

BRANCH
  add-desktop-and-downloads (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: abetts, huoni, markg, fabiank, progwolff, broulik, michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> jobuidelegate.cpp:229
>   widget,
> - i18np("Do you really want to delete this item?", 
> "Do you really want to delete these %1 items?", prettyList.count()),
> + i18np("Do you really want to permanently delete 
> this item? This action cannot be undone.", "Do you really want to permanently 
> delete these %1 items?\n\nThis action cannot be undone.", prettyList.count()),
>   prettyList,

Please use semantic markup and the `` tag instead of `\n`, see 
https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12420

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: michaelh, bruns

D10980: updated hanle icon

[Andres Betts]

abetts added a comment.


  Just to provide perspective at what the rest of the industry is using, here 
is a search online:
  
  https://www.flaticon.com/search?word=drag

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10980

To: andreask, mart
Cc: abetts, rkflx, mart, ngraham, #frameworks, michaelh, bruns

D10980: updated hanle icon

[Marco Martin]

mart added a comment.


  In D10980#251710 , @ngraham wrote:
  
  > In D10980#251709 , @mart wrote:
  >
  > > In D10980#251547 , @rkflx 
wrote:
  > >
  > > > Maybe less dots?:
  > > >
  > > > F5817550: Screenshot_20180422_111540_less-dots.png 

  > > >
  > > > (Not sure yet about the size of the triangle.)
  > >
  > >
  > > i like this more :)
  > >  (proportionally the size of the triangle seems ok?)
  >
  >
  > I'm okay with those. I think it would be best if they're rendered in light 
gray rather than black, so they don't compete with other icons and draw visual 
focus away from the list item's content. Most inline drag indicators already 
follow this convention, in fact.
  
  
  light gray could mean disabled tough?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10980

To: andreask, mart
Cc: rkflx, mart, ngraham, #frameworks, michaelh, bruns

D12448: Fix KCompletionBox on wayland

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, davidedmundson.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  On wayland it would immediately disappear, now it doesn't anymore.

TEST PLAN
  Tried kcompletionuitest on xcb and wayland

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12448

AFFECTED FILES
  src/kcompletionbox.cpp

To: apol, #frameworks, davidedmundson
Cc: michaelh, bruns

D10980: updated hanle icon

[Nathaniel Graham]

ngraham added a comment.


  In D10980#251709 , @mart wrote:
  
  > In D10980#251547 , @rkflx wrote:
  >
  > > Maybe less dots?:
  > >
  > > F5817550: Screenshot_20180422_111540_less-dots.png 

  > >
  > > (Not sure yet about the size of the triangle.)
  >
  >
  > i like this more :)
  >  (proportionally the size of the triangle seems ok?)
  
  
  I'm okay with those. I think it would be bery if they're rendered in light 
gray rather than black, so they don't compete with other icons and draw visual 
focus away from the list item's content. Most inline drag indicators already 
follow this convention, in fact.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10980

To: andreask, mart
Cc: rkflx, mart, ngraham, #frameworks, michaelh, bruns

D10980: updated hanle icon

[Marco Martin]

mart added a comment.


  In D10980#251547 , @rkflx wrote:
  
  > Maybe less dots?:
  >
  > F5817550: Screenshot_20180422_111540_less-dots.png 

  >
  > (Not sure yet about the size of the triangle.)
  
  
  i like this more :)
  (proportionally the size of the triangle seems ok?)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10980

To: andreask, mart
Cc: rkflx, mart, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 113 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/113/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 12:14:36 +
 Build duration:
5 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 138 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/138/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 12:14:36 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13515)18%
(1978/10693)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/452)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2316)7%
(102/1554)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

D10980: updated hanle icon

[Henrik Fehlauer]

rkflx added a comment.


  Maybe less dots?:
  
  F5817550: Screenshot_20180422_111540_less-dots.png 

  
  (Not sure yet about the size of the triangle.)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10980

To: andreask, mart
Cc: rkflx, mart, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 228 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/228/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 10:47:16 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29943/59677)36%
(17661/48989)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7400/9127)42%
(4550/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7908/14351)48%
(4677/9749)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3874/7858)33%
(1631/4934)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 206 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/206/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 10:47:16 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 72 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/72/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 10:54:51 +
 Build duration:
3 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 61.37 KB...] * ECM (required version >= 5.45.0), Extra CMake Modules.,  * Qt5Core * Qt5Test * Qt5 (required version >= 5.8.0)-- Configuring done-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --usingInstall /home/jenkins/install-prefix/Scanning dependencies of target qrcAlias_autogenScanning dependencies of target scalable_autogenScanning dependencies of target breeze-validate-svgScanning dependencies of target dupe_autogen[  4%] Automatic MOC for target qrcAliasScanning dependencies of target newline_autogen[  8%] Automatic MOC for target scalable[ 12%] Automatic MOC for target newlineScanning dependencies of target symlink_autogen[ 16%] Automatic MOC for target dupe[ 16%] Built target qrcAlias_autogenScanning dependencies of target breeze-icons-mkdirScanning dependencies of target breeze-icons-dark-mkdir[ 20%] Automatic MOC for target symlinkScanning dependencies of target qrcAlias[ 20%] Built target breeze-icons-mkdir[ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[ 25%] Built target breeze-icons-dark-mkdir[ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[ 29%] Built target dupe_autogen[ 29%] Built target scalable_autogen[ 29%] Built target newline_autogen[ 29%] Built target symlink_autogenScanning dependencies of target dupe[ 33%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.oScanning dependencies of target scalable[ 37%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.oScanning dependencies of target newlineScanning dependencies of target symlink[ 41%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[ 45%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[ 50%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[ 54%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[ 58%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[ 66%] Linking CXX executable bin/qrcAlias[ 66%] Built target qrcAliasScanning dependencies of target breeze-icons-rccScanning dependencies of target breeze-icons-dark-rcc[ 70%] Generating res/breeze-icons.qrc[ 75%] Generating res/breeze-icons-dark.qrc./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" />  ^./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" />  ^./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" />  ^./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" />  ^gmake[2]: *** [CMakeFiles/breeze-validate-svg.dir/build.make:57: CMakeFiles/breeze-validate-svg] Error 1gmake[1]: *** [CMakeFiles/Makefile2:137: CMakeFiles/breeze-validate-svg.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs/usr/home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9/autotests/scalabletest.cpp:75:26: warning: comparison of constant -1 with _expression_ of type 'KIconLoaderDummy::Context' is always true [-Wtautological-constant-out-of-range-compare]QVERIFY2(context != -1, ~~~ ^  ~~/usr/local/include/qt5/QtTest/qtestcase.h:76:9: note: expanded from macro 'QVERIFY2'if (statement) {\^[ 79%] Linking CXX executable ../bin/dupe[ 83%] Linking CXX executable ../bin/symlink[ 87%] Linking CXX executable ../bin/newline[ 87%] Built target dupe[ 87%] Built target symlink[ 87%] Built target newline1 warning generated.[ 91%] Linking CXX executable ../bin/scalable[ 91%] Built target scalable[

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 112 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/112/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 22 Apr 2018 10:52:21 +
 Build duration:
5 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 76 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/76/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 10:54:51 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 78.34 KB...]-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- The following REQUIRED packages have been found: * ECM (required version >= 5.45.0), Extra CMake Modules.,  * Qt5Core * Qt5Test * Qt5 (required version >= 5.8.0)-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target symlink_autogenScanning dependencies of target breeze-validate-svgScanning dependencies of target dupe_autogenScanning dependencies of target newline_autogenScanning dependencies of target breeze-icons-dark-mkdirScanning dependencies of target breeze-icons-mkdirScanning dependencies of target qrcAlias_autogenScanning dependencies of target scalable_autogen[  4%] Automatic MOC for target symlink[  8%] Automatic MOC for target newline[ 12%] Automatic MOC for target dupe[ 16%] Automatic MOC for target qrcAlias[ 20%] Automatic MOC for target scalable[ 20%] Built target breeze-icons-mkdir[ 20%] Built target breeze-icons-dark-mkdir[ 20%] Built target qrcAlias_autogenScanning dependencies of target qrcAlias[ 20%] Built target newline_autogen[ 20%] Built target dupe_autogen[ 20%] Built target symlink_autogen[ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[ 29%] Built target scalable_autogenScanning dependencies of target newlineScanning dependencies of target symlinkScanning dependencies of target dupe[ 33%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[ 37%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[ 41%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.oScanning dependencies of target scalable[ 45%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[ 50%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[ 54%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[ 58%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" />  ^./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" />  ^./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" />  ^./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" />  ^make[2]: *** [CMakeFiles/breeze-validate-svg.dir/build.make:57: CMakeFiles/breeze-validate-svg] Error 1make[1]: *** [CMakeFiles/Makefile2:169: CMakeFiles/breeze-validate-svg.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 66%] Linking CXX executable bin/qrcAlias[ 66%] Built target qrcAlias[ 70%] Linking CXX executable ../bin/symlink[ 75%] Linking CXX executable ../bin/newline[ 79%] Linking CXX executable ../bin/dupe[ 79%] Built target symlink[ 79%] Built target newline[ 79%] Built target dupe[ 83%] Linking CXX executable ../bin/scalable[ 83%] Built target scalablemake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] email

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 - Build # 10 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.10/10/
 Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.10
 Date of build:
Sun, 22 Apr 2018 10:54:51 +
 Build duration:
50 sec and counting
   CONSOLE OUTPUT
  [...truncated 59.56 KB...]-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Failed-- The following REQUIRED packages have been found: * ECM (required version >= 5.45.0), Extra CMake Modules.,  * Qt5Core * Qt5Test * Qt5 (required version >= 5.8.0)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:KF5_HOST_TOOLING-- Build files have been written to: /home/user/workspace/Frameworks breeze-icons kf5-qt5 AndroidQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks breeze-icons kf5-qt5 AndroidQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform AndroidQt5.10 --usingInstall /home/user/install-prefix/Scanning dependencies of target scalable_autogenScanning dependencies of target dupe_autogenScanning dependencies of target breeze-validate-svgScanning dependencies of target newline_autogenScanning dependencies of target symlink_autogen[  6%] Automatic MOC for target dupe[ 12%] Automatic MOC for target scalable[ 18%] Automatic MOC for target symlink[ 25%] Automatic MOC for target newline[ 25%] Built target scalable_autogen[ 25%] Built target symlink_autogen[ 25%] Built target dupe_autogen[ 25%] Built target newline_autogenScanning dependencies of target scalableScanning dependencies of target symlinkScanning dependencies of target newlineScanning dependencies of target dupe[ 31%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[ 37%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[ 43%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[ 50%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[ 56%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[ 68%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[ 75%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" />  ^./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" />  ^./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" />  ^./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" />  ^CMakeFiles/breeze-validate-svg.dir/build.make:57: recipe for target 'CMakeFiles/breeze-validate-svg' failedmake[2]: *** [CMakeFiles/breeze-validate-svg] Error 1CMakeFiles/Makefile2:131: recipe for target 'CMakeFiles/breeze-validate-svg.dir/all' failedmake[1]: *** [CMakeFiles/breeze-validate-svg.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 81%] Linking CXX executable ../bin/newline[ 87%] Linking CXX executable ../bin/dupe[ 87%] Built target newline[ 87%] Built target dupe[ 93%] Linking CXX executable ../bin/symlink[ 93%] Built target symlink[100%] Linking CXX executable ../bin/scalable[100%] Built target scalableMakefile:140: recipe for target 'all' failedmake: *** [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextr

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 20 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/20/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 22 Apr 2018 10:54:51 +
 Build duration:
58 sec and counting
   CONSOLE OUTPUT
  [...truncated 79.07 KB...]-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- The following REQUIRED packages have been found: * ECM (required version >= 5.45.0), Extra CMake Modules.,  * Qt5Core * Qt5Test * Qt5 (required version >= 5.8.0)-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks breeze-icons kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks breeze-icons kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.9 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target qrcAlias_autogenScanning dependencies of target breeze-validate-svgScanning dependencies of target newline_autogenScanning dependencies of target symlink_autogen[  4%] Automatic MOC for target qrcAliasScanning dependencies of target dupe_autogen[  8%] Automatic MOC for target symlink[ 12%] Automatic MOC for target newline[ 16%] Automatic MOC for target dupeScanning dependencies of target scalable_autogenScanning dependencies of target breeze-icons-mkdir[ 20%] Automatic MOC for target scalableScanning dependencies of target breeze-icons-dark-mkdir[ 20%] Built target qrcAlias_autogen[ 20%] Built target breeze-icons-dark-mkdir[ 20%] Built target breeze-icons-mkdirScanning dependencies of target qrcAlias[ 20%] Built target dupe_autogen[ 20%] Built target newline_autogen[ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[ 25%] Built target scalable_autogen[ 25%] Built target symlink_autogen[ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.oScanning dependencies of target dupeScanning dependencies of target newlineScanning dependencies of target symlink[ 33%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[ 37%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[ 41%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[ 45%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[ 50%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.oScanning dependencies of target scalable[ 54%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[ 58%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" />  ^./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" />  ^./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" />  ^./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" />  ^make[2]: *** [CMakeFiles/breeze-validate-svg.dir/build.make:57: CMakeFiles/breeze-validate-svg] Error 1make[1]: *** [CMakeFiles/Makefile2:169: CMakeFiles/breeze-validate-svg.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 66%] Linking CXX executable bin/qrcAlias[ 66%] Built target qrcAlias[ 70%] Linking CXX executable ../bin/symlink[ 75%] Linking CXX executable ../bin/dupe[ 79%] Linking CXX executable ../bin/newline[ 79%] Built target symlink[ 79%] Built target dupe[ 79%] Built target newline[ 83%] Linking CXX executable ../bin/scalable[ 83%] Built target scalablemake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextre

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/77/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 22 Apr 2018 10:47:16 +
 Build duration:
8 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(287/442)65%
(287/442)51%
(30188/59693)36%
(17775/48985)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7398/9127)42%
(4553/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)56%
(7966/14352)48%
(4694/9753)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3869/7857)33%
(1631/4934)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1780/4338)34%
(1364/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
  

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 137 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/137/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 22 Apr 2018 10:52:21 +
 Build duration:
2 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13513)19%
(1978/10691)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/452)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

D11137: overflow-menu as view-more-symbolic, and horizontal

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b518d06b25c2: overflow-menu as view-more-symbolic, and 
horizontal (authored by mart).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11137?vs=28967&id=32786

REVISION DETAIL
  https://phabricator.kde.org/D11137

AFFECTED FILES
  icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg
  icons-dark/actions/symbolic/view-more-symbolic.svg
  icons/actions/symbolic/view-more-horizontal-symbolic.svg
  icons/actions/symbolic/view-more-symbolic.svg

To: mart, #vdg, andreaska
Cc: Fuchs, #frameworks, michaelh, bruns

D12379: [Containment Interface] Don't enter edit mode when immutable

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a0b7a71a94a7: [Containment Interface] Don't enter 
edit mode when immutable (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12379?vs=32642&id=32785

REVISION DETAIL
  https://phabricator.kde.org/D12379

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma, mart
Cc: #frameworks, michaelh, bruns

D12379: [Containment Interface] Don't enter edit mode when immutable

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12379

To: broulik, #plasma, mart
Cc: #frameworks, michaelh, bruns

D10863: [KRecentDocument] Use QGuiApplication::desktopFileName()

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:73f3a9bee0d4: [KRecentDocument] Use 
QGuiApplication::desktopFileName() (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10863?vs=28111&id=32784

REVISION DETAIL
  https://phabricator.kde.org/D10863

AFFECTED FILES
  src/core/krecentdocument.cpp

To: broulik, #frameworks, #plasma, hein, aleksejshilin, mart
Cc: michaelh, bruns

D12439: Add EventDataDecorator::hasEndDateTime()

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  There can be events which have no duration. Those are represented by having
  a start datetime, but no valid end dateTime.
  The new method hasEndDateTime() simplifies querying this from QML.
  
  Follows the API of KCalCore::Event.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  addhasEndDateTime

REVISION DETAIL
  https://phabricator.kde.org/D12439

AFFECTED FILES
  src/declarativeimports/calendar/eventdatadecorator.cpp
  src/declarativeimports/calendar/eventdatadecorator.h

To: kossebau, #plasma
Cc: #frameworks, michaelh, bruns

D12438: Fix PlasmaCalendar widget to not mark days with minor events

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  CalendarEvents::EventData (in KDeclarative) has a property isMinor, which is
  described as "If set to true, it won't be marked in the calendar grid".
  
  This patch fulfils that promise, by introducing separate roles on the model
  which explicitly report the existance of any major or any minor events at a
  given day, so that the marker loader can concentrate on the major events.

TEST PLAN
  Using a plasmacalendar plugin which feeds events with isMinor=true the
  widget now only marks days which have major events.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixdisplayofminorevents

REVISION DETAIL
  https://phabricator.kde.org/D12438

AFFECTED FILES
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/daysmodel.h
  src/declarativeimports/calendar/qml/DayDelegate.qml

To: kossebau, #plasma
Cc: #frameworks, michaelh, bruns

Re: Required Compiler for KDE Frameworks

[David Faure]

On samedi 30 décembre 2017 23:41:01 CEST Dominik Haumann wrote:
> Hi,
> 
> on https://community.kde.org/Frameworks/Policies, it says:
> 
>   The following minimal compiler versions are supported
>   by KDE Frameworks:
> 
>   - GCC 4.6
>   - Clang 3.1
>   - VS2012 (MSVC11)
> 
> Is this list really up-do-date?
> Afaik, we even require VS2015 these days. What about the others?
> 
> Also: Can we use 'override' or are we still bound to Q_DECL_OVERRIDE?

Now updated, to at least make it clear that full C++11 is OK.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D10980: updated hanle icon

[Marco Martin]

mart added a comment.


  i would use something on the line of the old icon we had, the grid of dots is 
very tipical for drag handles, this with every possible direction (maybe also a 
4 directions handle one)
  F5817422: Screenshot_20180422_111540.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10980

To: andreask, mart
Cc: mart, ngraham, #frameworks, michaelh, bruns

D12423: Install pri file for qmake support & document it in metainfo.yaml

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5a6aff54fc8a: Install pri file for qmake support & 
document it in metainfo.yaml (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12423?vs=32746&id=32764#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12423?vs=32746&id=32764

REVISION DETAIL
  https://phabricator.kde.org/D12423

AFFECTED FILES
  metainfo.yaml
  src/lib/CMakeLists.txt

To: kossebau, #build_system, lbeltrame
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12371: fix always reproducible crash

[David Faure]

dfaure added a comment.


  It looks like the issue is that forgetDirs() doesn't find smb:// on the line 
of code that says `DirectoryDataHash::iterator dit = 
directoryData.find(urlStr);.`
  So it goes into early return and doesn't do 
dirData.listersCurrentlyHolding.removeAll(lister); 
  which later leads to using a deleted lister that is still in 
listersCurrentlyHolding (for a slightly different URL).
  
  Can you check the contents of directoryData at that point? Could it be that 
it has an entry for smb:/// with three slashes?
  One solution is to call printDebug(), which will output lots of information 
including the contents of directoryData().

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12371

To: jtamate, dfaure, #frameworks, apol
Cc: apol, michaelh, bruns

D12424: Install pri file for qmake support & document it in metainfo.yaml

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:5018509d5748: Install pri file for qmake support & 
document it in metainfo.yaml (authored by kossebau).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12424?vs=32755&id=32763

REVISION DETAIL
  https://phabricator.kde.org/D12424

AFFECTED FILES
  metainfo.yaml
  src/CMakeLists.txt

To: kossebau, #build_system, lbeltrame
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns