D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a subscriber: jnoack. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg Cc: jnoack, #frameworks, michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg Cc: #frameworks, michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg Cc: #frameworks, michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham created this revision. ngraham added reviewers: hein, Plasma, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY This patch makes the venerable and wonderful

D10078: Add separate lib KF5::DBusRunner

kossebau updated this revision to Diff 33026. kossebau added a comment. update to MatchReply & handleMatchRequest REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10078?vs=32916=33026 BRANCH kdbusrunnerlib2 REVISION DETAIL

D12341: fix detection of taglib when compiling for Android

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Looks trivial enough ... REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D12341 To: mgallien, #frameworks, #baloo, bruns Cc: bruns,

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/22/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Tue, 24 Apr 2018 21:09:38 + Build duration: 9 min 32 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/78/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 24 Apr 2018 21:09:38 + Build duration: 4 min 15 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/61/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 24 Apr 2018 21:09:38 + Build duration: 3 min 43 sec and counting JUnit

D9951: [KUserProxy] Adjust to accounts service

This revision was automatically updated to reflect the committed changes. Closed by commit R296:6655238c0282: [KUserProxy] Adjust to accounts service (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9951?vs=25552=33017#toc REPOSITORY R296 KDeclarative CHANGES

D9950: [KUser] Check whether .face.icon is actually readable before returning it

This revision was automatically updated to reflect the committed changes. Closed by commit R244:e55d452031c2: [KUser] Check whether .face.icon is actually readable before returning it (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9950?vs=25550=33016#toc

D11278: [KateCompletionWidget] Create configuration interface on demand

broulik abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11278 To: broulik, #ktexteditor, dhaumann, kfunk, cullmann Cc: hein, martinkostolny, cullmann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D11925: Add "SkipSwitcher" to API

sharvey added a comment. In D11925#253074 , @graesslin wrote: > The adjustments in registry.cpp are still missing. I apologize, but I don't know what adjustments to make in `registry.cpp`. In all other cases, I followed the templates

D11925: Add "SkipSwitcher" to API

sharvey marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

sharvey updated this revision to Diff 32996. sharvey added a comment. - Update PlasmaWindowManagement interface to version 9 REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=32906=32996 BRANCH arcpatch-D11925 REVISION DETAIL

D9028: [UDisks DeviceBackend] Slightly optimize

bruns added inline comments. INLINE COMMENTS > davidedmundson wrote in udisksdevicebackend.cpp:67 > Never trust existing code. > > You're not going to get to process DBus events until we hit the event queue > anyway. Its also clearly racy. You **have to** connect to the signals before

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 210 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/210/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 24 Apr 2018 15:04:57 + Build duration: 31 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 232 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/232/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 24 Apr 2018 15:04:57 + Build duration: 28 min and counting JUnit Tests Name: (root)

D11925: Add "SkipSwitcher" to API

graesslin added a comment. The adjustments in registry.cpp are still missing. INLINE COMMENTS > graesslin wrote in plasmawindowmanagement_interface.cpp:122 > you need to increase the version number. this needs to be 9 REPOSITORY R127 KWayland REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/81/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 24 Apr 2018 15:04:57 + Build duration: 6 min 50 sec and counting JUnit Tests Name: (root)

D9653: [FStab Handling] Clean up process running by using lambdas

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9653 To: broulik, davidedmundson Cc: #frameworks, michaelh, bruns

D11111: Only show supported schemes in KUrlNavigatorProtocolCombo

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bf21c02675c6: Only show supported schemes in KUrlNavigatorProtocolCombo (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=28897=32980

D11112: Hide KUrlNavigatorProtocolCombo if there is just one protocol supported

This revision was automatically updated to reflect the committed changes. Closed by commit R241:48231dc9fc10: Hide KUrlNavigatorProtocolCombo if there is just one protocol supported (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D11112: Hide KUrlNavigatorProtocolCombo if there is just one protocol supported

davidedmundson accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2 To: broulik, #frameworks, mart, davidedmundson Cc: michaelh, bruns

D11111: Only show supported schemes in KUrlNavigatorProtocolCombo

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D1 To: broulik, #frameworks, davidedmundson Cc: mart, michaelh, bruns

D9028: [UDisks DeviceBackend] Slightly optimize

broulik abandoned this revision. broulik added a comment. The important stuff (double/triple lookup) was already committed elsewhere and the rest is just minor coding style stuff REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9028 To: broulik, #frameworks,

D9221: [KLineEdit] Use Qt's built-in clear button functionality

This revision was automatically updated to reflect the committed changes. Closed by commit R284:92f59edf698a: [KLineEdit] Use Qts built-in clear button functionality (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9221?vs=29479=32978#toc REPOSITORY R284

D9221: [KLineEdit] Use Qt's built-in clear button functionality

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9221 To: broulik, #frameworks, davidedmundson Cc: michaelh, bruns

D3837: [Calendar] Optimize Backend

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. marking as request changes based on my comments

D10078: Add separate lib KF5::DBusRunner

davidedmundson added a comment. We have lots of KJob API patterns when *making* an async call to something else. I can't think of any async-ly handling somethign else (except for maybe slavebase) , so we are in a fairly unique position here. I really like your suggestions with

D12490: concatPaths: process empty path1 correctly

anthonyfieroni added a comment. > Q_ASSERT(!path2.startsWith(QLatin1Char('/'))); If path1 is empty path2 will point to full path not absolute e.g. /something it should be ./something. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin,

D10078: Add separate lib KF5::DBusRunner

kossebau added a comment. In D10078#252871 , @davidedmundson wrote: > This makes it quite easy for a developer to screw up and block krunner. > The RAII approach makes it very very hard for a developer to screw up with any of the multiple

D12490: concatPaths: process empty path1 correctly

aleksejshilin added a comment. In D12490#252959 , @anthonyfieroni wrote: > path1 *should* never be empty Hm... I thought concatPaths() is supposed to be used like this: `concatPaths(basePath, relativePath)` - then an empty basePath

D12490: concatPaths: process empty path1 correctly

anthonyfieroni added a comment. path1 *should* never be empty REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin, #frameworks, anthonyfieroni, dfaure Cc: michaelh, bruns

D12490: concatPaths: process empty path1 correctly

aleksejshilin added reviewers: anthonyfieroni, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin, #frameworks, anthonyfieroni, dfaure Cc: michaelh, bruns

D12493: Require NetworkManager 1.4.0 and newer

jgrulich added a reviewer: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D12493 To: jgrulich, #frameworks Cc: #frameworks, michaelh, bruns

D12493: Require NetworkManager 1.4.0 and newer

jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jgrulich requested review of this revision. REVISION SUMMARY NM 1.4.0 was released in 2016, even Debian stable has newer version in repositories so it

D12490: concatPaths: process empty path1 correctly

aleksejshilin requested review of this revision. aleksejshilin added a comment. Here is an example of KUrlCompletion breakage. Before, it returned invalid absolute paths like /Desktop etc.: F5820341: Before.png After: F5820340: After.png

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added inline comments. INLINE COMMENTS > cfeck wrote in kiconloader.h:279 > loadIcon("test", mygroup, 2); > > Which overload is called? Looks like it's always taking the one without `scale`. Meh. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To:

D12490: concatPaths: process empty path1 correctly

aleksejshilin created this revision. aleksejshilin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. aleksejshilin requested review of this revision. REVISION SUMMARY When path1 was empty (i.e. 'current directory'), concatPaths() used to return an absolute path

D12490: concatPaths: process empty path1 correctly

aleksejshilin planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin, #frameworks Cc: michaelh, bruns

D10078: Add separate lib KF5::DBusRunner

davidedmundson added a comment. I read your comments. I had also left a description when I first made the change. This makes it quite easy for a developer to screw up and block krunner. The RAII approach makes it very very hard for a developer to screw up with any of the multiple